From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0D44C5AE59 for ; Tue, 3 Jun 2025 04:52:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 570166B03A3; Tue, 3 Jun 2025 00:52:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 521056B03A4; Tue, 3 Jun 2025 00:52:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 437D56B03A5; Tue, 3 Jun 2025 00:52:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 246206B03A3 for ; Tue, 3 Jun 2025 00:52:31 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6D3741201AB for ; Tue, 3 Jun 2025 04:52:30 +0000 (UTC) X-FDA: 83512868460.25.AD20556 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf02.hostedemail.com (Postfix) with ESMTP id 6694180003 for ; Tue, 3 Jun 2025 04:52:28 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=B3P8Y2kD; spf=none (imf02.hostedemail.com: domain of BATV+175a1930472064472083+7954+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+175a1930472064472083+7954+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748926349; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2HXdpwNFEIc5X8bhVnayNQJw7eGMBpc7Yo7s6dM4VOc=; b=UcAJUrcwDHYpPml4CC+EPweD9R1hFpyxFfnJENIht4zLC398WgJy/lYWHlS/bnpAHzO7eU /jGcaptGfzm0O2nZqA+w/Q3JDh8WHeP/D4S37TPNfskhNEFnvEFot1x/8ibbqLhXJ5LznS 7iZz5kNRIyVhHBBgLh1hJfJLTxfEY1Y= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=B3P8Y2kD; spf=none (imf02.hostedemail.com: domain of BATV+175a1930472064472083+7954+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+175a1930472064472083+7954+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748926349; a=rsa-sha256; cv=none; b=Cluztr/JtL0LUBznwLfJzPlUfKF2uSpT0WpShVl0zLaWQVkdayo4bh0J5x8AKGrshyR42b wRH2Oo3gtZrvWxKlV40oI2pQPmO4PcM+P05Str1H3oL3Ytk4tQIEZcwTo1ZlF1skwhCHTy 9JcIOXgmYX8t/EB7OvPkHFg0OKYLDGo= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=2HXdpwNFEIc5X8bhVnayNQJw7eGMBpc7Yo7s6dM4VOc=; b=B3P8Y2kDHXidjM2mVVCC4kBNNF Qz89tdzXTMecebZG7XmRmDmZwVxd749GOy/SzyY/EpmsmfsqSNw/cnSgrpSTVCApUquqkhPfVkAc8 kieG2QRArS7d2eif4k5WqxYt4D0T0IvW8HLaOTbXkSr40XTEVz8CgyPpGf052cciIXiuAonVHjKp5 ca8tnKvTKMeAP4pWA1TQQgCniiO5gADuWYcy575ZsQpE9t3qic8U9fIg53T2QtSkg9Caxfp7AVxdf qRln17kTFNcHJEKM2R61la51Q5Mz0A+L2g/j3ozbDXhSHyJ/Sl2JQG5pkhq4oDDJmJzkj4ZENkv79 jz/R5CFQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uMJdM-00000009izV-3hPv; Tue, 03 Jun 2025 04:52:20 +0000 Date: Mon, 2 Jun 2025 21:52:20 -0700 From: Christoph Hellwig To: Ackerley Tng Cc: kvm@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-fsdevel@vger.kernel.org, aik@amd.com, ajones@ventanamicro.com, akpm@linux-foundation.org, amoorthy@google.com, anthony.yznaga@oracle.com, anup@brainfault.org, aou@eecs.berkeley.edu, bfoster@redhat.com, binbin.wu@linux.intel.com, brauner@kernel.org, catalin.marinas@arm.com, chao.p.peng@intel.com, chenhuacai@kernel.org, dave.hansen@intel.com, david@redhat.com, dmatlack@google.com, dwmw@amazon.co.uk, erdemaktas@google.com, fan.du@intel.com, fvdl@google.com, graf@amazon.com, haibo1.xu@intel.com, hch@infradead.org, hughd@google.com, ira.weiny@intel.com, isaku.yamahata@intel.com, jack@suse.cz, james.morse@arm.com, jarkko@kernel.org, jgg@ziepe.ca, jgowans@amazon.com, jhubbard@nvidia.com, jroedel@suse.de, jthoughton@google.com, jun.miao@intel.com, kai.huang@intel.com, keirf@google.com, kent.overstreet@linux.dev, kirill.shutemov@intel.com, liam.merwick@oracle.com, maciej.wieczor-retman@intel.com, mail@maciej.szmigiero.name, maz@kernel.org, mic@digikod.net, michael.roth@amd.com, mpe@ellerman.id.au, muchun.song@linux.dev, nikunj@amd.com, nsaenz@amazon.es, oliver.upton@linux.dev, palmer@dabbelt.com, pankaj.gupta@amd.com, paul.walmsley@sifive.com, pbonzini@redhat.com, pdurrant@amazon.co.uk, peterx@redhat.com, pgonda@google.com, pvorel@suse.cz, qperret@google.com, quic_cvanscha@quicinc.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, quic_svaddagi@quicinc.com, quic_tsoni@quicinc.com, richard.weiyang@gmail.com, rick.p.edgecombe@intel.com, rientjes@google.com, roypat@amazon.co.uk, rppt@kernel.org, seanjc@google.com, shuah@kernel.org, steven.price@arm.com, steven.sistare@oracle.com, suzuki.poulose@arm.com, tabba@google.com, thomas.lendacky@amd.com, vannapurve@google.com, vbabka@suse.cz, viro@zeniv.linux.org.uk, vkuznets@redhat.com, wei.w.wang@intel.com, will@kernel.org, willy@infradead.org, xiaoyao.li@intel.com, yan.y.zhao@intel.com, yilun.xu@intel.com, yuzenghui@huawei.com, zhiquan1.li@intel.com Subject: Re: [PATCH 1/2] fs: Provide function that allocates a secure anonymous inode Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 6694180003 X-Stat-Signature: 6pkr1acs4htwwtzkf4kmnrkjnntnnmsn X-Rspam-User: X-HE-Tag: 1748926348-375425 X-HE-Meta: U2FsdGVkX19hTEGDpmnNgY1LMxYHT9qhlP77EVsKxruEVgj5Ef1dWzusDqDBp/FKseQtsFcJDIQNfVCliM+O5kTy3+qxjXdHGSo3ox3yNdIKs+c/hNo5e8KXXwnugIQM0gq4BYNB4Q4rp/P/RYZxk7wpASVuuX2QGLFdm42JTLY5+QCVSH5HLfY16fWryMMlK4JEzlHYf0ZBYaQB48UnSyWRJt+G8nZ/RRFIM4jsH527xXPlkG41j8QZjoBdNpAv4LL6XObBBA1Kj9FLwdNz7/7nTw5j7tJWLMrCCQ91kKkL217Uhgez+kI1E2Fq566nmGA+j+erllOmUMbFAA4oSaK5MfAOecKwad2RkthPOOkzxivZUMrQUKsMOWZExW3Y0IbH9D3jWRK6ppphKBu4xRzBhCrWNwYJNdwguHFC6dHDVtKwxCX2DjmqTXmTg/FiphZf5UwUxkgxLPd8b6TpKnixPn+1zW7cQ14r2MdEWWKrHlKcuSP5De/0Wdom2rLGcsB0TdzC2MO8Yl5VRQr1nfyXrJQH4gV3C19hTWG2XB94k9eC9Mps6CrW01O7W2Q5XslwBXZz3b6AiCctsek4ZdYlrkxQ9q0gvh3elR46ZUA9+2p1RvZAhJoFWbTxxC+Yk9mGzYd2PiYPtSoUP0v5aFVznaAWBUEadtyNn4jWrHVUVSw84K4Zhv6rudENrQQA3oc+XRgZlWJ+Q2idkdTQNI794raHy6z79JD+hhWI13DbHtPVVz3Czba/e3+WSwRw5WFk4/+ToJryaMWV8plTinsIQN7ZYDGpOVnHxKqV5L0KWvrdMhmaJDorNgwHUlHyQepM5pFPoyIcn214swU+cs450iE3dOgsmwt2IulcVYCbTAAWv0FgybeuenkMxaV0bYaWm+wxHw8VbgJwDA4FIMKgFlx5zX+cz03FRSoL0N2z43rlBETW2dA9MCtGqwpS/hCEqH7xTsLn0HdkK+Z aOSbnjfU lzWLQyCbXbmomenbd/SJ4q1+A24aknVuPBovfPNd3FWzWTLSVBNs/gfctJBQenDiox6MmsAVgY/+nX4StS0D3tsv8Y51KXf6s7GkGYdtXytsxGu/cQ46X8I9IshidZl/9TgoW/50qW67JFJrh2+/w42CcyBGDq9EzIJ72TEi3OZ/uQkb16o0/0s0bG5+h9GYbdzMnb6I+eKFfwjV7RcUOmgIHKQAkapC6rRuRc/eGPnWwnUoVGLYvPzBL9ZrTduDRRhiv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 02, 2025 at 12:17:54PM -0700, Ackerley Tng wrote: > +struct inode *alloc_anon_secure_inode(struct super_block *s, const char *name) > +{ > + return anon_inode_make_secure_inode(s, name, NULL, true); > +} > +EXPORT_SYMBOL_GPL(alloc_anon_secure_inode); What is "secure" about this inode? A kerneldoc explaining that would probably help. > +extern struct inode *alloc_anon_secure_inode(struct super_block *, const char *); No need for the extern here. Spelling out the parameter names in protypes is nice, though. (and fix the long line while you're at it).