From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9100C3ABB2 for ; Fri, 30 May 2025 05:24:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A8896B0082; Fri, 30 May 2025 01:24:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1588D6B0083; Fri, 30 May 2025 01:24:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 070396B0085; Fri, 30 May 2025 01:24:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DB8526B0082 for ; Fri, 30 May 2025 01:24:23 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DAF251623F7 for ; Fri, 30 May 2025 05:24:22 +0000 (UTC) X-FDA: 83498433564.18.9475D7A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id D35E814000B for ; Fri, 30 May 2025 05:24:20 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Iqx6LUm7; spf=pass (imf23.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748582661; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0ktySp/azTrCQL0RO8tR5rVfOyqkae8In8+R+OPxIQM=; b=UhvcyYKycocKw01DZn95rv8MMcRWp6+85g+DJbZ3YMXAYNWLHAWEJ47SjqhmT2+0LQ9DC5 VGqlVaxzZirN+3HW7ogQ74cdgTDJhOUsJvN0CJlWTsnTiNxqJzD4rUiGn9vY4wPH1LGiIF PNx98WfU6U/38iYpNPbe/HpO8I4NUu8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Iqx6LUm7; spf=pass (imf23.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748582661; a=rsa-sha256; cv=none; b=LMOzJAQOuHo+XfxCHyIiNDa5RYMP1Oq3vkCBavci0wm7C7nunPaxI/PjNtZwoQMeRj+r6f gAYHohfloSljGIfwPlwUL4mkXoykDdcW1Yn6+06BmombNWP3MrCIgzNkSEqKaQdtATlxf3 NicqEJurUqOp/pIWhLCPy4mwmZXJ2v8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748582660; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0ktySp/azTrCQL0RO8tR5rVfOyqkae8In8+R+OPxIQM=; b=Iqx6LUm7zg9cvDMR/x7IBoYAuchLrZfM1vMM4DlxVhkFXe2ha8EIDCpZXuA2aJ+xctmBnv 6b777yEJh9OqUXi7R17EM83NEUiiOWWjn7vYvNdr41oSBdrei80DDx1joWyJVicDRSCxS0 ufp061DD/xsC/fMb+HI+g0+snCOdWAk= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-U53o6Mj6MBGqoEmg9cni1Q-1; Fri, 30 May 2025 01:24:16 -0400 X-MC-Unique: U53o6Mj6MBGqoEmg9cni1Q-1 X-Mimecast-MFC-AGG-ID: U53o6Mj6MBGqoEmg9cni1Q_1748582655 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E4AE1180035C; Fri, 30 May 2025 05:24:14 +0000 (UTC) Received: from localhost (unknown [10.72.112.13]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8DC1918003FC; Fri, 30 May 2025 05:24:11 +0000 (UTC) Date: Fri, 30 May 2025 13:24:07 +0800 From: Baoquan He To: Kemeng Shi Cc: akpm@linux-foundation.org, kasong@tencent.com, hannes@cmpxchg.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] mm: swap: remove stale comment stale comment in cluster_alloc_swap_entry() Message-ID: References: <20250522122554.12209-1-shikemeng@huaweicloud.com> <20250522122554.12209-5-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250522122554.12209-5-shikemeng@huaweicloud.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Rspam-User: X-Stat-Signature: ji5enuc84hqo1imzcu6pqg8suzbrhokh X-Rspamd-Queue-Id: D35E814000B X-Rspamd-Server: rspam11 X-HE-Tag: 1748582660-560025 X-HE-Meta: U2FsdGVkX18SCkMevi+OcJsNGaunidxZHKG4T/Wot7EMUNVt0e3a9FLOAO3ZzOsrmN5BW4b6Dn0zfih+2J7kI8NeWKBNutmLWVScNenzvDnqimZhCYrZ6CnefvGBIY032Wbuu9L+/IZORsnlDtUYOZ7PpaR6tEsssNQN2H6a9Lwp+KYZlYO9P5OBeN7X3hd1fFVUhzYcN1yXxEQy8/jRFZkQb01XW7pC+DtLmmEdfpR7qJE5cMZpCxjIGoRu++TKebxx3gdzAZ+LhZ4ADhs6AvInBQ8hRYTVc3JD0IiAvS7H7BR6HRYDdDBh4GYVH69WRH4fj51FTAuNKKJ5qkUY+4zwe4qRn4RFzpm0EOKGRNqS8wF1wMo24JwFkFNkJKrQqCMKkHoERrYCUmhrWsezgZaH9L/M88lMFGcYKBuOatp/EJrWkUJx5fc56nxVzOLOdr0jIpZN3Sb9Bb4BDq90PN6GQ9SATk9gDaCMmvD48DPPu2R/Ps7fRYyJy/6u/zO/CffJ6kCgljJicQ7fsNHgCCLy4gbwD1AowPleVGtC/IRE09iLlEwveTCn0mLvxH5lJv8EmqjVmzITDD9K+D01It/VrPeggmwlG4MxVaggqrcYuCy3b/45s9/vOi6lUMt7iOaUcGwCws6E/cP/BW4Zttw7J2L/AKgQp6X8bmrhAH7+5oBr17BtYsbjnogTpcFGaTJeQ1vg8Mu0E/o3h2s9xfTIEl1o2ROP1SVxB8LCJWbIPmdYtYfDPcLvE8qakRFpWn34AqZxNrLOREp/8DhV452xLjUNf6XBUNGa/YnhlW7ZmsDoCyXqsn/8maFornz2uUPsyoZNfcMs2ncLwp1ItGbBgEcXpzh4bJLcklp34trFQcUl00MKmydsGnsHn7J6TxiuzPJ/xFxJg2INs/pXkeDQYKJlPPUbIgE3uHUQkSZo+ecnI91s4EuUtAf7+cTOXuuoXWIeM0bnkB4gtE8 o8eHnFtP Dj0UambhtYRAzlrgQB7WaBlvi8vNH1QxVCCdYMjhzFSBg5A5M+zeC/Egq3S1qJA1EzIS/+ot8nzk+jp1ngyuM3eDBxhM0eLloQ6knVgzMqDRpXqzQWmtpVH6yUkHgl7UJpitoR6/M7UXgkTd+yEx3T97OEVogwuv22Dja0LArbjNg2luFaF5IJfNmP9R8j/7EVe2/H1UkKIhsauVUyl2LELfzUQzKvFif24OrZRXVBGxepOvrfWyV4WrvXHn1lLNQoULW1fyqvI5VVljkeQOlpYxxAgf4JorBMrqWGkKdzs+EE7zl4zNuRC4PCJ6HTl4eMUECfBrFIB41ZhuDHa/Nn/iqfGK0aaHPtjgILclEoDBEmYHohzCBfoe0KhGngWjDEcILenSFOYF7FmjgZTJJVQjzxLSbdFVIoY58k8qgld8gAX5FoYHKIgntjFHUz93QgN9VZWgrDapMV6RiTb7WTKEeTiK+GmtvRnyucsndT8i7imeNYpa3GqhuJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05/22/25 at 08:25pm, Kemeng Shi wrote: > As cluster_next_cpu was already dropped, the associated comment is stale > now. > > Signed-off-by: Kemeng Shi > --- > mm/swapfile.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Baoquan He > > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 63ab9f14b2c6..8525515fb06c 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -956,9 +956,8 @@ static unsigned long cluster_alloc_swap_entry(struct swap_info_struct *si, int o > } > > /* > - * We don't have free cluster but have some clusters in > - * discarding, do discard now and reclaim them, then > - * reread cluster_next_cpu since we dropped si->lock > + * We don't have free cluster but have some clusters in discarding, > + * do discard now and reclaim them. > */ > if ((si->flags & SWP_PAGE_DISCARD) && swap_do_scheduled_discard(si)) > goto new_cluster; > -- > 2.30.0 >