From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17661C5B556 for ; Fri, 30 May 2025 16:59:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8AF0B6B017D; Fri, 30 May 2025 12:59:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 838406B017E; Fri, 30 May 2025 12:59:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74E286B017F; Fri, 30 May 2025 12:59:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 532906B017D for ; Fri, 30 May 2025 12:59:35 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E42E21A1087 for ; Fri, 30 May 2025 16:59:34 +0000 (UTC) X-FDA: 83500185468.05.85D9844 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id BDB7A1A0008 for ; Fri, 30 May 2025 16:59:32 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=blmAPTUY; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748624373; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OoVTE1G1Q2DTmsRPkg5M4FIOu4586porR/MJ2EgcVZ0=; b=o1XVft1mnbLp/jOxZHso8q+xOr3ll74jsTfMJPVV+OIlVDma1dIWDvixNVitrLPQc/B0xl JWfmsWA8lw8mvqv1qh05QoMTQdurFs1pViWuEre0LDH+yLly+Yj8dbTPw+kaElwymj/tme 1NQ88Cg8cI4ogcRcIBEIi3xUk+DWmco= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=blmAPTUY; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748624373; a=rsa-sha256; cv=none; b=dM7Dn+2cukBbb87Yog6vnWj/V+dKkAp9eB6/pD5biVFZSnq6cI6wnQ19NmQ+aYwN1nJIZX GpZD0/4wq1I19UeTQFHiAIuvRe6LaV5+YE4SddAR1JQgfHvTWVC9xDKpZ7fNRe+D1ksdZX 0e3R9IRI/O6ZnAUmsKGxgaFuAtetlVE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OoVTE1G1Q2DTmsRPkg5M4FIOu4586porR/MJ2EgcVZ0=; b=blmAPTUYi4GVtIclESrhPLyLyV XUtSy21zua9b85UF99ozhe6OTKejUOeegtLnmlVW+bIdOaqATGobMKkFvjvdpeiFylzVasSlBQj/F c0FyN5jdTU0gotUWdDjZOm/vOFG4qF1rEiNoPAYwhig2jHAMjuuQPbrG7mycRzX7LyRK8KxqY92kR uVZ4f+LfU4SMeiluegjIGPIyiUXpk/RfC9C62XQca5JH8eKlscB/wnJAVT/evRipNElrn5BtP8I1t pe2fV8HdPOw7z9qLpbjp8fpxLT+yfPxM2q6Q+mGMJZp0iZQdXdSfOJUM+PXVKhwAJTZ/x2lb+WlYK gtsdLimA==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uL34n-0000000G1yC-3tls; Fri, 30 May 2025 16:59:25 +0000 Date: Fri, 30 May 2025 17:59:25 +0100 From: Matthew Wilcox To: Roman Gushchin Cc: Vlastimil Babka , Christoph Lameter , David Rientjes , Andrew Morton , Harry Yoo , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm, slab: use frozen pages for large kmalloc Message-ID: References: <20250529-frozen-pages-for-large-kmalloc-v1-0-b3aa52a8fa17@suse.cz> <20250529-frozen-pages-for-large-kmalloc-v1-1-b3aa52a8fa17@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: BDB7A1A0008 X-Stat-Signature: 15ou3raozqj9z9hko69d8g9i3tsef7ge X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1748624372-206865 X-HE-Meta: U2FsdGVkX18iVdkfdih1Jh7CPhHpyjVZg+u0WGK8Aou0ur3ktoJXKu37+Gt+wVRKWfgGJRrw2Mc+zNKKZalKgFO7XdjCH7ja12oW8158Wtcj9MI/8vrQn1WQgQj9s1NOvFIRLKvPhUnyUz3/uRn6VsA9K8qYMI+M0iMiEDEIAQql/P9ivHLS+3JZh0Zitz91JmIk6WYcd6dd9VQ3C8/HexGZeQKVbf1gKIHNAu9NF6A7hnITgfjMxO89X/Au25bI/6Wlq9Yjp9RW0iRtDNGQHb9lEz4Fo/EAS/cSsBcm93dDMwaIKQTFWRfyPTP1XnfqKrJluF33kPTyS1S6u3ZSxwIKZmsPrPk1DR+nPuOjeLNo6fmzxoHRQIYsdfAE/eTMW5yIrjL/Vv2wfuXBK5lc5A3J8IdF0imNWe/V4Ur9YRaxNu8HQPMoRyRY2+Z7PoIR7PitY6UYUcGNCr2Zm7AAQsrV4oiF4QGXNj5kygKyoW1FL7DFk4kBhcolmf94EUPyLyB5L5MR27PzAIEiSQ9WdIVeKsZZV3t5+Fx9Au4Do6hkR4+roSjgg/+FhdQ430vtN/4+kdUMJhKttPf1iMa0MfinSdWvOZ5Ky3JtJnZI+coxmfzQHkP3riJINpM5xIP1JfWcUAkoNcErMMZG/QWEQIkqbNdwYAFlIxTSTNbhOmHEbs/Csi2VnPkfyTjB9MqdO183d8o/fxCpObGfT1AUkr8Km5wZyaPFonGujM92oBvEzc4dLldwhagfafieaL22kapudVaWjSn6ETGimFXrfQBB+1mzr8eRVBGaJOKt3/YpAYKta2T5Gn7C2pX5/+AO6s4ngknt3RXPCjcxIL95d2HBBmGsLuIwrDfT1fZt4fCTO/kxXlGLa01BBPU/ODLL67aaztKibVkNa460xoCAETXs5bKONDVyfbt5ZfERL+f3N1XuyG3qd6/IM+X7qH1pWflIxQEAT6Rau7dDu96 4K6O6V5A zbYK1T1CR4L5FUp3kl3SFd1mfqX9K/WqWirUM3SgXPVv7NkYa+OZQ8Kv6XRk9SE8rNWwPEV8ETnf7TukpVYAJ9/kWF4mqZflI6xsM2l3wo/qVGTe4NuzJTsn/8MqWplRMi/mMnBG5ll0608Z5mB7saiuTbUjlU+tsYGdCLWx8wBZtLFWC6KYaPuxaZVKDcWQnFnCjMnWn+zlXfEh5OsTR4n+RsoXBefIQDbbN45Cfzw94L59iozzgrAynnCqJ/l9sKAvy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 29, 2025 at 03:46:26PM +0000, Roman Gushchin wrote: > > @@ -1549,6 +1549,8 @@ static inline void get_page(struct page *page) > > struct folio *folio = page_folio(page); > > if (WARN_ON_ONCE(folio_test_slab(folio))) > > return; > > + if (WARN_ON_ONCE(folio_test_large_kmalloc(folio))) > > + return; > > folio_get(folio); > > I guess eventually we can convert them to VM_WARN_ON_ONCE()? Eventually they go away