From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E00AC61CE7 for ; Fri, 6 Jun 2025 17:33:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 697306B0088; Fri, 6 Jun 2025 13:33:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 647576B008C; Fri, 6 Jun 2025 13:33:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55FBF6B0092; Fri, 6 Jun 2025 13:33:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3687B6B0088 for ; Fri, 6 Jun 2025 13:33:13 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A7DC0C0536 for ; Fri, 6 Jun 2025 17:33:12 +0000 (UTC) X-FDA: 83525671824.27.A93C355 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id 04037C0003 for ; Fri, 6 Jun 2025 17:33:10 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rZDOkafw; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749231191; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=kveS2Dd6YaEdlOqyhtCB1PV31upYKFn6xdFqVkS+NOA=; b=PCYrUJ9sZtMMkqN/Sjovk1dRQcL1Wepx1vXsA4ZQRmm/tsulT4ShTFsK/tvSUa5NkgHlVX BTEevTrD4nF8blBV3Jzvif/UC1MgwgoxXDpMJCNdidTDNiGGVuusvqzeaLtTUfLr3adKL5 cXL1V+JTIdZrgYu9hGfipnbNKBvLZg4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749231191; a=rsa-sha256; cv=none; b=wKBDa3McvPhzUA9vTimYxdC+5QvAwnfxeHlsfYibX6CDGOPO8+b6L0qxdxgUfMIRmYvZSo rUpMGAkVdV6q/gQT9/WAs3FSuE1qTx9uBjvoD/WE0KKHnp2a+dS2P8BfIcOGEY3J5Uj0Au 1rJGM+X+5Lfjm8VeTkq/AwH5QF1LatU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rZDOkafw; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:In-Reply-To:References; bh=kveS2Dd6YaEdlOqyhtCB1PV31upYKFn6xdFqVkS+NOA=; b=rZDOkafw1LKH6x1J0GlVhLOxRt XfOWJu2xCnA4tmPG1GcC9GaWw3dNwVrxXtOGB5gz8YQw7c9mkixKszou0hMja4X20TS3kAxOOwdrm YA+OxkuXpdZ0oi1FzxPuGV9BzbubYVUFgFXvh+6BZMXpAsw2ATO6D1Oss7yBbuDRBdys86LxzeG3c CIy1pYYPfW3UrcaFBJR7vskLyYhhd4QniZpKXs085ZhhgiUIOPkM3eFwQJQ5sgasoZ5aAeHzLb98S W8q7QQpPoEI0CjsUcX8rMNACDnP7TFT/3tuyf5CDvN3TO/rqiYsmqPp+lWEzD3EHE0tQy3i9hGncR rWOssxqw==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uNawG-00000005a9q-0ESG; Fri, 06 Jun 2025 17:33:08 +0000 Date: Fri, 6 Jun 2025 18:33:07 +0100 From: Matthew Wilcox To: Roman Gushchin Cc: linux-mm@kvack.org Subject: Fixing memcg_slabinfo.py Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 04037C0003 X-Stat-Signature: ft5e4rus7o8k3fugyt3b7epamti9kwyp X-Rspam-User: X-HE-Tag: 1749231190-558571 X-HE-Meta: U2FsdGVkX1+OKDi55gHUfpb07LLZ9tpkYaPzQRW20VqzHa3JTD5SGyIr3H0CtwXPD7ZxXo9QZQWcQsNuLgjG8B7Bnn2ZdTaXId66TdOkGocGj9pffrmunBdBT6UQbZ2CYk/xc1HYxaboE/yVx/17fqX3eddRPTHimh0z9WkEhWndisBNmB1NEXDnYVf1+OpbOjog/VE8NlNVOPQPIR632Ved7W5wI7A/BIRsEL/V1NUjh/DtB8QkabiIyO0eC5rc4ynWJki3a5Wo14ookRlec9Gc4McDEnvNy0CiX0pe2PRud8izGKviM4zprJloqGY/PTxn+vyO7u/Q3BOZiDEjEbNjp9nZMTCg4xaKY29SOflwRdcIPyjXafuy0aXm2RMeKnj3zfaCKMx/yURhT440EVB5SheSgdFsWoFC8M1Dq9u0QsANBRgkTsD5YysVPUFEgZ9DJU35YRgBpv1pYroMj9CXzvFawthGolC8UPOaq18jeTTwJop1+9adpOSTgh2lOPNXHtHVz/7x78bd5BERGg6Lw4mL8T335UWEznBN6ci7HkPFQ4t3sYUxIHdKr8DDts4TtGPo14CcSXcM2I2m6SmZyo7sj1DeCULy0lL/y4giaVQGiPZusQh/ynUeslYhdcmBmWgHQydvZSRjbvM41LdmqQRY6ZzZz7ie72ACidp36n5G3BSGK3TxY0/AeCIoRmAzcpEW4VyLp0WicyfgPQ98JznlKRbn++eQ578llb2iNy7oMs/4gX0waCMkR90cYtNN7KMmKHGPm6PDIgA4PxK4GkWQ6iXx5m5h77Q7h7hc/lHS6ym0FrIlAJeQP8CgKQmj57k62r2mj7e4o6Kv2tBTYKCWeLtLbjYIbAqBVD/RvNhl3QLGSLOZ7t+91iT+6RxvvKA686lc549612KziiJRKhuUgiPQCkJT6r+6LcbmU6XlUHa4g1HuugBE3U0oUa0njZCnCNAcepPzJFs YJpvnb8c 8QsufijAO104hz2TN1dN97gX8p1Hr65ZkXd6yqw/wAvncZGEco5BLZGJ6vyF9JDS5y3pp5pvc1+GK2viAYkuUqQJ35rfCVXpbsJlb7URgdGUN1oW7GRrL0/RNZPsu2LEaosdY0+2rc2WwfjGZWbzpLJJNsBqs0VrHY0JrZ0piN6DtIgCK0g7posy1aYA+BNynZqG9vzIYdRcd5gy0WS+ruR4T1rBkQF7EY6BzDA8dDKbgjEPXAjsI0TOpTYWGnQTJVC+ms1q3QK1dP2OoUgNEOG5B+1vcRs+Fa2yIh7c8wSlrtMA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.097824, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Looks like nobody's used memcg_slabinfo.py in the last year when I broke it with 4ffca5a96678. It should probably be fixed, but I'm not fluent in Python and don't use drgn myself, so have no way to verify the below is even syntactically correct, let alone works. diff --git a/tools/cgroup/memcg_slabinfo.py b/tools/cgroup/memcg_slabinfo.py index 270c28a0d098..bb3de16e3510 100644 --- a/tools/cgroup/memcg_slabinfo.py +++ b/tools/cgroup/memcg_slabinfo.py @@ -146,11 +146,11 @@ def detect_kernel_config(): def for_each_slab(prog): - PGSlab = ~prog.constant('PG_slab') + PGTYslab = prog.constant('PGTY_slab') for page in for_each_page(prog): try: - if page.page_type.value_() == PGSlab: + if (page.page_type.value_() >> 24) == PGTYslab: yield cast('struct slab *', page) except FaultError: pass