Re: [PATCH 06/10] vmcoreinfo: Remove documentation of PG_slab and PG_hugetlb

Harry Yoo
2025-06-09T02:45:08Z

On Fri, Jun 06, 2025 at 11:22:08PM +0100, Matthew Wilcox (Oracle) wrote:
> The changes to kernel/vmcore_info.c were sadly not reflected in the
> documentation. Rectify that for both these flags as well as adding
> PAGE_UNACCEPTED_MAPCOUNT_VALUE.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---

Acked-by: Harry Yoo <harry.yoo@oracle.com>

> Documentation/admin-guide/kdump/vmcoreinfo.rst | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst b/Documentation/admin-guide/kdump/vmcoreinfo.rst
> index 8cf4614385b7..56700d9a3e30 100644
> --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst
> +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst
> @@ -325,14 +325,14 @@ NR_FREE_PAGES
> On linux-2.6.21 or later, the number of free pages is in
> vm_stat[NR_FREE_PAGES]. Used to get the number of free pages.
>
> -PG_lru|PG_private|PG_swapcache|PG_swapbacked|PG_slab|PG_hwpoision|PG_head_mask|PG_hugetlb
> ------------------------------------------------------------------------------------------
> +PG_lru|PG_private|PG_swapcache|PG_swapbacked|PG_hwpoision|PG_head_mask
> +--------------------------------------------------------------------------

nit: maybe you want to fix PG_hwpoision typo as well!

>
> Page attributes. These flags are used to filter various unnecessary for
> dumping pages.
>
> -PAGE_BUDDY_MAPCOUNT_VALUE(~PG_buddy)|PAGE_OFFLINE_MAPCOUNT_VALUE(~PG_offline)|PAGE_OFFLINE_MAPCOUNT_VALUE(~PG_unaccepted)
> --------------------------------------------------------------------------------------------------------------------------
> +PAGE_SLAB_MAPCOUNT_VALUE|PAGE_BUDDY_MAPCOUNT_VALUE|PAGE_OFFLINE_MAPCOUNT_VALUE|PAGE_HUGETLB_MAPCOUNT_VALUE|PAGE_UNACCEPTED_MAPCOUNT_VALUE
> +------------------------------------------------------------------------------------------------------------------------------------------
>
> More page attributes. These flags are used to filter various unnecessary for
> dumping pages.
> --
> 2.47.2
>
>

--
Cheers,
Harry / Hyeonggon