Re: [PATCH 01/10] doc: Move SLUB documentation to the admin guide

Harry Yoo
2025-06-09T01:43:11Z

On Fri, Jun 06, 2025 at 11:22:03PM +0100, Matthew Wilcox (Oracle) wrote:
> This section is supposed to be for internal documentation, while the
> document is advice for sysadmins. Move it to the appropriate place.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> ---

Acked-by: Harry Yoo <harry.yoo@oracle.com>

With a nit below:

> Documentation/ABI/testing/sysfs-kernel-slab | 4 ++--
> Documentation/admin-guide/kernel-parameters.txt | 12 +++++++-----
> Documentation/admin-guide/mm/index.rst | 1 +
> .../{mm/slub.rst => admin-guide/mm/slab.rst} | 6 ++----
> Documentation/mm/index.rst | 1 -
> 5 files changed, 12 insertions(+), 12 deletions(-)
> rename Documentation/{mm/slub.rst => admin-guide/mm/slab.rst} (98%)
>
> diff --git a/Documentation/admin-guide/mm/index.rst b/Documentation/admin-guide/mm/index.rst
> index 2d2f6c222308..ebc83ca20fdc 100644
> --- a/Documentation/admin-guide/mm/index.rst
> +++ b/Documentation/admin-guide/mm/index.rst
> @@ -37,6 +37,7 @@ the Linux memory management.
> numaperf
> pagemap
> shrinker_debugfs
> + slab
> soft-dirty
> swap_numa
> transhuge
> diff --git a/Documentation/mm/slub.rst b/Documentation/admin-guide/mm/slab.rst
> similarity index 98%
> rename from Documentation/mm/slub.rst
> rename to Documentation/admin-guide/mm/slab.rst
> index 84ca1dc94e5e..16933b7b3377 100644
> --- a/Documentation/mm/slub.rst
> +++ b/Documentation/admin-guide/mm/slab.rst
> @@ -1,10 +1,8 @@
> ==========================
> -Short users guide for SLUB
> +Short users guide for SLAB

nit: Maybe keep the word "SLUB" or use "Slab" instead?

We've never used "SLAB" to refer to SLUB allocator before—it might be
confusing. We're not resurrecting the old SLAB allocator ;-)

--
Cheers,
Harry / Hyeonggon