From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E100C7115A for ; Mon, 16 Jun 2025 08:55:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0B89F6B0089; Mon, 16 Jun 2025 04:55:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 08FF26B008C; Mon, 16 Jun 2025 04:55:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0F566B0092; Mon, 16 Jun 2025 04:55:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E0C256B0089 for ; Mon, 16 Jun 2025 04:55:15 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 5E0555D3A4 for ; Mon, 16 Jun 2025 08:55:15 +0000 (UTC) X-FDA: 83560654590.15.2D21847 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf18.hostedemail.com (Postfix) with ESMTP id 889E91C000E for ; Mon, 16 Jun 2025 08:55:13 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="D7/BL2qY"; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750064113; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TpKjwHm3h0zyZvqUZvcV1Soa+aMv/1eXz2QWwVRrL7M=; b=5vnLNvqp56DQLkEQbPkHESHgrDMKZMiTjsDZBJvx9pYi8GoMlOFioRwzNuGbHPaggbQfHC ViI8/ybu7WtZdLZrJTiq0cz5kpKXqhr6EX9RezF3uLpN4LiORZ1azGHbHLctYIq9eFCI49 DezZzC3Ab0cQb65kO2s6l5c6Z7HA/q4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750064113; a=rsa-sha256; cv=none; b=QlBCKv3YAiltVviFIdRPm2KNpajC859iSHMpq2sluWfnt1lVOWvzW0RGYPAfuUd7hGqJLo 2JA3FKXjvYu02IB5APTJOQ5YeANrImS3kWmMqUu4ssVG8AA4o/6VhZAxp/oIPNEjnmI/P4 P9Iy/vOMjrUV0amsQzlC3UYtlHAHwTU= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="D7/BL2qY"; spf=pass (imf18.hostedemail.com: domain of rppt@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 4831F4A4F3; Mon, 16 Jun 2025 08:55:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54239C4CEEA; Mon, 16 Jun 2025 08:55:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750064112; bh=yVMK7o6TEsrw4Q3fvl9FM+ShlUKqWavW41gkW+rpmNU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D7/BL2qYK+YG+ojniL/KBt0nWQXdG4qf3Jm32w2X6tFbOXvb1tTKbeR+BtGuiQppV tjqqf+YZH9c074Q2KfLZEu1ZqD2dicn1wPI8RLYgsub4TH71CZBENIpnMTel64DXay M+w9DO9z7qJbRAnyhuuUYDrmz56xKMfL+adRPVGCGIAmxauEWqAM4RltL5/3sOYQBF vqkTzHZ2CwTqPndh0KHWRxboh0cAEXLwuhahMJWTZ+THuRCxzyUqpW59mlrctnSAi6 OMcY3gZvmbhF078IkIIklL8hK9VcN0F22qTV2YxTSO47EjYrBty289K/VkoYzuNBeR x/tPq4dEv6ISA== Date: Mon, 16 Jun 2025 11:55:01 +0300 From: Mike Rapoport To: David Hildenbrand Cc: Hao Ge , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Richard Henderson , Matt Turner , Dennis Zhou , Tejun Heo , Christoph Lameter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Kent Overstreet , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-s390@vger.kernel.org, Hao Ge Subject: Re: [PATCH v3 1/2] mm: Optimize the ARCH_NEEDS_WEAK_PER_CPU logic for s390/alpha architectures Message-ID: References: <57e110be6d8387e403b4ef1f3b10714c36afbb51.1750040317.git.gehao@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 889E91C000E X-Stat-Signature: fpayhqcz6ir3kt59wsbaf98ic3psro9b X-Rspamd-Server: rspam04 X-HE-Tag: 1750064113-217869 X-HE-Meta: U2FsdGVkX1+KN2/B5zS+ItnfTM09NpCA7OP7X7+TsMJNj+wo2N69qf0UhYu3cXtzOwPMWcSsf2yy011gFOi/UedNS5hHegvk6FxaFl3sYx4NBV9zRMS9HA13OEZsvA/g2nFOqQv1gHpNlWSKh12d2jL0ywTUxdNI7XDmyn5SzyDS+l59iyYaqxHBudXM2MUhJUvlLMJRtw8CSGoN6521860pe9jB/7LzBLwdwYbATvGspZQIAtTYETESbjxNAXe3P2qPCxoG0kI4RKx+pb9GMdU9DCcJsZ4keNjmdlYWOTb1I/RIs77E5VvHmmvsssPdssqBhVrn+3MHPgSpSuCm5TXom9sJogP3goPd67ej5rLCXDcN8bdfv77TjkWrd8akP+zawqegPKkBg90/wDAMNRmx5Aznr0O+ka5eb7O1PilLIScSF+hiuuaeDIZB4ndlcaF92rsuNWoFCv/6aypoMhqWy7iYIJEqQJ9SQGZiPwNBmWxhtpLz7JZo1zNZ3rqclR36DlZ+X9Wc2Gv4JGhEXYroAgOgDYOjiaU9fyt3UoP/Dvh2xksASuIMXR+m3lD/aMtRrytdUWEYEoCzzY1L2lTIzfvyXjrG+HkUMKwwji6eqR+P/9wgfl7Kfc9D5hFtOKAwTbcgNZKqVf/kc26LU04G5/vf2G7er9oSXSVQoAZi2hKFVCZJxTf1h919unkKrQ2V1eWdcgFn2i6dfo5wFQIt2c7Cbw5TF51NC9UvYGGUyNW5tsAgoo5H8N7nkYKHxOeaV/WKh14nZPCdP39CNn9yBklopMYaOAHnWDhHO+W7OcVw9ksjnWV5VXIeieqA9O31+PNWTCmsuCe4M1EXD6Ol6jTEqNDx1H/6xcuVZKw88T4yOB7ayBXL13d8RTJeDdv6xx42+sqhHCmxlLk23y66Byy8Gv0gULANJvp1ErT38hNLQFioK+pf9RBWUgmwg1P0jjfyHw2V+aCyVX8 STZhh0LP zquTj2MDuWB1DAt8hks2DV12T2Cgkc9ZkxC0qFT6e8EdtiX8DtZKKVgLePQIdHWDbY3ZCa6Xigs6zEvOCmus3FN6TI7KAyEtJYYGiRruc+o9kxT30s0A/Et9ZXhz7DpwcYRLc2fQJ0glWHIXPpD6lB2JrMbs7olzgkhODOpJXOfD1T5Jjz461wXXA6ZuDRUniuG002EelKSWmgizfAQCgJZqGlMHlV6IWwmgb3KdFokrrBqbPf39TbWC5WKjaKIo1O7QribuHShHmhudbZ/A93a5B48xoT1dnJ3ekvlc/olxypn5Oew6tGKKNDA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 16, 2025 at 09:59:09AM +0200, David Hildenbrand wrote: > On 16.06.25 04:29, Hao Ge wrote: > > From: Hao Ge > > subject is misleading: we are not optimizing anything in this patch, do we? > > It should probably be called > > "mm/percpu: rename ARCH_NEEDS_WEAK_PER_CPU to MODULE_NEED_WEAK_PER_CPU" or > sth. like that. > > > > Add the ARCH_NEEDS_WEAK_PER_CPU option to the mm Kconfig file > > and enable it for the s390 and alpha architectures. > > And replace all instances of ARCH_NEEDS_WEAK_PER_CPU > > in the kernel code with MODULE_NEEDS_WEAK_PER_CPU. > > Most of the description here should likely go to patch #2. See below. ... > So what you could do is move the actual introduction of > CONFIG_ARCH_NEEDS_WEAK_PER_CPU to patch #2, where it is actually used, and > limit this patch to the rename. > > Similarly, teak the patch description to reflect only that. Right, if the patch only renames ARCH_NEEDS_WEAK_PER_CPU to MODULE_NEEDS_WEAK_PER_CPU the description can be as simple as mm/percpu: rename ARCH_NEEDS_WEAK_PER_CPU to MODULE_NEEDS_WEAK_PER_CPU as a preparation for introduction of CONFIG_ARCH_NEEDS_WEAK_PER_CPU. No functional changes. > -- > Cheers, > > David / dhildenb > -- Sincerely yours, Mike.