From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAD01C5B552 for ; Tue, 10 Jun 2025 04:00:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 661C96B007B; Tue, 10 Jun 2025 00:00:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EAE36B0089; Tue, 10 Jun 2025 00:00:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4D9C26B008A; Tue, 10 Jun 2025 00:00:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2C5806B007B for ; Tue, 10 Jun 2025 00:00:00 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CA29C1A0EA2 for ; Tue, 10 Jun 2025 03:59:59 +0000 (UTC) X-FDA: 83538137718.02.1806371 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id C5489C000A for ; Tue, 10 Jun 2025 03:59:56 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=1FBoKFDA; spf=none (imf22.hostedemail.com: domain of BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749527997; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sU5sUAgpuF+2t3bLSMGu6a54oU4ikoAiS1gLuK6x3Gc=; b=CJIiZ2fE1iipHk82rd65GvRFbyXLSkcyF/ju92v5xF9DFMbYanJeo/EORpHb0SmI4bY4L1 NuK6fUmcNCJsp17eWWJjhPhUv8H8wW9IS43hQlFBDDrbvCPp/9RcVW2sxdizCmXStP0Za+ 7AF4vWAFNFW0hIuXL7uUJWIlPL2Evqw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=1FBoKFDA; spf=none (imf22.hostedemail.com: domain of BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749527997; a=rsa-sha256; cv=none; b=LMwmuwqvhLrElpyl3uF81EgOXMvayiXyClFWJYPOIL0Prcc+Cq3y6OkBkDHjkqa/8nmTPq NQj2oOg4FKop6WhCZ5jRhKUK0UQ6S4l+TrOapsWeZTM4KBS9etd2eatIZRegtlRwC1/QiO u09Sz6kL9srFzziyZnb/AWMFcknNkmk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=sU5sUAgpuF+2t3bLSMGu6a54oU4ikoAiS1gLuK6x3Gc=; b=1FBoKFDAcxgKfiPuLAzUUCEOzs jXtioUSLW9JBSVhxLsOuApjNKF6+grjpCHz28vZd/IGQfabO94E7Iy5zrXHaM7sXd5rWOt2ohXMjh IWjBY7xM6+f7ASZxAQImXZ6HEjUUUHZ59t4SqDwjBqb0ijo1fQSMNM3YVMJNRZTmW/JF7jVITfhFN Om33T3rbortPWrfpdDQwGCcW9bg9KwyLjGGEn4aa+lLwst/wrBxiji30T7o9I9d+l54gXlYhPL1Mz UUJc2OpwcU3Pi4aVWATmOfvoWIH1c766ic7f60/L0AflKqUPUEEjPU0/9pUl2qanhdNErWy5AQfO2 NN74eOdA==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uOq9R-00000005ife-425e; Tue, 10 Jun 2025 03:59:53 +0000 Date: Mon, 9 Jun 2025 20:59:53 -0700 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , Joanne Koong , miklos@szeredi.hu, brauner@kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, bernd.schubert@fastmail.fm, kernel-team@meta.com, willy@infradead.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH v1 5/8] iomap: add iomap_writeback_dirty_folio() Message-ID: References: <20250606233803.1421259-1-joannelkoong@gmail.com> <20250606233803.1421259-6-joannelkoong@gmail.com> <20250609171444.GL6156@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250609171444.GL6156@frogsfrogsfrogs> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: gy9dk1e1c61gdw9gnqfxss35tudxhofo X-Rspamd-Queue-Id: C5489C000A X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1749527996-443754 X-HE-Meta: U2FsdGVkX1/EGoYu2Ns5i1dB90p6TCCiQJu3ssS80/QzyoZbMEzStUT/hYL4vdkvxZAgM5W9p18ieSTvryaP3Wmaty0FulKSjjxufwp/Crv3kb69JUtn8UPQ2KMuiOTujrMZ/O30y1cL+wrZwkqRpzwxxDzvzSOaeuZHmlG5NtBL2zKr0GBQliIfN8Xl6Q5/ZO60sjm0YW17ZCVty4DKbt7uubXqfjSLc63J85dqV9d9/b/m3h+JgL2BCFGhJGir68RRjJ3H7bhKUP9MY/VK5lTYGjecoiVQ1UDRlcBjqp006ahFVB02SA6IHX7FTdD1NQjcgVnLWxUAx0E3h5qHpnlEsolX++XU5Q5hKe6ZxxP8sZqbsoIDvKvfip5CNDo2ir/7uIqpIOwoDG/Xdwjg1lJGtzVa5h/LRcStSZGZlaiauwb5484Kajv50kGTGV7sapzqoQzOPhj5wYGP1ry+/C7bxQGWvbWjeREnidy6cIPPYcwlyQ3RiwtkT2DmCSrDcDsSEE5grn9Y1A0BkJCCNrrjvrWXMS/SAzx4zlY3I/ffnGKoWLIwZVkTcf+HTrCA+fYtp3xJ0Tl7ykTOU2KaJt0y+5UdF20220unIApLtWt1X1Bmf6wICQ3JG6btCXXwoiHl6eBtd59q2cbqZ14A8hoPtF9eihkObiAMPc0uVYcJS/s/fj3meCXIU2zDlVHOGW0+w3kVyZswyoXpO/6xA0AB4cjIpGZCsQQvbRL0rjeApWYbH7rqXVCrl6RRtjUejZ5t6rfye2C7kID2RPvadvXYn1QN5j95aOgW9VUTe0tJnPLD6ryB7xnlzOw8cKTmj7iKrVZUeGb4HFZbr5aIWW3HkjnvHoqakL9EQ3P8GpA7Gi84Ua+nC/QrUCnAZYhRVaoqoE7WhvcVi6mcASCoblppQxo024LDeh+O/8lC41/gp/vi3n1i4iT1Cp8M1+eTDTeZNp97dDNKC0nMcVa VMhvNMAP MxPhudOV6oQG2FVoDuOY0RGDl0nFZTn71ej8nF2vjvzKGErdQJ/bAe3zsVRLbRZ7M5bpYpp/8zT2EtcC3VxV7so426caVrsvnK1Qob86Onw3ojLddNGNYPfmK1Zwam9+iPlS3TDkCnt3KQUyzVOwFpQxZI79P2V+SmUmsTkKRWEgSOC7P01zhCQ1tltC8DCBzlOhQhwRHOk6Z/UzIBr1Rw2R+lhjsEphdTlgZNos7RrHVpxD1ntmz6P/HfnADCd9B4o3D6WxsM1rGEACDmuPZhhCxtD6LFXpuhF5pG5SCTav71VxmRCmj9I4Q2U1Qh5PHv1aaE2/H692LwpPfYwAOk5EMtghFsYwmrindcR0DAgJWk8MpGoOM+Ps7sjwkw0QPzquKE3UFHxZW9qIjMwtB7P73JWjsBEMzH1mVdfL1BIDy2+MtU7Zs6Jlh3kkS30gpyIuLk7t6afGcOa4Ltatr54aV3Wj3g+SWMcj+krUCOuc2kkcbhnmWBw/GEshYgmphfISY4w11AL6CobuHAXnh/XEVLGVvccXKyJWpq0PTgr6JFoQuY+S2l95LSVbg6XmbeH8AoGslKJwn0PE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 09, 2025 at 10:14:44AM -0700, Darrick J. Wong wrote: > > Where "folio laundering" means calling ->launder_folio, right? > > What does fuse use folio laundering for, anyway? It looks to me like > the primary users are invalidate_inode_pages*. Either the caller cares > about flushing dirty data and has called filemap_write_and_wait_range; > or it doesn't and wants to tear down the pagecache ahead of some other > operation that's going to change the file contents and doesn't care. > > I suppose it could be useful as a last-chance operation on a dirty folio > that was dirtied after a filemap_write_and_wait_range but before > invalidate_inode_pages*? Though for xfs we just return EBUSY and let > the caller try again (or not). Is there a subtlety to fuse here that I > don't know about? My memory might be betraying me, but I think willy once launched an attempt to see if we can kill launder_folio. Adding him, and the mm and nfs lists to check if I have a point :)