From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 722EDC5B552 for ; Tue, 10 Jun 2025 04:22:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C1386B007B; Tue, 10 Jun 2025 00:22:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 072966B0089; Tue, 10 Jun 2025 00:22:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECC176B008A; Tue, 10 Jun 2025 00:22:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CE39E6B007B for ; Tue, 10 Jun 2025 00:22:23 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7C1B2120F7C for ; Tue, 10 Jun 2025 04:22:23 +0000 (UTC) X-FDA: 83538194166.09.846A2FD Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf18.hostedemail.com (Postfix) with ESMTP id ED7D31C0009 for ; Tue, 10 Jun 2025 04:22:21 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=vKTrabqX; spf=none (imf18.hostedemail.com: domain of BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749529342; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w+AZigyEDNfL3bND+nDNpgFpnH4Oa1zpGwvKz3U2VkY=; b=KK15kEp8IwcmuOm9IcIsXdDSe9pWf2uBGLaRAY5hD/i0KWD+VX8PLeIrnZqZl/q9GtztHO QNl94ktLqKci5iy5DNZpPZBqNdZuvC4OugSIwD0Nj0SlTkmnxGUXemN16hloY1T22BlZ0d WxAyYVVJBSRk9ZRolMMBBfhrkHoYJ14= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=vKTrabqX; spf=none (imf18.hostedemail.com: domain of BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749529342; a=rsa-sha256; cv=none; b=J9Sl+5hYkBTJ5TvS9B30797Ahp5hL7kPrMbzJaWJYzzTvy9HkmvdttQpAjO5Ho4dXes7Lj +YtTm/8bDHzBa59kVADalh2SpJmZ6cyfyURKIMvI0L6ZzNK9J9ZX1t06F3cIRaa9C19z2s f3uYlGaxrpPrcz0wzzyWYjxM2q45MPE= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=w+AZigyEDNfL3bND+nDNpgFpnH4Oa1zpGwvKz3U2VkY=; b=vKTrabqXBsJq+TJs177GBxW6cW FpbLgLE5gjzKJghClry5M+lXn5n0KtqOt7IUCkIatnaYFgdHG7qURpCpLfY9cxBq1DqlbzcHhKu7d W+SACWSv+3AFW2Rh4OU6w+/3umrozyHNC6nNTxJTRkTTU0asF5d2uIVF/jsQ3hEIezVe6QpdJMk+V z3XbGlnTGxb3mX6+K9LvJaQCU4y9La0p4hFwgzI13H192nTJ4TFZ0shDjeqc2VmZA4L1VlmVEkgSu PQY5KGgVq2SJ5KbediciYA3RamAGpA0kKjONG6sg2J+ejn0+3YRLmt+HQYe+db8tS8jgpG8woa8b3 BZUmlo+Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uOqVB-00000005k3X-0Mrm; Tue, 10 Jun 2025 04:22:21 +0000 Date: Mon, 9 Jun 2025 21:22:21 -0700 From: Christoph Hellwig To: Brian Foster Cc: linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/7] filemap: add helper to look up dirty folios in a range Message-ID: References: <20250605173357.579720-1-bfoster@redhat.com> <20250605173357.579720-3-bfoster@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250605173357.579720-3-bfoster@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: ED7D31C0009 X-Stat-Signature: zufogjwhtasm3qtergkt3s8x8z3izpay X-Rspam-User: X-HE-Tag: 1749529341-907021 X-HE-Meta: U2FsdGVkX1+7LDhmntM+7HTq46VO0XdXOgczmArvhk3zBldbqHjEDQWOSeXPpBzHRTu/MxQ6urVgG9s8TttdrnqlUTbTmdrWx12OVDh5U/03XBuQCWqYVKo0wKXjRoHn1rjzkwbyY0Tm3virFkRqAjQULoDVeAf71qh73YeNSsiDSv2DnF1oZXMpqHCzCP0HOYdgJKhOj+CI3/eGRwZhJWLvcV9/8Qcad9oUNks03ryv0n7DTfxs2axV15vHUtWRcRH95NDzDRrVYEPgcr1GdEMzCFPstOD5KN1+J+s0oEOlUMfIgeY91XLUM8j3G5LPt+xqIBXv1AK/vngJRe6wwm9Trgbfde/m45j97KxJ49GfAqC/m2tE2YG9jgmTF/P4nxDIPWNdYv8hhqbZjIPQjujYvndPFkqemv18q8URlolBSJEMZ8nRNKsR4Qr1HqLidZtOrnJG8fBtKLI3k6Xbz2WDiEsdixb14n4au1xSs6KTEKYFlKlxZW5F/BLX3ihgVwMK/JCUz11ZRqiZw5PeGK7oIeuPlpZSaEfXZ/6BwY5/W/xvUrPzqmuXHF4HGY3xz2PrWsiNu/k/yGQTTU9vv/tSm/Gaq57TC29/8fAhv/sFsfGUYgMI7ChsIThWIO4/HuAs5oNxxM6NmLRIGvDh0yV+x83jtS2uIiffieWPIsJIoSoZpQrdXtgt8+7dafhg+GFeC2pwHUPsBrSiUJMiQU5pGDt+igETEdQHuWQN8qDaMRiaPwAYwna9/bUy2MzFMzwhOwqkOues5+YISxMfJg3xn8yyXs1ZrfpOp5PbeQ7n+UfOn8MCJAHjNKxgp2d/hLXo/CM8K9Lzs75n3ZMjKcjHbm8FHBcOK5COzG9znhw69UDW6n0bR9hiAKF5ELwDuLT2k8h9asoSQT7M9xCqFhC8JdT/4P8IYtyS/wDw7ejU6Hp+HntdQtcBWCeq5K+aZfK6T0LIeJhOn7sv9lx 9an3ITUL o+zi+2x9oj1pRGU/R35HKKy7igZuQvH+SbjyQhTKFLD3A4a9WOJb6/Q2aiZM/Ym/GSYc6CgQ5ckNHRHxZ4/yD9Hql5J1Ls66u/NPCdZHt+inOQb4ceNjX/x0QIXS3KFBzvCUFJlZQQ5eb8cZW/LIXpekNZxdLjnurzRQXnocIdVqfSruSnKcytkZh5ucUaJlTWEbefdukxgRiwtqy6bFGt69VfjuJ3pLXvYypfEzwYs5ZVz9XDPGAoT9haUYSeie4/0jE5cWccBNLXWlCMxhH/Oa41fbCpIYX2GZltuExjwMUbsL9tnakVzeqArzZUKQIBqdXW4phpgOQ0YRGwhkMiAKvwhC08vkV8Sf7MXsG6zDifXPU27aRQoAfaVhd46fCIGr0D2//K0P2sTYIpQ5wi1LKW43/ukqo2l6PlRmh4wvgDjb6Q3qUGV97uHXOSxwawOyOfZLf+T3yWHcPqY/ctxv+M3hpzQF0nXf3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 05, 2025 at 01:33:52PM -0400, Brian Foster wrote: > +EXPORT_SYMBOL(filemap_get_folios_dirty); Right now this is only used in iomap, so it doesn't need an export at all. But if it had one it should be EXPORT_SYMBOL_GPL. Otherwise this looks fine, but as Darrick noted a kerneldoc comment would be nice.