From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83DC5C5B543 for ; Tue, 10 Jun 2025 12:13:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0ABAA6B0098; Tue, 10 Jun 2025 08:13:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 082586B0099; Tue, 10 Jun 2025 08:13:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F026C6B009A; Tue, 10 Jun 2025 08:13:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id CF6676B0098 for ; Tue, 10 Jun 2025 08:13:10 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4783C80117 for ; Tue, 10 Jun 2025 12:13:10 +0000 (UTC) X-FDA: 83539380540.30.2B20788 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 6F61914000B for ; Tue, 10 Jun 2025 12:13:08 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BgMBc1f4; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of bfoster@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bfoster@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749557588; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=heKlbXfDgVVxe8Ad9VgCzHCzkhfC1CaiT7d1fNBqdeo=; b=sl5FUK6WfGhlu0/Q6nyBYhnuhaFLG7mYU6HqtBShGqu9sNIct8g3XJlGv3Lb2AgxGI2pxe oXZCnLu9vJX3S6jPfVq7/IgxtxzHYVG6QVMkoFc2yrsD/zUKvPhgiTI0qiJO3a+1iqses+ aJJjDoqx+/Ldmb5tUn80ZULTPsW4PSQ= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BgMBc1f4; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf23.hostedemail.com: domain of bfoster@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bfoster@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749557588; a=rsa-sha256; cv=none; b=MyNs8glLwnJQJngH/meoop38bIN6Uxy1TfXczV6NPqzAUaqmk2gRYFswgfjTjS3/c5Dg8w OgELWp/ShXn3WBK2g2TLjR+unNdZdzDLLeS6zRtXQpaBGRiyvRmx8zGa2ss7zRZBtYAGo8 oGLIfOtZg94Qe0CdufFw8j23TBVE8MQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749557587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=heKlbXfDgVVxe8Ad9VgCzHCzkhfC1CaiT7d1fNBqdeo=; b=BgMBc1f4JM9Vv+UPOsieDQCVtmGxCLDFPtlwkvfOkLHg68ZJsRFC6c29Mv4NjpiIe4sAh4 7dIVEDhT1P/OioQFfE9Kd+W3S5Tkfg/9EUnEVsEi236bGdIn3NoacW0pjeVsJ9Vr0skxzL NbAj1c0G+DPIoXkMBla1fpWuC3mzAwQ= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-528-_zIHByZTNMCjtTFLLKzi-g-1; Tue, 10 Jun 2025 08:13:06 -0400 X-MC-Unique: _zIHByZTNMCjtTFLLKzi-g-1 X-Mimecast-MFC-AGG-ID: _zIHByZTNMCjtTFLLKzi-g_1749557585 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 05BBE195604F; Tue, 10 Jun 2025 12:13:05 +0000 (UTC) Received: from bfoster (unknown [10.22.80.100]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E8BAB30001B1; Tue, 10 Jun 2025 12:13:03 +0000 (UTC) Date: Tue, 10 Jun 2025 08:16:38 -0400 From: Brian Foster To: Christoph Hellwig Cc: "Darrick J. Wong" , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/7] iomap: move pos+len BUG_ON() to after folio lookup Message-ID: References: <20250605173357.579720-1-bfoster@redhat.com> <20250605173357.579720-2-bfoster@redhat.com> <20250609161649.GF6156@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 6F61914000B X-Stat-Signature: 566u8gtp3xogqjyn15shybudjfmweb4d X-Rspam-User: X-HE-Tag: 1749557588-167022 X-HE-Meta: U2FsdGVkX18OglLTQfFSYHKjoW20Ab9zc80QDVdD72i3+S2fSZGrVLFKbW5MsJD+KaobrYQ4h1tIhuC4EMUfr6Jb0fPFCVfAWzPM/gAgn870vDj1Pz7LKwnVBo5QJvhJpY4QjactvdM4+2Iaf42Cxa5F09qimZemjX91WwxXiguqN9XtZuHZnpqh46v9LmuGvez55gFksxVQCqPAIu1t7x+6G9qANz9ffHsyqmsOrJtkT0YxEeeBipyCxQeBFx9Z4/F5LkxztK2B5KlDWmulBSS1FQiAbRQ2+pXo6gkvkzJlDuadDqLF5eAclRMzwbUWuYgwuTQU3k/osJvloBbB6xV9mU5UcQjvTu0A3NgRiR+xIR2awcbBQ6asWZk8y2r9wC9Vm7fQssU+3i8EvFmYu/jGCzVXCMMhAtHwJnBAWvPp+cC9ixP/mGAvsKmwF4736afidedP9Kcy3nuYVvVg00M57O/jZS6waZdmawWkfSMNzqzmEUYv30VTOWPlwB13dVxOU5/Z3AvdxZKpzRjYw4eUzfO0P3E24M0sn7goE+iZSSWc0RVohgwp+05hIzcE8rLWFGDnpYIwRXdOFFvP566NHOP99til6Y/51lXLBgvKXhVi/F9tZajKv6PDKavh1Su0kSkq4DPlD8IVNBoVPAcyh7AVxRx4EunpGmlYqzZVUrtaVec+9W1ppUn9fH2wQnqP9uQhDuzKzNBE/lHUZUWUsSRdkC2025WRf6JCN4dsid5aLwvmLpnJ+QcrTFTpL7vYQmA+X+QQgvR6CK26uc7w0WQ06yrj4//25BKIDOJyxzdfnWL9CwRWeOvkj5e9Wseltzy5d4SaC+HCF15S0OhFfqeCPUMJQnamFUT434xkZSRTVExN83/MRWl8qVOYRT/FXDP3WpcmS6EiCu6/0SZ5e/76ZKD4uoT25vNkXDquWlDY3LWgGqYsELJ+nUULPKXhO1O+FSQIV3n8uBn 70REeZDv mRpnffD5JBQ8jg0yexnGO081ChY97NTdFvLpnBEKCexd1D5ILbJX/SeCrOjhhODRo3KbSu4VdrxI7MOtnEMwdJHbrYeg7gpqEErYItYcYaBhMcA0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 09, 2025 at 09:20:51PM -0700, Christoph Hellwig wrote: > On Mon, Jun 09, 2025 at 09:16:49AM -0700, Darrick J. Wong wrote: > > Hmm. Do we even /need/ these checks? > > > > len is already basically just min(SIZE_MAX, iter->len, > > iomap->offset + iomap->length, srcmap->offset + srcmap->length) > > > > So by definition they should never trigger, right? > > Yes, now that it is after the range trim it feels pretty pointless. > So count me in for just removing it. > > Fair points.. I'll update this patch to just drop it. Brian