From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A39D5C5B552 for ; Tue, 10 Jun 2025 13:29:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24F556B0098; Tue, 10 Jun 2025 09:29:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D8896B0099; Tue, 10 Jun 2025 09:29:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0F0866B009A; Tue, 10 Jun 2025 09:29:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E110F6B0098 for ; Tue, 10 Jun 2025 09:29:14 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 873FD140324 for ; Tue, 10 Jun 2025 13:29:14 +0000 (UTC) X-FDA: 83539572228.27.CE3792E Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf30.hostedemail.com (Postfix) with ESMTP id 40C4F80007 for ; Tue, 10 Jun 2025 13:29:12 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Cl9Bf2kH; spf=none (imf30.hostedemail.com: domain of BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749562153; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=domkUHVehPfx76IBEd/l63OBFvXJh517vLAmlk842T0=; b=D4Zo00gbg5QDPe5hQUgJKGw88jLQsetoFXG4rGTKtXdlbE4o2/C5yJpVaEEwIEJioobYtU 0DYyuSNdhEndqvDUHAMx56il5GYsIiDnInUO+frhccZXQttbUMgr93tL2wcAMvw2dY4xog q8+H1nMGR6wWarx0vlwOojuKHa9iry4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749562153; a=rsa-sha256; cv=none; b=FALClHtF5cZPzNSbJgnUJE+KtFgLR/1bAu0oFnT8LZuHAuWLP1IERGFugNPsjdJxtONkef bFxfmZH0e+55f9jS6l25o4b1Y/Brp+pquQUzAJn1JNf1/wVKlpwpPYaBfrLf/BuUTepuP8 NZGHqdUSihgnOr95n6bYtmwjwz4mANw= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=Cl9Bf2kH; spf=none (imf30.hostedemail.com: domain of BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+631296521f62fa6b3e9f+7961+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=domkUHVehPfx76IBEd/l63OBFvXJh517vLAmlk842T0=; b=Cl9Bf2kHC7aUQRw4B05gV6P7R0 1BXN3hWGUcPJb+K+LzQ5vkM3XY1/s65aVKRlscQMkJRrBlIe6X1PKQu6ObwUYyUGW7wyLFiaDogwf q1QbJD8A62XPkw8vcS6cU8+fFu7VIk8ENZNvG/cWxc12DI7QMZHcGyWwTTLW9SaVUgPIuEo7EYIKU jWKBZNCrQSv3X6TkBJLOswm0C3QMMxF03XmpsNfXJlnmzoAoAWLp3Ygr2/bsHhqV/8yqS74018x3v siZOx/Pkh7PQ+bXiI0xdiDqUdFWGrY3Gwj1OtPEuqj79LkkVbZPW5yR2U5icJYFolMZczuEqS04ep SdYtj2Ig==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uOz2M-00000006yAI-2cTh; Tue, 10 Jun 2025 13:29:10 +0000 Date: Tue, 10 Jun 2025 06:29:10 -0700 From: Christoph Hellwig To: Brian Foster Cc: "Darrick J. Wong" , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/7] iomap: optional zero range dirty folio processing Message-ID: References: <20250605173357.579720-1-bfoster@redhat.com> <20250605173357.579720-4-bfoster@redhat.com> <20250609160420.GC6156@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 40C4F80007 X-Stat-Signature: 7awcu3m4b8qk18hr1iff8btpy9m1zb19 X-Rspam-User: X-HE-Tag: 1749562152-321721 X-HE-Meta: U2FsdGVkX1+vrnQeweqxDmTccmclUugQ5ZAP/lyyTXvgE1PbIX5DiHZ5SLC1V+NpWbqzktzyyHQ9xrW/PZ+SEPO0NMv22/maytM755UFlPpzpCGT6U406JaZrZlCuKU/+LRpJg8CM/v/UesjXHkKrSbq8D7lhHikxpdNMn/q9xagd1i0NHyzbYhxSY/igJ6pUmdmxOVUVwf73qNxXMVrPcj4aepVMiAMpOCdYQcLU59QkalfeE0cAvnrZiSQ9J7M4/cZxyNvfoI3EY0K1T8/Ibgyj6lOyAc0BI9jdm/uXu36U2obUYMxctKPOEbEVd6ST/FUWf5FSSrN4WXH9XVUAVw2h5Q9oj1uoX1vUSstbciWM+SaoanApD1/fewtWBsYf9GoQfdPX5szNchhH9GDlZ5IMWOwpyccSrbkfJ4PdqtgPwQpCm9/sPt6UWmACbVP8CdFtJ7ohuSS/rPCdfH3hfu2TsGjojRik4IsW9F1r58pW0b6J3BOzwG8TuSjKJSBjEb74d3ixUb84iE7m0I0Nz8poQEFgLABEUqpVIBON9Bx5bDejYDPNl5bHgt/zU3daOZVvxOtFUBjD2T84H/jGQcIBSHEIxehovG+Xw4FBN6dYtTUWedISGm9piTnsyKom9UbigUZuEFq6l/BDTXE0EV7wt+J41zjwaOK3jse2g8gIKeWo2UNzW98OtZtmWGLWys3fI/R377EIngF/RusjutnmHLHB64C7XtZjlEmEA6aW3pn/b6HoeOVKdigq4eYNUm7DAUqvtleeHfBKi6z3L9zKFfSKCjpnyHFWupaW7TXpkdTvmSCb708OxN3knSFOGKOH+dLBEIix40FQH9S38wvypvdYk9w9YRLNGstxY0i1xu/chLdis0SJ3B6vrMz4SQQauFZOziwqxrilL/CAvYcbpIlZgKEa1l7ANpcIq1b8z4uO7UbwbGtP75CA6QuIJbydenEXUkyE54yhV/ eE+szv4e Y4C3+nngGIoOomGeGdDBLSw19fiLQPUPYJwe/Ah1T/n5tGh5C8mlXjd8mvINE1Csr3ZySLMLfacQkKsp2ZdBh2vh02RoMSHqMo1hKDGUllZt8Un8xo8+rQPOlQ4ORFoxs8cqCOEchoF5kGBuiWp3SqWC3sPUfOj+icEnDY1FZ9F/9K6wGXQolhiLwUlWhmVG3xh/+Qzj1Zg3A27QkALWzwOUs9zI51D+h3nTKjr77bbimyYIe3cN0hpuVWnZ1yTma5Rx1hlbgIzsByKwQ1kuNSAmJap8dWr6SfKPcBttnrFbj/ZUFtiv2UZZF/JOOIYZrBJzMst43kZJlMJplT4V42PZyttOeLNZX1wjHEC98PTF+bgYoAxZ6B0SHtco3xZIJIBcIhaVmHOLFcd8nU7gSs+v7ohNXkDow8QRpqPOGQiHMLxzDZ/r7YaQrX2ci4/c8e2Rjsl5JR7O8ly9fR9USFbHmJxikgx3FSDrI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 10, 2025 at 08:21:06AM -0400, Brian Foster wrote: > Yes.. but I'm not totally sure wrt impact on the fbatch checks quite > yet. The next thing I wanted to look at is addressing the same unwritten > mapping vs. dirty folios issue in the seek data/hole path. It's been a > little while since I last investigated there (and that was also before > the whole granular advance approach was devised), but IIRC it would look > rather similar to what this is doing for zero range. That may or may > not justify just making the batch required for both operations and > potentially simplifying this logic further. I'll keep that in mind when > I get to it.. On thing that the batch would be extremely useful for is making iomap_file_unshare not totally suck by reading in all folios for a range (not just the dirty ones) similar to the filemap_read path instead of synchronously reading one block at a time.