From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57CBFC677C4 for ; Tue, 10 Jun 2025 18:51:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACB466B007B; Tue, 10 Jun 2025 14:51:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A7A6F6B0088; Tue, 10 Jun 2025 14:51:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 968CB6B0089; Tue, 10 Jun 2025 14:51:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 76FAD6B007B for ; Tue, 10 Jun 2025 14:51:52 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 20157B9DCA for ; Tue, 10 Jun 2025 18:51:52 +0000 (UTC) X-FDA: 83540385264.04.549A28C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf25.hostedemail.com (Postfix) with ESMTP id C5D2BA000F for ; Tue, 10 Jun 2025 18:51:49 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=FhWmBNK4; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=TrA3Wn1u; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=QilBw13s; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Hd6gaiD4; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf25.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749581510; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7mQHH+vhumL7j1yn5CjeuyhPzB/xFc8OjZKcCfAnLSY=; b=VTx+5t7o/S9cf0bTd9NReHwHFym+jidcK0EhCKn95yC4p8QwEwJbh3Upsb9rokPLUbcGzc VbQ6+3tXQlY9UxtfiRcJqHAwgviJ7SCtisZedMKRou62qLJxiHuFo8RVJwtCg9q6dvHfLA rJYdVCCkAiK15dDOi1gO/uLfOMWHoVw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749581510; a=rsa-sha256; cv=none; b=GUdpdSFKyyzQ9h8q/rqd2js70Em5kh97GR/WKtX+FpJvbCfRwkw/UvlMkcYHEvNUQAaqBD 3uJrie+Zv8IOdAvpsi0Yc6wFbidhElXgw3vRnqbc5sYABAqbSmPnbYiZl3+fesJ28aOVtt Oj6mSA9ng0iL2RY/penliDFpvJw4RkM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=FhWmBNK4; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=TrA3Wn1u; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=QilBw13s; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Hd6gaiD4; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf25.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id C4ABF1F76C; Tue, 10 Jun 2025 18:51:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749581508; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7mQHH+vhumL7j1yn5CjeuyhPzB/xFc8OjZKcCfAnLSY=; b=FhWmBNK4SlsBAz0cGHhQXWDUjYxTVy7wxoteIKaXh83YDzH3Dc06mfj/I7iOF4yrScpW3D Orfb9VJ5rsHF0CwNgxj8vTtCNoPAJsDtjOJA2SDvJgyUrt/MVnKAAORjF0Mt4NbE8jzcOY VxngHvqMQVwj8zvXW+ipspyTaGFtDi0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749581508; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7mQHH+vhumL7j1yn5CjeuyhPzB/xFc8OjZKcCfAnLSY=; b=TrA3Wn1u32KhOgjGEFyTfYktr6z8wooevRmrvqQ33bnMyGDwIyPaI+saRKZ9p9zANPaSes T89BUBHRZUaUjqDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1749581507; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7mQHH+vhumL7j1yn5CjeuyhPzB/xFc8OjZKcCfAnLSY=; b=QilBw13srQbiscx39rJPkukhgkxO34+Pa4ggEZTdpAZrs+7dWVjRhHk182x+kN5tyjIhKr 5f59F1LxTvX5I7R5oXRTNm6rvApahCi0KQl50f+9PjX1/T3GlZJN98deIsyxJ7R2DgZ69l Al1uiNiTNIxxA//P83GsoJNhLTTbwew= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1749581507; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7mQHH+vhumL7j1yn5CjeuyhPzB/xFc8OjZKcCfAnLSY=; b=Hd6gaiD4/7foGkYjndKWD+wby1+yyE0adoLeu1wrGZqiFwcN+jHL83wjp3ATzhbXbnr4ny GSbSlg9HlHzbHTCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 76667139E2; Tue, 10 Jun 2025 18:51:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ajdFGsN+SGjqDAAAD6G6ig (envelope-from ); Tue, 10 Jun 2025 18:51:47 +0000 Date: Tue, 10 Jun 2025 20:51:45 +0200 From: Oscar Salvador To: Hu Song Cc: muchun.song@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hugetlbfs:inode: initialize 'error' variable at definition to reduce code redundancy Message-ID: References: <20250609065615.108240-1-husong@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250609065615.108240-1-husong@kylinos.cn> X-Rspamd-Action: no action X-Stat-Signature: rh16dyjf3k4q9py7z9ghihamomcwh3oh X-Rspamd-Queue-Id: C5D2BA000F X-Rspam-User: X-Rspamd-Server: rspam06 X-HE-Tag: 1749581509-964174 X-HE-Meta: U2FsdGVkX18MKJRZFUWhgRFIQj6WkCVZ2AknWyJHkOMw70eNplV0mQ93qFHZCddeiM3x0R3cjJcyOGP5EHTlyu8C/g7kpSeRtXjwVmC6IqMca5zsiN0v8gP/p6zr73w4U5L5UPd4xRVZvlRvxCa32I6LZCn4gyLhgpLXozsSKCZfj2sgWOBxEFHQuruQlRC5Iv6UVJJsoUCi2ZViHW7okfGMtEf5X5F3CWoCXU9z70OrfzlWYenBaJb5LtQ/cwokvGpOqYwyMFgD1jQ0Vf2VQxiB5fD2CPqk+FxXQVK5lW5UQ3lV48Xnbrg0lVZZrWEFLND+FA9UozI+cZvJV0nF5YD4x+NeNdfXoyVV7dXeXNhbx7BlZRtBFo0YMlN7KVzosFSv5S9xwN+KLSyt+KinLlR6K/HI50Zz9AKrKANnexcuXZrcVePnGAoVLtOY5yOZiKDy+/ZO/reja4KYDjz1oxRWajtvU6vDGOefzrT2i6kImEDqbLLx3Mf0rr8iz05HEU6TnUhjX0apaFpl2vgg5APTyvBG99c6lXtP9FffcS7s5+UlK46dvOVAj+e146bYrbE0fFxOuCDnCrLZK1NGgi7IhPwaktHjxRxkclwiyXAcg3IzknJ7/YfOuNR0L8v5KdoMfneTy46m6MZg3S6JSt1aBxFway9Gak+rV8ZJ9Drcu9XfNPXk3dj/shAXlOzDiYBvDtse7eMeQkr0E49G60c39pbE8lZ6RzUJUxvv+ArV3k8yPjy1gkCVUlpOAdLShNOUPQVGGQxO+VR66K/nTW1SCBBn//ZTYBL81DoCy7rf+PMw5XDwi8HAYdGxF4/8MLc0NmjmC7u5icU7ZDlgpqSZ3tg36vvXSEgdcDGYTHQzlt7W4dYY5OHgFq+xUcCHocgykjVtUdrFQe47s+JVVHMXFHfwO67JNy9s/bCJqniU549/OqKrX2nmIvkh+ivxsk+ENZEQzTr3BGzm8pY M7rVHM4z ZxgMdYPx1eRhu/J6NKZ4rM8ew3L3Hr7/4dp4KK+/jgA2wgh8LXSZzz0sPYuevOxPlM5tV29FVNgvaNyO2N0J1DFu8jD11m3ZRStg419DOuS+x8BgRiJTiptww1y/1zml4r2efuOUxSqyEzzaLUkIiQrAl9UT/VV+/cVm7PUB0Xis6nplAVwnq1jOcd8pBFTnHBCN3wu2PcqohOBXHHG43nRd3MR7GMMaGHrtClLficH7j/fQRREAYNPCBGzR/tRZYi+lSD5gUtchy1n4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 09, 2025 at 02:56:15PM +0800, Hu Song wrote: > Initialize the error variable to -ENOMEM at definition in > init_hugetlbfs_fs().This removes the need for a separate > initialization later and makes the code slightly more concise, > while still preserving the original logic. > No functional change intended. > > Signed-off-by: Hu Song > --- > fs/hugetlbfs/inode.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index e4de5425838d..390cddd5872c 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -1600,7 +1600,7 @@ static int __init init_hugetlbfs_fs(void) > { > struct vfsmount *mnt; > struct hstate *h; > - int error; > + int error = -ENOMEM; > int i; > > if (!hugepages_supported()) { > @@ -1608,7 +1608,6 @@ static int __init init_hugetlbfs_fs(void) > return -ENOTSUPP; > } > > - error = -ENOMEM; > hugetlbfs_inode_cachep = kmem_cache_create("hugetlbfs_inode_cache", > sizeof(struct hugetlbfs_inode_info), > 0, SLAB_ACCOUNT, init_once); Uhmf, I do not know. Often, we tend to use those declarations in order to mark what error code we will return if we fail the next operationg. E.g: error = -ENOMEM if (try_to_allocate) goto out; error = -EINVAL if (check_params) goto out; out: return error No really strong opinion here, but I'd vote for leave it as is? -- Oscar Salvador SUSE Labs