From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64079C677C4 for ; Wed, 11 Jun 2025 03:54:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC42A6B007B; Tue, 10 Jun 2025 23:54:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4DAD6B0088; Tue, 10 Jun 2025 23:54:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3C726B0089; Tue, 10 Jun 2025 23:54:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9556C6B007B for ; Tue, 10 Jun 2025 23:54:15 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 319ED1CDD0C for ; Wed, 11 Jun 2025 03:54:15 +0000 (UTC) X-FDA: 83541752070.25.F87C853 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id 293ECC0008 for ; Wed, 11 Jun 2025 03:54:12 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=dtSQsPco; spf=none (imf22.hostedemail.com: domain of BATV+d633bb5ca9b5c368f99c+7962+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+d633bb5ca9b5c368f99c+7962+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749614053; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MprDUbh+gGPhemE6iohYc3WODyPSYTtQz588hZeuMn4=; b=HUi4JGJZvBRe5SFMhxgeFU5E/KZqzc/006yQcJ3dEwNukQzs8mnmeDxQ2gguczRZmjiPpj Ml/Nwgrwx5FTBgCH1jCc4TdIBUsctSbukKAjXU7PVCeWNOrj/fjvMgY355ud3MyjIHj2jt r1auG0d4W1Wavf0GdlstvOBXJyfBa0o= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=dtSQsPco; spf=none (imf22.hostedemail.com: domain of BATV+d633bb5ca9b5c368f99c+7962+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+d633bb5ca9b5c368f99c+7962+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749614053; a=rsa-sha256; cv=none; b=szLEfb8QbJ3IaQWf87QBjvFtyukvf+Hv+UM9SalJ7a2O5wRcdm3wBbCJoZh/Z4JmLaU+xp taNIbApCsIVWT8jAYIFcjqBmH4nMZIOQ+uGyBVhi/U6J+40M9zAYJaIYNKbD2tIOtSLIqm Hf8pPqkzhneBCv+jS0JQ3lGKUuo2Je8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MprDUbh+gGPhemE6iohYc3WODyPSYTtQz588hZeuMn4=; b=dtSQsPcojptqxJG/Gwd89Rtc8G D8nGFwBKrCEyWneenM2ZTgRL6+Q44f53zDo2Yt5pKgI/jt99Xma+tgZHyemBAMO728PkTseH3cHlk wRV1UwegwyHyfiuCU64NNLpUtnaFQFHYHEFJhBFRjeogCh1w0VxD5SUFFyHHylLtRNg6Ac0y2lcJY bMT9YhCvJfpmpWauQPekyhAwnl6Xcr9Kqu+uU3qTSnNUKveCkul3ykvQugyv+8rC8X2dqvIb+rJm3 vhu4z+xnZIGZbd2y4kFd+YR5+U+JFx1JSh/Sho2moyV/jEEqbm0F36JBtapmRygvadOd2Na+7rSN2 +cuj2/WQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uPCXT-00000008maB-2bqn; Wed, 11 Jun 2025 03:54:11 +0000 Date: Tue, 10 Jun 2025 20:54:11 -0700 From: Christoph Hellwig To: Brian Foster Cc: Christoph Hellwig , "Darrick J. Wong" , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/7] iomap: optional zero range dirty folio processing Message-ID: References: <20250605173357.579720-1-bfoster@redhat.com> <20250605173357.579720-4-bfoster@redhat.com> <20250609160420.GC6156@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Stat-Signature: du9frp5q6rg39i6ya3xtt44s89uejfxk X-Rspamd-Queue-Id: 293ECC0008 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1749614052-86042 X-HE-Meta: U2FsdGVkX1/kdDZ8Un3nu1QJdMxZOYhhyJV5DwbwlRhZwlRrMkeUkndFj/GVtMu83rAXfjszfLqFyPgbzo3Qa3XnnQxtdBfPK0J4AgVaXbWVnI8phUqFiaQT/IswvTHwf2GsucVGQn+jg0SQgpoQSxxJxqNi/c8Tl8LNL03KnvC/ZpbP3723GMsVr/iF471mXOaOf3yHuLcBo+3fQTY0zLYVJ2X/3r0XbMXnHCNaGLBSD2Qh2FGDVjED3Aaqmp8pOfmhivfa38RnkhoI58FQWw+2Zb9u3Pw6Jae2T5NVJE7DFPy3f/MowJxG44mcqC0SqTKrAyQQSs3i0HB9ZYxTcQl5V571Y5IP7vVkVUWCMEZZqo42I8nXhZCrD+q7lPp4orA7ZDWfUqW1CkCHp2l3T1N7yC5LJt5A2tnB3yOSLj7ej1/fcr2Rpm9sdHm/jql91X7kGU9MZoSpPPjn/0xO05EsGef6eyiuCllOvevR+fOck2DB5cxcWCIIDq6XOYsVc8y03mtuWOrE8URGDqt4MtSbIKsE0ZpV0rUFdTukd1yiEDczRQzVnmU2QjdMVvqW2R1VMbSRNuBv4NhbqxYNX7iM99MsnG1XsUu1WQy3bC3YSHVfwsrEsg1h7AbnR8wtsIBpC4YDMLkSRqASRfkCm/x0fiBPC9WBSEVUa9kbZWaOExuF4sFzFQ1BN2S1Zu9ooPPTNPGGj46i26V+8dTpbch3UhkQbWsSDULu8tbXAHH9NBgO6fvsUgTfS2LUoB6Rxcdq9YmfggjzJTqf3T/p4VSIQv/wpp9Fe6a3qx0DU+qZY3BH0MwI4J0SSy1OkCeTqo0g40V3z1OgjW86Vfi+tlSdL47vnn7NFZv228PK/OmB7HtnvvYntdhMnTu1Tap1Mo6WYICqdQg6us3H5MUjAVQjJZMaJEmLnhh6nfzWZ9vcAuR9+30HbV3zGrzKaiGmhklwMb0QHSmpyUxcmG+ kc1R6vgr 6zdHrYWgrVtbB8YhDbDIzrxeTkLMHg14C//lMxO5+1+MqsiIveLS7LNP3z3T1U4G6yDjQqtd8CbtoUQyKk94rN8pd2EN2XA6XYWCMGBo7hOD2rdHrCk4DCg4zQ+xkeTsBTjGKiJUIzWqeLiLyuCuJiVDT1+ekGX72FeVOTGFtM1tLOt6H2Qf2p2Bms9HySb3rULhlo2+5lXqogwKsdggGAloX7Z/x9VdeU4jp0nz7KCpi0+vFvC1WKlG5G1nw5Mao3yOPC57dmYJxfgzMfgkWeTb4S2MUwK7HfgoNT6Qm5JXH/CopdCK73ues9Hf8FKqE/RX3pp+kaj83BAWkTCXUfGeMn/cMBjidYv8ZiWq+AtC53XN8h1OxWcokzlq1ScTu7tymkZkkarC1JZsmnMF9pWXnbC6FLAIH2tceqPi9b+YcnsGPTbgwoM/uH7thW+RQ0lRgAfy7JSYjs3hTTtG10GNvqBmsPuiRcvKn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 10, 2025 at 10:19:35AM -0400, Brian Foster wrote: > > On thing that the batch would be extremely useful for is making > > iomap_file_unshare not totally suck by reading in all folios for a > > range (not just the dirty ones) similar to the filemap_read path > > instead of synchronously reading one block at a time. > > > > I can add it to the list to look into. On a quick look though any reason > we wouldn't want to just invoke readahead or something somewhere in that > loop, particularly if that is mainly a performance issue..? I was planning to look into it once your series lands. Yes, doing readahead is the main thing. But once we start doing that we might as well try to reuse the entire folio_batch optimization done in the file read path, which has shown to be pretty effective.