From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ABC8C61CE8 for ; Thu, 12 Jun 2025 08:58:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF0286B008C; Thu, 12 Jun 2025 04:58:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA0056B0092; Thu, 12 Jun 2025 04:58:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB83A6B0093; Thu, 12 Jun 2025 04:58:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id ACBD16B008C for ; Thu, 12 Jun 2025 04:58:03 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 14845BE4FD for ; Thu, 12 Jun 2025 08:58:03 +0000 (UTC) X-FDA: 83546146446.29.EB580F1 Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf06.hostedemail.com (Postfix) with ESMTP id 7B95B180009 for ; Thu, 12 Jun 2025 08:58:01 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BRWbeulX; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749718681; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RVjh2riU4CcTq/3jTD/IdHxLSXZuJ/BRDGyHFr9phiM=; b=ucXsTp8AZ9sl2CXzfXVAxVmJ4CJNl6lY9Zda4Zz11CimPCX/cv/3eQeQ7SSadHryCl7AV7 iqKrasAFzYtfsRe0nz6+A/Qh9rHxgLlypW4Z/YAAMoA7+cKkQ9UV70p4MHgym6obeW8MeZ NZ/WBzIB13YIsbaMF1fPpmzIWkw2tYw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BRWbeulX; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749718681; a=rsa-sha256; cv=none; b=fkOeKRdM3fXbdqQ3xsFMG9k1X9v9quivq/iC0X9SLsC96wBRn97pkTpdQ/vi2Iu0kpNPmc 8fkZRQ9lqWagOB5lwDuUYcPvva/qH6n+LIRmdI/3pD6YLmwOX7fDxWSCldAXQVdUEVjX24 cighWfoc8hpa4L46LAqbfOesYIhkJxk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 9049660EDF; Thu, 12 Jun 2025 08:58:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 03E3CC4CEEA; Thu, 12 Jun 2025 08:57:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749718680; bh=BypLNqwBlyb9rBmpUWSRlT4eLHQJ96bKDnE5K9dLUG0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BRWbeulXkdN4ok9yIEgSL+AxDcjiHgVrzKUttBjEjCJRA7theN+HcP7h7GIkvq2fx DfUdY9qcFt1YSg/O4JpAYBIZKU9hVfCJpfO/cD3G4UulkhyrynbA0qhMJhcjsHuf/j CKhTvB1YFnCWKjV0TsXKgtQEXY/VVlnx/mSakcuQ1W85arY7TQqHY0cq6ucYAVliyv LBFNDwvzSEeCL4Vy+2AlUwHfKRtrbhAf/KeEwqk8AIPhD6XmBgMG9mJXiSeOwAg1Kb E9x2gnsnW0avJ3AG33q0w6NWtz+YUzS3DoJVFTjY8laOAnFL6SYsm4gkNNj1/sMbiR v+mq4H0ZEdyBg== Date: Thu, 12 Jun 2025 11:57:49 +0300 From: Mike Rapoport To: Hao Ge Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Richard Henderson , Matt Turner , Dennis Zhou , Tejun Heo , Christoph Lameter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Kent Overstreet , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-s390@vger.kernel.org, Hao Ge Subject: Re: [PATCH 5/5] mm/alloc_tag: add the CONFIG_ARCH_NEEDS_WEAK_PER_CPU macro when statically defining the percpu variable _shared_alloc_tag Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 7B95B180009 X-Rspamd-Server: rspam07 X-Stat-Signature: 3jd9ex7u8sqhdn5f1t8p13hi5yx9d5u6 X-Rspam-User: X-HE-Tag: 1749718681-631067 X-HE-Meta: U2FsdGVkX19RnLCazwQJ1DAENX2Qje7oARaGGfj/LgtbujjjVqhaTC6hwijgb6XBtUEwYhcjCaFnRAmIEYwSY8be6K5xJmGxiQmpX54b8E4/1kZOfnsuaXnefL9FbJCJ5222rzFAbP2WTNP2+NCftMVaEcKnSSB+qxHlN6gJUMgRS1f2YR47P+6kbk56RnGgPGJuFBq7+x8CUBCRrRGSD0LQJn6oTvjfSIfzcG9kkQkpytbpt1HAFTcySKP4eo61MAVM9f6tBSbSLZEkVdVwIkTOCl70qDwSB1kKfQBA7DdkEOt/RRuiNXLUgMq2wKj5zWNGhovLxmgiKQgZA/VjRHeA0ld47PbjDYIO7Sgc9FRibS47BaWaDb9j+2yIhE9BngGlZk8p2BYiRdO1r1Jv9aHx6CYCGSDHqfqlkQq0hPu3an3J2ng0fi6MuoZvhgU+80OzP3fUctBi17KpkL1wTP706ws7Uq+mi4NyR+M+B5jIASKaqJvbsD4PA3gHNTBBgyh/VBxOk2hVV4A3LmSOrWF01XE64/9rKS32p7IMjzlY/XcCv+odIR9bp3BpRgV+6Q++7FbtOaVsq9u3Lm8mW9p17O1fzmkdd9hJ5WRJHNQ51JdFVvfUrJ6BtxQIAqzbmXhHcGMvh9uKyIkcoqcOQ/WBNzl3K0ypLTdx7bqsj/TTUA5T0T5c//oHdyRgy8pQ1S1Mq9muiKBoYb9Izv5AksrtJXrjHG1y+BhcH/p4bjHE6lGjXlTjBfFhHw8Ayg+W6Yol/EAwoUo/Itiig98t7r8DZDn6LIYqyNLDqrtZlp80YA7ZTm2MzAOyDZVGmcpgf9ocY+LbQ6uxIS3APisrtlwnFI+/CI7N84h7YJVTiKucsOW+0xRxHbfO9eM3JmvyxEv9wENeM1i2Anbsna1wqOrhyMTGyxNsVqitmvy3bwE+yoHOVed1m6cHvxv/gNONs+AMJkoSV3i6yXBPgbl qs1Fp6BM 42bm+dn4vWQiiPzM3n/bAnzAbtpdsw59Qxg/Wczn3L+Gty57VbBSaTJvdB/7aOjam7nemckPIU7y+NEc8bE/K9lITOFVayHMrZUztW13VM4fIaeTP+g4m41Qx1bDkvz4R5Kr54uFXJbUjqDTpb4m/mRLNf0ZdlOx0EzYrvoDp3Bj5JGY0AOeEQzs2zOUAm2ZhlMI7CbMrYlGtJblhvsjCJ5rHYCiysJup1OFfpxJADs7E0IlgeLZKvXUQDin2D4AvNorWx+gx+KVz9wQA48A5X4ZvleWtuZ99XR0hl5s0HrYkud4WSv6rwUa7/ww314td7ln7r2dMbWjY5/k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 12, 2025 at 04:27:30PM +0800, Hao Ge wrote: > From: Hao Ge > > Recently discovered this entry while checking kallsyms on ARM64: > ffff800083e509c0 D _shared_alloc_tag > > If CONFIG_ARCH_NEEDS_WEAK_PER_CPU is not defined(it is only defined for > s390 and alpha architectures),there's no need to statically define > the percpu variable _shared_alloc_tag. As the number of CPUs > increases,the wasted memory will grow correspondingly. > > Enclose the definition of _shared_alloc_tag within the > CONFIG_ARCH_NEEDS_WEAK_PER_CPU condition. > > Suggested-by: Suren Baghdasaryan > Signed-off-by: Hao Ge > --- > lib/alloc_tag.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/alloc_tag.c b/lib/alloc_tag.c > index c7f602fa7b23..14fd66f26e42 100644 > --- a/lib/alloc_tag.c > +++ b/lib/alloc_tag.c > @@ -24,8 +24,10 @@ static bool mem_profiling_support; > > static struct codetag_type *alloc_tag_cttype; > > +#ifdef CONFIG_ARCH_NEEDS_WEAK_PER_CPU It should be enough to add #ifdef ARCH_NEEDS_WEAK_PER_CPU here instead of all the churn. > DEFINE_PER_CPU(struct alloc_tag_counters, _shared_alloc_tag); > EXPORT_SYMBOL(_shared_alloc_tag); > +#endif > > DEFINE_STATIC_KEY_MAYBE(CONFIG_MEM_ALLOC_PROFILING_ENABLED_BY_DEFAULT, > mem_alloc_profiling_key); > -- > 2.25.1 > -- Sincerely yours, Mike.