From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10FEDC71136 for ; Fri, 13 Jun 2025 14:19:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D6E86B007B; Fri, 13 Jun 2025 10:19:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 887796B008A; Fri, 13 Jun 2025 10:19:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79CEC6B0095; Fri, 13 Jun 2025 10:19:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 57E5D6B007B for ; Fri, 13 Jun 2025 10:19:38 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 03225C0960 for ; Fri, 13 Jun 2025 14:19:37 +0000 (UTC) X-FDA: 83550585636.23.34D73E7 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by imf21.hostedemail.com (Postfix) with ESMTP id 05F311C0009 for ; Fri, 13 Jun 2025 14:19:35 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Gb9RYyb8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749824376; a=rsa-sha256; cv=none; b=QWxgQDNwJgMx91rxydlf1Q1oKK4A0DJGDiT3HXHG42U0+leECzgjU9TTQuIFIwRAPIBGJx bdsUgcnbujxb/pwy0DUMsPwIovGZU9d6cRkRGJmr/StJbryyiN3iu/In5QCjsZQ1gx2OVl rCfy0LEuXyE/9DwJ7mSlZPRZlVwJCyQ= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Gb9RYyb8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.170 as permitted sender) smtp.mailfrom=urezki@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749824376; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gv8I1GvTHth13eKfrZUg5M6EkOo2RTJ8/9XLE5ScqU0=; b=O4thEpWVTtQSR6rMZlyD95oGDTEQnp+wFaZCfHUdz5UmXyAeDWAx/5RUtZ/se+oOLyEI5N k/v3FnV8AUWEb1APzgny9/khn6WerARiPQiDUMsLGDkWELeGr5xLACHMmo1teNzoj72dFO JcyzZHwwAGvb/MFFh4JXxumLZG1KtOM= Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-32b3a3a8201so12760371fa.0 for ; Fri, 13 Jun 2025 07:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749824374; x=1750429174; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=Gv8I1GvTHth13eKfrZUg5M6EkOo2RTJ8/9XLE5ScqU0=; b=Gb9RYyb8xOiuv2x7UN4IKDGN8suismq4RxUaVqpatML177PkMxAJbpW35+YYylcwTp 6gnaiEtera3rljdYLLqPTxpPGwoghDB4fZgKY24/olm6bsziKCLW2FbP10jTsqXN1in4 xDDOEDkgCOkxfde1Ktjxg4zz4S+HxK+aOS8hyuV4yFlQfa67NXXH7pMPVpfh48Bs0bHX iBCN7abcPfX0ltw3oGja3Q/PBP7zOO4DfA19h5R77z6IRFZ1hvmDLiieZ7ElQ3qo25s0 2GCwvbdd6nHxPNpa6+WcdSQ7uEqOriLO7dlufWagspYpyjUsJZx7PGVHUCpSt+yh/A3V pXWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749824374; x=1750429174; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Gv8I1GvTHth13eKfrZUg5M6EkOo2RTJ8/9XLE5ScqU0=; b=FPMcfKIaBHwq3CSWC+YM4jPoc0COoj7hs9ToVgYRx7MLuYpvABBl40tu9/w1DhX9eW MnqUw88MFrSBz8vl80FMuKfNn7gQ36vXaI0TCpH7PRblcHpI66fYGPx6wsJB1a2zbyXd akh+FNaeGvrgh9VtnA0ybcXLpBaNH2mqOKskl4JhG31N+iTdtw14NjQUr0DyRbKgenaY 26MFm5oX2wDZhV4xUi0WcQLaFqLcS6uV5vbu4hvHZG7OnvB4x93aZZUSif3qfy7GW/Ar Lr4KtYt5/ZojNsjPp5TUOPVTQqRLgC2wgQlmQ2db6uR6t6bRo/bCaY2DeK5XdkKvNbm5 XezQ== X-Forwarded-Encrypted: i=1; AJvYcCUYJfp9nkX5L8d3q8ewi1g+iJT1bz3ZIzngdUyrG5eeZm2cJ3DMZC2Eg2FL3NPiKFTJ3E+AS30/ew==@kvack.org X-Gm-Message-State: AOJu0Yxj2m3vGPtCrONMDnjCVaaoKXhE0gXtWXjwT+MmYqOJn/hc3nRS KOILZV4JpNqRrvNBf4SqI+sO7FOBgEKgwFulsItcpCNGK/JrjX1eCXNu X-Gm-Gg: ASbGncuUINcPrAiorLXjajiZ11ZDuuZ4LBl0c0tXKvp33huCy2QldvUjNbho9znp9zC oIJDCgpO2utG0SUjCnXoBaCJ8A1ezOn4NTrWpCh6Tq1+aUxyySEfLQldp24utUO1iULoz3Dof4P v2qZtyN5yEsvTG9E7EzckBZ0IDXb5PGotVgJKyP1ffzAJ2xYJTRJkdB6m8Ru/r51oDIyAkYdDVx 63+w33oiMVWtjbSt5HePsILmBzNulapNK/x6Pu9ubYDHnPtvD5sN0Y7gTZrHUe4nkpged6LQdbl OyO62AiVt/6igwIIjwQTNcRrt2884XzVYFG+Br/nfeR8EElARjsQZz7Se5wngqzS/tlb+Z1b3k7 AQuHlFKkFDuA= X-Google-Smtp-Source: AGHT+IG7goMirBRQmDPAqY7PXhhkJ6tXRdtqjscRKWJowWlCVBZ/NcrvEhvkOqwn6Mfkf9bRzm1M7w== X-Received: by 2002:a05:651c:1503:b0:32a:666e:9f14 with SMTP id 38308e7fff4ca-32b3eb185a4mr9327241fa.19.1749824373735; Fri, 13 Jun 2025 07:19:33 -0700 (PDT) Received: from pc636 (host-95-203-1-180.mobileonline.telia.com. [95.203.1.180]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-32b33170a5esm5606011fa.71.2025.06.13.07.19.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Jun 2025 07:19:33 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 13 Jun 2025 16:19:30 +0200 To: Dev Jain Cc: "Uladzislau Rezki (Sony)" , Andrew Morton , linux-mm@kvack.org, LKML , Baoquan He , Christoph Hellwig , Oleksiy Avramchenko , Ryan Roberts Subject: Re: [PATCH 2/4] lib/test_vmalloc.c: Allow built-in execution Message-ID: References: <20250417161216.88318-1-urezki@gmail.com> <20250417161216.88318-2-urezki@gmail.com> <6c6f1cfa-7f1b-4133-ae2a-c6b1ef2d82e8@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6c6f1cfa-7f1b-4133-ae2a-c6b1ef2d82e8@arm.com> X-Rspamd-Server: rspam01 X-Stat-Signature: dfi1ge8p3uynxe9nrf8n1zds7gnzyj7j X-Rspamd-Queue-Id: 05F311C0009 X-Rspam-User: X-HE-Tag: 1749824375-906441 X-HE-Meta: U2FsdGVkX1/5Op8CiuPFPVJSmTBH2gqwQ332tLjfk87SVE8pRpfRgr/nFixsQSLIJXDlPhsS1JHuiIdZig9rEP1XgWRMEa/TczQee2HUdfkdPlfTmtgDwtE8cdgdjubFdzHb8v655BzUVNOQ8jFzb57jj00zZ3d/vIh91ZAFmD5CEZ/j1Sr5Po6mbwRb30n25sYjLZe8Ggf29Htu1BHrFMvb+aA/CwEQwPpBdNcoqObfvZa9Z0v3tTISW3GVO0eKzAVZmn9BJgnWnN31ZIenPrEiH4b7JWwjHr8ubrCib494fP5L0UUh3fPv0a+vO70H0ky/6eerljA3ao84lHt+xOh5Gbv6lSBoPJVS3cqgfQ7h6nYLpDLNqzAMmEkOT46+0JepjyoWQe+b4B3fyamWz1QSVbGzqUp8GX/JlOzN/HgXYXNvOiRqR4gm+V119JKKt/eT3NDiT62nxPIJJveAIvB7BVVIHwNiAvBvoqUNByJHJjMwKEd5K/D0t0cMigizhZhVRQPd0AEpTTeXVBJRpLoxhxr722jT8gcKfHzoMiUMAS4yu62Lckg1t2P00j+UNsWGC6xzmNqL8ca6JuSSm72ZTlhe9mWRMfkAvYxjSlfsWO265nvApMxAf0Q4tkcSjOJ23MjiIHpPYX7r3W2n0VO7RpJxUV77T5OJMG+4v1bgO19n80tCyRVGSdIbV9aSi403lCBPCo4FaUChElhzeQtswrH8ycZQYiXpxW7RGpzip3bqvsdWCkyc6wf1Yy0oK5KDgHitBWBDyXuES10gU4+ruF/nldb6AjeDxHQLqxAoC8HjCU0YFjK+5TB9n9Bi8cOsK8A0n9ET9Ro07StPprmLwxb/8/oR6K2MbmdIc6IRVbLcR0xuOzmRdFIsfjyYN3GwofuvYr41YdJkwz3V6o/l0sW5Jzp04qI9ZntkPV1aPeBVdTo8pg8a/oo4hoRh6iyIfjKxbQp89A/Zz2F nKPqMPuw k1wUCkyla6e5uQHwa5Ciq2T694p4CQ4bcWX3QuVnYVYwa1oa+B7b/d7vK83Rt+HX6kxihCtz4gHxsbLjMIlyoeicldQRyfoZO0RjIQSAwzch579Z+BPMvSVDkAR7gm/V04QaXVBASPOwx8h1lnrGjIJWil1z4BGK+79qIYqdH1iceETnFebHW9eveOFImtSteFrRVmWmOm6r7QZWMuPSWBdXE88XMp7EuIADylCgPNLX7HPwVPbFWa/renuvVfHM9eXoPnE4OFNQ57Ql8GQJplF7eiBzpzWS1somEzvtvvd5XcN3HXN14ThTYJLSBRWAtq+ho5e7Hg3bV9dYbDc2aaKzSyMm69zqTcXOrkTGmV4SE7Kog79FpQ1PGkXC+oiYxSBCH4m7323hVzz3TqKDTtIlzYmE7EoqO6FulReqQDRUrnxDkl96MLN6HO2MTjl80sRn/FB4R/jnJg+AicO1zC7K1yQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, Dev! > > On 17/04/25 9:42 pm, Uladzislau Rezki (Sony) wrote: > > This patch removes the dependency on module loading ("m") > > for the vmalloc test suite, enabling it to be built directly > > into the kernel, so both ("=m") and ("=y") are supported. > > > > Motivation: > > - Faster debugging/testing of vmalloc code; > > - It allows to configure the test via kernel-boot parameters. > > > > Configuration example: > > test_vmalloc.nr_threads=64 > > test_vmalloc.run_test_mask=7 > > test_vmalloc.sequential_test_order=1 > > > > Signed-off-by: Uladzislau Rezki (Sony) > > --- > > lib/Kconfig.debug | 3 +-- > > lib/test_vmalloc.c | 5 +++-- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug > > index f9051ab610d54..166b9d830a85a 100644 > > --- a/lib/Kconfig.debug > > +++ b/lib/Kconfig.debug > > @@ -2574,8 +2574,7 @@ config TEST_BITOPS > > config TEST_VMALLOC > > tristate "Test module for stress/performance analysis of vmalloc allocator" > > default n > > - depends on MMU > > - depends on m > > + depends on MMU > > help > > This builds the "test_vmalloc" module that should be used for > > stress and performance analysis. So, any new change for vmalloc > > diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c > > index 4ab23e5e772d0..6d65ef725d42c 100644 > > --- a/lib/test_vmalloc.c > > +++ b/lib/test_vmalloc.c > > @@ -591,10 +591,11 @@ static void do_concurrent_test(void) > > kvfree(tdriver); > > } > > -static int vmalloc_test_init(void) > > +static int __init vmalloc_test_init(void) > > { > > do_concurrent_test(); > > - return -EAGAIN; /* Fail will directly unload the module */ > > + /* Fail will directly unload the module */ > > + return IS_BUILTIN(CONFIG_TEST_VMALLOC) ? 0:-EAGAIN; > > } > > module_init(vmalloc_test_init) > > Hi Uladzislau, > > Post this patch I am seeing the following problem: while booting the kernel, this test is > executed and a particular testcase triggers a warning splat from the kernel, then the boot > gets stuck for 3-4 seconds, then proceeds. I am not an expert on modules so I don't know > what happened but I am guessing that when the test fails, the delay is due to module > unloading time...do you suggest a solution? I reverted your patch and then proceeded with > my work, so apologies for not having the dmesg log, if you need it I'll replicate, although > there is some subtest which has consistently been spitting out a warning on my Apple M3 Linux > VM and I have been just ignoring it for long : ) > This is because CONFIG_TEST_VMALLOC=y is built-in in your case. Therefore the tests are triggered including the ones which generates kernel warnings, which is expectable. It takes some time to execute, therefore you see a delay. By default the CONFIG_TEST_VMALLOC is not set. This is just for debugging purpose. Please unset it in your kernel configuration. It is located under: Kernel Hacking Kernel Testing and Coverage Runtime Testing Test Module for stress/performance analysis of vmalloc allocator -- Uladzislau Rezki