From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B45EC71136 for ; Fri, 13 Jun 2025 20:35:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CAE976B008A; Fri, 13 Jun 2025 16:35:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C38416B008C; Fri, 13 Jun 2025 16:35:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B00216B0092; Fri, 13 Jun 2025 16:35:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8E9FE6B008A for ; Fri, 13 Jun 2025 16:35:38 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3C610140327 for ; Fri, 13 Jun 2025 20:35:38 +0000 (UTC) X-FDA: 83551533156.21.1FFEEB9 Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) by imf02.hostedemail.com (Postfix) with ESMTP id 47C4680004 for ; Fri, 13 Jun 2025 20:35:36 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="fI/PyeGy"; spf=pass (imf02.hostedemail.com: domain of 3lotMaAYKCCkXJFSOHLTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--seanjc.bounces.google.com designates 209.85.210.202 as permitted sender) smtp.mailfrom=3lotMaAYKCCkXJFSOHLTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749846936; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aD6EYmSk/zIl2SjxJRx3+64lAlSQfo57iDrafX9vuYg=; b=nyvvgYUbv5X/y36/wAmhYWcG8hh+Jjo7c7rPhb/FHbCQlLsex/eK0apALZd6zgAkLuLPrW XnHQexziIJdtRyb/wDPvwYXvbi9yGkjTcmTXciJsgqkAEvyAfHUVwtdgUSaE6/GB6nthv6 ZPpEVQdUR1QAiJ8p8QcRmMXx/MJkfxI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b="fI/PyeGy"; spf=pass (imf02.hostedemail.com: domain of 3lotMaAYKCCkXJFSOHLTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--seanjc.bounces.google.com designates 209.85.210.202 as permitted sender) smtp.mailfrom=3lotMaAYKCCkXJFSOHLTTLQJ.HTRQNSZc-RRPaFHP.TWL@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749846936; a=rsa-sha256; cv=none; b=g2eCnJglqAE1jb+ic/Vul4/BBQ2MJUF0FAvpQdTYNvO2E5QZVOqUUN2tPWJuBV5GlHkK76 JFlkKBDCe9j9qlMa6rdI7RxyhLAfXrehnRhqi9GN0HP8Ge2LgPcPuf79WFjouYxdpa6T3u 1F8CRcLT9ksQmlAk0+Xa+5+2UXQyi28= Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-74847a38e5eso1645003b3a.0 for ; Fri, 13 Jun 2025 13:35:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1749846935; x=1750451735; darn=kvack.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=aD6EYmSk/zIl2SjxJRx3+64lAlSQfo57iDrafX9vuYg=; b=fI/PyeGyk4IPezJG9p/M/oNRkhvuYeyt/87Jj47OXclKt+IkayPdsjvS88jIM8kPa1 7dBzeIjgyqflDaZtIFXZ13dVDXw+nEjT6nIlOtbGgsW3Ct7X/g4hbJtB95XnOiQoE0bO cVJ6QDCoAOb8QmR9hnXoFb5FRgY/y5+n3vJ/Jf501sf6u76dvtSO4rgt4SXrUb+unFNg TINhuAzMXRScqLf3yD/lWnr7MI2YQlBBZIkLYAck+WqXEmCeckEIiumeiNN5f197ccnG phQXa/2BiI9CZ7H/zwrvNQuT/YllaMvRG4uhLYmqjVlgrU/HKT1cBwmm1L9AjJoWuXTw OkSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749846935; x=1750451735; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=aD6EYmSk/zIl2SjxJRx3+64lAlSQfo57iDrafX9vuYg=; b=CCg7MbQNOuB73zpmqpmnJjsnlf6jKvktJHEaNgDOzaEOFullFjaUhYX/nE2GovIBpU 69EKzdusVwJkYBE0LVS+y34AASl9klQKfZiR4PnFDWqhyLpiCVXxw99X0C3kfxOrvltM n/nv0mi68juUn0AC7rQaywWhhXtJnn0M33Jy9EMiZ2iCXPpfSL6KMFvlItqmXyID6012 EgJpEjh5wudafA5Y9DO7k+QwCE96GF3Ti+aCnaYkLSoLKE1uyzpLeYlZLAtIaX+VCEHH jbSfqRSzNo3LRjqqyyrA5DSW2sKJRgyQNQLrjhyu8ouu4dlP/W+uH02pyTsCPpovI9xZ kN2g== X-Forwarded-Encrypted: i=1; AJvYcCXVmU03+LUx13UcEio1jg6l8muOJkDiXGzX9Thdk6eXjoxgsIGyLQWxBCyl0VLCW8Wl4qpPFPsE3g==@kvack.org X-Gm-Message-State: AOJu0Yxm+pnat98qdZNuwQvKqC3cEAN47EK2Jhr6SukPB3iz9oHQmPAd tOcuGnI5CP/WSRnftc5A7ZunvlkKmYVRMfVxS8HMtiIYMwn73hPW45V2n8auoPwLllYtD8lwR27 IM7ciwA== X-Google-Smtp-Source: AGHT+IFQyKC+fuYoxxZ60HlL1zbUz9ZwG4ryuK7MxSum1tmaUoFCTmYa27wuTrzB35IdSIo2hT+LP8d31ms= X-Received: from pfmm18.prod.google.com ([2002:a05:6a00:2492:b0:748:4f7c:c605]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:2ea6:b0:747:ee09:1fdf with SMTP id d2e1a72fcca58-7489cf6aaf9mr933541b3a.4.1749846934794; Fri, 13 Jun 2025 13:35:34 -0700 (PDT) Date: Fri, 13 Jun 2025 13:35:33 -0700 In-Reply-To: <20250611133330.1514028-5-tabba@google.com> Mime-Version: 1.0 References: <20250611133330.1514028-1-tabba@google.com> <20250611133330.1514028-5-tabba@google.com> Message-ID: Subject: Re: [PATCH v12 04/18] KVM: x86: Rename kvm->arch.has_private_mem to kvm->arch.supports_gmem From: Sean Christopherson To: Fuad Tabba Cc: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev, pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 47C4680004 X-Rspamd-Server: rspam07 X-Stat-Signature: aj5rhyqfqaq1gu3b65corxestgig6p9u X-Rspam-User: X-HE-Tag: 1749846936-607482 X-HE-Meta: U2FsdGVkX1/stn+pCbyKtEPx/RMTZhQQTPtgKEVe++rAG4hhwIM6aOq3reu0LWrRxioY2k0s60oGZv/YuHhdOi4KS1ps/QEYekmWo2uckR6Rk+6lauKJ+BlICo8KzDg7AjMZF1RfSczCjgUCWV3LXG9KfcNRju1WepM0oBVjMWwA3V37zqQRodhF401TrEhSvf40lNn8uTHDkc0u3YYryeA3HqD8IlxU6K29xGi0JwlCxi48Use3ntpqzgYFoXeA8erteaCRwgB09oMZRA+ipvAFwvTZuukGr7IG8GHumGlAvEnEMbYfZOutWxF5AOpJBw6i0X1TeGkmg75XoMIDSKebrbj9Q5lvjyM1iGshcStthig2ID5URDPMWDw+KtS43JALuftTVq1eVcxEa6cvSfY0gUUNadRJjx2BmPnzJgEz/mERDiMrvCSpkJldvixrhpKx32/Yem5DVT6E1PTGbX9l5QmgeM5wAOPtoMsckSVRBUCcCrdx2o36MmObYx/DifDA2o3lbaIH3E25AZUOD2CAg9NfBSuOKKmkwC/GFXcxzJzDt28KOrUf1h0Ux9Dz8kDqz8Hl4I6IbHXQVS8eu3cIK4LCpZzymrVYTjiqQTiOfo4CbY6hN6WKfAfq23qIu1CaXg/7Ret8OveM3222so5j51DNkgfV8wyx5JIfbYsGIzZseBdUuskEFz1tKmxxCYFxn4bb+V0xZxd+esTARcjnMc+zksWe0kBP4xLq+puWUmX4TS8pmCIyYugzz6FER7/jQ+mBv+qUeZL2K3FwlzNeteuDy6GHG6HZ+ee8kvkNeNmbSdnupNccf4bZeRyirbP6BtIivZ3hq1tSho9tUhyvbaoJ+2WW972P52vcJIiPDs4X+cNJ8upBsATXehFbP1Xem4Yo+3xQMLmb4KC23P0UGxnjqzL99iQLEMORSr1vDwy7robxmG9RcN3NvtZV25sotZo5Tj/T8lwNd2q rJG9Tdrd duFV5jCAvAF2bk18Wc8m9czFWmfGbS/V0lMgfjWkF0ons0dJdaOifUYH356DiVA6hS+UICGbEHcTkQIhkwNKsbhx/lJ9cmAu4JcEEJ6WdY7FI0c15s53CTRs3B9OxhLqhOh58LfHhpfU06NvDzT15480tPjnqw3FMcJIA8QTvBghUgqNZv59koGx6THlhHwgl5inO6t7v3pw/hrFUKpUDU3QnCRsQnsU1qZ59A/mTh7Np/oiK4JywHGoyvPFH7pdhb0Z+o9umoOS9KCyepi1edbqle2/nOt6rfoEhj1nRHq+mgAysJYxl1RnN3BbgAHclNS7sKZ1+wL99HsxtEq54MP8uXIIh2KC3nTvpmwG+wfFyHYRzqZVvd1kGNOjZR21gGdFcyVIaPqDeTk5Y+a9jMc7ooOqcK9pZMjDf1a5KDeO/53vnuMBhWdHDciM9CxvH/mipQLMyhq6j5+iQD2J+LTwXwmeigTO6LSaoGZ/2sNvLVM+/0xU55vXvukZvMq3ngsnpCLF+75zxz6I/I9GDsKmW/GPguWjEwBfZmYgN2pY7qea5RTlcnbbcwAHhRa4KYvKzBNSpPgdCRgh5dEMmiwzRz6fj9jEqSAToCh2J5RJqkVooJIXLle4BCE5V0rYPjilkrMbbzoT1ynPyBbFzaJy62udyvkUMAAEtZGOffZszqvQwGkCGNLhmoIQ8PhAzMyjaZBnNeZ0sinfLythPgYoQTC7hLOYPHFnyKzAOi7SoXRHUpAHvDxAg6ap87/1934m0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 11, 2025, Fuad Tabba wrote: > The bool has_private_mem is used to indicate whether guest_memfd is > supported. No? This is at best weird, and at worst flat out wrong: if (kvm->arch.supports_gmem && fault->is_private !=3D kvm_mem_is_private(kvm, fault->gfn)) return false; ditto for this code: if (kvm_arch_supports_gmem(vcpu->kvm) && kvm_mem_is_private(vcpu->kvm, gpa_to_gfn(range->gpa)))i error_code |=3D PFERR_PRIVATE_ACCESS; and for the memory_attributes code. E.g. IIRC, with guest_memfd() mmap sup= port, private vs. shared will become a property of the guest_memfd inode, i.e. th= is will become wrong: static u64 kvm_supported_mem_attributes(struct kvm *kvm) { if (!kvm || kvm_arch_supports_gmem(kvm)) return KVM_MEMORY_ATTRIBUTE_PRIVATE; return 0; } Instead of renaming kvm_arch_has_private_mem() =3D> kvm_arch_supports_gmem(= ), *add* kvm_arch_supports_gmem() and then kill off kvm_arch_has_private_mem() once = non-x86 usage is gone (i.e. query kvm->arch.has_private_mem directly). And then rather than rename has_private_mem, either add supports_gmem or do= what you did for kvm_arch_supports_gmem_shared_mem() and explicitly check the VM= type. > Rename it to supports_gmem to make its meaning clearer and to decouple me= mory > being private from guest_memfd. >=20 > Reviewed-by: Ira Weiny > Reviewed-by: Gavin Shan > Reviewed-by: Shivank Garg > Reviewed-by: Vlastimil Babka > Co-developed-by: David Hildenbrand > Signed-off-by: David Hildenbrand > Signed-off-by: Fuad Tabba > --- > arch/x86/include/asm/kvm_host.h | 4 ++-- > arch/x86/kvm/mmu/mmu.c | 2 +- > arch/x86/kvm/svm/svm.c | 4 ++-- > arch/x86/kvm/x86.c | 3 +-- > 4 files changed, 6 insertions(+), 7 deletions(-) This missed the usage in TDX (it's not a staleness problem, because this se= ries was based on 6.16-rc1, which has the relevant code). arch/x86/kvm/vmx/tdx.c: In function =E2=80=98tdx_vm_init=E2=80=99: arch/x86/kvm/vmx/tdx.c:627:18: error: =E2=80=98struct kvm_arch=E2=80=99 has= no member named =E2=80=98has_private_mem=E2=80=99 627 | kvm->arch.has_private_mem =3D true; | ^ make[5]: *** [scripts/Makefile.build:287: arch/x86/kvm/vmx/tdx.o] Error 1