From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 639C0C7EE31 for ; Fri, 27 Jun 2025 10:41:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E42946B00C9; Fri, 27 Jun 2025 06:41:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF1F66B00CA; Fri, 27 Jun 2025 06:41:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D0E326B00CB; Fri, 27 Jun 2025 06:41:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BDD186B00C9 for ; Fri, 27 Jun 2025 06:41:08 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 64F3680652 for ; Fri, 27 Jun 2025 10:41:08 +0000 (UTC) X-FDA: 83600838216.13.A13A02E Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf23.hostedemail.com (Postfix) with ESMTP id BF44D140008 for ; Fri, 27 Jun 2025 10:41:06 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=M306hN6G; spf=pass (imf23.hostedemail.com: domain of dakr@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751020866; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yi1DPJqc6JsXQ37zNMQ6eini7pgSl29wjRj1SvbWlGg=; b=hu+aANziZdUW1AZnvJhTkGs4glRIW2nNqZqg5Sdo5+FFF3U7TBbfx1ZaiP5Hv1d6m2z0il sJrqLMXRU2uy8I9umuv7Nu76xj1wd6vfKHdiRQWmf4BZM8B98658K6YD7UA6/BCdOwPL33 uByDQZtajMBpVc6TDSgThnHGnzPCiQw= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=M306hN6G; spf=pass (imf23.hostedemail.com: domain of dakr@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751020866; a=rsa-sha256; cv=none; b=4TFu1wLj/vYFI+/tGwTuTFS6xNOabJkfSc5E+4WvhuksHhr+Q2p/BfKjNHxvYexKCjy9tb kYWkUBQyvjUSWykQcFJpmg0h4qqfjOGXTv3knuxbngglFs2XD1ej2FQrBEb0SfPkcywIZ3 owQSyWVajaqd4U7xzYBeuSbE6rEDoCE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 05543A52D0B; Fri, 27 Jun 2025 10:41:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0FB27C4CEE3; Fri, 27 Jun 2025 10:41:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1751020865; bh=rzLraCNuwTpuf/DUAb7YKc3FNpCiMSkIclVF2DPCAuY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M306hN6Gbd1Gc0eJnFzf0djXisEUIKObApc/k5J1CV4qprjUwcg+Mz59+LP32KFL3 GYVIZADFbzS4qNopkBV8ktDgDogH1TqLRM1y/MZk9sPQhCUyZQsr4KvyaZHIvKqWFN mhl7oc484C7kjweoDcz2qstW5s7qei8lNxdyaOZ3rdRft4GLVL086ncZw5xoGqJTjo x35XKN5ZczLLlGin5ck3EhmjsUO/iqt3BbCXNyL4Y1dmvs+tXU2w2oSzlYFfTJ00bO TFAUnUQc1kVBoYoxsusUX2G7iCw6Ssi1np9NmON3IZ6ATy9v3fhbAcFvfzf08x/yqD 3QMnYXhiNHz4w== Date: Fri, 27 Jun 2025 12:41:01 +0200 From: Danilo Krummrich To: Vitaly Wool Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Uladzislau Rezki , Alice Ryhl , rust-for-linux@vger.kernel.org Subject: Re: [PATCH 2/4] mm/slub: allow to set node and align in k[v]realloc Message-ID: References: <20250627092901.356909-1-vitaly.wool@konsulko.se> <20250627093714.402989-1-vitaly.wool@konsulko.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250627093714.402989-1-vitaly.wool@konsulko.se> X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: BF44D140008 X-Stat-Signature: 6zqe681xmbs6eff8khny4mp9orqntrii X-Rspam-User: X-HE-Tag: 1751020866-681060 X-HE-Meta: U2FsdGVkX1+pG30wlL0Sj0rIWfk57Hc7sTw4k63IMdFoUycbe8rrIMy5jVVKhy23MXxRGheCjzSy8cLYNvD/zvFexQx2DxustYxOBaeS9ofzFyphNN/qql4NT2fMAKMXRU10ERxfad7q3dOlmoHjB6nC5jYF2Vy6x7ymK76KUQQh/TF7+k7+6l8D23TGCL7VuNf7ndE23zeKxl9qd93IaoJLSSbXAnQJfAP4yx8VJ3RMgpjTeeTv1XpNP5yC76LA2IOalOXaGJ8tdtlwEH/7Vt35Wo8wLZSipr7KF/L6MCzEUOt512UMDq24ozo70e+5JLBU/trNw7ScgvHcMGw8DYhN+mkKioMI7Lx4rBPIDbxWov6nQzeDM4QCrVvrDRvHWT/MOI4Vif+ZkNUedNmQeuDNgufLnzkvdNTL5j5IeHL7S3kzI2WOq4AqtUXbRcGIiV5K4Lg+g0+2dy4+btn34CDQzmitdnc3qIqS4NnWf1Sf3+zLShfyI+xbnd4UWPONpeXphTUboCTtFOT/JBqRpQVofoMThOUdoiEzFKE5JBFrz1KVPrHiinT1QI8ktAvVXws3auq7q9RjSVLS7ewU+C7BQ0+k3LajyoFW4aXi/r0H/ImlKFCIjG+0y1rnOKfU1iZn3bl2fPonFkC/W8WNCvI+Xen+dNAFFcasGgBSS/5WCEtQiDnkWTEnxHAmFCxfsd8trRIr4drbTgguvf+7bm+YB2Pde3AwBxOBFVW4t0r7422zz+58sKooNNkw5y9zzjGth8GrnSffAvG5R6WPplnhuVweyykx456txcn9kzaKpbmXBx2hJY/N7IfAnahJxlGRdWQtD2BWveUZrSvU8rfmXyqxmoRUR4s+W0PuFn0w0XKhR+yK04tksmVvivQOwS3lnferPyCEiLNZ/yfLK34q66bsFJqI3p9niXZ0GtQfXVg0RTSG+S3S4XDvGLTUpQllGYJWGfhLAydm3BK BOFp3XjZ rZzNUPy6dtrJprvNAyKfuxksSrNoV5P4oqXeGPZ2967mo1Bi8cjTN3KDh5bKn6GB8TbwCQsAf61p8wuexDuxeYmHGsOKPijqm+wLwVlIwx9bJY5twLXvpF/SoAB95oDXtHIeUbzxEmvF73dW0HDUFDK+lkdE69thzjkxntA7U8vvjSg3jr70nnBd+41tw9VRS2JniTlKwwM7k849K4hnT7hGI1mdmResu/smgl7P8RVof9QxFD/fuwC7g6w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 27, 2025 at 11:37:14AM +0200, Vitaly Wool wrote: > Reimplement k[v]realloc_node() to be able to set node and > alignment should a user need to do so. In order to do that while > retaining the maximal backward compatibility, the following rules > are honored: > * kmalloc/kzalloc/krealloc remain unchanged > * kvmalloc/kvrealloc/kvcalloc remain unchanged > * kvrealloc remains unchanged > * kvrealloc_node is implemented as a new function taking align and > NUMA id as extra parameters compared to kvrealloc. > * krealloc_node is implemented as a new function taking NUMA id > as an extra parameter compared to krealloc > * kvmalloc_node/kvzalloc_node/kvcalloc_node get an extra parameter > (alignment) I see what you're doing here: You created vrealloc_node_noprof() in the previous patch, taking the following arguments: vrealloc_node_noprof(const void *p, size_t size, unsigned long align, gfp_t flags, int nid) And now you're aligning the newly introduced krealloc_node() and kvrealloc_node() with that. The idea for having an align argument on krealloc_node() simply is that it fails if the alignment requirement can't be fulfilled by the corresponding kmalloc bucket, such that we can fall back to vrealloc_node() in kvrealloc_node(). Generally, this makes sense to me. However, now you consequently have to add the align argument to kvmalloc_node(), kvzalloc_node(), kvcalloc_node() as well. This is what creates this huge diffstat changing all the users. IMHO, the problem here was introduced already with vrealloc_node_noprof() taking an align argument in your previous patch, since now you have to adjust everything else to logically follow the same naming scheme. Instead, I think you should introduce vrealloc_node_align(), kvrealloc_node_align(), etc. This way no existing function signatures, such as kvmalloc_node() have to be changed and no users have to be adjusted. - Danilo