From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B0E7C71136 for ; Mon, 16 Jun 2025 20:27:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EA6CA6B00A9; Mon, 16 Jun 2025 16:27:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E57376B00AB; Mon, 16 Jun 2025 16:27:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4BC56B00A9; Mon, 16 Jun 2025 16:27:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C6B4E6B00A9 for ; Mon, 16 Jun 2025 16:27:32 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0CAF6160E74 for ; Mon, 16 Jun 2025 20:27:30 +0000 (UTC) X-FDA: 83562399102.25.9B25CF5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id EECDA40008; Mon, 16 Jun 2025 20:27:27 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XSnCmY0M; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750105649; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rMTsK0YsjlB18wsT75a6evHrM3XMSVJTrFI3gzXouMw=; b=Ni+h4Jks+Je8q6Ur2DbSRjRjRkPjSoaS+0q7fP3IBc7dIkspDP1amIxbHhdN94L/mCiwnP dwONDLZ+oq7m7a2lmDKAcc0mBBDhW24KblvAcdU3smNgdi21zMfYerj4LqeWlwPr0taboZ EB3FFVOsQldJXEACYa/MOLX6/nb/GyY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750105649; a=rsa-sha256; cv=none; b=g20quEHqc8eAaLrZZnEaNg9G7B250wOqQGIV8UKMRdPpuWUqPaWXxu9P4D09rje7xokDoE MTSi8x9WDCYdOuMcYFLHsDSR9yIAwa7mx2GAy7i9jPmg5fEo6m2vRMaWkfZbo0nQGl3xR9 Z6gK1OUQPhiJecN/LzBLy7iL+SyQtVg= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=XSnCmY0M; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=rMTsK0YsjlB18wsT75a6evHrM3XMSVJTrFI3gzXouMw=; b=XSnCmY0Ml7NLCrMRP4OfNwKCxm t3knyrRU4umUwqGsAQ78VDJwhklMHyppjzgkgSiDjEr1eDLbkdmMI1Ud09tK10NOTGSkVr9OAVdA5 yeDW00x8GaS/9hTn/5iTIiI7ZEmOX2IYVaYsUKHT/a7Sh9XTAvxkYrLcfI6adjZOgVZ/EQ8izXpRS N7CyfmoYNKAXSZWjXkcw7dH2WIhiyXqdB2rcIWxw4KPMz9e5BecjG1NA5nrYsPuYwy5tj/ShXnUjZ Hx7i1JazW+vFcm5JpzfYFwz2+TREcWXzGJRoblKfrG12x8d/ZXuZZBMy93UQ4ahuLIE/06ESgJ7x2 dKaQyh9w==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uRGPu-0000000GKxl-3X50; Mon, 16 Jun 2025 20:26:54 +0000 Date: Mon, 16 Jun 2025 21:26:54 +0100 From: Matthew Wilcox To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Jens Axboe , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Alexander Viro , Christian Brauner , Jan Kara , Benjamin LaHaise , Miklos Szeredi , Amir Goldstein , Kent Overstreet , "Tigran A . Aivazian" , Kees Cook , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Namjae Jeon , Sungjong Seo , Yuezhang Mo , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , David Woodhouse , Dave Kleikamp , Trond Myklebust , Anna Schumaker , Ryusuke Konishi , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Zhihao Cheng , Hans de Goede , Carlos Maiolino , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Dan Williams , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-aio@kvack.org, linux-unionfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev Subject: Re: [PATCH 04/10] fs/dax: make it possible to check dev dax support without a VMA Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: EECDA40008 X-Stat-Signature: zwrdsferrscjczybaiah75rcsnjozi9i X-HE-Tag: 1750105647-852389 X-HE-Meta: U2FsdGVkX18BdevqBYFw5w9U4rNDtb/8iFIlB3BsGEcl5VsIg2luFSvdK3p2E6e9NrG7ZBxRdbr9IJ2USF4eCCh5MNVDPocUh++ALVw6N0eowxGbi4PH9Sqnf/85PUlB8CeQTgzgod67q0q/ECo+9ecHqw9l3AaclvikSRqKY2k5SHeDObWgT/o2uJM03Z0fjznLo8GCqAeoWBpm0X7VFE2o+uV57XqoKWhSfvSnK0H/K0j3eMb1eycuVzG4EZSVNyfwu4rZ2bUTlS8chjTyQeB3KcAkYqw36pcKPpUyEuVzEzKyfUshlgrkVlFX2edydMwVYOS00H2Ps39OxCBvkIkRf8LK8c54nLnKFYl98TugzNibQU9AWw9inXIgu89gw3BB0ptpBOS5D4o/iq9tt5Hq0xYEAsn7S2eCp9vfosKaNlSKSuzqHxrQyiNlC5A6msTkiltxILWeizBdLO8NjD+TU56qsWsscvbtmzePr4H0mhCKyXWoAsexrsRGRHcYIE4eYS6giebkN58bwZSGvSXPJdpySzoi9xistILjncED8195xrwBPIi81s3b4calg7HTd8L6cRpBFNiXW3A3UrnkgCaBf6LYV0RMvOKqMcNJZDG4AqCW1CpIK/J2MdN9laW548HHOrcmvlWLH8R+N66o4YNF6+MeVKc3N6PZpYzNpgMU9gtKo4W6OvCRSUXSQMkfKyAoO4BEZvjKCv0CS0Li9M04yDRpM+5Hn3hSDEl53xH0nmiHzvGdvVank0JocyHoPwcggzW2QL4rP7kDWyhNvKjWDdG63o/hX3T6jgO1m9uytUskULKQI6lc2LMSZA1ugZhLQdaCaXgyVY2UI6qic4CNqvCRmfmO8yTqEMMh2ji0oOJeHaQVlOl47MRbYM+0FYZenkng39WVIYSm4LaYpczgBMzIXKXpXa4Oik55TCl8rF+UgVdkYpWA1g1EBGwpsEghEL8mQ3N5vtI toZtmOSJ MgMV0G/zsBEQYNBafVa7WYHgVGwNdXsM3tAUhcILEnIeCYhzhhZ6PS4EbIpSSAQTxUE8Vko79wP/tjv/eFspjPZAL5nZPJh3birCNUQ/oUWLx3OC/1eMpcNQvCAlhcd135LiAqDwnpFdA9lfa8C5d8IPwNiFjRJom6iXXBdALyohfmGuj0WlTNaYpQFKADCppn5b7jAK+Nb2F8o3YMqBl6ZB63+TbdyCoMclWD9FIDGPDnl6V7NT0cnPt+FYXNkIZlFERsB5IELTbWZl10mJtIuAAGV9K4pPg1k2VP0Ngc5++6Wp69KRl75c8BBiAr1Q+GDcIsLgzUht94SQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 16, 2025 at 08:33:23PM +0100, Lorenzo Stoakes wrote: > fs/ext4/file.c | 2 +- > fs/xfs/xfs_file.c | 3 ++- Both of these already have the inode from the file ... > +static inline bool daxdev_mapping_supported(vm_flags_t vm_flags, > + struct file *file, > + struct dax_device *dax_dev) > { > - if (!(vma->vm_flags & VM_SYNC)) > + if (!(vm_flags & VM_SYNC)) > return true; > - if (!IS_DAX(file_inode(vma->vm_file))) > + if (!IS_DAX(file_inode(file))) > return false; > return dax_synchronous(dax_dev); ... and the only thing this function uses from the file is the inode. So maybe pass in the inode rather than the file?