From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 285A8C7114A for ; Tue, 17 Jun 2025 05:08:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 973FC6B0088; Tue, 17 Jun 2025 01:08:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8FC946B0092; Tue, 17 Jun 2025 01:08:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74F2D6B0088; Tue, 17 Jun 2025 01:08:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 54B566B0088 for ; Tue, 17 Jun 2025 01:08:33 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F105D81767 for ; Tue, 17 Jun 2025 05:08:32 +0000 (UTC) X-FDA: 83563712064.16.8164B84 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf05.hostedemail.com (Postfix) with ESMTP id 931A3100006; Tue, 17 Jun 2025 05:08:29 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=QNDoywVG; spf=none (imf05.hostedemail.com: domain of BATV+4b43f024140bdadcbbf7+7968+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+4b43f024140bdadcbbf7+7968+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750136911; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=MnSFdd8xjqrBRMNrjDtPx5JnmQica7Kdjxsp8Q9K/Q4=; b=R6byPGZa4lgiwf6P2z02AhxFBBwzGRZwtf8HzRY6pA0KQdXo1VBK1hWoLiyIzCaZLsYB5s 1LFFaT7e9mbFK6ex3Dfc3w3Xxq36sAMXA7FJs119D9MDNEC8IlS7Q2BjMOBpBaiioQkek2 r6RILD82GWJtsK8Y4/H+PpV/ASwemNk= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=QNDoywVG; spf=none (imf05.hostedemail.com: domain of BATV+4b43f024140bdadcbbf7+7968+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+4b43f024140bdadcbbf7+7968+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750136911; a=rsa-sha256; cv=none; b=ii3bhOq6MqYhQhL7Eumn1AQOFGhknHEONBcum/I/ryV0M2CWedvHCPC/q+UndLJmq3vcNo XF+gmgFKa0hVo7HpS1sAoNl6KFZA5WSMLaPFVDucZ2jY2wRR5R3sTIybi1tgbG8G1MExbW elG2R2aNG3dUyjBwDuYI0qqFFkmgwt0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=MnSFdd8xjqrBRMNrjDtPx5JnmQica7Kdjxsp8Q9K/Q4=; b=QNDoywVGRFryPFg2RDAGbDqnER kMwwVaNvmdaPWaUdYiw4uVs1cwpES6Y1BZK6zmz6epnmQf/31dqrJ33hky4AO7LYDYrEmHWzT5Bgg VyfgKX5JeKt2VwytR3aURQTHJg+QRiPTD7MQPSSkuL5gSVT+THSOdd4vmpMu97aV9REIFv8EPvGoL F3fP2a1meh2mhDu+1cb3aNJjUMgJcQcJkdsXsvzXczzr8NFZjGt/s0pWBSaW/4wNY4j8IybNcONJm YgcOcrsyjgwc13MQm/OFO8/8KkG1q6x4Z+oB+mDwuoX4JPhpMCDIGJM1OzS7S4z578+cbogTh+9t6 xs0eBXpg==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uROYF-00000006DYq-2nid; Tue, 17 Jun 2025 05:08:03 +0000 Date: Mon, 16 Jun 2025 22:08:03 -0700 From: Christoph Hellwig To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Jens Axboe , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Alexander Viro , Christian Brauner , Jan Kara , Benjamin LaHaise , Miklos Szeredi , Amir Goldstein , Kent Overstreet , "Tigran A . Aivazian" , Kees Cook , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Namjae Jeon , Sungjong Seo , Yuezhang Mo , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , David Woodhouse , Dave Kleikamp , Trond Myklebust , Anna Schumaker , Ryusuke Konishi , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Zhihao Cheng , Hans de Goede , Carlos Maiolino , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Dan Williams , Matthew Wilcox , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-aio@kvack.org, linux-unionfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev Subject: Re: [PATCH 06/10] fs/xfs: transition from deprecated .mmap hook to .mmap_prepare Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 931A3100006 X-Stat-Signature: 36ku6yyai7rc3m77mgsrpfp6dgrwr4u9 X-Rspam-User: X-HE-Tag: 1750136909-514179 X-HE-Meta: U2FsdGVkX1/qTOUZiC/dvs9vYdGBU0rlFsYa9+SGBUE218DgU93+9euBTMaqkej8l9sXSyqskHwfXh0gfvYscs+rM2bJ9lSv4as3ttd0EP2uDAvHIJ9FVFGQ+x7no9URW4FIny+AQOcjNCHu8/ajGJN7R9eTyuKbzxiqHLTLlmTb1Wc03psWKKjVsapPue4izQts3CL80W7VaJPmnCEnZtDo7GRIHTig8YqwY8qVhY/bbJwX84AqIvqBujpwmJjSagGokb+mNAD4Sph+oO1IITxOwB0fGLfyf7kgKyZhRxwYdDQBZisf61SvcUVOP8Vs9NPN1cuoR2md4aYEmJNlhqGDOx+/uWgwRLb5ByLwkEESUoMzpS1XeK3bydkTWuSIvGJ1cZBzIhH6jNTrKRM1g5vHzy9GJGY3/Um2UsBMoVM480Z05rAVKNx563PR2IPZeYMV2LpiRNiZM3zALlySeooeooWA9nhqjoM9hpygV5tYWC0R04FxhEC8NQFT8aWEWTzIFfA7oY5vn1gY1Ul0ZMjPqf57VXflphPKORDnvpPAaHG4+kIiVomoxDkSl6gQ68F61LnTk6HDyWpHM2rm8sDzHPocc0YXwdz2bBFd1P5vFf7u/iP28xuw762QRpVFlSuiWbgckHI0HE2YlBIWtcwN8oz37adq6+FYXSGPaCVcmyDnRejx2sLg0TVCk3q5bIBmM8RhTSZZPT2EHCG+sYjbhJEme0aPAD5Rsgt9tDz1Xw9nXFMPlKHHg8yI9TzNZ8aNmD41+ldttnHchjKfGAqjTs8INItb4MxDdgOwCUwb8x9IKnUNaFJ1mrIZ15s4RFOP0kFWlfqGr0HytjDn6Oz0SrsECAl+RbGL769+B8G9FFz8NZdNzKgupDUirue9eWjAjShkdGXC2wfN/XjXKeLnbGxLOaS/NmokxNZ7eqe4fptuF82aflANpsIGQ79q6FOR5AROksftcsjmzvB wg3uR8Mz 1wR7/umXofM78hL4KhJIzTHCLs/LfaVfLnbTYZ0y4YhVsdWJEJSsyJAQtHHfXVA0grWguWmDEgbHu/97CXfMHKrZUuEBdD1IUdAciNKzMd/99LbdaOppJUp3XH5B+2KtxPFYv+2Synxh3l8lEIC2icFDxOdPaz2wv9gis62B3Hyq4OvUtgz2z7znYzhFARVsNRzxXw82r5a8KvuYWgxrQadVEfKgYneTsHaMW+L3aeZQFIbWOkTePAsRhFaWfKKsCYq1mMTAWhGHrCUiw9VsoQB84ddpRT7th1t7IThjdO85jHoXSNX/aD4fKWw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 16, 2025 at 08:33:25PM +0100, Lorenzo Stoakes wrote: > STATIC int > -xfs_file_mmap( > - struct file *file, > - struct vm_area_struct *vma) > +xfs_file_mmap_prepare( > + struct vm_area_desc *desc) Please stick to the existing alignment for the declarations. Otherwise this looks good.