From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37DA1C7114A for ; Tue, 17 Jun 2025 05:10:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0F116B007B; Tue, 17 Jun 2025 01:10:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B99866B0089; Tue, 17 Jun 2025 01:10:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A40296B008A; Tue, 17 Jun 2025 01:10:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 947296B007B for ; Tue, 17 Jun 2025 01:10:42 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6E2E2C19EA for ; Tue, 17 Jun 2025 05:10:42 +0000 (UTC) X-FDA: 83563717524.17.31E9845 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf11.hostedemail.com (Postfix) with ESMTP id 37CCE40006; Tue, 17 Jun 2025 05:10:40 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=JLzFVcD4; spf=none (imf11.hostedemail.com: domain of BATV+4b43f024140bdadcbbf7+7968+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+4b43f024140bdadcbbf7+7968+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750137040; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7hewv5VaHf/nCFVYzE18Jb3sDfwjWx9bJqENJtpan9o=; b=Jf+qMY5o2tAjzowxjUpK7bZsOLo8b+Sv1L89y6oKEq1VfaDW4QhFoHyin58m07e8AIR3Zz hkNB6xD39KdkvVhDmDdeYqfK0ZilQ4cf3f5ArssZx82Vj9VV3BytG61ujzc8pw4ut5cm2T j/tSo52LsWRAcMKMXeV96z5WUu4XM88= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750137040; a=rsa-sha256; cv=none; b=hcORb3OjqzlisjBrV4Ku+Au0oh/q97DBfNQpSChSaDEnnso1MDqPF8p4zEFb5B84nXnFAu Ccs3Pf40UjHIOrZ7WVpJrqefdDVlBCncTQaaOSNeGjs/Kzp6VQ3RSwosXtU4r/8t27DmCk z+0dlAWWiwCsl6jRVoen02cDuQzDreg= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=JLzFVcD4; spf=none (imf11.hostedemail.com: domain of BATV+4b43f024140bdadcbbf7+7968+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+4b43f024140bdadcbbf7+7968+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7hewv5VaHf/nCFVYzE18Jb3sDfwjWx9bJqENJtpan9o=; b=JLzFVcD4P4hX82nyMOI+BRPTFS 9m9nUf8QSnN3KcOf1hfPPNg8SY5CD8KGmTwZG9p42mwem0h3+g+jr8vmH1IdJ03DA5flPOfwfb8Kb 2p/Z3NPif2HWA7V7Zh1b/Hzs0cuKS7D2jEWqmC6rRRVe5v+D58zBUGfE4pJ1gAH0HUd1EKkuocvQE /AS7xYTlLDrNF7H7t6M6DnRrb6AncDawE5sQF8d0UGBLNipdl/wWjLzy7Aye1Ze+VzA+g0jzxlIg8 VUglo0acb2sgxrdZjdYWcBo4907Ol02gnYVbwtHB4bd+XE+ZjOsUlox9yo8MazTrsTyF2g2LImZhO mwKximfw==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uROac-00000006E8g-3Ody; Tue, 17 Jun 2025 05:10:30 +0000 Date: Mon, 16 Jun 2025 22:10:30 -0700 From: Christoph Hellwig To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Jens Axboe , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Alexander Viro , Christian Brauner , Jan Kara , Benjamin LaHaise , Miklos Szeredi , Amir Goldstein , Kent Overstreet , "Tigran A . Aivazian" , Kees Cook , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Tyler Hicks , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Sandeep Dhavale , Hongbo Li , Namjae Jeon , Sungjong Seo , Yuezhang Mo , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , David Woodhouse , Dave Kleikamp , Trond Myklebust , Anna Schumaker , Ryusuke Konishi , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM , Zhihao Cheng , Hans de Goede , Carlos Maiolino , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Dan Williams , Matthew Wilcox , Vlastimil Babka , Jann Horn , Pedro Falcato , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, linux-aio@kvack.org, linux-unionfs@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev Subject: Re: [PATCH 01/10] mm: rename call_mmap/mmap_prepare to vfs_mmap/mmap_prepare Message-ID: References: <8d389f4994fa736aa8f9172bef8533c10a9e9011.1750099179.git.lorenzo.stoakes@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8d389f4994fa736aa8f9172bef8533c10a9e9011.1750099179.git.lorenzo.stoakes@oracle.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 37CCE40006 X-Stat-Signature: pbbsenxhgwin3ibubnddy1gzg6dmunjh X-HE-Tag: 1750137040-190356 X-HE-Meta: U2FsdGVkX1/6NtGZ3anbmtcn2Om22e3QcWfokzJV/EoajQ5YgkFpjtNc4drpo2SYyyez2rqkAiCyAs+ZzDGKezdWPeeba+4xKvGOLttZH+steirF+lPaCfBy3D+6/ypmSKn/qh1JPjihS/TUy1RNU3qpDMZZipOXwS+79icQC7RINqJQJ/jzLudGMX5RZfA/uE7zroLwN2F2oC/wO1JXA7WhcPJ+u/YsOPPnFLlJZ5hEcYu2eWqBxuQl7m76lRnPKA9oZrYb1Unk34moyKlqNGpmtwGQJkCWbTW8dB0wYUU6NLQtmo0qD6UfShINJ5bEe7XEspCT8Iovab6d70tEwSK5CbOjiFmnbeyeK45kv8onruNMLh/xwyTZcF76nfYd7fZja6JiDFHMO5DCJSJZ9Buc2ZVqRs0b6HGhug2GqGZA6W1GcVVvYXunPVCUhwkKH6F8EPDc+x2yXHmPx1AWyI1mssHzW1DysXUmN3Cyg7eTikU1JSOUd90cRXsx579c0S1PtyVjvIq/3bN7QGuR2cHZp8SSWE0bqk5dsrNj4g1JeM8LTaZQsAWcIIcoG90gV6tgV1pu2HllR9bx/tFhLTrb1rpBeenqLQY6QVO2VGPAzdHxcaZn4hLEw+tVbjHpcAz0AlWGHVV5KBi3PGxI3THevNg+jbm6gj++ThO19yZMfx4ih8F58q9ahFdXNZRW6LknKkOe4NFSncFJ7mxPHyr7TPLLURVvgL1EQB+lc4RcFQD9gnATZ/6iNixULznjt70QomXi/ho55H2rWv0vgCIKPaA5Vjku1Q19kz7jRRnuUGM/x7yvtw5//LGOcHsJoTD8JCUPPJTVUr4fwlT1ruF7ZyQ3dQ76nnZqpAHc0iyZIs6rLXjAj/bcsFXcHwF156HPciytBX1xvzkT9AUjmprImkV1dKEKcFYWcS/AfzaSLJUDNaEQOelh48uxpevixEm4wIa1EmZJ/IvqxRD 5w8tfE4m Je2UWVdVnTQmAjWuA8rXE7kGIEuhanVAkhWJF6V2tXQiUsEG8iVL0AJ8jec2rm45slW9B/UFFj0l1vWfhYl2Ur0ogMHLhVn0Xhi/sk1eOAiL81d3PqmwUKChDM9X0dQdhukePiavU3GOI6gGaNjBisyb0KL32CKCrNKWjPF0JgD3M9tOSJebY4wh852iWZZydlwKR5yyqATWYuLraEFGtVtfcCCZMLEVxwwQJbu+dwKE1V1qc5jzUbDs+xDzjYHVc26SnFR0j2MO5JtM3e4Osrb8hzN+jGkZMgf7mnPQ7gWMX5/zxA9JXKx69r0+JYDPjFlStNcj0kSNdqDZebpuIhWeYcDWaZwDgQ1IlXCLCxt4LzBxYhCw1kPoyEwaalLVigyJlXRH1znMOtSEQpXWT1YJTJzj2xMSZ4lAPs22t2APFoYH20tila2QqcVL8LfUlITDVp1AjJJru2qQAGsbhKRhDGPYRT0KB9VMFoH7lNx2LXOeAdCt72EXdwmwiL5aLSPB0UZ1s5n4TOZeIUjxsztCYvEyOkRUCrIjCeCk0HIc66qFGi5FPOcjLayijWODf/CLMVDYQ2rrQ/pwaF8egp/+8UDfMAFckyJwz X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 16, 2025 at 08:33:20PM +0100, Lorenzo Stoakes wrote: > The call_mmap() function violates the existing convention in > include/linux/fs.h whereby invocations of virtual file system hooks is > performed by functions prefixed with vfs_xxx(). > > Correct this by renaming call_mmap() to vfs_mmap(). This also avoids > confusion as to the fact that f_op->mmap_prepare may be invoked here. > > Also rename __call_mmap_prepare() function to vfs_mmap_prepare() and adjust > to accept a file parameter, this is useful later for nested file systems. > > Finally, fix up the VMA userland tests and ensure the mmap_prepare -> mmap > shim is implemented there. Can we please just kill these silly call_* helpers instead?