From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C614BC71155 for ; Tue, 17 Jun 2025 03:54:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E64D36B007B; Mon, 16 Jun 2025 23:54:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E3CBC6B0088; Mon, 16 Jun 2025 23:54:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D79C16B0089; Mon, 16 Jun 2025 23:54:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id C959C6B007B for ; Mon, 16 Jun 2025 23:54:04 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 14B865FD29 for ; Tue, 17 Jun 2025 03:54:04 +0000 (UTC) X-FDA: 83563524408.10.6FD5776 Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by imf06.hostedemail.com (Postfix) with ESMTP id 29BD818000D for ; Tue, 17 Jun 2025 03:54:01 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nfi9Wqyl; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750132442; a=rsa-sha256; cv=none; b=Q3tQmBUcDBD3F7kxhzPXrFlnQToOQ6eg23b4on5faDkNmsiFUdX28S+ao3mG579U9YOWAv rkV4nXuKTPw6TZnHI/ZPbhQyCw8MaPWidQRrrTfoFtMtFJQC7/Nnw50O/E2aRhS6qt/mj4 ZW10BDytbP48SlDfx5/PmZ9LfgwERVU= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nfi9Wqyl; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of rppt@kernel.org designates 172.234.252.31 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750132442; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BS8fZ2CqCkTiPW7i/X3b+YUaBZzieuZiketcSa7rv+Y=; b=4jeKKR43EBXmPUqCjojdEl7Ac1ZHhsl7g8jdqaR5m9FWR5gqjbsox1hMSOvU1w2Q6mvhWi hqnvDySkc5uWKD00K0TzqKDmb5MME4KvKalMooaGlVN7lrSQOdQyU+ewvRVkCPEMNWIxRq eN4X84AdHN23nCnKodfQvUY4gxuxQkc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id D360A4A02F; Tue, 17 Jun 2025 03:54:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 14093C4CEE3; Tue, 17 Jun 2025 03:53:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750132440; bh=T/OKqkeDi+4ifeO4oxLf71wbRvA5+2EW8V9yeqB5SIs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nfi9Wqyl9vFmTcaXwZw1livpaoZRSlcPaWxZWLDnuuoI0O72JO9/QSHtBh6mxqXRJ cMX8kfebMfhH2aEq+A/FoX0nm/s/OtT0EJ0MhvB0KouqIV3W2CXaO/b3RxKwUKMRLx JjpLqvP/3sCSDjVNH2zGy5nECoUgSjvlM48FSqhh0LIoJx3xM/X3u+nn8YnPVXlSDP sSWHRme+owO0vPmhi7MmsJbp42+iZP2GYgIPCvNo46Efdzh2ZMHeZvCp/u5bkvkVfg j/C3hCXQB8LRC8JnzFhyBFf63k1/qVcTJS539b2roRAwiV9bD/FPXiT6RjFbNZ6HTq ocowID+m3pDyA== Date: Tue, 17 Jun 2025 06:53:53 +0300 From: Mike Rapoport To: David Hildenbrand Cc: Lorenzo Stoakes , Andrew Morton , "Liam R . Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] MAINTAINERS: add further core files to mm core section Message-ID: References: <20250616203844.566056-1-lorenzo.stoakes@oracle.com> <727b5e89-89d7-4abf-a93c-8d6f2cb2c438@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <727b5e89-89d7-4abf-a93c-8d6f2cb2c438@redhat.com> X-Rspamd-Server: rspam01 X-Stat-Signature: eqe55t1zkafntkmebamffgigwppi611n X-Rspamd-Queue-Id: 29BD818000D X-Rspam-User: X-HE-Tag: 1750132441-136092 X-HE-Meta: U2FsdGVkX1/Utv7IoO7yM1uNR5WAfp4FGoY1EimURRWOVmI7wC0JTDmZrYFjQe9RAfhx/pEo0qY7feX4ui9psr2M0hLIkEujmtruMxis3xNqlTDAEUbo/h1CIbUTfWeaOr9aSNP/y+UnXBc4KCFbqvaTD4Bfv+LHBvedV/WaKKCcGNB6f3505D3OrRmF3LaxJAW+WpcyIUsLjuRq53aq9+3yo7Bl7XDVJtU1/8TzH+uhzsLsPdIZbi6q99w34/dz3FH41e65UTKJ959GjkRR1nhHSaVDGz4mQltbVW9hwS0WFT6IDlvxjI/xHBJH8PoKKamfbzVEwqnPe9lX7VUkIdNCYk+PbyCzCUPFFpwF0vFl6iH8eB3fBA6Rs5llBn4Fvs8Gg6Z1MecbJAbw9zSRoExzjEyYGt5x+4ZcZsKo+mRXGBgqcFHMX/gmCaU6J/xijHlQuYYr23j5cjSOGHeLcCeqqemYNX2rZFmVZ+qFjkh0RPjOVv5+UJxzZIPZ0rRX11hLKI5gFJxKS2unXUpn7555MyREeSDV7xWodAYVZjiwxwx/jqOLZ6dmW8jQLV1p0HXKPQRScFjhfUu4NJt7OFePGrx/dYXqoxNnEN8MBp1EVpas/r4/nPytKK311cmkx8ZaMNwN670MI1RW0/yO8hFm/E+LrAhivA6mNR8/qblAphBxPN1qYSsfRBHjiOxVt/ApB1sCcimVKw1pnhkTcV/gCVqzcO8Z2oLLk6JUZkpAckjgHDpbcUiQO1/cGDhs520YbfW+EHBVxRkxiuwfjtx12whLWQTYbxndURqajYX5u1jQM7RrGa5K1xjcR3RKzBQCgNaG0gfhx5vP+oKFY1mhw/mtrkWfrGbbBW+K72mClofJFNkPQ3qyrU+64PP4+q88eCPc5xkNhD260Pdr9bM4/jawV7BlN8eTqTD9qCIzjmohV++nXurjqH1+rScCa9VjgHNxnlZZh5NT7Bc vY1OysdD jMpCUpy9cbCx2kEuanPK9FB/iyPUOg8x+LV8HktFVuVNg8Zr96XKknkWE7UFnXbLYlWxoh6+c3jIT+To/JICpLYAnc22tf2qEarskDQKU0sBV1kmhxBWYt4CWbzGBdeAQhPxKgghD90iiVLysAFzVEvBqiMR53GZ2PMDkJ89Mt0GHgSRyMUXd/O+Weh3OIOAvGtxdTztZSIxhVxbc31HUOxODbbGddyfsyN8EkwJv5GWbS/Ycnattd9f7sbOe6bRZkonrQqModtQSnd/1CWb9SK5EwLIXFZCwbtQm2O5vS8NI29Fdw83YNO4RgLinkxU3N7WgdXCpL/ci/uklXKEDcDAPC0s2WlRPkTPtthv3XOQjnSk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 16, 2025 at 11:10:41PM +0200, David Hildenbrand wrote: > On 16.06.25 22:38, Lorenzo Stoakes wrote: > > There are a number of files which don't quite belong anywhere else, so > > place them in the core section. If we determine in future they belong > > elsewhere we can update incrementally but it is preferable that we assign > > each file to a section as best we can. > > > > Signed-off-by: Lorenzo Stoakes > > --- > > REVIEWERS - let me know if these seem appropriate, I'm eyeballing > > this. even if they are not quite best placed a 'best effort' is still > > worthwhile so we establish a place to put all mm files, we can always > > incrementally update these later. > > > > MAINTAINERS | 28 ++++++++++++++++++++++++---- > > 1 file changed, 24 insertions(+), 4 deletions(-) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 4523a6409186..a61d56bd7aa4 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -15740,10 +15740,6 @@ F: include/linux/memory_hotplug.h > > F: include/linux/memory-tiers.h > > F: include/linux/mempolicy.h > > F: include/linux/mempool.h > > -F: include/linux/memremap.h > > -F: include/linux/mmzone.h > > -F: include/linux/mmu_notifier.h > > -F: include/linux/pagewalk.h > > F: include/trace/events/ksm.h > > F: mm/ > > F: tools/mm/ > > Probably better to have some section than none ... was just briefly > wondering if "CORE" is the right section for some of that. Some of that > might be better of in a "MM MISC" section, maybe. Maybe rather than add files to MM CORE we should move mm/ there and add the MM MISC section for files we explicitly want to exclude from MM CORE? > > @@ -15764,16 +15760,40 @@ S: Maintained > > W: http://www.linux-mm.org > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm > > F: include/linux/memory.h > > +F: include/linux/memremap.h > > F: include/linux/mm.h > > F: include/linux/mm_*.h > > F: include/linux/mmdebug.h > > +F: include/linux/mmu_notifier.h > > +F: include/linux/mmzone.h > > F: include/linux/pagewalk.h > > F: kernel/fork.c > > F: mm/Kconfig > > F: mm/debug.c > > +F: mm/debug_page_ref.c > > +F: mm/debug_vm_pgtable.c > > Wondering if there should be a MM DEBUG section. But then, no idea who in > their right mind would be willing to maintain that ;) The same people that maintain MM CORE? ;-) > > +F: mm/folio-compat.c > > +F: mm/highmem.c > > F: mm/init-mm.c > > +F: mm/internal.h > > +F: mm/interval_tree.c Looks like VMA to me. > > +F: mm/io-mapping.c This is an interesting one. There are no in tree users of the only function it contains. > > +F: mm/ioremap.c > > +F: mm/list_lru.c > > Smells like reclaim/memcg. > > > +F: mm/maccess.c > > +F: mm/mapping_dirty_helpers.c > > F: mm/memory.c > > +F: mm/memremap.c > > memory hotplug related. Well, one could argue that it's just a memory > hotplug user. It's mostly ZONE_DEVICE handling. Wonder if that would be > worth a separate section ... > > > +F: mm/mmu_notifier.c > > +F: mm/mmzone.c > > +F: mm/oom_kill.c > > This contains quite some meat. I wonder if a OOM section would be > appropriate (Michal, I'm looking at you :) ) > > -- > Cheers, > > David / dhildenb -- Sincerely yours, Mike.