From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84CECC71136 for ; Tue, 17 Jun 2025 14:17:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 149526B008A; Tue, 17 Jun 2025 10:17:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F98C6B0092; Tue, 17 Jun 2025 10:17:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 00EA46B0093; Tue, 17 Jun 2025 10:16:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E1E526B008A for ; Tue, 17 Jun 2025 10:16:59 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2EB9E802FC for ; Tue, 17 Jun 2025 14:16:59 +0000 (UTC) X-FDA: 83565094158.15.2B96A04 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf12.hostedemail.com (Postfix) with ESMTP id 659094001A for ; Tue, 17 Jun 2025 14:16:57 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=uaFnBZEH; dmarc=none; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750169817; a=rsa-sha256; cv=none; b=PDOX5W3frRecCXUtppvb1EgrMiPHE4B3WMKfvyweTDP4cXGeYcCcJ2JY/YV7Rn4i3KI3oT HSgYwuR0AGjxhw27u2qOc3r97HGVX4JYtLRrHDATKDak9yDru3IebSaYzDyAIm/Hqrswxw FGjLbiT4IxGUQB28VapSDTo1UuloVSY= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=uaFnBZEH; dmarc=none; spf=none (imf12.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750169817; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aJ2ZBRMp3+eybhQRBUP5iID6A+0X+CVA5YnPzVi0/zA=; b=Yf1SrwfidvOvS7npEhRJwc2qOBjBKbmFPc3volWzsvQzT5JBwztns9fpxcM/gRCkRQd6sh qT56qbdbxZlrmg5uggzRJA5aZPdK9e6aZu/GwtaWUejrZF7EYb6XyLJYZoGAzbWIoFCsx/ TpRVJB+CXNkzxWk8Y6Neon6gC8CNK08= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=aJ2ZBRMp3+eybhQRBUP5iID6A+0X+CVA5YnPzVi0/zA=; b=uaFnBZEHmp9pnEPfCCG0dgOJfA SkuG8qf28vknvCvheoXZun11q0yi2k/KemNf9V3vzvRGa3heI3qWfP8HwkSOjy8PF6JH74t/6tVOh bCdHnQttp7Cgh0p1BM1fqhgdNcFVoAqnEZEZDhZ6TNc1wmA5ll2Bai9c/3ZQ11MViAusU7/Z8xriq xSBtfpUJ8J4Mrd1CaFdVsfOiHrmBLLq33IZr0tZpy8HO+hogz+/LcSKuEgaZiEj+sjpXxBGVzxqIi YxIEcG+MHi5ucTmEhUYJccbvyogCmiiFvz7k0+nP5ftPrMg2z6R+XpbQ42Kdr6uEMtN17eyhFpiCe zJqKUUkw==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uRX7N-0000000HFAu-06u3; Tue, 17 Jun 2025 14:16:53 +0000 Date: Tue, 17 Jun 2025 15:16:52 +0100 From: Matthew Wilcox To: Vlastimil Babka Cc: Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , linux-mm@kvack.org Subject: Re: [PATCH v2 06/11] doc: Add slab internal kernel-doc Message-ID: References: <20250611155916.2579160-1-willy@infradead.org> <20250611155916.2579160-7-willy@infradead.org> <3ff99403-9de6-4fad-81b5-3eeb657c4bbb@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3ff99403-9de6-4fad-81b5-3eeb657c4bbb@suse.cz> X-Rspam-User: X-Rspamd-Queue-Id: 659094001A X-Rspamd-Server: rspam02 X-Stat-Signature: ybd8stc16tgctgjdhowe8qkywt6cn3ey X-HE-Tag: 1750169817-487480 X-HE-Meta: U2FsdGVkX1/NDjBlc7PoDZLjohQZwybi5bUNX3ZIxh9+QOIeD71x0AWSoSUPPcRcSPHGhW/BIpVwXOVIVKZhkg1J+bdLbg7KC9FEY6/FTS/cpT9q1MOxUivnBkWvNlO+gZVPhlCDqqIapcZWWdT840lnJCB0VU4kW6FpqmTTHhKpceQspiAX6ewmB3kpNXZm/+QvrXyUdQfS6iTazcmpf3bosayFY8jhlijK32LdC1Zi6kPjJSdYNuop0QoAwLyfm5EfKs/Qlaq4qzI2t8MZPrfnmzWjoLIClz44tcO1GKo6seA7cjwUpYl/AJNmsbqbfzX7EOhrGCnUfwbMxRbj07pwZeoF1BleDc+JLrNkbBq7NMcKWVOE1ATgN12HoUq2ePgTpA3v7YtM7xJK7d24FcKfq52fOjnaDslZtGD65lIxhHX8jZywD+gp4exEt09eRm+e8l1JZEocwdA/gcqaMemJmUxe1MbQI0SNNe4Nteg03G2AXhv1rTbVCsbbP79oVo9yHeefj5krtxG/Q0dVrZ+ErfjNvO+nhvLWj1KTXP4PU5giFvl20zRGAMBwe/Qp3bokbbtMmLSzeBDB3elrMNtngjX+f4fSZzlUOyXGyo/1G/qoru0HsgzDEQGCWtTbu8c9QWgrrECwTTDAuQsxqSpg9Zb0LOKEZj1O7vUncULeh37ctgfUYW3kbxV6O81F5iYTP1BFZx0FBm2nmNpKLfSUAeO3OMp9g1dGOTfrjl1xJlUYJVeMxn+9R1oZaMDOATlRH505Qmvw45Y1t6lRGot5JBYRJmii/sL+EmPgBwq6BhfD/ZqgCyiGwTeLfnzK1YqjE1LjlDEJ0lEmrMYrJLhofKYfCvkjFtY/j9Qlh81X7tZ034oUJ19ge8qdpxybpPG4DGNSqCcchAU+rBoguPtQLQlzw3dYAox9MmPkBZpz9d6kiaJqSTJGO4f8c29LZxPVKqYpzqXryrQ0Nw9 r1h+KKKV zQmc0UJVhxeP0EcoDJWRtVgNxlvjtB/Uv51XJWSy3rU00bnjVVaYQhxWanlt8v68PX2hmJ0lIxDb6DzIUj65Dv16xvngFpDjRH6ZVQCGBfer+mgqc1cz7S/5BHCOw88BZPEY1VCg5ZrtVSUSkhR8qKhUqj/B7xGd/1IQidhjXg9pJoPPve1fNQx+88B5EKI96dzKA5rTEfz6ZBPJypos+Do31OW3/Shnez6Ua X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 17, 2025 at 04:03:26PM +0200, Vlastimil Babka wrote: > On 6/11/25 17:59, Matthew Wilcox (Oracle) wrote: > > We don't have much real internal documentation to extract yet, but > > let's make sure that what we do have is available. > > +Functions and structures > > +======================== > > + > > +.. kernel-doc:: mm/slab.h > > +.. kernel-doc:: mm/slub.c > > mm/slab_common.c also has some kernel docs, should we add it too? > > > + :internal: We already pick up the stuff that's EXPORT_SYMBOL here: .. kernel-doc:: mm/slab_common.c :export: (in core-api/mm-api.rst) and I didn't spot anything that's internal documentation. We can add it later if we start documenting internal functions.