From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64504C71157 for ; Tue, 17 Jun 2025 12:10:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEE6C6B009C; Tue, 17 Jun 2025 08:10:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D9EB06B009D; Tue, 17 Jun 2025 08:10:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8D8A6B009E; Tue, 17 Jun 2025 08:10:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B563D6B009C for ; Tue, 17 Jun 2025 08:10:15 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 651A180168 for ; Tue, 17 Jun 2025 12:10:15 +0000 (UTC) X-FDA: 83564774790.25.9DD0DBE Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf21.hostedemail.com (Postfix) with ESMTP id 3811E1C000D for ; Tue, 17 Jun 2025 12:10:12 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WHLNpWqm; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Y35zgBKQ; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WHLNpWqm; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Y35zgBKQ; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750162213; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H3tv14WSt0c8uWmDlD5dHVqan5MBcFz+Okygv/WCaY4=; b=JbctmkYxmigwprSWtfIPnpUniEHCG4sF7MOyaJTrZXm/0LpRyeamJ8KnjId+mfrYloN0Or DXdotO8w8kqaJMsQKZft+1ebQKZSIPCcVmxL+b/9RcMztSan16ptB+CJR6K1HQjLuSkSqf Lycz5B8v70CkujZ1iGFM0NmX1Pt50KY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WHLNpWqm; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Y35zgBKQ; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=WHLNpWqm; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=Y35zgBKQ; spf=pass (imf21.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750162213; a=rsa-sha256; cv=none; b=RqKdNZnNtAiXUzVmjvtL2paVtDoj+EuFC5QuT5RtI5FlrKzFPnB6Ne9N2F6HF52q22mMhM mjbfwFEA61Nu1oT8KlOC0ysR+75ltDHrtSF7jCmEOh/NqN/LaGspNgaNILgu+T59gHdEUK EHZWPP9C6kep+gR5+sn/VfZyYMtWMnI= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id A91DA1F78B; Tue, 17 Jun 2025 12:10:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750162211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=H3tv14WSt0c8uWmDlD5dHVqan5MBcFz+Okygv/WCaY4=; b=WHLNpWqm0bSM54bEz567SLE49aGHEyqV1E2viIy5ugL7YlvRq2RqQifWbujG5C/baZl8pP xXMMU82b9C9vp7Fc74uN/1bjgOs/+AvRccfFrg+tWjkSsJUN3Yg5zGAIIKUagc1jVa8J3+ 6YRq+EnWk5TCtYVbFeaUi6wHEICvAMM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750162211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=H3tv14WSt0c8uWmDlD5dHVqan5MBcFz+Okygv/WCaY4=; b=Y35zgBKQJQ0pt00ITua8nmr4M/m5p1Phc8OY/3+593btN6KHqeapD1srXspP2I6CIz8Hsj wK3VOU6lavXOqYCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750162211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=H3tv14WSt0c8uWmDlD5dHVqan5MBcFz+Okygv/WCaY4=; b=WHLNpWqm0bSM54bEz567SLE49aGHEyqV1E2viIy5ugL7YlvRq2RqQifWbujG5C/baZl8pP xXMMU82b9C9vp7Fc74uN/1bjgOs/+AvRccfFrg+tWjkSsJUN3Yg5zGAIIKUagc1jVa8J3+ 6YRq+EnWk5TCtYVbFeaUi6wHEICvAMM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750162211; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=H3tv14WSt0c8uWmDlD5dHVqan5MBcFz+Okygv/WCaY4=; b=Y35zgBKQJQ0pt00ITua8nmr4M/m5p1Phc8OY/3+593btN6KHqeapD1srXspP2I6CIz8Hsj wK3VOU6lavXOqYCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 2A47513AE2; Tue, 17 Jun 2025 12:10:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id q5ZYByNbUWhWPQAAD6G6ig (envelope-from ); Tue, 17 Jun 2025 12:10:11 +0000 Date: Tue, 17 Jun 2025 14:10:09 +0200 From: Oscar Salvador To: David Hildenbrand Cc: Andrew Morton , Muchun Song , James Houghton , Peter Xu , Gavin Guo , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] mm,hugetlb: Document the reason to lock the folio in the faulting path Message-ID: References: <1297fdd5-3de2-45bc-b146-e14061643fee@redhat.com> <11a1d0f7-ef4e-4836-9bde-d7651eebcd03@redhat.com> <3eb8e1e2-5887-47ed-addc-3be664dd7053@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3eb8e1e2-5887-47ed-addc-3be664dd7053@redhat.com> X-Rspamd-Queue-Id: 3811E1C000D X-Rspamd-Server: rspam07 X-Stat-Signature: fzuiokkef5c9ebxzx6t3be9jdurw1pyh X-Rspam-User: X-HE-Tag: 1750162212-246466 X-HE-Meta: U2FsdGVkX19UyU9UPH1DfISH8GyzwEyc2KG4Dt9deiNwghWgIPfigYgGERrWnsF57K4euPFuEbd9taI/c522x+eYQQWVLHbJcFg95S8D4FDBNKexF5YDcKjhS12FXZ9yKCmXXVZCB1GH5fgffTRYxcyMppJoVfaqsg2T6xTdjQ6fFTR2QfeDB8Oj8faAnD59Z82urW64218bDkR+Bv8lf+rcpccoMfoYixGlOuIjqwk22m6Dy8mrJKwsXugISdSd4zGGNLd0JAtgBvpB4hLml6qqq912tpl6ydmU0pRklFGaxZ13D6M9/AsH8VLyiZQzkbe081imhSIWnFcmDs0TBvwZU3cCHBccqH9lLLIZHW5IGNeVkc/857AINhZxJa2ekxMF4i4qjDaw9/jWa1wOdFIW2Vs1hozfhFpJq0KYTqtpKblQ79a4jULqaYZ30dGM3iCFbyCtevx3DLy/9H3rf4Vnk6rRiaTZ3qsl2zwLNpslJmU1sfhdR4TJaY9OijePGhmz1CX8R9LCZvzHLPdmSzhbsQIinLumQwtLRyB2/fK3huBn8kDI0CPEAOZWwm+QxtGVaZkHNryMN9fK5qTAjvmw/xPcBeck3hC90kMH6+7DEtun+Ff+sqtvlFAjSqmJ2A0YK7eYfryKOI782HvPyqylJGsamrEhqyiwKkZ3ZjAtjgAg53Bx6WjRVCxwauNyfn3Q6K0ixwUH4eyYecLsJM9GyJOh9UrlR3/HbdTmHqOHpJLZ7yUzgdLH8/yUgcAftILkGBVkf3Jsh4FB9lthZxx1EGU7iAQT20+i2VSVOAyTfc+WdrffV0mZFqPnViF1cJ4dMU5lJSAXaqz2Sn27Ul1BaFSGqKW3NKiVnGrXZQfBthzSgZs1dOaVOWr6xarqONWbJfdCM5jVtgJ2rifYdQR1ImjPG/6Zmdc1MFSn2aTQcTBOKsZxYkeDNtvUmV4YIvuFjC09EvK+CCWe6zW Ne3/FP1p P8+bEcFquafCVGXLrjC21fn/RxG56YyCta3QDBsflZ2eW3xY0a/W84SXKM1sR1fetM/6TfvAks/0Z23mJUJ/3VSn1CJVcLCR3oqDdEF8/vDy10SmX4mHLeibPzxyrHmH5xnV24BxzFBA8Fwd+FEYIdL6fOY0ABu9zaxRYOzyKRJilWZsxG4CjoY0sdwpx1yAe48LAsGtJVwz4YSKpqwK3/DKNlK3OmB+lefZ0ifRcDI+kOdjCrpyXsh8eCl12zdzTAxQXZJHGKAa/tES7KRGhl07eTz40Vhs1ZWWk X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 17, 2025 at 02:08:16PM +0200, David Hildenbrand wrote: > folio lock is a sleeping lock, PTL is a spinlock. :) Lol yes, overlooked that totally. And I also saw the comment from mm/rmap.c about lockin order. -- Oscar Salvador SUSE Labs