From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 748C0C71157 for ; Tue, 17 Jun 2025 19:06:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13B396B009E; Tue, 17 Jun 2025 15:06:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0EC896B00A5; Tue, 17 Jun 2025 15:06:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF6B26B00B2; Tue, 17 Jun 2025 15:06:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id DB13D6B00A9 for ; Tue, 17 Jun 2025 15:06:05 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 89D99101385 for ; Tue, 17 Jun 2025 19:06:05 +0000 (UTC) X-FDA: 83565822690.19.34D01BF Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf12.hostedemail.com (Postfix) with ESMTP id E71EB4000E for ; Tue, 17 Jun 2025 19:06:03 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ckxOpqbe; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of tj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=tj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750187163; a=rsa-sha256; cv=none; b=lnfE5eXTEb8+Q9RUBzqrikMGQ8oFK90HM2xbfc+pP360T+4k5/MJD5/KstsxrOi2hxI3FT EvTCPu0G6gJb6u8X73pd6fR+DRwoDiLUJsz3BcGBX/H7l7CD4TNw3hT3WdRMm3FPmqEAvD MFKS5c52wYbsgoBxnkpbE3Fi2iPmBBw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ckxOpqbe; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf12.hostedemail.com: domain of tj@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=tj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750187163; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B6cbxOusNMsbFdgvaP2Jz1ThbcQ6WQuIdcvrrM7dqp8=; b=lyV+39AFH9AfcoPi64ZYLodSIZE1PMuXTEkox3DCokJkvO/TK0hAVeS5viAHlcezEpyDF5 bJc7EJG2mG3N2kTYIr2HS1WPRIz17AQ6+6/N8t1ea6pM939kyBmBLox11dffB7GyLvSGO9 PUpkmRSl8bsYSHJx5ItlxoRLIGiJUXU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 2AF69614BC; Tue, 17 Jun 2025 19:06:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1664C4CEE3; Tue, 17 Jun 2025 19:06:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1750187162; bh=1P8H001I4NcApk8NZd9sZWJ/AuyDiCxxMbY8Tze/VL0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ckxOpqbeewl7B1vnPJ7SqgcFWh5XVMm7aTnbvc2jnHHxXeXU+qncsrzpYoUrB28BD 7z6MSCdNwvSDHAOy8yhQsulnn5L22NI9uAPga9hGo5qMref1e1um8xxUgKar/rYQpP SF3R1g/e+nyA8Hwfgz01oCnKykN2lhB5eM0tSMtYjM8iLum4llMLVskIT2QGXllxqU ovMKdsQdpQ8DJ7bzMP+kzdiV5PrikoPZ7MCD2skR4U4M1abPdn2dw0VHJNNk6B4MDl KlgHNA+bRis5OTmbdLXpydx7cZWJjC+uwJ4/5YCo3mikFS1jn5UwxpRbt8iZhibAf/ I/O+rE8ih6u9g== Date: Tue, 17 Jun 2025 09:06:01 -1000 From: Tejun Heo To: Shakeel Butt Cc: Andrew Morton , JP Kobryn , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Vlastimil Babka , Alexei Starovoitov , Sebastian Andrzej Siewior , Michal =?iso-8859-1?Q?Koutn=FD?= , Harry Yoo , Yosry Ahmed , bpf@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Subject: Re: [PATCH v2 0/4] cgroup: nmi safe css_rstat_updated Message-ID: References: <20250611221532.2513772-1-shakeel.butt@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E71EB4000E X-Stat-Signature: nzwp1yqt1bfkek7w1q3nk7huswa3zpyx X-Rspam-User: X-HE-Tag: 1750187163-815352 X-HE-Meta: U2FsdGVkX1+2MhhHGgIj9VVN3ubbGjvVKKYjvJDwymLvsW4TwjeIVydNP3JMX4nYnOxk8YgSImhsC+UHRSbYAuRimpzJVd+NWZ25rZtBZG+E6wtdOGCV/QixVfVjQjetnEqezPFZAA63A4vEOelVBVWlrftUG4aRejJ8L2SkdmQFJZVXXZ+2UbQoXiA+YCmUYsNV0SGx//uPoXWm9eWV9OsjuS/NMbtdW8IXCJx/h10u06GfoX5RItoaKTZ9zFML7GYrmhHaCAH0jgDpFfHtRXBKiTMSeez+ZrQRwpXgj79xpJ0K4DOA6s82m1QFGxHXcvcyKDi7w9Q9GJ8+Q7XKGTnfDISfPUBroZlnfAXv6+x40sxoo73sSTEEPy0UVWezEt7xe7tCUQR92PQzjEeA8fwd3Dx4Y0KWCOcsnGTGxJTEEwr38cy8NwJFdtFFp1n/xhz/wK5ro9Yg96J/WJ15yFFbG8XJkaT0tmeHdSjKi4/E0/+wVN0Vo2ybN4AtL3EJo2IcDbn9h9LzLtP5lmUQnPovCOrMGGFhdRwB0RjV8doA/laHYa9SafkQT7PXwJrbs6WxkImwv7+SMSWjAQGoGJRb9zgMIUq8FdpUjDhvURkAS8/ZAlaTIgot/06XmLr1Gv3v9G95o5/yqpLsGVkg3CYrGFDvyNRKVvs0XJyD2idYQF6jYLJKl83x2g+3qF98MSsp4zmzZfqYahOYGpp2tID4nVI24B7UNQwCMeMUEBmHZvrrkkh+oApBUbJa3aUfakDFIdkj5CMJJLAL4uuuJ/tKvzy9UfnSwn9BYnKXNxNwAXkCm912im5jtW4uX3LjbhSXgdvXeq2Qn7+SXEJHN4jM8Zd84GjrtPoWryQvw4yYr1/1tffEW3wr1GzekReF83fn3HVodgQqE5COp75QNYIv7SWtoGcRy5MhUGI2qMgO1JJlaBX2XtEjQXfcc5pqKwZnGTDNwz7o24OTasw bEoUjIS0 jPeA/tPPnE3zTVIiUpAJcPO+Gv4Di2OU1r9J6RT3tCV6WeUTyx+KUlKVWln//SfH9bYXK8NFUMYODDSElIheXDqGThnpfeZB0ymSR1sC3Kapwdl0uh0x2TV0WWKGADE/H1DgLldO1tjabv0k3ut8Y4pfXXVXODA9tmfj8qfF4EIFe9lFcvrtu5yJpYwOxKKQXrqysxXTb6Bd4trUVj/TQ2EcMZxMVOWJsfR2lIH6KXz+pppr4GPNOCIvZe+jCZu4JbVGKprCOVTPbhw4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 16, 2025 at 12:20:28PM -0700, Shakeel Butt wrote: > On Mon, Jun 16, 2025 at 08:15:17AM -1000, Tejun Heo wrote: > > Hello, > > > > On Wed, Jun 11, 2025 at 03:15:28PM -0700, Shakeel Butt wrote: > > > Shakeel Butt (4): > > > cgroup: support to enable nmi-safe css_rstat_updated > > > cgroup: make css_rstat_updated nmi safe > > > cgroup: remove per-cpu per-subsystem locks > > > memcg: cgroup: call css_rstat_updated irrespective of in_nmi() > > > > The patches look good to me. How should it be routed? Should I take all > > four, just the first three or would it better to route all through -mm? > > > > I would like all four to be together and since most of the code is in > cgroup, cgroup tree makes more sense unless Andrew has different > opinion. Okay, I'll route them through cgroup. The patches don't apply cleanly on cgroup/for-6.17. Can you please send a refreshed set? Thanks. -- tejun