From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D654C71157 for ; Tue, 17 Jun 2025 15:53:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A15696B00B6; Tue, 17 Jun 2025 11:53:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C5BA6B00B7; Tue, 17 Jun 2025 11:53:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B4426B00B8; Tue, 17 Jun 2025 11:53:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7B86A6B00B6 for ; Tue, 17 Jun 2025 11:53:03 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2AECC16058A for ; Tue, 17 Jun 2025 15:53:03 +0000 (UTC) X-FDA: 83565336246.02.7B27783 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id B35DC100011 for ; Tue, 17 Jun 2025 15:53:00 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iJApMhc7; spf=pass (imf05.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750175581; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=A4OJt/a44jwhdTN+yTSXPXvzY99d5n2WtYczgJuAvKg=; b=HPmt2ITnao5DYVejsARTb/pTDJyJBKq5d3Q9P66A97A1Uj1ew/b776MU0yZVG0Sau02Q0H eaKlUi1wEq9fF7JN397siebOYe/L/Az/Gk+wubp7aA6XztamWSyCblmUQbFBmCaamuhjFa Unw/FOFrdOIUK5BpMElbnRRKshbtJD8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750175581; a=rsa-sha256; cv=none; b=DRej807Y2zcQXmF9pMJJqOFkqw5ebaKvbPFdvk2XoN1rTVIPLHUyT9uoZRe2QFltKm2Kzc WqQOGfgKpkpa5QRes9VvXJcK8UfFi31m01tJ0a567qsQ+0Q8jCTWp7F5I3T5/cngHtVpDo 3JD2L3bGxNJeETZ+Tt7qUIOXC+1G5iU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iJApMhc7; spf=pass (imf05.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750175580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=A4OJt/a44jwhdTN+yTSXPXvzY99d5n2WtYczgJuAvKg=; b=iJApMhc7A2josu5hV7jJ+RaTJicLnMlGku2LzKTqyb06HuJRcdhypp5bre4ebHVpgb25Lc z06pTfnt6yb0ZswTah5zr7toMzLuafmNPuZuFG58oFD4xnRx3uwARW2m5JRz5p5uaED2ij ml/xNdEyq5SS7Hf86m0VVlh4bHpYIKw= Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-292-McwS_j8POWCNsWSQ8RbXcw-1; Tue, 17 Jun 2025 11:52:58 -0400 X-MC-Unique: McwS_j8POWCNsWSQ8RbXcw-1 X-Mimecast-MFC-AGG-ID: McwS_j8POWCNsWSQ8RbXcw_1750175578 Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-b2eb60594e8so3712812a12.1 for ; Tue, 17 Jun 2025 08:52:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750175578; x=1750780378; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=A4OJt/a44jwhdTN+yTSXPXvzY99d5n2WtYczgJuAvKg=; b=JVURyF9L9MufJTsCpJkiJslVQLCcrWcwHILvclIO0o1vhyF1/jzvnMo18LOFPnU7GV uzntnmbRcHQ8H2VJh6Yiq5U2vbPmbI3zWBhUQjYtYmc5si2uSoCyig4qGBM2+Odfcu+c FeLj/f86mRTJdL2pfcZGl63AoEBjFLRVRZ9iIKjAQz9pfINO4TWB3HIGmQipNa0AhHTc VoYt9zZEX8A5skG458l7p52y6il1UBdZHBMDfmUxUtRiZmhRLKjw2upznAEZcn9iFFyq XTHTQB3Dpmt0fSgAI9sDIw0qPIjiSwdWZTkSebV4Rg+0/nDiFCQNAs1cWeqR8OKOAnVx IK0w== X-Forwarded-Encrypted: i=1; AJvYcCUMQBbVGGrewztD0JM98uzQwTJZGYpYyNRQ4/8uY8qUUDhcO+cs0yh872UWZ+OM/6QnEI5hnwLxTw==@kvack.org X-Gm-Message-State: AOJu0YyHvj/Wv4qpLySG7lQsepyUB4ePScdMZxHVr97GCyycl5DU0vXs bY1VDiBh7uhuIS0kQOOxcx10It92NnLdU81CX2g158vAvoxcozQKuzfRLOb7vGXb60D3wauP66Z xbPoxOf0398+hQM+gHgUafeACnA5CwUFy8v7RnQDUBjs1HJVkepx/ X-Gm-Gg: ASbGncvBdLjzt7BOvI2FVZUzAmsMiFqzXO/I9WOhRcjdWFTYwcJRflhgh8yrN7Nq8cD YbX7XNeCPuQP0sknt2G001fowrJsfEoRRc+bTvgAgvVfqxy99aojXv/4+iSEN1PHYdohLChLrxg brytEYlmP1Th7NVTQ5zBIQJsj5xPofje5qR5TV/GGM5tPdLVG+Xobk5u4APgYExNb3xwplIzbNO qd2dAVcS70aiammMxQA0Bl8ZR5LQP6tk6ynIQJDPbUD/CMShUe/kobq+COPmA6SCFkkoUTEiA05 N4RNwhiFJ1BcqA== X-Received: by 2002:a05:6a20:d04c:b0:215:e818:9fda with SMTP id adf61e73a8af0-21fbd67f904mr20435855637.27.1750175577741; Tue, 17 Jun 2025 08:52:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFj36Oe4A2jcNoqS2BQRql6Igh2aHBYLuNua+frzBld7sGbq1gUwnVFHIYvO1JZJWclqgsPDw== X-Received: by 2002:a05:6a20:d04c:b0:215:e818:9fda with SMTP id adf61e73a8af0-21fbd67f904mr20435835637.27.1750175577393; Tue, 17 Jun 2025 08:52:57 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-748a6b1d620sm6123165b3a.116.2025.06.17.08.52.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 08:52:56 -0700 (PDT) Date: Tue, 17 Jun 2025 11:52:52 -0400 From: Peter Xu To: Andrew Morton Cc: Ujwal Kundur , shuah@kernel.org, jackmanb@google.com, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v5 1/1] selftests/mm/uffd: Refactor non-composite global vars into struct Message-ID: References: <20250501163827.2598-1-ujwal.kundur@gmail.com> <20250616100406.2853-1-ujwal.kundur@gmail.com> <20250616172618.0609127a8b1e406d4c228d24@linux-foundation.org> MIME-Version: 1.0 In-Reply-To: <20250616172618.0609127a8b1e406d4c228d24@linux-foundation.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: GUb7SJEjGA8GI4Yx3-4GMdh96Y9hyV8a0Xo5Gk9aqIs_1750175578 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam03 X-Stat-Signature: dujcq8g4a4fqfao674gybs4e94wjtwc8 X-Rspam-User: X-Rspamd-Queue-Id: B35DC100011 X-HE-Tag: 1750175580-755275 X-HE-Meta: U2FsdGVkX1+2+2I/TLWBVN8EpVWvErn5+ypSzDwB5pyYyBTif2qLEo60kBNzFbNmNdZTMug47xz0w3l9Q24VD3EWXrYPyRc+rR2Ve1j8AxM/qHCpMnkOK5z9ojP7Y0vciQInwsyhl8fjzpAe2sZAx+pK5eRpyQq6ySdFMtAGSjuP0yCe4ttjs47nyA4jyX/ZSf/6DfkHUcgsrqKhGQHkMRLH7z8SKiWYUa3ih4M02v977o2OnuoL6Nwc0vZWHdXKcUpdOml5WGzy1se8Nq6ikZb5PdIOdg3Bgw7FOiRA7DiXRowPJAulJoFu1N3lhKVGY94XJbGGLfjB2TQYnMPDPBw+NFcJrSTm681eqDbeIrGf1aPK6Ks/YBpw64X3iX59uoikz+JE2y5eHSS7jEKcezcC35MNBGPnDccpoOr/a84KJEN8eYKL7T2/wBjQuIreXVdGQfygohUUtV3QIhqtq3U01iBR+2JaBqCxz0m+B6gWW3JkcVkAuiazO7RMVBShG7Rzck+kfaQmPoO34ZC0T/xileDbGsbmhzlYElYCiwOwZSuXTLYPGFIiBTZrlSVPpPv9vyoHV3MKBY0TfB9nYAkMARwS9mbTdFVSRidS8inYRNzifSxjeOxWFYkJhAWponIfetLw672gcIynEy6Ae9ab5IcrlzvMJ/X2yv1koNjSEjuRpw97LvvyFzKrGj1fVb0EeeaKUa4hvXIj3HbhwupfCnul5tqsIbwIbTPXw+tzThJPRarMNsCM31cUmW7MyYw/KMctbPpJegPbIPFf2acM+fV8U98nvxpjVVgjZqakzJlTEvI08pa5LayndHSM9Zq7Pb8MPVuBaKX8XaLiyCcn6jF6Yav+N+186I5LaDQHnWqsntxrM/fUN1tvp4htjEMWK520djZe1rPmEDi0G7KGVyqaukZW+Mqin3NcHQFx3un8l3jiYkrBXvwMw+svKA3QK8AOZTrX4frADjD YXtdjnmi evQEa7mB6RgtIrQj3X7yhzaESmPvuPmAs2jj8BdFNQ005r6pVvJMr1sr7gcVuDZcTh/Ugq6Fsa4Qwd+xb0IiytiS2q1ze3J2OsuszpFp115HTJQt3SFWCB5dbpLVKyHeXWjk1wrPK9XW1C7Cbw1NtNSa0YI7Ilt26tMa3AeOXB86dDLDgZxbAhQ4X+gYFnr12x7ayULJvB918WuDjt+pMXq7PTJVeqCNtDw5Gh9rix7cLKRBgfKnzC/t90Q9uVTCAghLv/67NFU/leKohcrBsyTtRcZ0BdzUOp4MsvnQyLvsih5T5aqhhnLBnE/dkuVOxEGocBDPalY26JiJjP53AMb9fBZ87HBS2KT4sRnn1zsH4ACoTqtX/UbS3DZEUNIPDbQ+Khq00kzWEfn36N4R5ftTrjxVzvzq9ZCjktA6+fjOCSmTY8oCWnCGwZA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 16, 2025 at 05:26:18PM -0700, Andrew Morton wrote: > On Mon, 16 Jun 2025 15:34:06 +0530 Ujwal Kundur wrote: > > > Refactor macros and non-composite global variable definitions into a > > struct that is defined at the start of a test and is passed around > > instead of relying on global vars. > > Well I guess that's nicer. > > > 5 files changed, 616 insertions(+), 542 deletions(-) > > It needs to be! > > Thanks, I'll queue it for testing while Peter thinks about it :) I didn't pay much attention on this one as I saw Brandan was actively reviewing it, which was great. This is definitely an improvement to the test. Thanks both! -- Peter Xu