Re: [PATCH 1/5] mm: Deduplicate mm_get_unmapped_area()

Peter Xu
2025-06-17T21:14:08Z

On Mon, Jun 16, 2025 at 09:01:34AM +0100, David Laight wrote:
> On Fri, 13 Jun 2025 09:41:07 -0400
> Peter Xu <peterx@redhat.com> wrote:
>
> > Essentially it sets vm_flags==0 for mm_get_unmapped_area_vmflags(). Use
> > the helper instead to dedup the lines.
>
> Would it make more sense to make it an inline wrapper?
> Moving the EXPORT_SYMBOL to mm_get_unmapped_area_vmflags.

Yes, makes sense to me. However that seems to be better justified as a
separate patch.

If you wouldn't mind, I hope we can land the minimum version of the series
first without expanding too much of what it touches. I already start to
regret having the first two patches, but since I've posted, I'll carry them
as of now. Please let me know if you have strong feelings.

Thanks a lot for taking a look,

--
Peter Xu