From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06ED0C71157 for ; Tue, 17 Jun 2025 21:14:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64B876B007B; Tue, 17 Jun 2025 17:14:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 622BF6B0088; Tue, 17 Jun 2025 17:14:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55F416B0089; Tue, 17 Jun 2025 17:14:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4B0C16B007B for ; Tue, 17 Jun 2025 17:14:08 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C14DF1D7440 for ; Tue, 17 Jun 2025 21:14:07 +0000 (UTC) X-FDA: 83566145334.10.5A68196 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf22.hostedemail.com (Postfix) with ESMTP id 6852DC000F for ; Tue, 17 Jun 2025 21:14:05 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WrI4WpNC; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750194845; a=rsa-sha256; cv=none; b=V/3bAGrqYvYpmxtX+Jbo+WmafMK/GWClRHfcyNF41oN/GQ34NPHWPebzoXaL7rsn9l75Pk T7pTKTzC4GNK+9ZcWTd7VmUyRE8Q8FzleQB/psvUKN/rtWFJS1aqzwzpNAnm0UqnWgxdeO widbMSzAVnULRM2YXj+UBu4HYtnjLC8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WrI4WpNC; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf22.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750194845; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5xyVcI21nsfxdfOvk8Q+hN3uxkhpR2sAV2MrhUYOX6E=; b=31jN8wAXsLz959d+dOiA0CzyV1Pv7iVfcITxSIq3NR4GpgqK8igjCXjjOEPuIspWjMP2qj 9/DzoaSawDQSo1CLjcULi9WEDEBJ4RKTzJHTuyJlwCyct5a4I/zXJ9o0XGxR2a7Ic05QWR hNUkWgrEx0PlZMmICkUj7AZsh5+PotY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750194844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=5xyVcI21nsfxdfOvk8Q+hN3uxkhpR2sAV2MrhUYOX6E=; b=WrI4WpNCcLyDDcGVcuMCVmrV/PKgMJCmP7/Cjm/w3uoqZ5zDRQYrE6qmStP6ru23BI8Yhu gk9vrSIrOzkvP+KMC895E02pP4ZxPleazBTgisYjJ/sla/2FeTr+6XhcDd2nQvkZfFpCeH Y5J4yEV4cHgTMYv9LfLl0AT86/YfFnI= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-680-m4SqspW4Owa30zWBmUhAYQ-1; Tue, 17 Jun 2025 17:14:03 -0400 X-MC-Unique: m4SqspW4Owa30zWBmUhAYQ-1 X-Mimecast-MFC-AGG-ID: m4SqspW4Owa30zWBmUhAYQ_1750194843 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-6fb50d92061so35816766d6.3 for ; Tue, 17 Jun 2025 14:14:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750194843; x=1750799643; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5xyVcI21nsfxdfOvk8Q+hN3uxkhpR2sAV2MrhUYOX6E=; b=EMqkPAuq5BfqAXhOOLukRXyZxRfkweTmekneIdpEHAnXYGgjBtikex5I7Y7uQvTch6 bOWMEELRs2seBkE9ScuFuuqdr5ET0nRg+1c61ZtjMSKXbQzkGyaqO2mSVfFqMb0KBezk jbhiuy7L2e9CXXDFILWTIW6rTgKet7SzNJHJjLpjLzMJZWEDvHqVWkbaDCmACWW8VQb1 BVvntiX3sMNRZkaUsrEEVn2vP5dHNZ6b+1mO9DcWEP/apL5dYPTQ0Jo5WQNuotAPHDrI GTwc54Ae/Q/QIMgEmcIVgczq0psVqpBs9kuryPkII6Z2Umkpx4UgvfXrAwMgMvyXHd5i qBWg== X-Forwarded-Encrypted: i=1; AJvYcCXsGpzHMBRo6MKJaLYeeN9OGKLg5k7qYA9NjjWsOUoJqml6O1N2+UfiTORplHZpjV5IsjPH9dYJDg==@kvack.org X-Gm-Message-State: AOJu0Yx3y5fqIFhQS4LnjXs7dj3cbcwL/xzPLThU0/fk8Gof70oxDp6K Z2kNr2YR2tdB0HW6qY12hKWIf20suIDd9e1H3Ivzz3lHwb118RrgVXuL2LJL6D2juu57Uk/YlWw 97hOJKiYhNYuNs/9Nm+16pxw62nJofuUj58TGHZlUiUO9glOTs3vp X-Gm-Gg: ASbGnctsw6xTEZka6KMq+AJBeacTBCSg/4RG9MMAb+Aor01S1/mhZLDnBjGxtV53Tg6 NS1Dpy7DvnQv7uJ9kengAVwxw1/swJTphf+7Dlxy/Q+7VKAlLLiGfUbR18bi1LDVUevl5wOu//P sDoHWl3QmKeCOGS/JWzSZFBNkw/y40I4bhAzERzyyyf5hUTjSc+rlKgHfJx1vJV/AhfiLx+PDP2 vTE8qcc8CquPtXUS48aqt8jRjJmPtpDXupJ7gIF3ikVpg6MTWTzsMrhcIPiVJfcB3EaRzaofdJa U11KXRi00yXauQ== X-Received: by 2002:a05:6214:5c47:b0:6fa:fddf:734b with SMTP id 6a1803df08f44-6fb47778883mr208411046d6.24.1750194842854; Tue, 17 Jun 2025 14:14:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGd9iW2NHB23PfBNcvXV74RskpHtC25owk7vFs1c30i5QjvUnprzErLHz+PlrbZV3IBT1BdGg== X-Received: by 2002:a05:6214:5c47:b0:6fa:fddf:734b with SMTP id 6a1803df08f44-6fb47778883mr208410726d6.24.1750194842564; Tue, 17 Jun 2025 14:14:02 -0700 (PDT) Received: from x1.local ([85.131.185.92]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7d3b8f2c4d3sm690671485a.116.2025.06.17.14.14.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 14:14:02 -0700 (PDT) Date: Tue, 17 Jun 2025 17:13:59 -0400 From: Peter Xu To: David Laight Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, Andrew Morton , Alex Williamson , Zi Yan , Jason Gunthorpe , Alex Mastro , David Hildenbrand , Nico Pache Subject: Re: [PATCH 1/5] mm: Deduplicate mm_get_unmapped_area() Message-ID: References: <20250613134111.469884-1-peterx@redhat.com> <20250613134111.469884-2-peterx@redhat.com> <20250616090134.476427c0@pumpkin> MIME-Version: 1.0 In-Reply-To: <20250616090134.476427c0@pumpkin> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -B8Z1vpUKjCCCOri1X1RrlV2aCKcLHhFYqtCkCFeXdc_1750194843 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 6852DC000F X-Stat-Signature: ob7iakur9ewgk8d63bn4jjqe37ccgmfc X-Rspam-User: X-HE-Tag: 1750194845-832006 X-HE-Meta: U2FsdGVkX19GhgRptvxa4BdtuCx47xdr8zSlHRH7E9EMkWIBJ4+m1kgXu1q+8ws/Sc+ozHF3YVJJKWbzrZAdNakWv9a0KxNxDwjQQ4cnxlPsJ8yz0w1+mk0aBUAgUN5F/GrKBpZJzyLwkzKNrTQ+vDaowpl9RYM4qMNkq0Ze8odR0jyWS78A3+LjeoVxDJl5NCdXYIwRIjxTX76e5SfYvvJ5KRoJZ9de1LQNOcdEDqnHJmbZTKLJqUxyqSjIOWzm2m+VL9phHppIFI1dr/Gdnn6tWdy6Y5ImXk6TVjXVdF08dAc4iy4pRNp0JFEPJCHXKbyG9M+xk3Z7MCoHH6xLCZlh3ATgj4/Ucf1Q82zqwg5iSaKtz6nJ9uSR7LKonYd/Hd5MHpQs9uh5nboAN9Aljbv7pHJmRtjCJfcVNNFQNBW0mYGKJ/GL3rdpPLp/EGFmGDK/byyf2VaVDMOIDVDxaIF217zkfLDZqWM+7LUgWbrnombABxxIJWMpVAYL5xb/DS3WHD1IjF9zBFtcu5403oTsX1QcaMnSaTj9gZssn52QtvPOO9QfW+9WLFden2AH2ngagatz4I3mY5Mug+iSmlsyHPWAyYKAPLvj4JxvFN+tyU+bqYmNI4MAkuST0QxxvwC054TqCCZfThdQ/z5fcDmQ3U7I3VCtMczkmm+DCvHG50KwRpcdT0sm0PLatduYEP8J++qM/G1GOQWSm3quj0eEYu7g1+Cqp5IC8gEND0UXNSGz1PSuiEii66cVXrq8R/Iem1XAKiumD3lzsRmDgaj6Nm+sjQSqHmNaWlk9gjJV3YknOuqZUeR9rQFUffN35eYYnLFr6U+vBhmaWLhJOiXhfaMj6prg1hEXS6Lf19oS5ZjNwBbZQHCB/Qv1PYZVugqhIub1tXk6cYHJK+1I8JqnCLvikGfNa4vl0NKKnEfGi+fCOwfGcg5bL5SJKj5D0cOKDDCF1MHzC6p/I+V LUYSvPvO VwjmYDedtTg9JxYcunY8xQFZvwJGpr6wpSVMN6zJr80wwJlOlnDOs9Z7hCl+/b5xprO+w3li0t+xDq2Ub9NZj0AzIJrUwzDEkXZp9YyM0RuwZ6WH8PSdhfC4Dxb6oChKuqXCUqHtETARO8i4FosFL7q6UIOkEp8Ynu02XjaVfgNESAQ/UcH3NBbJB5eY6iMXez/fxp/ugeDzRw+T2w7v9fvHMwKfszW6p8ZkFnU1CujeEzFl4DXM842X04taj1YWNmM/5VRGdPZzP3fePfzieDqvKoXoUbeFCLE6zUSCrhRzPWycoY09lZLST9sLJQQnR3Biqr+zU6zsdB4QlS9EHS6afFcJcdtDBpXp4MeHNK8O+Cqc3r1lrgPe3XtrdjLVfzCHeZ5KlDN5ryr8N4/KjWy5HwrAEqltElAdUrmZ++/86BcYuBok3H6VK6b9kRJfVzraR9QyCZqGO9infhzltiiv+haIsL24qFYn81YIBucIChQ0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 16, 2025 at 09:01:34AM +0100, David Laight wrote: > On Fri, 13 Jun 2025 09:41:07 -0400 > Peter Xu wrote: > > > Essentially it sets vm_flags==0 for mm_get_unmapped_area_vmflags(). Use > > the helper instead to dedup the lines. > > Would it make more sense to make it an inline wrapper? > Moving the EXPORT_SYMBOL to mm_get_unmapped_area_vmflags. Yes, makes sense to me. However that seems to be better justified as a separate patch. If you wouldn't mind, I hope we can land the minimum version of the series first without expanding too much of what it touches. I already start to regret having the first two patches, but since I've posted, I'll carry them as of now. Please let me know if you have strong feelings. Thanks a lot for taking a look, -- Peter Xu