From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA96AC7115A for ; Wed, 18 Jun 2025 17:46:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 742296B00A8; Wed, 18 Jun 2025 13:46:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F2EB6B00D6; Wed, 18 Jun 2025 13:46:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E20B6B00DA; Wed, 18 Jun 2025 13:46:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 464236B00A8 for ; Wed, 18 Jun 2025 13:46:49 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D498316087E for ; Wed, 18 Jun 2025 17:46:48 +0000 (UTC) X-FDA: 83569251696.25.A35C003 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by imf11.hostedemail.com (Postfix) with ESMTP id 0CFF440006 for ; Wed, 18 Jun 2025 17:46:45 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=PUwnkHNb; spf=none (imf11.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.10) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750268806; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0cjbC4n+dVyw6tEbQjaYr/a0phGROcAt0dBwT2Yvm08=; b=Xf321ZohEfwKEVFkoJ2UMq3mGhFBIGSQfOqmxnY4ow1yUY5+XE6MUvCMSaNoomyrNL1438 5dMTZ0TlyucnJsodSTUr7o8MsGG9VEMH57BoqdYry8xAo7xOYJfndT+BFUY2PjTx+6vnhi VTBxbo3oOrpjIeVb1QelMAo+QOd6XtE= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=PUwnkHNb; spf=none (imf11.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.10) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750268806; a=rsa-sha256; cv=none; b=NkWT69ty07PmQKnY6/5SOaKqwnM+i9ymsZHF/VWfxS+wEHAHIY2q3OOtDQD00hzCTuI3m3 kFMLPMgh6qtO09BZx8JsPTWqrCIgD9H9qcKdCTrLLQwuDwyVDsSh5oBdJdkOO0JAPgQsS6 jBxNCTA4YBe+l8/MBUiI6zwkzeDiV/o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750268806; x=1781804806; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=CX3CVwC+8hJczoghG3urZ1kcfu4HjXWGEcQWKQNEuQA=; b=PUwnkHNbfqMlFp+DCk7yy2/U+3CpctkCFKbR9x4/wFtPJKMLcOJqjC5B 4L+Uk5PBuy/de1lG8ZCRia0RHCa+jlt5K7HTbvVvycF+39aatr6BrEaW8 VxpOLEDIwxGGNMtDhP+WHTNi6lkwwH4hhYnZ0uZ0ewJyiCbl5cfhHwBCa yz+SFmctJAgLLhfrQh49KoVl+5h3JlXACwdR69kkd6ORk3eiriVpKiCwE F23Ninov4eCudmZ2WtCHzsIRMjot7TkvD9yyZ6d8uayDlvgAOuZKtywtV LZwTjkZib5FxfgBs2foY/rzF0uFlLvOgYYVTigRbUOKfZIiWrW7NcsaOe A==; X-CSE-ConnectionGUID: UprR9XzxQFSgwuw3qfoI8A== X-CSE-MsgGUID: eQDpT0c7SzmWHb0IXSRNrQ== X-IronPort-AV: E=McAfee;i="6800,10657,11468"; a="63856729" X-IronPort-AV: E=Sophos;i="6.16,246,1744095600"; d="scan'208";a="63856729" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2025 10:46:44 -0700 X-CSE-ConnectionGUID: ESfDO2g2QGiLU6Mzwp161w== X-CSE-MsgGUID: YjB0iG07RZKToR9caSShAw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,246,1744095600"; d="scan'208";a="149827039" Received: from smile.fi.intel.com ([10.237.72.52]) by orviesa009.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2025 10:46:42 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1uRwru-00000007oal-16HD; Wed, 18 Jun 2025 20:46:38 +0300 Date: Wed, 18 Jun 2025 20:46:38 +0300 From: Andy Shevchenko To: Anshuman Khandual Cc: linux-mm@kvack.org, Rasmus Villemoes , Sergey Senozhatsky , Petr Mladek , Steven Rostedt , Jonathan Corbet , Andrew Morton , David Hildenbrand , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [RFC 1/2] lib/vsprintf: Add support for pte_t Message-ID: References: <20250618041235.1716143-1-anshuman.khandual@arm.com> <20250618041235.1716143-2-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250618041235.1716143-2-anshuman.khandual@arm.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-Rspamd-Server: rspam11 X-Rspam-User: X-Rspamd-Queue-Id: 0CFF440006 X-Stat-Signature: bkww3g9jie4zjo7dc9eppo6x3tqb37a9 X-HE-Tag: 1750268805-45450 X-HE-Meta: U2FsdGVkX1/Z9mw44a4CsUujYqg+4fxN8zYcnUkAeGLEpaf+EHHbqXkdgm4F4yj+jIWVKex5w7FNnvbbEfoiiGTAjiD+deLyw3Sc4SBcfQqP5OVzGQF8XfA6LEoETJnjJDi2qsJv3TalGz7nbBhI2V70i2eRcqq41Ll7/+SYXe2PqwEI/148yHKg+uRl1m4+plQKb1qpz7srl2V22mJhMu6frC7b4ZTc2hpOqgJnLT2ybXyGL78hBrS5dHF9ThpatdgmEFBE2EzAPlLSIGB4l72j1ibu3hcXtHGSJaCaiAKM0V72w09qk6XP7QN3YYssz35jUlHACCDMRvR8jzQwLMvt0CaBbuKFPFlylssceTcz96TEVvyf4YFyVwkvl76RXebWpBSOK3ukgn51wlIsxNAh6yizsrnCf/xFgI+BviaIb4d/+VhENsHwR92AJ57yeFvkiG/qq3hkOPDLKj02vsmHYKcutbo4CcKOn8kEQYs+IKMGdE3YL8DZ7NOVGPa8XQJDxQ3jHSsQQ5bBGfI5oY1iS6RxZO5CtavkOMpTM3mTOC8IRy+0FeebEpou9qb9Taab2Oht2ZEnJi0tbE9bz8nlC3mOeRJmLu+KiPIlOrkIcuKzrVBcsAG51TBJwD0okQd0pchHQhOkrJ+n5JnDlfLnv5t4ic1JtdgFmrfmXH7UDTOZPCRcXuluOX+wH1vk3DCaTlCt2r0XdMBvjD1fI1FvFzs953l61A48wUNGEmuvJGVRwx6sdDWj5EtUPLrwNJQ0B4RA0d6YuTozjmamSvIKmLCBFDIDkD+x8CvQ1wbIO4S8Ao2IMVzZ1PGZsWXh+GrVzYSB7VN+homW7uanAWLxmwJ28mVX4UZQZnSThE5DBrHD0sHmxTHJ4plQnTDftlUbxpU3A9JEiSJkM0L33mKtA2F7ULc7EYReRdXJjmWYcIl8tzROvJNwfEuAyJjvdOyCVkdnHb//e7Bg6kK I0afvTcJ ZRs00zlffcil2UCeyklOJLBEDbNVJpyJ+frIoZNWc1LQ338l6IbjWZgeiAc+xxc3JB2Zs02VDFVivPcc9A3vwcpLCaMOHJnbbLBEGX6wJeBaH+JsAbThYFBfb7MIEJWk5mfpdxAep4DgOimDer1lJe3rxHfZJTj6pjg1i9LwxzodFQvRsbIEUTyfPCda6uN+aKmxqRaVG25in8lia8JkY4pRTzXWCbmQBsqKbrCeLpQB0KGhxYl+0ikCcfo/BLi4Pgmcasjk8MSIC5BSQfiCCUkPM4lBa1GHD3E44zm+JEkD9L1BslMyzsR0Y2S3SRnReD/6WEzYMXr5gVQELMRll579bSJok7t9Hj32CzaedkLe920amzrjyJBVzyjhG0o61/q7WSW3zSFctKKnxymSjNqSLOURRlIko9pOYGO1sEoQ7BjFrbqnzP5aH3q/YnXjfQM/IXR/6x4eDB3nlYy4zRhI5BsXrY55MARbs7+hsWoivpYFvpq8iRuC8jj3anAsHNLsilfrvpsa/sApWKEwkRB4Acs7K7JQgiE6RlAur5Gi5sO2lpSZAj6JapoWKlX4PVpwqVPzovlY1jU5hattZiXhTTiBimgoPULRwItw5fazsTmM5JxX+UaB9yBVQTkkn13+J7c8ROlTvT2KZHMaNmWwq68myMo3R351xJS/30/wDYHo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 18, 2025 at 09:42:34AM +0530, Anshuman Khandual wrote: > Add a new format for printing page table entries. > Cc: Petr Mladek > Cc: Steven Rostedt > Cc: Jonathan Corbet > Cc: Andrew Morton > Cc: David Hildenbrand > Cc: linux-doc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-mm@kvack.org Please. move these to be after the '---' cutter line below. Just leave SoB tag alone. This will have the same effect w/o polluting commit message. > Signed-off-by: Anshuman Khandual > --- (somewhere here is a good place for all your Cc: tags) ... > + %ppte I believe you can take %pte. ... > +Print standard page table entry pte_t. > + > +Passed by reference. > + > +Examples for a 64 bit page table entry, given &(u64)0xc0ffee:: What does this mean? > + %ppte 0x00c0ffee Can it be ever 64-bit? ... > + spec.field_width = 10; > + spec.precision = 8; > + spec.base = 16; > + spec.flags = SPECIAL | SMALL | ZEROPAD; Do not duplicate code we have already in the file. > + if (sizeof(pte_t) == sizeof(u64)) { > + u64 val = pte_val(*pte); > + > + return number(buf, end, val, spec); > + } Ditto. > + WARN_ONCE(1, "Non standard pte_t\n"); (almost) Ditto, > + return error_string(buf, end, "(einval)", spec); Ditto. > + } > + fallthrough; Please, avoid this, it makes code much harder to read and maintain. See above how. -- With Best Regards, Andy Shevchenko