From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C52FC7115A for ; Wed, 18 Jun 2025 18:39:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4E0F6B00D2; Wed, 18 Jun 2025 14:39:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFF0F6B00D4; Wed, 18 Jun 2025 14:39:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BEDB66B00DC; Wed, 18 Jun 2025 14:39:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AD4876B00D2 for ; Wed, 18 Jun 2025 14:39:27 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B7F895C2DE for ; Wed, 18 Jun 2025 18:39:26 +0000 (UTC) X-FDA: 83569384332.28.9A44C54 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id C539918000E for ; Wed, 18 Jun 2025 18:39:24 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=DsxNna+m; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750271965; a=rsa-sha256; cv=none; b=pIp3GO1DMVL1TF60N4KFCpjp+/cFJcvSNWIXh9TeH1Mlj92xiJQcfoFym9vya+jgcKtnNw CRjRTVk5wgJsHBXyzFpJY5bljdRGIHsYs7B9cHRbd5b63mzgH7oJNR8T5IQr3wKYQxR9m6 l8LefWv2CkcngaNC/ZHndR0v4Hex8lk= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=DsxNna+m; dmarc=none; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750271965; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v5tYhFD1j+yv3Iu8PpEhj2ETO0QbZsDAEopsQ/A9bAk=; b=FrN16dMEP78SSVe63EeZns328kWfE2sSs5AxBX4sHgsEljn+Q2IDvPiWRx80+jg6cOB1Kt NcTyd/umITnKNPxh1iR0FpYOuFRfGh3gAnIaYQH7jlsOMGPbXOwRhvqUYhIXTjXS6pqAYu E1X7gZHmCWX/xk1adees8uI47VqjwaA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=v5tYhFD1j+yv3Iu8PpEhj2ETO0QbZsDAEopsQ/A9bAk=; b=DsxNna+mqd14Y1R+bYWGnLXAQZ KD6LPHyGeHF0KI/3kpZdMUU/dhkMhaL8WEah3c3V+49Ysvqs6Bu1vdm9Vpq/S7pzTkPI7eJtMEYxU uBoRjKpFcj6CN3GQQtP1DGIdK3sIxGUq5tAbQdEdFNW6f1UST3AvhDLuU1qvMN21EAerKLDVmvRmF Bz18Agad3kUCnPAoloNaQzMvUnGOBL6wdnqo4xVUjT0N58jBE6K3YMI7r0d/dCaUiT95wlFWeD+R/ 7Mj3cTV1CtHQkWAw/n5cxdS/2TVEKUTcA+WwGRREV4fUaL5WvVYXbK9HuC1rY3t6P+y7zHGbMhwx9 5BjmFRZw==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uRxgn-00000004Z0Q-0yr0; Wed, 18 Jun 2025 18:39:13 +0000 Date: Wed, 18 Jun 2025 19:39:13 +0100 From: Matthew Wilcox To: Zi Yan Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: Re: [PATCH RFC 07/29] mm/migrate: rename isolate_movable_page() to isolate_movable_ops_page() Message-ID: References: <20250618174014.1168640-1-david@redhat.com> <20250618174014.1168640-8-david@redhat.com> <9F76592E-BB0E-4136-BDBA-195CC6FF3B03@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9F76592E-BB0E-4136-BDBA-195CC6FF3B03@nvidia.com> X-Rspam-User: X-Rspamd-Queue-Id: C539918000E X-Rspamd-Server: rspam10 X-Stat-Signature: h5mu6te6a59rbx1h8e936g54gh6ewzox X-HE-Tag: 1750271964-802460 X-HE-Meta: U2FsdGVkX1+JeLMXfhQ44TD7m3/0UtFT7tUQm2L3e09Lzbop2c3FRvCFT64CIRuqDoWpd0MXzqpyxBu6AmW7NJ9vJHt9tXdhIQmaLnk8kddnEaOb4eJ81RwoCL8aFNMyAp+d9y8Zvyc7hZVPdIEjYfLulGkgvhJBaiDBePnm6f+3/L2Tr0TJ6f60IwDRsp8kEjh88wsvS38QErEVzdbMVeEi3MD0DS+MATT4H4N+GcJ8VA6Vw+IH/aroaeFm/jzZPdySOscv7CcxdL/baDihm1FnIfd32tFwIuFNz+dYYZedcYU1aI8iRAq0hZxzsibUeUgw01X9c8hhFysxXYOAoGbzhTx0+pNd4ZddVAq78YpYqdHSSPTJmm/XDAxm8tEnufLHTOvPEl9+RGj+Hc5Ufsn0e3938Kd8cP4Hv2tSrxZF847aBlVsN0o0/33mqIwe117OOkps5otpyNcVZSDNWPgFVKVGugDsR/beLALi3tIuDzolKNfnuFB23QGDGHLtg6/6XndidAdfqzqi3o5Kdz6FGXYp5f15ACmRlQyavb4wRXz7YDTlSa6ydncCUA7dO02wOBo5jdBTev9cvpo7ma45DoklamuKoVXbrNwF0cCKULP5aI91zFa9H9oCoOECy9jVAzV/+fjQV+87/W/0rfDoDRcJHHmjJyQUDYHUoL+M4KhZmLVA8eX1xgXfETXTWd2rJDZrMnkckOoVEGj9Plbfi8tU4syDI5nJ64nMKdbVJM55rrKEcxI765ZNS/dwIJ91km/gKM3gCffpIQxEmDHVWbLohMPrkcwGseO/A6oT8+21x290UgnkYx+rnVdukemmVYvHxlrMfujnzMV5q0l9Z6OvIUEOEzbYsMIBIKo+8/dua1IWBXpBxxS2EHbz/Oa1WhSd5LrsWzHLI4EemRDWmC1gDkDfIsGYK9cn0N0Ek5DaaDy//Z11jA7Rhx5kYW1/QeUu5qzuFDQhl0g WtVKRgY7 Pf4x1oE/Lj7bIk9B5j+wH8pWqCSIWEJ/jyKIuuPG6hrWUCn0IfOrk//yHc9J2XjL+uB/xf6F6u98qs6I7AzR8OTD7Bn51ViB7yYUjttCje0SxRLXQJtuQbaJBj6aQA6ukwqkmBnDvFRMtA81c8I9gXHC1so2LZ/pOx1j5SpCrtFSrl8R7oNv/rAvVN+93cc0WRdW4YA7fP5BBWBCejkjeSxWhoF1rhiQXZGlqJdb+nug7nIkw0FNT0QSkc00aUx7VD+AD6Fu2HmLuo1jHoyQVVOrOFEQWF30RElfhuU2wRSyx4TL+mupl7jeKcP0agNUZZCkBaH5mlXbBFfR8jhCao0q2uhzhWmmsinSK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 18, 2025 at 02:14:15PM -0400, Zi Yan wrote: > On 18 Jun 2025, at 13:39, David Hildenbrand wrote: > > > ... and start moving back to per-page things that will absolutely not be > > folio things in the future. Add documentation and a comment that the > > remaining folio stuff (lock, refcount) will have to be reworked as well. > > > > While at it, convert the VM_BUG_ON() into a WARN_ON_ONCE() and handle > > it gracefully (relevant with further changes), and convert a > > WARN_ON_ONCE() into a VM_WARN_ON_ONCE_PAGE(). > > The reason is that there is no upstream code, which use movable_ops for > folios? Is there any fundamental reason preventing movable_ops from > being used on folios? folios either belong to a filesystem or they are anonymous memory, and so either the filesystem knows how to migrate them (through its a_ops) or the migration code knows how to handle anon folios directly.