From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE85AC71157 for ; Wed, 18 Jun 2025 19:18:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 582D06B00CE; Wed, 18 Jun 2025 15:18:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5332C6B00CF; Wed, 18 Jun 2025 15:18:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FBD86B00D0; Wed, 18 Jun 2025 15:18:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2F70E6B00CE for ; Wed, 18 Jun 2025 15:18:19 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id AA5BD5C730 for ; Wed, 18 Jun 2025 19:18:18 +0000 (UTC) X-FDA: 83569482276.15.771711D Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id C9B8EC0008 for ; Wed, 18 Jun 2025 19:18:16 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="uxWTjN/+"; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750274297; a=rsa-sha256; cv=none; b=D7VbLLhrBriRX0Ib7OBTnhdhww9vxIYyB1RAhyjGgmRfJ/4sq/FhmKLQkFyLV5Uv95IQZ2 4ShzlK9E789i8MeKwZUB0x3PvTvVUAreWs6KQ1cbcIXPNyXolvDZ6zUwY9Y42WWjo0ueJe /5THx/p9lV/yOEHCHzmltL4YC5pmac8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="uxWTjN/+"; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750274297; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8hntqsSm7ttpU2p3v9XMZdIXXcuDbNK0+BZVau+dW3k=; b=lY95KWn33IMjLR58IO+ekqyRxJ6In+RF42Z7mka62PWf0x72uUJjoewnfGmywr7i8/9676 B4sSfQIea2qxShB3ZzWLk3CwsHYw4dmxlfCA7pdHCwmvKkFvZZXOipM/h+ee+KsIB8g8nb fpi/U6WASQ+axss40STsW6q1kIwuHfc= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8hntqsSm7ttpU2p3v9XMZdIXXcuDbNK0+BZVau+dW3k=; b=uxWTjN/+ZWc+mTjBMRrp/oTsXW rnH540ClGs1DNrTnrTu8s8zdw72fa8ksy2E3fwirF0Tkn52OUhXgWXhaCsyhvWsUVTX55kVNy8YQj MCSW9Rl6c+qNx/WyXrJZCN7CWw+S26o6oF0PH+Xpc42Km6pTCtbsPIhLeO7f2toarX3K6oeojX+HP Wyn/eU55xKr3xiE3iMbBU8LkO4HEak7HXqbLdGOfXrtXYkL/c43HdgXdRHekTOG9H+ihWaRphVSnA H53jr1wk84BYDLQEZRUKbRv6gsckr3u0EDiswDQv3XKSdVhnREeXbczHdYwBqXH6OZgi16c/dTDqd c+X5pPGw==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uRyIO-00000004eRU-0SVD; Wed, 18 Jun 2025 19:18:04 +0000 Date: Wed, 18 Jun 2025 20:18:03 +0100 From: Matthew Wilcox To: Zi Yan Cc: David Hildenbrand , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt Subject: Re: [PATCH RFC 08/29] mm/migrate: rename putback_movable_folio() to putback_movable_ops_page() Message-ID: References: <20250618174014.1168640-1-david@redhat.com> <20250618174014.1168640-9-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C9B8EC0008 X-Stat-Signature: fezjawcexx1sh6sbrd33g8kfwqfyuua7 X-Rspam-User: X-HE-Tag: 1750274296-509414 X-HE-Meta: U2FsdGVkX19vR0wXOy2Y9IX+RkRgvE1UfE+yFjyhWRYORuGnzYcLTWvQvmSYl5ZFFBGfE/VzAmmCqj5FmLklwp5dZPh2PkYC4BW/2nk/Lsxco1D/h7CfaiuotD4VnrjRD880BHSXSRRQY6qJuwUqkD+91iUbjI9vNys/3a+SrlS6GlmhqunnVEGxWGTVzReAqJDW8A1yb1T+NKBLqRUGEg8ElTUqecVB9AyuzY6bzBU2OHuHXN+OR534astCmDb1nC0Hfc26wp7fkuY0U8ugdLYa3/ewExlxPWtQhzFxT9loilyDfkpVC4PZso77oWo9a5wAD3rTEQRpI/E3/f73ZefIAtHTr7gVfadORzeo2Y8zQ3WPd7gaeyWAEHJaF8hBMIAgDermmyDiNyFgTUx14jRHZ3BAASSCdLc9z2AkzvWS5AubxrIGRa+fUnDWCaaEsKMuaZUVc596gWhIhxPs8Hd511vH2sECad/2Cf9PIeb7wu6pPmq68bvKyz/txXhGKCKBUthh+JBnl5+p4XFYRiXNSNzcrVNdQk8nWE/IRR/o1pMMQIuOsdi9x4qcznQ10rVCkcj0vPFDKDuyhy8evEKWLG8XqEoixwMlnZf8H0fzxsC0UOM0ItSeGIMO4dURo0+kYgtinLVKq+7zRRsNlQZIDARFjFWWGVguGTexUp4N+yoy+pXzqFd4LWHFci3r+aN9guU00bM7pM98dWGk3tDIegpMp82l/ybhGTSHCKdq2uQ0wvluuRRt/iflS3Da+6ifYD3HgvscVgyJBCvVKhRBSkDbfw9NRsexU/Q/vG/gpdbzyOiRzrNMz+jTu9ERGAyzlJZ5iPjnPoBX67yMRW52uB1/hCXmG9913OaZwpzTNrK7TLjb95SwtH7zjbIa7+wklh7fsx1rB6MZKUXBgMsCMr9lqQ4lpL0jIa2qTBEYNGp0YDXj1AjLD/+/iYqUtXKnQaPbhDtu/R0oVIB okfBC2xI YPrW3w5tYGuSz/KWKnpmPcOdRkYXtQxtU9YxSvPR4ZyQNBLTu+sUfU+oALLoRbfZi+M7Paiz5N3tklf8xmMJI5VUqPbodjOgPpe/NaJSfuxxKsNQgvo/9qSKsbW7YHvcrq+uYFbq5bk5uCZprylpNtTnJNMMnsLSd3cjNX9/M8di9QnUt4605TpQcEIirNwy+B85r7ZYd3TRE19ZYFobJRgGrA38EcVKd8NKpUFGTL8sa7/doLhxKNsa/4lOYpUqL+PlODFyYWBVAfQJr2626jG+MAyNcbIlZenslrNVMON6dm+j2bsav9nzixQfda2PSUPBuJLY+eDqLJvgvqHK9IobUrfcyQEtAMIli X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 18, 2025 at 03:10:10PM -0400, Zi Yan wrote: > On 18 Jun 2025, at 13:39, David Hildenbrand wrote: > > + /* > > + * TODO: these pages will not be folios in the future. All > > + * folio dependencies will have to be removed. > > + */ > > + struct folio *folio = page_folio(page); > > + > > + VM_WARN_ON_ONCE_PAGE(!PageIsolated(page), page); > > + folio_lock(folio); > > + /* If the page was released by it's owner, there is nothing to do. */ > > + if (PageMovable(page)) > > + page_movable_ops(page)->putback_page(page); > > + ClearPageIsolated(page); > > + folio_unlock(folio); > > + folio_put(folio); > > Why not use page version of lock, unlock, and put? Especially you are > thinking about not using folio for these pages. Just a question, > I am OK with current patch. That would reintroduce unnecessary calls to compound_head().