From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76679C7115A for ; Thu, 19 Jun 2025 12:00:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09BAB6B00A2; Thu, 19 Jun 2025 08:00:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 04C786B00A3; Thu, 19 Jun 2025 08:00:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E7D686B00A4; Thu, 19 Jun 2025 08:00:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D48636B00A2 for ; Thu, 19 Jun 2025 08:00:14 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 5BE221D6A8C for ; Thu, 19 Jun 2025 12:00:14 +0000 (UTC) X-FDA: 83572007148.20.E06FF68 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by imf16.hostedemail.com (Postfix) with ESMTP id 81F0018000E for ; Thu, 19 Jun 2025 12:00:11 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=h0xOxZo5; spf=none (imf16.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 198.175.65.10) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750334412; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CtnJ1v2qz+ky6ba2mO9uS0LKK0du9OGDnl/7ROMvuN0=; b=Ogc3/kf/iVLQ7+LSYqWo02shsU/qVVlvGfNghQZnmwblSEbVdrTnDR42f+/vusexQdXvzG gMLGh43XE6LyGCEy0sV4i/LfoOJjGbrwh7+n8zmMilsgr7MeIs1tQZLgLOnSnZiO2iPbQL hnfwRn0SEkKH7ojsAGgDTg3/2I8hXF0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=h0xOxZo5; spf=none (imf16.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 198.175.65.10) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750334412; a=rsa-sha256; cv=none; b=Xo5yrmjbA9tr72CGdPY9v5iT6pMmhYnMAPi5fYj1k4NxwCbj7IKjWJLE0jOh3dzQBXIzMZ /aWDKOH44BTTosNdXpNJ7m4mqhW0lyfsXMNQusBkZYxE+jBOIAuelZg+OLHxhqeNv83IwX W8zsHSpFVHaNrf9i0JY8e65bxjLh8Nk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750334412; x=1781870412; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=shAGsPRVCD9WLCfkB8/hfTQiugyQs3/hQXd6YMMUOBs=; b=h0xOxZo5ZpAp9PH/KPuJN0KhJBtXOIFJ0iPWQyog043cL7EOvUTVWj/Y 4WsGowMXA2AWR2j8oA1r9gTEhZ15I5BV6/8AKhHsvwnUjRveA+asQeGvb l2EGRhulEKXTAvxflaCjz0k6c/JaHQEM/Hjhk2V5eAFTS+NRWuiYcU8FT v8hlktwSmKsb4agW8Jivm3c1EZVUB59UB/vvUrYoCyw8RA6Is5jbXV4/A s2fqIPxZpHM4mYf0FkWe2D7/AzIx6pAstT3Wb2l86xyegkzF9zvl/U8gF 9guVmeMJdk6BnbuLJ7p7Gk4SNS48ze/3sh2Ce0EWI0ZX2gRUNb4ni6jbM g==; X-CSE-ConnectionGUID: ZI84IWLmSDykah5nvRJQGg== X-CSE-MsgGUID: HRRDGqSGSqWdFz6OLk3ytg== X-IronPort-AV: E=McAfee;i="6800,10657,11468"; a="70022708" X-IronPort-AV: E=Sophos;i="6.16,248,1744095600"; d="scan'208";a="70022708" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jun 2025 05:00:10 -0700 X-CSE-ConnectionGUID: xPDoivaZQwqnfGAstWAu6g== X-CSE-MsgGUID: d6i6qvTBTe2v473jPcCmuw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,248,1744095600"; d="scan'208";a="174245909" Received: from black.fi.intel.com ([10.237.72.28]) by fmviesa002.fm.intel.com with ESMTP; 19 Jun 2025 05:00:04 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 35F06F0; Thu, 19 Jun 2025 15:00:03 +0300 (EEST) Date: Thu, 19 Jun 2025 15:00:03 +0300 From: Andy Shevchenko To: Anshuman Khandual Cc: linux-mm@kvack.org, Rasmus Villemoes , Sergey Senozhatsky , Petr Mladek , Steven Rostedt , Jonathan Corbet , Andrew Morton , David Hildenbrand , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [RFC 1/2] lib/vsprintf: Add support for pte_t Message-ID: References: <20250618041235.1716143-1-anshuman.khandual@arm.com> <20250618041235.1716143-2-anshuman.khandual@arm.com> <0d437b3e-37b5-4e98-90bc-afa6c8150e77@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0d437b3e-37b5-4e98-90bc-afa6c8150e77@arm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspam-User: X-Rspamd-Queue-Id: 81F0018000E X-Rspamd-Server: rspam01 X-Stat-Signature: 77zcg6yhs56oi7bb84pn7tujtsuqmze7 X-HE-Tag: 1750334411-84643 X-HE-Meta: U2FsdGVkX18Qo2O254isaX885kPYB6xCYYhZFIy3PLD8eSyfwzGl4w5piPQz+jy/R0wcII/kEFxz5D2CgCf02NjHhn3z3JBAd0OPXSccIE+p8PJUKebvBZXT3NTLKneVCTQJZHyuJDhQlzBBy0kWOQaBQE/CU3AAZvcOM6O/E91tMbr+3j3hwG41fNryfdNzCL93kyVzUyo31QX4TGGYlF7QAZE05tS8+YN8a2L53C+3qNP35+nOqc6mY/+63Q/Ds6upZk2iAjFbl2U2AIOIIZWY91/B9ULJbytrX40tTGfb/Z86/gxQzd19ATEpVtfDxGcAM/10iy0FcJ8lG1clq+fwwdivWwLvbWh6ySCxBfEmXOkSbDCGSFjaHomo/4eSV/hJVoByzKd1opyfmu2+7A/kNd0/H6E/iKpPbYEX/MpmTzTyMaMSA/V20FWwanD+ZSV77qmHUr0scJYvvAVUEYXZDklk0OG0LoPww9n6cXzqueQf4ECNX1F+PxrIQwe6TCPUiFLizcMhyF3ymSI79y9SLrFYrlY7GLPn1mSoTXkDXOoWJDHBbLMZETdv8dZ4ETh313RypQPVFefI/wm7KeTs0KC51dbBN0F/oJSBfhUCvmA+DSvsWuYAosEBBBGgPG76pYqNWDJlDQSsWb9DwCtXTKIA/hhbcu0O1XhAL6u7pcIparG+e0hIMx1CBVOhNjQKp1ADX0IMhMU2VAwH0p+veZjMnIPPl6tMuUwyG83kGErHGoHTc786SN/g/xYiXGpJ60VANt1xpntVaIrOenI8eW2vlRZDUat1Rd2NHSJ5Esx3jK7M4siEUItZZ3ECOybaRsOAOFlR1SSZp62Z6J0RwWQ1EdiN5yPDlfKRNFUM7Ft/aSmlNHg3Kc3VxQE/1m1Y3SddzZlSm2pb/nQ2Qol/R/qdDZEX1dCZ1WRBLS422F2J36JyaIVVe1rNlHR5PAYaDjpgWHX/V5Kw/LV eR04kIrS 8ogSFVH4i/Ts5dnp2hK3lbPVuNlIoqD5FbcAU7+PTqArBdAEYLdkNSnovqdxx+qftqVpjQMdHNGFQyYCC55Gsy0Xx+PzfL5K3yTU04qr/FT2CYFnPpLDaV/U5viOmI/SLIoX525cUWU45qNnm5unzMmm/WAH3hsCY+kCZCzoaojb8lwL9GGeGY/NTM9NJCep1URHzf2I0rXCNUhyjnq8sGY065Z8+XIXNFkLyQO6kpR+IGb5FetCgU6OvhMDvpa/E8NrRvUm+QK2iCLcayjdEeLecyX5ZRhEZTqZptqcPRPZ35z7HZg7Ja5GiC1e3CbkWqFuRs4x7w2yQqRze2Rp4PbC65Bn9eq8QAHqC1drhblNbM2VVdC+FTVSu1FIowSOIBcD75u2RWibNwD8aMZUCp9GCKFmsm3pk5e4C+OO6PFh0sPDkH9iPAxi8wr42IYwmw6OOpf4tIt033eNyyDQYByF86bQYIF7EZkynz7VU8uAgIm4hd2qdHKgJURhC3ttd7g2oawIxu0D49SNTtB1TpRV43+dEs8hD3MJWi/ZyHyxKTRiDj5v7X+nY9QzdSaT4HxnkYqJNrWTkn24a2kmeWLvM62PE21n9vVR1XrPmpMJvIzi0/C7baCs59Gz4/MZO4B7EbOl004R4sEJIBhCF+5Pxar3HmXNRaqyXSQuP++iKxaU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 19, 2025 at 03:05:10PM +0530, Anshuman Khandual wrote: > On 18/06/25 11:16 PM, Andy Shevchenko wrote: > > On Wed, Jun 18, 2025 at 09:42:34AM +0530, Anshuman Khandual wrote: > >> Add a new format for printing page table entries. > > > >> Cc: Petr Mladek > >> Cc: Steven Rostedt > >> Cc: Jonathan Corbet > >> Cc: Andrew Morton > >> Cc: David Hildenbrand > >> Cc: linux-doc@vger.kernel.org > >> Cc: linux-kernel@vger.kernel.org > >> Cc: linux-mm@kvack.org > > > > Please. move these to be after the '---' cutter line below. Just leave SoB tag > > alone. This will have the same effect w/o polluting commit message. > > > >> Signed-off-by: Anshuman Khandual > >> --- > > > > (somewhere here is a good place for all your Cc: tags) > > Is not it better to also capture the Cc: list in the commit message. No it's worse. One may easily get the same from lore. Can you give a good justification for the polluting message with 8 lines over a single line of the useful information, please? > Seems like such has been the practice for various patches on the MM > list. But not sure if that is an expected standard for all patches. It's not an MM subsystem. ... > >> +Print standard page table entry pte_t. > >> + > >> +Passed by reference. > >> + > >> +Examples for a 64 bit page table entry, given &(u64)0xc0ffee:: > > > > What does this mean? > > 64 bit address containing value the 0xc0ffee Please, make it 64-bit address. The example as is is quite confusing. > >> + %ppte 0x00c0ffee > > > > Can it be ever 64-bit? > I am sorry - did not get that. pte_t contained value can be 64 > bits if that's what you meant. Yes, see above why I have such a question. ... > >> + spec.field_width = 10; > >> + spec.precision = 8; > >> + spec.base = 16; > >> + spec.flags = SPECIAL | SMALL | ZEROPAD; > > > > Do not duplicate code we have already in the file. > I am sorry - did not get that. Is the above flag combination some > how wrong ? It's dup. Please, take your time to find the very similar piece of code in one of the helper functions we have. I recommend you to look at the history of the changes in this file for when the new specifier was added and how it is implemented. ... > Could you please kindly elaborate on the code duplication problem > you have mentioned earlier. I might not understand your concern > here correctly. Just find the same or similar pieces of code elsewhere in the same file. Use them. -- With Best Regards, Andy Shevchenko