From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5959FC7115A for ; Thu, 19 Jun 2025 16:03:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACA946B0088; Thu, 19 Jun 2025 12:03:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AA29C6B0089; Thu, 19 Jun 2025 12:03:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9E1416B008A; Thu, 19 Jun 2025 12:03:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 935E56B0088 for ; Thu, 19 Jun 2025 12:03:44 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BC8EB1D458B for ; Thu, 19 Jun 2025 16:03:43 +0000 (UTC) X-FDA: 83572620726.18.765D6FD Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf05.hostedemail.com (Postfix) with ESMTP id C7A5F100009 for ; Thu, 19 Jun 2025 16:03:40 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZBIPyIW7; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750349022; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OqgTG9bdN8KsCUPIOjEKZnMRxiOerNNgtMPhKjugJzU=; b=lafsv6ftxgKxtjMdlvNeX8pM9JqaJRY100XBn2sgfwuI8oDMblitswzOZihsJTShWx7kxq +MwvsfbGW5Lv9jcxmClYmuQ+A302fwrAIMCalYcsE+pVbVui5Bl04IxELFdR/yRvnAtGy4 8qoOKaCMwnQ025UKls3SB9ebtHmqUq8= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ZBIPyIW7; spf=none (imf05.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750349022; a=rsa-sha256; cv=none; b=NWVKv6U8twvtmwMHADp+Al1HUj8TL4arDKB7KCaUN0GscLW8YYC/NmUuYYoVQodQr32fd9 5RB/kF3yRb6n88pVnXrGRQeKugplOEmK4tJwYWA1oqFgo7i26PiMee5aPF5ynzEWsjTKKQ gD475oWqWL1MFb11TRfAA7KwJDRMecY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OqgTG9bdN8KsCUPIOjEKZnMRxiOerNNgtMPhKjugJzU=; b=ZBIPyIW7OHWA7HpZ/jDa0ZXFT/ e75q0jndhVd3ufFi+j6zVf/lV+bTF3M4lyTQhNhMa+BME9MosUJgrG1L8nNV2OJwUfRNPrVqyUwcC wkvOttZUwiJK7P9yFr2v5+Tqz8nzfpGaZgXgG/qOdExAiSBlFpqE8ydY/GzgM+Xcpogwfs1n01mLu LynfUH+cgn8CcH8WzgE2iUNmpQ047OLl4fQGADPyEpRoPwuQSznI+D9C1+dwIXPNtSmaptwVw7bO/ AZGKqXE2RLW3Ha/1MZWF9FcHxQGSQSQxqmjQRPTVOLQ0+J5mApbCQximHGy6sAuSMmpkXkzNUeTaa jI1NEVKA==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uSHjM-00000009Mqg-03kb; Thu, 19 Jun 2025 16:03:12 +0000 Date: Thu, 19 Jun 2025 17:03:11 +0100 From: Matthew Wilcox To: Shivank Garg Cc: seanjc@google.com, david@redhat.com, vbabka@suse.cz, akpm@linux-foundation.org, shuah@kernel.org, pbonzini@redhat.com, brauner@kernel.org, viro@zeniv.linux.org.uk, ackerleytng@google.com, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, pvorel@suse.cz, bfoster@redhat.com, tabba@google.com, vannapurve@google.com, chao.gao@intel.com, bharata@amd.com, nikunj@amd.com, michael.day@amd.com, yan.y.zhao@intel.com, Neeraj.Upadhyay@amd.com, thomas.lendacky@amd.com, michael.roth@amd.com, aik@amd.com, jgg@nvidia.com, kalyazin@amazon.com, peterx@redhat.com, jack@suse.cz, rppt@kernel.org, hch@infradead.org, cgzones@googlemail.com, ira.weiny@intel.com, rientjes@google.com, roypat@amazon.co.uk, ziy@nvidia.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, kent.overstreet@linux.dev, ying.huang@linux.alibaba.com, apopple@nvidia.com, chao.p.peng@intel.com, amit@infradead.org, ddutile@redhat.com, dan.j.williams@intel.com, ashish.kalra@amd.com, gshan@redhat.com, jgowans@amazon.com, pankaj.gupta@amd.com, papaluri@amd.com, yuzhao@google.com, suzuki.poulose@arm.com, quic_eberman@quicinc.com, aneeshkumar.kizhakeveetil@arm.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-coco@lists.linux.dev Subject: Re: [RFC PATCH v8 3/7] mm/filemap: Add mempolicy support to the filemap layer Message-ID: References: <20250618112935.7629-1-shivankg@amd.com> <20250618112935.7629-4-shivankg@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250618112935.7629-4-shivankg@amd.com> X-Rspamd-Queue-Id: C7A5F100009 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: j5wknashm55q9a8jbk1mcm7qa6hk58cw X-HE-Tag: 1750349020-68025 X-HE-Meta: U2FsdGVkX18Cfdm7lnBCu/xqpESLcaHti6JBkQoWioIvQdnQT9GEbOD67mUyzsf2zUO8gqCLuVe/pNXRa6zotPv9KNDygbZnSmKcITE5EeJENNKtDnHjU2tWHEvOuBLZduw7ge2Qsc1sHU2tWMQNb5uqmEPwiftSp0b29nUT8+Pb3/GJ8wcKlSAken0EjXVZN7AzyPDTGRo9Vw0MhmBB1Q8P2UXi4rO8/EDhKw9isD4Vyc2YVWvvGiRVnwQOTFjSrsf/0tnQ6a0pywuuafluQj4fSgXr5Io+Sl1pt7OZMxncNHILKdez1ceoWk2V48N6gY8Mb3IditbYjJOJEyviMfKqzlfyT4ZDJuWyL/c7bh92bdCVGK57WqIYxJ4drBL9GxQPKAiOAv6NfFT79X++qtV2Gr7BmHRmGhUPacy3mGSzQRnz35xx1nIs+KzBu/I+RZVKW83vLS3awNO10D2Flv65IDaPjsEDUcXuQExz4eYnyqv5OdCMUxurhZWfXTeDx0Sm4dXIaOFpct1A0L2OttMbfquq8iZsO4wt3JV0CFtaxD90/yiNF7H31h/NgcaKP1h5qBDWb0xM2+rxDB3jPvU5Nt6RkxK0B0EObEVjDIftib6DMj4tOf9NkUC2vpeMcwsIfpeGUcrBzIIXmr/oHTzg/h//J3iRyM1u7wyGqfvpU9d27iZE90w/gBJO9S2JSHZm0iuyRuquZtGMEGtdxhBjDe6pNjRmzxIAlDKOERxKbMMJ4Q1QwCMru4O/XQtqVyrUTJEf87ZEJDLISz5lSaf2o+Lkccp9Nm+oV7a9PMjSREzI5YOBg8tciE9LOr8vigPlG6yy4vLGy52SC5NPDthRnlvC0qeYIhJcc5Tb2WlPg+WrqFne8/k4M6PiB9eIlRjv5wmZtjzZO4ojIdSkdtaWhsRtIdWD4djjze/NHOM5IwOy8JVq5d0ODx4jdsPfb4RbkIiEBfWqT3ekmmm fB7y/ThG 1E2v/cG0atqNN3bKLaA61V5cCkLpufXSy1nkZ6mH1CA3dLJ5+OPOLiNua1ggwys6Mhgu7DP9aZ9UFT/+Xd05irU2FlK6AwJnt44ARZn1D0e1fUcqF5uAJo1xlWvtUk+cIt3+1s4uxA4GcZ6v2MayUusCjk/bDVwtkX+b4ZiJ5pWaxrFf4ZKvm6PMYGRa0ABohO5KnMRsMC0L3BMhpxZAfzE9nxqxgBzD+fotG5mjROcdwiOAYUR2DHhyD6jL97LQ9Vpv4cVxREoAsrGbNrmce7Yq4FaER7IX4MD2CEslepBbhGGpNWnOomwVQQsPcnk4eblA3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 18, 2025 at 11:29:31AM +0000, Shivank Garg wrote: > From: Shivansh Dhiman > > Add NUMA mempolicy support to the filemap allocation path by introducing > new APIs that take a mempolicy argument: > - filemap_grab_folio_mpol() > - filemap_alloc_folio_mpol() > - __filemap_get_folio_mpol() You don't use these APIs in this series, so I can't evaludate whether any of my suggestiosn for improving this patch would actually work. NACK. Introduce the APIs *with a user*. Come on, this isn't a new requirement.