From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9904AC7115B for ; Thu, 19 Jun 2025 13:08:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A3186B007B; Thu, 19 Jun 2025 09:08:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 27B056B0088; Thu, 19 Jun 2025 09:08:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 190EF6B0089; Thu, 19 Jun 2025 09:08:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 090A66B007B for ; Thu, 19 Jun 2025 09:08:26 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B3B4E5EB42 for ; Thu, 19 Jun 2025 13:08:25 +0000 (UTC) X-FDA: 83572178970.02.A1A4B68 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by imf16.hostedemail.com (Postfix) with ESMTP id 92DF018000B for ; Thu, 19 Jun 2025 13:08:23 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=JHOTWzR3; spf=pass (imf16.hostedemail.com: domain of pmladek@suse.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=pmladek@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750338503; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qdHw6p7z6zmQz0C4ujdVdisan2PpMVfsoufPTvfXsp0=; b=nUDgXYS9qj9kYxOEAMrObrw4QTDVYwoj4gF8i02Onoe4NctHRK1aImi4XPXu3C6JYlvjXk JP+5H3IHjDur7WzXBCkCKjKIjQ6sy0/pQO/DdGv+sgC2kk1aktpF+yRcc+qpQmogdJjlYA Cf+dGIbMaBFyrFrrZwgToQ/rx+BvWqw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750338503; a=rsa-sha256; cv=none; b=rL1E4pTbpDpMCM2wTS5PYEcQTjXRcMm3lSLMKlx6v3/CFu19ZQdx7z19bNiXyHlKLKPBub PYhKfk/B/linOcoP+mh/1JS5TM6Md3jQvYBqB8NjDzVINHZ+hBNNzlebxQU8MRN9vD2QlE lj7Q+uKNhz1iDjLayXHPQVP2bqaOrAs= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=JHOTWzR3; spf=pass (imf16.hostedemail.com: domain of pmladek@suse.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=pmladek@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-3a54836cb7fso471375f8f.2 for ; Thu, 19 Jun 2025 06:08:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1750338502; x=1750943302; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=qdHw6p7z6zmQz0C4ujdVdisan2PpMVfsoufPTvfXsp0=; b=JHOTWzR34jLlYrAxquy6HCsinC/Sh2IK6E64JaCwowMCoV11x82gwqeNe2q6aOMGW9 5Jjfuto0K+gREtdughWzMLx+PNE+uMrccoE0aRBy0z7BSMHnovJIL2e9+bwiQJ6LzF7E v4k5KKwTDCi/QqylXjucuvTXBXr68e8SqrW7AKNLhK1MvtFgA3w4sLr3XPChvnjwAU4p 3ie7fSJhEpihojZr+4MXDv1QO/AbO1OVJwaAkP++izPEA32YP7PDVZ5Slib06tGT10Xq d5mwPmBm4MGfa2E6fpbh9ThO0eZNvF4uTrmn+I6JX/fghmXWcbalhydlyFJ6CspCV5Ft 16Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750338502; x=1750943302; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qdHw6p7z6zmQz0C4ujdVdisan2PpMVfsoufPTvfXsp0=; b=MocZ5fj0tETieiyloGr8NKwTFY9lwvOXDCI+aH4lGkZX0hZTEsrKtn1rw6Pi6tW2gb pNZH0AcQYhqv35IA3I9SL77MTl5rbIW75nk9xreAvM1/9Ty3yn+3oDuU6sfLdEWwcXj0 QnlWwYJeTt4U8yoogbYoPyV5ueuWg/TFM67GBhWFZpigKrJIZoliMVGu2xLCTJl/l9QV HqagzJFQ/ffnxlCGIDkJgxxQbpSj1L0GjLcYUVZdR2Ye7YE7umFtiPEYIokRbj88qn3A flrFbG1FO3XuvungTK/PyrVDwUSxDnjYc3ms3tAgAyZE1+dpKxQatGe3IbdJd1vJkaDq V7BA== X-Forwarded-Encrypted: i=1; AJvYcCU6YnkN1a3J0GxdLcwnHR9tBSv0mQ2fYqzyJay9GSqU+HBuLsFG0hnHEFvV+zXfOiHiSsQpoXe/pQ==@kvack.org X-Gm-Message-State: AOJu0YwEF67ArWiOLwYTkDprUB9sGStdGxC9y9Fr6TO7lR8K409BZCiO erBErpSDrXUX0mCOSbOl1wvoITGFwGKGF6OFhhbthKU+O0954ntFxUUTOCg+s+bclaU= X-Gm-Gg: ASbGncuXlOtmLRePhVIWZbLM/aiK+p2Ub80KBpvZlUSNIzMZaQgfrY4ehkUPoPodfqy uve9snoHSuxr+spV0T9FPpUVvzaPmklr2EVl+Whgh0M1qmrt7R/Hbq/mJiG5ura+MOxH8uV8oS+ n1Z2c8oRwDhWSn83+lZwt2W8d4frn2XQtsgp1UCGO4RJU3EkFzV3hMXgUXurIQxofyjCqdIL2FS ugL383uaOlGf/tzNuDGGvhllyKeUlgmac/lBLZauY1V5MDnpdU/ThlSaNEWwXKKe1x6YD/+h2G6 v5aYZxVWC71o1ZzsZwUFaM3K5hjbEoLeBthjPtHZc0yPEVb4Q22F3xLIX6OifAf3 X-Google-Smtp-Source: AGHT+IEGQ1yCiIqL8EMmQw2kxNWpjg07NWygAGfH9GX1YhqdFPogOWAcwOYs9H9mCLBw99s/RI+rsg== X-Received: by 2002:a05:6000:2310:b0:3a4:f722:f00b with SMTP id ffacd0b85a97d-3a572367c83mr15931408f8f.11.1750338501821; Thu, 19 Jun 2025 06:08:21 -0700 (PDT) Received: from pathway.suse.cz ([176.114.240.130]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365e0d0b04sm119652365ad.247.2025.06.19.06.08.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Jun 2025 06:08:21 -0700 (PDT) Date: Thu, 19 Jun 2025 15:08:06 +0200 From: Petr Mladek To: Pedro Falcato Cc: David Hildenbrand , Anshuman Khandual , linux-mm@kvack.org, Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky , Steven Rostedt , Jonathan Corbet , Andrew Morton , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [RFC 1/2] lib/vsprintf: Add support for pte_t Message-ID: References: <20250618041235.1716143-1-anshuman.khandual@arm.com> <20250618041235.1716143-2-anshuman.khandual@arm.com> <5d037cb6-91a7-47b7-a902-c3e36f2adefb@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Server: rspam03 X-Stat-Signature: 19w4anucinjds1b5pufajqzesto4qyh3 X-Rspam-User: X-Rspamd-Queue-Id: 92DF018000B X-HE-Tag: 1750338503-379968 X-HE-Meta: U2FsdGVkX1+PITNAESCygvyUnRuT5rRNxhQz3ioPdz56Zzpw7HarPFBbgcujiJnSq8kepkCZbD4jfWlMedzBmRfvW9WzwZTg2P5U00dBF+0FnwCQIP5oDv9sVa+Z6EYkuMI41aXHEJyVVrtzJGklVSGWkmGDHGkKbklefpMTeqcO7IJNebOWwD+vsZWApbG+f5FqKOjVOXq7J/BDcvgUEq3cEh5zaCYo14tSM8e6WKkPW5tI3foro66q3wNsct/MWVVnMLBpy1cwt0+GHYneNH1/iYg3owoTeuZ0wWPoPSTGRWkYNBbyXp+fCaR75sQYwbLZowkisY9xhrwnZaUuMKKIuk23v1ri/PLoW7yBwjTSitO54CNzm9LfalQbMvQEEXWiE52MpGWgOkDdTU7sPgiRb6qFotVNYb3zXpL1lAXpQXV/7B7dQsaV6yrpzy/BLWl26j9olAaIUDCnq3iqNzCITabemMBu/OveVQUNffJlMUggVUzqofNbKI90wd5MwbGfW8nASwqnUOKRzIK+T5FEyWVNyn/KbuG1WXInf2mp8NnbnrId+rLNDGY/gdoYizWC+Dgck/3cUsq4FpGKw6uLSGmvw1ljyOQZQr1DwJzeX4eHnWfBuxc4eUWwOyRP4tzmGoQ5j8zYAnD8uTZZTNleVOFZAj4zVs7IAOM07c5qNyU0mT6eqHcMMPgrJANFUi3SPgogaDM5nIO/yM0cA1kvH7AoUsewNReRixT2MRHaE4YETY+WbwkCEPkGeW1vxHzxTOunsetCCIjTUgciUgkqLE4COEgxxKHajc01Xiaq5fToMO0Egz9sBwkN6DgQHnQ1B56g/aY3QP7/8q9EholXhL6/87LjKqIaczAePZ6zngY4XizJbELnM4Sm4vxBTtARX5xyL/e5TMKR9QxzDZxxtAv4YozTsDhj0NkI0haB97ili+IvL4Ijr6i4PZkIcXr1YReB4RnQJPtn19c hxQoij1f ipHMK13sh49Z7DIZXi/CtJGmpAb9VOJhqjJW0zY19egwQ0J2LYG3wsk59F3bspkYaXuOod6K0iM/mIcpxdX4DnXFsUg5gVIIk2oTvczUikycoby22k+vTuRKgkwFuqfexXBBKvROy2sIpRUDeeplFeP9yoWrMgpWJCFtq/e5+v1WNPF7Xb39cLZOTMpcRAnoVgcbigi6+0kMNMtz/Z+7Z5v0sjxiEUkTWSnif3gBzjQz2pTm+s6T7IcKeTFs4HDtiaOipZojQBK+Ww1JizWhE4R12mFxYbxhBJRX9Aqc7D+G+1FBkzkDeqpIWb/H2TJdi28kBQBzXwUJPM3dq/vUP5L7EwXinE00y5/QHKQnXqHQVmgKhKDzRUH1Q1VtNqMbnz7MPPmzgj4R1yB6OBZe1VPS7iR1cjBXU1Ee84gLmpCwrNTQf7NiZyA49/VOovo4MVkU4dvsQ9tTNEo/2V7EdkNk7Nzb+zYBpcahlyko7/Jjz3FoL64m+7qdE3ZjPe1pR79nOJaG2HF4YWLvg2MWRjXnzW8rtqE26Hmg+0KJMvSiKvaytzPXnfh75yiqxxceMTFuxRxgKNc9jX6aiH4KBerhv4qXtiRIUVdlKjTPN8RouRlkBxKegicM9wVJ5iCOGqm0x3vAGcR0086XU4tEw9A7VDcMUfDQH+vuvUA1ttDbOcB1pknbFWqlQOugLAzjMqSSak3GcE6q9V/5pjrsBVSV+fzdaYylii0X2MJXSQCN37fYsWk1ZuPhqrw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 2025-06-18 19:16:00, Pedro Falcato wrote: > On Wed, Jun 18, 2025 at 10:44:20AM +0200, David Hildenbrand wrote: > > On 18.06.25 10:37, Anshuman Khandual wrote: > > > > > > > > > On 18/06/25 1:48 PM, David Hildenbrand wrote: > > > > On 18.06.25 06:12, Anshuman Khandual wrote: > > > > > Add a new format for printing page table entries. > > > > > > > > > > Cc: Petr Mladek > > > > > Cc: Steven Rostedt > > > > > Cc: Jonathan Corbet > > > > > Cc: Andrew Morton > > > > > Cc: David Hildenbrand > > > > > Cc: linux-doc@vger.kernel.org > > > > > Cc: linux-kernel@vger.kernel.org > > > > > Cc: linux-mm@kvack.org > > > > > Signed-off-by: Anshuman Khandual > > > > > --- > > > > >   Documentation/core-api/printk-formats.rst | 14 ++++++++++++++ > > > > >   lib/vsprintf.c                            | 20 ++++++++++++++++++++ > > > > >   mm/memory.c                               |  5 ++--- > > > > >   scripts/checkpatch.pl                     |  2 +- > > > > >   4 files changed, 37 insertions(+), 4 deletions(-) > > > > > > > > > > diff --git a/Documentation/core-api/printk-formats.rst b/Documentation/core-api/printk-formats.rst > > > > > index 4b7f3646ec6ce..75a110b059ee1 100644 > > > > > --- a/Documentation/core-api/printk-formats.rst > > > > > +++ b/Documentation/core-api/printk-formats.rst > > > > > @@ -689,6 +689,20 @@ Rust > > > > >   Only intended to be used from Rust code to format ``core::fmt::Arguments``. > > > > >   Do *not* use it from C. > > > > >   +Page Table Entry > > > > > +---------------- > > > > > + > > > > > +:: > > > > > +        %ppte > > > > > + > > > > > +Print standard page table entry pte_t. > > > > > + > > > > > +Passed by reference. > > > > > > > > Curious, why the decision to pass by reference? > > > > > > Just to make this via %p<> based address mechanism. But wondering > > > will it be better for the pte to be represented via value instead > > > of reference ? > > > > We commonly pass ptes to functions through value, not reference, that's why > > I am asking. > > > All printf/printk extensions in the kernel follow %p and use > pointers because %p takes pointers, so it lets us use -Wformat with no issues. > > So yes, taking a pte_t * is required. Correct. But the pointer is usually needed because the %pxx format need to access a structure. Passing a pointer is another potential source of errors. I mean that the callers might pass an invalid pointer by mistake... Another aspect is performance. It is likely not a big deal for classic printk() which is a slow path. But trace_printk() tries to optimize the speed by deferred formatting where possible, see vbin_printf() and bstr_printf(). I think that this is not a blocker for this patchset. But you should know that using %pxx has a cost. Best Regards, Petr