From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5CDDC71155 for ; Fri, 20 Jun 2025 14:58:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6161F6B008A; Fri, 20 Jun 2025 10:58:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C7146B008C; Fri, 20 Jun 2025 10:58:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E3F86B0092; Fri, 20 Jun 2025 10:58:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3FF6D6B008A for ; Fri, 20 Jun 2025 10:58:22 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F0E22160D45 for ; Fri, 20 Jun 2025 14:58:21 +0000 (UTC) X-FDA: 83576084802.19.6D8A122 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 391D71C000E for ; Fri, 20 Jun 2025 14:58:19 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JMwRBRP4; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750431500; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K//bAiLbmISqUPyK6Azwtg9feHOVYjryLBsK0/OS8/s=; b=RKa1e4dVzWZx/ClYcTxcDPeKpEfBGq3xGZaN6Wlp4xLi2+sU32DTJBYOm1oJATYPg38zSS Rgz2Sye9q3zDQ67C0oe/c8gXDNHWhe/Cf9SvppgAfXbDkznvomd4Y1p2qelxIVkF18XGR1 x2cPBwqNckXuFllRqyWMcF5iF7pVhzU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=JMwRBRP4; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750431500; a=rsa-sha256; cv=none; b=1aHznnW7xGfmWJQG50AcNVDbzag5BotbURIWr///YdufACnyqQhBKIJooE3xhEM6cP0L4j +Td/iJfqUpKU8RAoHlmppfVpcw5PHvrUc3I8yHl85pEsK20FKMXDPpQ/9WWFXtjEF3HtP6 8Xw/kSBJ5kfFuHxnhRl4H1fHhrlSEm0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=K//bAiLbmISqUPyK6Azwtg9feHOVYjryLBsK0/OS8/s=; b=JMwRBRP40O20cGv8SLd14bVTDB +chNkdSNjwYKbFPbRv4u2goCapsVlp/qSLWfsi9weh5rsF1AYmFZKCPBY2sjOVqVkiHdAWVocBURv UJNxAurcZZoMLgpSoqDFcJChlrnZAmRVjvoCFZtQAeuouKayjav3GLpD9Uawy4Ie/jlsWzZKTbCMw X9/uoKMDRe1o9ZUBAIT3I9/LxKMsW7Y3sAGLQgQ4irAMbJW53GLTllWp6X0XKnKY+7XiTs8/qyrLt j8TqWfrGK7AZz78b6PagqTHC/vQyK4d9s2xiZGtGpfWIXqBQzzdbpmW8PIxNpn34SzcrbvVBqpaw2 Kvsrs7ag==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uSdBr-0000000CrUW-07Kn; Fri, 20 Jun 2025 14:58:03 +0000 Date: Fri, 20 Jun 2025 15:58:02 +0100 From: Matthew Wilcox To: Shivank Garg Cc: seanjc@google.com, david@redhat.com, vbabka@suse.cz, akpm@linux-foundation.org, shuah@kernel.org, pbonzini@redhat.com, brauner@kernel.org, viro@zeniv.linux.org.uk, ackerleytng@google.com, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, pvorel@suse.cz, bfoster@redhat.com, tabba@google.com, vannapurve@google.com, chao.gao@intel.com, bharata@amd.com, nikunj@amd.com, michael.day@amd.com, yan.y.zhao@intel.com, Neeraj.Upadhyay@amd.com, thomas.lendacky@amd.com, michael.roth@amd.com, aik@amd.com, jgg@nvidia.com, kalyazin@amazon.com, peterx@redhat.com, jack@suse.cz, rppt@kernel.org, hch@infradead.org, cgzones@googlemail.com, ira.weiny@intel.com, rientjes@google.com, roypat@amazon.co.uk, ziy@nvidia.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, kent.overstreet@linux.dev, ying.huang@linux.alibaba.com, apopple@nvidia.com, chao.p.peng@intel.com, amit@infradead.org, ddutile@redhat.com, dan.j.williams@intel.com, ashish.kalra@amd.com, gshan@redhat.com, jgowans@amazon.com, pankaj.gupta@amd.com, papaluri@amd.com, yuzhao@google.com, suzuki.poulose@arm.com, quic_eberman@quicinc.com, aneeshkumar.kizhakeveetil@arm.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-coco@lists.linux.dev Subject: Re: [RFC PATCH v8 3/7] mm/filemap: Add mempolicy support to the filemap layer Message-ID: References: <20250618112935.7629-1-shivankg@amd.com> <20250618112935.7629-4-shivankg@amd.com> <2d571f86-67bf-42f5-a20f-6c691ececae9@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2d571f86-67bf-42f5-a20f-6c691ececae9@amd.com> X-Rspamd-Queue-Id: 391D71C000E X-Stat-Signature: 1a3fse69xn1sbx7twuyx3uozgfrhwdck X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1750431499-465971 X-HE-Meta: U2FsdGVkX18r/bq5NKDQ8GbV9p+yEGcbE8ImQBTg/qXnAx8CzWYuQzDlfTV0EFeraJOje65Zq8A+dPbDrVeNz4EzPEIqfaQrml84K1Wzj6R+qSlz18kvONBMhZu1jFCdKRMsd01Ga9Hx2gk/K6FDPhFzghFio4BjmeQkCOCixRIe08Yg8O1T7iY9PJzeapPjAIohyLT67jUHWwRMby7P1xLlwxGXiZk/1NsMrXrBmjcnFYU38QO9OvLKv4BpH2HuYL9+2q+fbXnAq6vVfI6At9y+K/Q1jWaP9JdpFpWomIY/M/OGQKx7Z9MIPvhHOzmyDLh70k7Iowc980rHY60Mi62xAvX+bT8V7tyOdDfTpSbx4kbCC/7JnGWnDrU5NNeunh5v3DogV6WdPXhQLuaUEThDCf1wOC1XYxygQuNTyvKx/mbVnlqE4CqtHwx4x8RHg90/WPif1kyV8fY0aml7eWF80WQ+F81WznydnL21GSae3PRt4g3EaYuU+9Sr2xU0laBxLlwOuY6ZlUhQ9WEdh29IqDfdcfTcPW+Shs4gGg1aQM1qV0GQqnjk+sNkMiqwdlPwlM+1fv9NuqO4iPf06i1BxZg6P3zxyTIHo1XUbl60uC6XKsQ8a8/iGCnf655cCeJPFlu9pseThPIGUnfBvLQDRf13CdqzHBdmTkzmuGifuBJkUZV0LYgtKBACV9aPyXmxCwKBsRkJf5cDVaAABjT5tZbUl2/f6MZcsEC8pE+D1HqY0uOKQld7zn1Fcqg0vO8y2eoXpGkYWZegEWJYeYL8gF4S568d3qUL+6BdHuLk/qXd/RaD7lSJg7vPVyYM0P/rcXuwAFSTJfvyXIHWjmE8GKPKcS+drnZ18Q531tm0yynkc440IekGoWWlkfqnBuS4bZeF2w57IkVzG6yfNuchTMAfXgFe8kNfMCNesnF53ADBByT3rBhQUixmcZXaSogdMHbTd0rPHybd504 wBYQICnA DMYBL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 20, 2025 at 08:22:49PM +0530, Shivank Garg wrote: > > > On 6/20/2025 8:04 PM, Matthew Wilcox wrote: > > On Fri, Jun 20, 2025 at 11:29:20AM +0530, Shivank Garg wrote: > >> filemap_grab_folio_mpol() is used in [Patch 6/7] in kvm_gmem_prepare_folio(). > >> > >> filemap_alloc_folio_mpol() and __filemap_get_folio_mpol()) are internally used > >> to support the filemap_grab_folio_mpol(). > > > > That's not better. We don't add unused functions, and unless there's > > something coming that's going to use them, the entire structure of this > > is wrong. > > > > filemap_grab_folio() is a convenience function that avoids us having to > > specify the other two arguments to __filemap_get_folio(). Since there's > > no indication at this point that there are going to be more callers of > > it, filemap_grab_folio_mpol() should not even exist. > > > > I'll send a pair of patches which should be sufficient for your needs. > > Thank you willy :) > I'll them add to my series. Thanks. You probably want to touch up the commit messages, I didn't spend very long on them.