Re: [PATCH v2 3/5] mm,hugetlb: Rename anon_rmap to new_anon_folio and make it boolean

David Hildenbrand
2025-06-23T14:13:26Z

On 20.06.25 14:30, Oscar Salvador wrote:
> anon_rmap is used to determine whether the new allocated folio is anonymous.
> Rename it to something more meaningul like new_anon_folio and make it boolean,
> as we use it like that.
> While we are at it, drop 'new_pagecache_folio' as 'new_anon_folio' is enough to
> check whether we need to restore the consumed reservation.
>
> Signed-off-by: Oscar Salvador <osalvador@suse.de>
> ---

}
> @@ -6640,7 +6638,8 @@ static vm_fault_t hugetlb_no_page(struct address_space *mapping,
> backout:
> spin_unlock(vmf->ptl);
> backout_unlocked:
> - if (new_folio && !new_pagecache_folio)
> + /* We only need to restore reservations for private mappings */
> + if (new_folio && new_anon_folio)

Could this be simplified to

if (new_anon_folio) {

...

--
Cheers,

David / dhildenb