Re: [PATCH v2 3/5] mm,hugetlb: Rename anon_rmap to new_anon_folio and make it boolean

Oscar Salvador
2025-06-20T14:28:48Z

On Fri, Jun 20, 2025 at 02:30:12PM +0200, Oscar Salvador wrote:
> anon_rmap is used to determine whether the new allocated folio is anonymous.
> Rename it to something more meaningul like new_anon_folio and make it boolean,
> as we use it like that.
> While we are at it, drop 'new_pagecache_folio' as 'new_anon_folio' is enough to
> check whether we need to restore the consumed reservation.
>
> Signed-off-by: Oscar Salvador <osalvador@suse.de>
> ---
> mm/hugetlb.c | 19 +++++++++----------
> 1 file changed, 9 insertions(+), 10 deletions(-)
[...]
> @@ -6518,6 +6517,7 @@ static vm_fault_t hugetlb_no_page(struct address_space *mapping,
> folio_zero_user(folio, vmf->real_address);
> __folio_mark_uptodate(folio);
> new_folio = true;
> + new_anon_folio = !(vma->vm_flags & VM_MAYSHARE);

>
> if (vma->vm_flags & VM_MAYSHARE) {
> int err = hugetlb_add_to_page_cache(folio, mapping,
> @@ -6536,10 +6536,8 @@ static vm_fault_t hugetlb_no_page(struct address_space *mapping,
> ret = VM_FAULT_SIGBUS;
> goto out;
> }
> - new_pagecache_folio = true;
> } else {
> folio_lock(folio);
> - anon_rmap = 1;

Let's just on top:

diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 57bb8b2dce21..f6ea1864ce5c 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -6517,7 +6517,6 @@ static vm_fault_t hugetlb_no_page(struct address_space *mapping,
folio_zero_user(folio, vmf->real_address);
__folio_mark_uptodate(folio);
new_folio = true;
- new_anon_folio = !(vma->vm_flags & VM_MAYSHARE);

if (vma->vm_flags & VM_MAYSHARE) {
int err = hugetlb_add_to_page_cache(folio, mapping,
@@ -6537,6 +6536,7 @@ static vm_fault_t hugetlb_no_page(struct address_space *mapping,
goto out;
}
} else {
+ new_anon_folio = true;
folio_lock(folio);
}
} else {

which is more explicit :-)

--
Oscar Salvador
SUSE Labs