From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9530EC7115C for ; Fri, 20 Jun 2025 14:34:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 155816B008C; Fri, 20 Jun 2025 10:34:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 12BEB6B0096; Fri, 20 Jun 2025 10:34:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 069C66B0098; Fri, 20 Jun 2025 10:34:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id ED1EC6B008C for ; Fri, 20 Jun 2025 10:34:48 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B4724120FB0 for ; Fri, 20 Jun 2025 14:34:48 +0000 (UTC) X-FDA: 83576025456.07.2D9FACC Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf27.hostedemail.com (Postfix) with ESMTP id 2B07C40014 for ; Fri, 20 Jun 2025 14:34:44 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rkcicpSV; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750430087; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=d9fw5HN0v/kKWel+rpUYgeRmoN6kOXJkrXAVRSMObCQ=; b=AD8eY0UuVs99IG5yKDnmmyW7YdqgLYzDqxqHsxJnM5fqxDEAIJqlE2DSH5ZN66CT+V/lXR Iz9fcG8NxKC4JxXWfZVH/d+9D2G5qHasuy4WnnCcHbY+J43/UZjGdof1yf2dSsQMCnhoQC iYwLvLuHRNU2OEM57/6TQP3aW/h5UMg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750430087; a=rsa-sha256; cv=none; b=iVyXQMIlD97qeAYYWIXRq572lRiaD66N+UU0ngtSnkLvekVQPwcnfdRoAKZs1cLKnIMy2F FyAHxp1xT+gC11ml4qnM7bf9oDyeOrJ3YPPHzsX77xSJmOWf3PzgI8n9AS4TK09o2VYvpb 4PwolTe6E0kIX2UDuFbI0zAsB+8CifY= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=rkcicpSV; spf=none (imf27.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=d9fw5HN0v/kKWel+rpUYgeRmoN6kOXJkrXAVRSMObCQ=; b=rkcicpSVsY9/iNejtlpkTvRkk+ f6/CplQO0sPdjeHV9G7GmsVOvMuUl5T0SQtUAUFodvOQ1VcR7uW1ytVPlw/JOs7vwkPZDKoommpRl I6uP76BWOwj1oLpFBLxetE8kQg0FMOrTPjZAeO+3ldSzsEBvgFhap2vj7TcpAhdrsmfyNkMO1sjQ4 qXoHeMfABSqx2hnkXQtTACb4y/KCmK2qNTuAkO/ojr7+VYZEiMiNjYg9U0fWHtUOI4WyzJQG/D/v8 MhUxXfCo8hGF3VZY56PJDFJXz/IsnK1Lghci6nmJzjUTXkE1EkhKzxgdhSRXZSMFsOJPDoysgcQWp BuPx1G8A==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uScot-0000000CosM-2xWJ; Fri, 20 Jun 2025 14:34:19 +0000 Date: Fri, 20 Jun 2025 15:34:19 +0100 From: Matthew Wilcox To: Shivank Garg Cc: seanjc@google.com, david@redhat.com, vbabka@suse.cz, akpm@linux-foundation.org, shuah@kernel.org, pbonzini@redhat.com, brauner@kernel.org, viro@zeniv.linux.org.uk, ackerleytng@google.com, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, pvorel@suse.cz, bfoster@redhat.com, tabba@google.com, vannapurve@google.com, chao.gao@intel.com, bharata@amd.com, nikunj@amd.com, michael.day@amd.com, yan.y.zhao@intel.com, Neeraj.Upadhyay@amd.com, thomas.lendacky@amd.com, michael.roth@amd.com, aik@amd.com, jgg@nvidia.com, kalyazin@amazon.com, peterx@redhat.com, jack@suse.cz, rppt@kernel.org, hch@infradead.org, cgzones@googlemail.com, ira.weiny@intel.com, rientjes@google.com, roypat@amazon.co.uk, ziy@nvidia.com, matthew.brost@intel.com, joshua.hahnjy@gmail.com, rakie.kim@sk.com, byungchul@sk.com, gourry@gourry.net, kent.overstreet@linux.dev, ying.huang@linux.alibaba.com, apopple@nvidia.com, chao.p.peng@intel.com, amit@infradead.org, ddutile@redhat.com, dan.j.williams@intel.com, ashish.kalra@amd.com, gshan@redhat.com, jgowans@amazon.com, pankaj.gupta@amd.com, papaluri@amd.com, yuzhao@google.com, suzuki.poulose@arm.com, quic_eberman@quicinc.com, aneeshkumar.kizhakeveetil@arm.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-coco@lists.linux.dev Subject: Re: [RFC PATCH v8 3/7] mm/filemap: Add mempolicy support to the filemap layer Message-ID: References: <20250618112935.7629-1-shivankg@amd.com> <20250618112935.7629-4-shivankg@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2B07C40014 X-Stat-Signature: gtkxrn8h6odwa1wcomchywcieu66xr8k X-Rspam-User: X-HE-Tag: 1750430084-585012 X-HE-Meta: U2FsdGVkX1/UzBNIVVn3lbRHpkZIKEuBOUrxFg9pWRpk67xVGuWx2HgKDCFUM1zPjd8rMVUpDZvX8F/f9p0eHdUi3MvpOpEIfZaGW2ztVwaf6zEPg3OoSukd6jRB6Hirt5M2bb/Cz9I2kHhbd5+l8bn73IJq42UZIrKx5irsl5z+wtaq3GiDGJYAuGK4PGtbV8pQDy+8i2un7FtxFT5jnMlgdNxxUDJsLq6RSF7PyqxeeRj1TvFIh1CgtDM0c3+/OBgEYbaHvuIu6uJq1ow0nJhnLCVAmsqVNn+0/furocakOIK0Wila3YF3wuHY1wAUi+oMKzX9S2hJHaay2o9fmcrsosDpvELo3obwkbI5DZHOQMKVIapth3tzfbP1n6xY3yV0dy4syQsy7wJSiMrwK1cKvEga40sXfw+okNO6ognhxBCJ1bI+PT29XZb4E+xftIIuuXB3+JXoHiUjmWGPNn8fTXKGtfS+uwt6qhTcNFXmuLBGrXsQhzIn1Bm644r2ghsgAslaXQwv+DpLH+JJvUXgwoOBPRS1cEAVVyBqqq1akMldtdlP+LfF0ZbwVTrd/PPdeyOofQVY2o3daWOjvkFCZbga9kWNxvL6ORxsIT/whi4pc4K5ER+ePvVJ9Pa/crN+RYGfhy2c2cBg1+56I555hz2VtrZq4ajAXAseLl006W9cQDC7OJmNzMWu0UbMHCS1lwRaVXO1vsQf+aKbGZY87B0YjEcIRB2l7bvbJOnX+XGQueihsYkyex7BLAno/8q7mDWNjYGjqMfLbgiYtIk9YqVnxPq2RULBfEuaBsPFrkyd0g/AtS5Kl1SmUPKLZtCaXQzfuWe40jXITiMG1tuLZOw5F6sjL9I0JUzAQgtXDI7TOBNxOK60vTB8LgRhLbZcUKH5RK8kSyHNUhKeP/Ax6qzP0Y28tNsH2xpeDnkts5XfJqrmRL44FW2eyxPQPkJVzJq6x63ixYXgegF ndArko74 SLHuJU5amY+LZK5zx5nwlRiRw0f9JNNL+CVRBSVvU4zCHa0sqmly4rMFtrztb30ZHV+9go3O0Gy/GUHetqxlCdcv39d+bZVyIATFdupn5BI4nfwaUSgx/trQNyx5x9S1ko7/1tN+GOEK+VX1jM3ZPnLfAKJGV1QQz17d8/4q5zZShaPC4vF8Rr/DfcjFSP2UYcf7XG6t53mVwtDGcKsxgPxpsXi/Y+7i/WUvQJVLpZpHFRwsjavWRdCMv2nSSvf1hIfl/tlFY1LIKqzl5BlOu9Tz6HJwmoCqeo3QDFT8SHIPYrAk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 20, 2025 at 11:29:20AM +0530, Shivank Garg wrote: > filemap_grab_folio_mpol() is used in [Patch 6/7] in kvm_gmem_prepare_folio(). > > filemap_alloc_folio_mpol() and __filemap_get_folio_mpol()) are internally used > to support the filemap_grab_folio_mpol(). That's not better. We don't add unused functions, and unless there's something coming that's going to use them, the entire structure of this is wrong. filemap_grab_folio() is a convenience function that avoids us having to specify the other two arguments to __filemap_get_folio(). Since there's no indication at this point that there are going to be more callers of it, filemap_grab_folio_mpol() should not even exist. I'll send a pair of patches which should be sufficient for your needs.