From: Christoph Hellwig <hch@infradead.org>
To: Vitaly Wool <vitaly.wool@konsulko.se>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, Igor Belousov <igor.b@beldev.am>
Subject: Re: [PATCH] mm/zswap: export zswap API to modules
Date: Sun, 22 Jun 2025 22:11:51 -0700 [thread overview]
Message-ID: <aFjiF-OIDAmHhZNX@infradead.org> (raw)
In-Reply-To: <20250620193552.2772125-1-vitaly.wool@konsulko.se>
On Fri, Jun 20, 2025 at 09:35:52PM +0200, Vitaly Wool wrote:
> There is no reason to not let modules use zswap capabilies to
> densely store unused pages in RAM. This will allow to remove some
> homebrew solutions for e.g. GPU drivers in favor of plainly using
> zswap pool.
Well, right now there very much is - there is no user of them. And any
such user should first have a careful review on the list if they really
should use zswap directly because that feels like a layering violation.
(Maybe it's not, but without a proper review that is impossible to say)
And this was the nice Monday morning after a long weekend reply. The
short form is "don't add exports without a user", and everyone should
really know that.
prev parent reply other threads:[~2025-06-23 5:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-20 19:35 [PATCH] mm/zswap: export zswap API to modules Vitaly Wool
2025-06-20 19:47 ` Matthew Wilcox
2025-06-23 10:10 ` Vitaly Wool
2025-06-23 19:33 ` David Hildenbrand
2025-06-23 5:11 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aFjiF-OIDAmHhZNX@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=igor.b@beldev.am \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vitaly.wool@konsulko.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).