From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4342AC7115D for ; Mon, 23 Jun 2025 05:12:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2B486B00A5; Mon, 23 Jun 2025 01:11:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CDBD36B00AB; Mon, 23 Jun 2025 01:11:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C18DA6B00AC; Mon, 23 Jun 2025 01:11:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B1D0E6B00A5 for ; Mon, 23 Jun 2025 01:11:59 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 675BEBF718 for ; Mon, 23 Jun 2025 05:11:59 +0000 (UTC) X-FDA: 83585493558.17.DDE4BF9 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf17.hostedemail.com (Postfix) with ESMTP id 4F95840007 for ; Mon, 23 Jun 2025 05:11:56 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=eztFYiUC; spf=none (imf17.hostedemail.com: domain of BATV+617475e3227a0a436e26+7974+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+617475e3227a0a436e26+7974+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750655517; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Kld/uITGF/u1zNJ3lTXiAZxc7BUp8iDuyP9wy6UrYpU=; b=gANJc7VN3Eix9f4/aB+vXEWZuY/Yw9tJDdzGT71dpAxSlRVaCBbjBlum9PB+g9ErZF4sp4 QNhCvVKSwXWn+0ZVPfUhvnJha63wXslolWe1aceSTqfq554RhlwE4Zw4MsIn3qWN39JSFj +VFNOfC+cbcxkPL4DwSCZTTP9wOW7zQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750655517; a=rsa-sha256; cv=none; b=IJFUh5WOqq83aiiE+q0amG43lZymdO0zHz2F8yvXWy42z5AwquHK+4capS5PsWewiyRK1m o85nromZiU5yekUbmaA2GJIJAYb3ddf6ntfMmT5VlN49yWE2FJFS+YKyQrFv2PvzAUwKj5 ULU5XOal/WwyFi8t1DxPygcRKRJntMA= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=eztFYiUC; spf=none (imf17.hostedemail.com: domain of BATV+617475e3227a0a436e26+7974+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+617475e3227a0a436e26+7974+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Kld/uITGF/u1zNJ3lTXiAZxc7BUp8iDuyP9wy6UrYpU=; b=eztFYiUCB/mKUUKIq6PM0W7pBA 7ZBQowHztYmGRDKfXT6TOdxi635pfTP7NWCU9oGmtQFewK4rLoICSGUU2QrYbEJr7PCIYR6dF4wEy VoSyhbV6mDuFTQDiQ9nZKDmgrT/BLSujpl4rsh48DFTVTkHe7RfL9uG3k1/6VymcwGnnNhS25AHnY CxP9Bsxe+KlNHyYbSq/Ng6U+szBFk9GdiXFblyX1O1Dp3Dh1H3Jl8G0LM1qbtJMigJMzWHB3Ntr8E UJ/I5/4WabOq5esjTQGsdaOYKAA2A/af6qzmkGVj/mGegpQHBInSVXJtotWYJ68KMzKfgL/Y+HKp4 vd/A1EQA==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uTZTD-00000001asl-3QLs; Mon, 23 Jun 2025 05:11:51 +0000 Date: Sun, 22 Jun 2025 22:11:51 -0700 From: Christoph Hellwig To: Vitaly Wool Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Igor Belousov Subject: Re: [PATCH] mm/zswap: export zswap API to modules Message-ID: References: <20250620193552.2772125-1-vitaly.wool@konsulko.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250620193552.2772125-1-vitaly.wool@konsulko.se> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam03 X-Stat-Signature: 6p3hxymm8qsymd6szrb7otrdykkbz93f X-Rspam-User: X-Rspamd-Queue-Id: 4F95840007 X-HE-Tag: 1750655516-689411 X-HE-Meta: U2FsdGVkX1/18VQL7XaV6wM7uF5tVQeggLXMXnX3sc1Gi4eXYhagsFHwaeyA3DHmB5V5hS+R9BnBYWvdbSFYcNveFaW3IcYsml+q2NkPQ6Bj/RdLa4srd8+vk3k0PeB8YY+VOMflmmyIESG8CqCzpebYQjt9UGBxNnTO7VNxwS/CVoZSCRLeInbMyCUiZif2TilMi2zIqF2VGjDIroQhi+6OykXbvyTDk8srYjogaGdFTaYkw/PYConJ9BTdSwFTpf8t+tHut+3R9T6jxAU+64J4634SjneRUxtzb5cvoGYLOFFQ61yCm02u7XgpIwtc8qHjcJh/6eO996lATVbl9GUElgy61RyKAKWnkXvyQ5mnG1tBcxDANN5gZo59n4Fn3dAfjMg4Vop0n++RALmgBMktDvIwiGKHKFAAGofcW4SWB49v34ev/mskt/tKoj8stcP0s0pcY9iRanGLPn83t/swF2mB8Vz2f6uJnWFq3jFjvkxYfy8aDIt1ghxZ7l9SNER+XnIkVjHyDa8KhX1tIiM/7adOwNRA8HOcI7zW1WGhm+I03QKGiIRQcAzVoxFxdvO9rjLMvk1w4b7mOdbNNf01Nk2INxRmNxaJHi53wvDpSbO4t84t6NbcJ6m4UkziALjAHAun5zngk8gm9MkTn9yA50wMfzfvzA2C+LZeWiL8i26AcReXQMnDE7Be9xzUb/hcf9Sm962Me/tPHWOnIrxxL7w+SWbBvpebUeTLMFfoxNQeZqB90otkyt/0Ebp45xsdW6l+aVGNuSvek7koPfPnhxga+JVXeut/KPga6MMHVE51qBhp5Ugn3Gz66Zoo8N87n+gyQ6LJ0GwwLlh+vE4iXQaO1CasaVcnI9bYurmzpQm7SlH44w5rcDHn+Vkc96pWsBg5lrR4lx/yD/aD52n8t/VdrexYyP3oDjF6ZzMwZjXxsJ0GiagRvuTRUE/gq4ZK0mGK8M3SE8ISKgX u32EEvfd Wh5Q+qQ2BhdwWDoHFgDuKLy8QJOdQU929yo2oipT+G8B41qpuij/zior/g2TZPuygISLG3GFzsQHH7Y6KvY73ek3PGNz4JekChnefKnHAigHTYR2QJFhwAU7VMu8EwaN3myywjv2l3r0NgRmdvTBb0R2OSJAXErVT4J9wfhgCIbXSBAJkeZ3eOOx+R8UWY2o36ynOv6uAaYxlKGOzi6yj24X1Pkx/qiicPQH/E9PpWqe/cVG2D0zFcSidHcjMmfjYaPYf7k9a70Tj8ihVZoQRuERbsCHJPjtPNEdhX7K7fvLWN/d4PPiQM7Fs6j5OrEvRAyFgLXGJKHPpfVIeXSKkJapi0mtAXtrQQRZXohsMOeekfm0GhkivxnyEjB6utIcOrnwmdhi3d7jKAlkPZDaWPf+Ud/i2reTTXKT1QmQSWW0DhnIQsT/uke6gMQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 20, 2025 at 09:35:52PM +0200, Vitaly Wool wrote: > There is no reason to not let modules use zswap capabilies to > densely store unused pages in RAM. This will allow to remove some > homebrew solutions for e.g. GPU drivers in favor of plainly using > zswap pool. Well, right now there very much is - there is no user of them. And any such user should first have a careful review on the list if they really should use zswap directly because that feels like a layering violation. (Maybe it's not, but without a proper review that is impossible to say) And this was the nice Monday morning after a long weekend reply. The short form is "don't add exports without a user", and everyone should really know that.