From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 875DDC77B7C for ; Tue, 24 Jun 2025 08:31:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 37C436B00BA; Tue, 24 Jun 2025 04:31:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 354086B00BD; Tue, 24 Jun 2025 04:31:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 291306B00BE; Tue, 24 Jun 2025 04:31:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 146686B00BA for ; Tue, 24 Jun 2025 04:31:00 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B910DB5CA2 for ; Tue, 24 Jun 2025 08:30:59 +0000 (UTC) X-FDA: 83589623838.22.C3EE393 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id DC3E040006 for ; Tue, 24 Jun 2025 08:30:57 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fp8Hkii4; spf=pass (imf12.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750753858; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uasRZZUq4je56X5RWLM0Pz1qlN/y56MEIUD9faMoeXs=; b=IRED9J2uhdK3dpfJZ5O3kzGObaxuObMmlvC4d9DSJeUW04JvSxBaQ6Ni7JRDAS5pOkZR5H ldj8UO7ahV+FGBOoF9j5vQ8ZpGA4Jito4qMCHBd7OW6i56GOHRw6R8PyTetCPsK/YllBwH 2Bw57LPRqbf6YGY5flyXwy5eMBufQpg= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fp8Hkii4; spf=pass (imf12.hostedemail.com: domain of bhe@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750753858; a=rsa-sha256; cv=none; b=nxXoFC/NgohbaWIGEzuiO2yK/RJfAZZK0Qsn+c2YaeKXPkmDLBp7L3pceydjNDYJ6M01eF y6/5xa81MVoD+GiOfSQxle30ub/fJRIH7S1MRD9mIu3OWchvXgIiPmM6l/IKek0+FNLIOC Wcz/1bmhS8yYAZY7jOvgWKTaAameN+Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750753857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uasRZZUq4je56X5RWLM0Pz1qlN/y56MEIUD9faMoeXs=; b=fp8Hkii4akpen/qv9am2IG4TXlJqIlQ0y00sykYH0+THSVyTzyhiyVv9J5bZh1Eqi4IBdP TWtRtqq+uCSXFv+tuxB7cyhPEMQQxD2yYi20aGB9WzmfRUDI9Kzpegyl+2JH7SeHzCdFpm XCSCC0S/Jyk5JmySw7lZ7XPlASF7HsM= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-124-GR_HFpohMWeLGDfluxR8nA-1; Tue, 24 Jun 2025 04:30:53 -0400 X-MC-Unique: GR_HFpohMWeLGDfluxR8nA-1 X-Mimecast-MFC-AGG-ID: GR_HFpohMWeLGDfluxR8nA_1750753852 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BC09E1955F44; Tue, 24 Jun 2025 08:30:51 +0000 (UTC) Received: from localhost (unknown [10.72.112.21]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 912AC19560A3; Tue, 24 Jun 2025 08:30:50 +0000 (UTC) Date: Tue, 24 Jun 2025 16:30:35 +0800 From: Baoquan He To: "Uladzislau Rezki (Sony)" Cc: Andrew Morton , linux-mm@kvack.org, LKML , Harry Yoo , Suren Baghdasaryan , David Wang <00107082@163.com> Subject: Re: [PATCH 1/2] lib/test_vmalloc.c: Use late_initcall() if built-in for init ordering Message-ID: References: <20250623184035.581229-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250623184035.581229-1-urezki@gmail.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DC3E040006 X-Stat-Signature: 8n6em7jd3i5p4bwqpyyywjjwxzaigufp X-Rspam-User: X-HE-Tag: 1750753857-649125 X-HE-Meta: U2FsdGVkX19sG+A13c41+lOYUUkCSSsLucoZBplDPInBuoEtq102H0dCUk3SJvOcYHnA3+W5jVQfRrvpwQAFI5PQHAqy9vM+gNHpMsj5U2WhuAXu6huFdjysL4qexIKKLWJ83+pENY5qQUvW73dE6r/f6NV6e8pm1B+pTqbAgXJkImma/W3EM1pZycWYDdv5IZC/YUAOGmK+PSOdQHT5I8ONukd6lY5fl0z5V4BKjvgEqX7I3cAC9v4pC6E4GJ4DOHjSGrNkLxkYJveK7TTpEZvfXzNHlDtvmKFSUkXOYwgSFgfRiimxJDxm2KU9hizG7jgit+XRkx3t9r/22LjcwfhP63cDzEQzRlvPs8/itwvzphZSFKp81yOwZ6sdwacMxxN08ulV7PywbF5tkzUzqAQdN0oZCE+mZ2hJHo8lSYk6y0lbWjyUVkliAsGPviKDl2Caip9gCll3C8ElD5gnBKVwk2KyaVScmef1NV/HL4U8vKGcqFBCL6MTrxBsJ3eptsCKQsNp0sZm6Ok/kd1WWTxBrVDYwEtrVDzqPUUKNBuKyuOpdRL+HocHAbhdImdlhUc9rkSojJlA7BsLmFFZ3B/Bmnwrocul4roGtuxm/re074/z0pPuQvu3n0mlFJHQm5OV6QnNe+DtS9ieWOxN0dPQpTzQWxcpFxszpv6XFvO0UI3qy8Kqo18cox+RIzvu6qfrlRds+efZFIsvdnxcyJBFuK5SPmrrmsscVOmlMyXoGjIkfQ49eflCvfYaFFiboaiCkADykNNpdGq1JetKgCPRu3/K1vn0UCd5cnM5Wjnxq+BIeAyaP336Aq8g2IbOP3qXrCBCi+echkPxmiK2W5Tla9Uo4TL2s1tRKwLQ4w+dTXKhocjkmP4XIn/F23twxxSwRxklqEkJ3GYDa2dumOLXWf0IoifvV6ImI13BJYQF5wKFNVbhRP1QkWcxwM4bHlrX9fbBW3VdQgSW6lA /X+bx+6Y 19VpdDO2YdM0AZ709ZQORcjcdcxUYh5S4l7WwasftbDZytLwkY+aEPeuMdgHFfNMfAi1wYN3HvWcXfFn8p+oieENFcgjJFtIJqu2NQXMeOtcCUOHry5aTnVJ3E0bbgLZvwTa4okk4+HGMdyMrDpat2ucoapGt7A7rORQwGhlaDOWeTGamSM0Tx/1tZ62uB7lhSVek6GFt3/CyjqOt/5rHDGa7fm53GqdbxUloE5VrtUM3MuOq7tFR7VUSWuxfI1gw1ULwvc2s70rWWcssrY6Sshk21p/1r5d1M0YpsZjiMtp5Q06kOeo03AXsYNMFyOv+SpHCOOG8kAY6Q+m/YFNjNxvlHbYo0qsKKOf1DjI9pu7T6u8SDCpsqiw0/qJAHwJ5Ns0mtmZo6JufY9JXe5vxCcYyaL1FX4ngcpUNT+PgCPJl+bUoRh7aOmg867MfQOSGN/3J4DY/vcCbg7yHy10hcHSxyqDy7HD1gCPzziXuePBh6ezvmz2C4bt+Lju0Cz2Rbsa11PobChIIN1mFp6PycU/PtrtxiXT31LMTr58MllboXkKNhTduecsCV/Ckb60mCztPDxg67tyQ0GLt5+hqj48gtJQnBkmyR4+QFg1daJmG6zFkL6Yn7n0M1w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 06/23/25 at 08:40pm, Uladzislau Rezki (Sony) wrote: > When the vmalloc test code is compiled as a built-in, use late_initcall() > instead of module_init() to defer a vmalloc test execution until most > subsystems are up and running. > > It avoids interfering with components that may not yet be initialized > at module_init() time. For example, there was a recent report of memory > profiling infrastructure not being ready early enough leading to kernel > crash. > > By using late_initcall() in the built-in case, we ensure the tests are > run at a safer point during a boot sequence. > > Cc: Harry Yoo > Cc: Suren Baghdasaryan > Cc: David Wang <00107082@163.com> > Signed-off-by: Uladzislau Rezki (Sony) > --- > lib/test_vmalloc.c | 4 ++++ > 1 file changed, 4 insertions(+) LGTM, Reviewed-by: Baoquan He > > diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c > index 1b0b59549aaf1..7264781750c96 100644 > --- a/lib/test_vmalloc.c > +++ b/lib/test_vmalloc.c > @@ -598,7 +598,11 @@ static int __init vmalloc_test_init(void) > return IS_BUILTIN(CONFIG_TEST_VMALLOC) ? 0:-EAGAIN; > } > > +#ifdef MODULE > module_init(vmalloc_test_init) > +#else > +late_initcall(vmalloc_test_init); > +#endif > > MODULE_LICENSE("GPL"); > MODULE_AUTHOR("Uladzislau Rezki"); > -- > 2.39.5 > >