From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F94DC77B7F for ; Tue, 24 Jun 2025 12:23:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D1E756B00A6; Tue, 24 Jun 2025 08:23:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CF5626B00A7; Tue, 24 Jun 2025 08:23:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C32DA6B00AA; Tue, 24 Jun 2025 08:23:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id ADB086B00A6 for ; Tue, 24 Jun 2025 08:23:27 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 876FEBB0EC for ; Tue, 24 Jun 2025 12:23:27 +0000 (UTC) X-FDA: 83590209654.08.219B419 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id 62AE018001A for ; Tue, 24 Jun 2025 12:23:24 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=S2Um+0qp; dmarc=none; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750767805; a=rsa-sha256; cv=none; b=vp3KUQZ1p89dFlob9PjZJ6Y2XVVk3PMooHlsqz/Smp+O6DtkeckMngZbSbHtQw0Ywl1BJb hxw5xHubQG8Vr8hxQs59TySQlsUMG5JX9+Cv/5g6pp3NHswMBTJtMiEFmua/7rnpJSNrra I9rNOLoSUm7LRt0TlHMemUFQCao//Ws= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=S2Um+0qp; dmarc=none; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750767805; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u2DmQaokTW2/gnjH2cgnlfjmMToaryjzjXcqnXsp80s=; b=MCDtWihMAIYtw5amWzxcPAIGq7HbL+qk7EC3kFUj1510pbXA4gAcN8K4zyyi1vkTLDMDvX Qxxq/POgoVmEXI1K4wCk5mwKNjwQW7n2pydnMhG5+hqVLizVikLxtBV9IbW3DrN27tIj3p XUqbFlKtT3xztCdyfyQVtVgpnYaeo1U= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=u2DmQaokTW2/gnjH2cgnlfjmMToaryjzjXcqnXsp80s=; b=S2Um+0qpagjVrhSQsPtu/Y9Ki/ qT4VCiz5D6Hf7xDHltAe+KRt7fHQLqHv0UCpc9w1zthcz8KjmNZ2CVeMcpCwT/TJqEXysR8c9CwDu vqzHC65Fq240pfKWV3nGQhGhzdCTpTIGbZvyf/Z0ZGRBRPGNbX1WRxPt034gUSlPqPHkBj9DzWuNS BaFAqEYcflqmFmayixuy5iaOWNh4p7Tih0ACK126a0Z16IkyVDVQOtz91tRsBCpCpTvEzylIiHonW zakG4Ry8rOhUB7dD3NNe9m2JxYVEHbBSgzM+IbcRxItxFOPiXEyubfjCK2Ty3Fxr3Hi91Y7XGbXMY Jyayik5A==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uU2g7-00000006YWM-2gs3; Tue, 24 Jun 2025 12:23:07 +0000 Date: Tue, 24 Jun 2025 13:23:07 +0100 From: Matthew Wilcox To: =?utf-8?B?6ZmI5rab5rab?= Taotao Chen Cc: "tytso@mit.edu" , "hch@infradead.org" , "adilger.kernel@dilger.ca" , "brauner@kernel.org" , "jani.nikula@linux.intel.com" , "rodrigo.vivi@intel.com" , "tursulin@ursulin.net" , "airlied@gmail.com" , "linux-fsdevel@vger.kernel.org" , "linux-ext4@vger.kernel.org" , "linux-block@vger.kernel.org" , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "chentao325@qq.com" Subject: Re: [PATCH v2 1/5] drm/i915: Use kernel_write() in shmem object create Message-ID: References: <20250624121149.2927-1-chentaotao@didiglobal.com> <20250624121149.2927-2-chentaotao@didiglobal.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250624121149.2927-2-chentaotao@didiglobal.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 62AE018001A X-Stat-Signature: hc6h8ebw1cibd7zft4ghyftyxegwexgo X-Rspam-User: X-HE-Tag: 1750767804-731461 X-HE-Meta: U2FsdGVkX19Zyz+IJpxDGZGK7KbbgLBPF4REzOHTvYgVnQIgSHgNPJYNlcHmIbu15HtK0gJ2Ihta+HFMuCZVhWyCu3NhMqjn6bgdgN2pjb5VWyGcj6FGZuUU6iP9N0FvhtYE0Fwm7JV3bPoF6nRUzOsG5iPG94Dm3We5hl3q9fQJjzH62RrAmre5pP+AtAVL/WO6Pjyya/C+nR2ERixRdwh3KoLHzrjyshQ+KVGGgdNLi5ANF2cuIExI6z7nphTsC36B84ZW/wzs8NfnTc8LL1AhHakWpFvUo5HmxXOZSEkEA35PUI9WGO9e2+m/w/60ux0Vr5T3XHfgJERWfOdVJraRHcxiebwOKPGCvpGYJ0xsvHzy/bhRlf69qVl9nmiiGBHy8i/fOQN0SHl9B//U5SIwQ1fV1j7dtY3lUjMucSn3IrcnNWifCBcnvRsWkBSsE17D4o0Y4yLZQCEqwQ0ulS1erc0It9B+WTfP61Zaz7A0uemDyIQrSROiNFLK8t30vhDWfWFmQ12UsRz++NBrFYAaQoWQK27lgpuw71S3nbXEZSHMhu8OPHilTL17rVgpD4ZT6A9xHnILCFBUfuqErs47uVuC4ID3JEUFpcBJEpZHWwc86iWwkBpA/2zoqJOMJCw3BRh8hqSegPp4dTplQuauKO6RKjwclCNg2keBM/pYIBITw870lDR6FZpTqMfgMWC39AeBns0Lo3KqFrGLXNcrkK83uWpOXLf1j1Xm/jMTsEL+zqH+6pmEsUfdpASDwqrJ0LX59XObXVJjrdmRTqjljFJhtAdgyp9Qa8VP9vDB47fdYuxpg8DNuBa1gKwpB74VfITa1sMgUBr5fLiwzfmYIvTTEOeuUh5dwIQ0APJJxFcQVy9OVD03bdWmksWHIduROWBgWFeRD1urtChDEl14P9ilq0L9VhN8IR+zFxXdRfz90Zr7J7M/QQwU2dedCwsm511g0fdad8I/EaA 7sy8jLf6 MuFpl+h7ERa6kghANTtRdXsda5ON6ybtRRgG85h1SBDp0In5jt4nEnEhNDhFkHyczaDVupN4IZTSwrvpgQk4YA1eqDkPIHjMBROLcCCwOr4zYsoQpO+JOHY7Uluz7jx5GH9+QBIHh5xsdfjfhTku3GYebupkQPhBecpAWuRhFgDMOkXCnu2n46XLamaw5XKIFaONvetSZSBwx2B02pSyq7zyf4Iqckgj0oGiJtOEFu1Cfac/xm/UkTppXIS3Chd9gd2gwbL80LLwzi3pnEzdzMcwjjqZJSCtlqiUuwvRzkIKoFyIqwtVCz/SmESKpA/+kwrNztAuN9a0Pd+EtTFvSHsbfrjA2rkV1JQYvt2ZzaY3EOfHKOESdKrHveg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 24, 2025 at 12:12:04PM +0000, 陈涛涛 Taotao Chen wrote: > +++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c > @@ -637,8 +637,7 @@ i915_gem_object_create_shmem_from_data(struct drm_i915_private *i915, > { > struct drm_i915_gem_object *obj; > struct file *file; > - const struct address_space_operations *aops; > - loff_t pos; > + loff_t pos = 0; > int err; I think 'err' needs to become ssize_t to avoid writes larger than 2GB from being misinterpreted as errors.