From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF04BC7EE32 for ; Tue, 24 Jun 2025 13:14:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E23F6B00BD; Tue, 24 Jun 2025 09:14:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B9F86B00BE; Tue, 24 Jun 2025 09:14:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D0DD6B00C1; Tue, 24 Jun 2025 09:14:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 202B66B00BD for ; Tue, 24 Jun 2025 09:14:53 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9C64A140808 for ; Tue, 24 Jun 2025 13:14:52 +0000 (UTC) X-FDA: 83590339224.02.07A6120 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf19.hostedemail.com (Postfix) with ESMTP id B8B3A1A000B for ; Tue, 24 Jun 2025 13:14:50 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=WkBzP0hC ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750770891; a=rsa-sha256; cv=none; b=1m3zJ/mx9EuhB0YDlVRXgtRe5kTCPmty29q+Uy3YYPhSu7ANuOU+hVKjraN/3Xdpq9MHsT BusVJmc9CT7XiUyYf5NTdXrIa71TecqE6qwsmWcCF0qmkrirBG1MNnjPqSlxLd24Eu/KGV 5dnzsiTBeYYO1MxTcguSvCjbqBhuEFM= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=WkBzP0hC; spf=none (imf19.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750770891; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BFg+UglFBXSDH09z4reIXqlceEQivXupwjdKDxA9w1s=; b=DWhY1zySjIBnbH26MG3cUCNFKCUjQc7anZ4gWO+M5KgX/EPpYHjwa8K4C1e9eqyqV/GS1u 62i5kST7q/iFaKVX09Nlqg+sw7syf0JUQZMj8U1KRGHucsJJtWs8LfCL2BhSfKC8j+glIE wtUVMZYPkG7Xh94BBuzRg+StyqVmV00= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BFg+UglFBXSDH09z4reIXqlceEQivXupwjdKDxA9w1s=; b=WkBzP0hCZtOxKo4teppSjK+dzU x3EAIuJi6DcR70CzRnVNPzz+XvfYus7Xy5emq8VwDnaVCN9PYUPF4b3ZJD80h5j+ix6ILv82cH6Jf 0t+CcA20J+dn3TGQPiC/DQOcon9+ZSUxc9dN+HO3Q8/x30MHFFM5+oMes6xeINMyfG6gk/p5yWI81 RY/Z0XFz2mjuOTHyxtG+r1MgCWj1aj79E4kObBeSUkdWpsHV1DauD4dmBx4OiVX7yauY+3DUpL2BU ALGEAJxfAjMLGJy6SncR4EVJz7L6eVk7KB7YadazhlPKfTtW51LrOdm7SX/uE3n7uTNYzTTXfeaSO GqaSWL3Q==; Received: from willy by casper.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1uU3Qa-00000006eUv-29ID; Tue, 24 Jun 2025 13:11:08 +0000 Date: Tue, 24 Jun 2025 14:11:08 +0100 From: Matthew Wilcox To: Anshuman Khandual Cc: linux-mm@kvack.org, Andy Shevchenko , Rasmus Villemoes , Sergey Senozhatsky , Petr Mladek , Steven Rostedt , Jonathan Corbet , Andrew Morton , David Hildenbrand , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [RFC 1/2] lib/vsprintf: Add support for pte_t Message-ID: References: <20250618041235.1716143-1-anshuman.khandual@arm.com> <20250618041235.1716143-2-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 8yr9rmzxcnb9xr9u5898qqayiyb96zoj X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B8B3A1A000B X-Rspam-User: X-HE-Tag: 1750770890-355721 X-HE-Meta: U2FsdGVkX1/D/yE/qOTDKXx4DOFj42EK4IFvVKPZowDpTQDEu+qJdIy8PfE6PgyWPdtigVnfLxO+G7i0jbmyZ1Y/jx4QT3RUGGx6iHNT7wTEosLkLbEYSgd7v7UjXP9Vsf8zr6+If8idJuVyPVV0af7QUPGj7vDjRdlaOPoKieZW5HB95bxS7UqrEITpqv1ot5EwZYNJFAGq3xYawve3bOHUNCW50KO2iVHzLtMgi4zDvqVxOcScIxp8VbeyUNbiXsc4+TWrLKDY0yN4HsK9xnXauQwRBgAUM1kYHcElKulOv1xUuSPT4gZ5X2SudCBdZWSNkIqSTL3ZNOhDUH8ziW4QffnABHZeiFrwVH/W0Z+wU9iTiSalDvLcAPbUSvCKEjHmIdMbKnBeB1Geuc6WdwcEARuyjRMTiG76rXdjbatnSXmcyDzq/ji49QaWrjUUrrQzqjBXCRgA/NdQSRUcfDtv0GTAlh4wJW3caDQNfjY1JOGqFFIhngljqFoAcLbe76i4nJMjNNzQLIp1xGKm0qRxScUjTnRmcMBVIeFuE3sOC3HU9ODZ9D/pBpDohPNUwfybSiLAgwM0WamwSlqJraEhbXYtjRhsOaAuTEWEuiM9NrHf3kkyTxLPjOGzJxl50de727jYjTa6YQx95qDaEzoxCa9FaoYdVT4UayL42p+ztzZkgQxjUdBqX+hjX+WXoqjT0jbl7NAmbNwNp4xZbc4EnyicncyykpVqDFoLDF2tOt0osa2rJ2uCpuPuPXh2lnsWgruf1ZXEfmGpsc2FV1Y6LdTDNGemKt/RhDnW40N7Wvo0ywVhOKGBxY5T9jjJiN1/MCM8sq7IhkcvjkMqG1w7hJMEt7B2y/RbTqeboCiVK5POFSw49cNg/XXvSNfH45PDVRmqw3oj2D59Hbt/2HtRGJthE4isbf01fVew0cpH/gitxE+bajkHQVUQhbSV17X84mm2UndTHKhEwF4 Ns5jfKXJ kCMVXfGs2DWwddwJy9WBKPIuIaHm0QCy6uQAPgN/YNbSUs5JT/f+hjKJmFkOR1hXAF+6NnbuXj1S0G/hQOFLwH+uCEfAnpWh6WJ0Ru4B66LhS3xMU8cXcHUjbzc5smi86olrSBXlmbdlt4NMj36X5yFuQ+lhJFAHfQOrPAizRyv9eK6H2oxO1YVdNOGACCXvh4mcJEjTYTILwVaSJmTgVOLAaNeIg/lfY+ktXTiRDvTbV3WAbxt+DBicuMLP56L1FSp6LTuf6vLIPdTY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jun 20, 2025 at 01:42:53PM +0530, Anshuman Khandual wrote: > On 19/06/25 6:56 PM, Matthew Wilcox wrote: > > Unfortunately, the one example you've converted shows why this is a bad > > idea. You're passing a pmd_t pointer to a function which is assuming a > > pte_t pointer. And a pmd_t and a pte_t are sometimes different sizes! > > (eg sometimes one is 64 bit and the other 32 bit). > > As discussed on a separate thread, this might be addressed via separate > printf formats for each page table level e.g %ppte, %ppmd, and %ppud etc. There's still no typechecking!