From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AFFAC7115C for ; Wed, 25 Jun 2025 09:22:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2D9AE6B008A; Wed, 25 Jun 2025 05:22:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2AAC56B00AB; Wed, 25 Jun 2025 05:22:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 172966B00AC; Wed, 25 Jun 2025 05:22:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 021206B00AB for ; Wed, 25 Jun 2025 05:22:32 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id A273EBF86B for ; Wed, 25 Jun 2025 09:22:32 +0000 (UTC) X-FDA: 83593382544.30.0B2C63A Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf01.hostedemail.com (Postfix) with ESMTP id 5CA2C40005 for ; Wed, 25 Jun 2025 09:22:30 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=rbtjJP9z; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=GgVMoCJy; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="O/vvHBWM"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=xfzFyc8T; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750843350; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PkNXozaFqCl3r1OmdA8t+IzKcrfCQu04Mbq/ObVKxp8=; b=iBvHrb61OCIshZ/oB05wF/aW/JWPUCxTYoJuiZZl4UHZAHibYLk92FXU+JXppoguqzUHNy URCgCrxg8ryUyxSIAbH2f81zao3N2k26glSUQUF+Zv7zpCLpsUTnAHVfmR2+VmH3WuP5Cn oYRuEdG18eT6mPw7CTggSt7RMHZYmU4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750843350; a=rsa-sha256; cv=none; b=vDfa3bndzERhO9PoEnU+u38qtN2uKCoQSwGBhiKTWbx1ZZYEV0KG4VqIwByPqZ84ve2OJ3 OvTjoSb042eeN7festo4hLcbco4MWQD/4J33k6gcVakl3h/Jo2Se2W7sqS7uaf8Ht1X4dK XdrOb8SB+0d7/SYqt7Ai+DB2+4eB7aw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=rbtjJP9z; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=GgVMoCJy; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="O/vvHBWM"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=xfzFyc8T; spf=pass (imf01.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CC8941F441; Wed, 25 Jun 2025 09:22:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750843349; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PkNXozaFqCl3r1OmdA8t+IzKcrfCQu04Mbq/ObVKxp8=; b=rbtjJP9zhGrVoJ43Ic9kugFSgL+KJpHkhNFjNzwFABe+2xjA8xtzPucLEDHFiRnRsWrdwn gsoOiPJig/Yv0UcdGA1Nce3zenDSyru5GjEROLMekd/5/3GvIDBP1sl3ABsroWeWdJ30X0 Egm+gOPeA6Oq9ou2STYzXGu8ISNcZF4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750843349; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PkNXozaFqCl3r1OmdA8t+IzKcrfCQu04Mbq/ObVKxp8=; b=GgVMoCJyBt986jshsNs+3JcbCpxXSTveGpp2fw/56tFaD4umjtQPTNQmwnmEUrXGcdYk/c Q8lfEQQpRSTJyyCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750843348; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PkNXozaFqCl3r1OmdA8t+IzKcrfCQu04Mbq/ObVKxp8=; b=O/vvHBWMUGSXvYo9OiVppR/pJSlJIxUObpuvSRpSaq2f4LaAbtBS3GI/sWSYARt0fzWuSg phQeflOpg4l1YLtUYYNw9Y1ctszd/PXb6vCfCv2Zu845RlwSlnNYMhul/Othun4kVSc6k+ sk3WDOpHEsJ3jKgJ66p7kU/LAAFF3YE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750843348; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PkNXozaFqCl3r1OmdA8t+IzKcrfCQu04Mbq/ObVKxp8=; b=xfzFyc8TfzuRj1e5fLLi2HFfMPWUNAuYgqbpY6DE84k35H3GMtTOQQ3rrTI7xZXm5gaGhn soUCykV8MVeapKBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 5E66713485; Wed, 25 Jun 2025 09:22:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id t8dVFNO/W2gdMQAAD6G6ig (envelope-from ); Wed, 25 Jun 2025 09:22:27 +0000 Date: Wed, 25 Jun 2025 11:22:25 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Alistair Popple , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Zi Yan , Baolin Wang , Lorenzo Stoakes , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato Subject: Re: [PATCH RFC 13/14] mm: introduce and use vm_normal_page_pud() Message-ID: References: <20250617154345.2494405-1-david@redhat.com> <20250617154345.2494405-14-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250617154345.2494405-14-david@redhat.com> X-Rspamd-Action: no action X-Rspamd-Queue-Id: 5CA2C40005 X-Stat-Signature: h6kerzgxi7adq57pmmox3p4s15twrza8 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1750843350-916050 X-HE-Meta: U2FsdGVkX1+GhQ0YUuzqvRUCgGMXR3Z6bt4SaPNj0iUgpQON2DUqXSCBR0s9se35qYxcNJqJ1OGJkR4hDX80iL9z5GJfEzfqKzvqq21Q/5cNkSfqioD7uqr/p91gEbY32NvodtJmGTKtY7aDmgsXCn6faOo5taD9zNgdgWAdGD6Jwe6DWjmSgOTwYdjUfq/zIAlKs0MwYVCWCVJLE5BwMT/pQMxe7izXVkEhmFjjnQ3iDHGTrjcsBkMVyBR3bGEZ1+LctAZTeLaL28FRMVHxXVeZzc6BiiKssnAmOXIOuCycmg3rujLQm0yqqgLEDlB+Kx0NBTRllefwtta6cHiIP2mPdktopxQgFxS2d+R0KFJCFM/bnLiKc579NGdsAwtPWPOD9RouTBsR+7/DS209oE8rAmlQTMVU5lyw0WGpzs/2NyinnLRQ9Rs6o/k0Cp8XcQ5NRelKhR0HrGgYnOboX7hMg7bmWEcXXvQApcVvvaJ3hWzwSCEjhRNqnmsRxV6YU+2wg0ijlLr1iJvUrK7bocI5hjgi9O58ldOZh1JTLzbPEuoKHFTQm/rBCMbpLDTNwsAIYYvIhbQ4fzw3Q1elviS6omWnlgLzuM5PW4o5nRxC4GQmEg/FbDFUxINm3pPlu4ArZQcQGHLkJzGcwydLZaUJmxL8oHR172a7m7nq9J13OYQV79kdltpFuV7zqQDtYp/i2EcAl46Nfhn6l7CAqZMnUKJLV6T1gqHOcpCFe7L9yRhqGtoB/ZTT2CzGGd+MJJkefIUBZal7l2DMHXhDhTP+X+V8qKz+SNaAEXmpc6+1mH2r3Tt3ervw25pGHI5bOTsgvcHTxeI/Ao5IBioKFY2/0W0aPIWHUlNgoA0/sQb0IX/2PLj/Kl1853s2Il0nCVF51nKK/PFYiFfRDB+lGTiERc+ecnJJwepR9H6b8TM2AXkTv0csKmLtL7SHz0TjXG/5TnejdKW8ioKFd4J DR0r0mxD i6LVw8jjpHzXlbD7mAm1BCLLTAAFAupZps6AgBxb7EeFk/0N/6IAsj5IcuM3XFNDzIeUaY2TiFzq/nalMrlqJhlv1hmMK1MHARXCjOe5xDt7xSQhJSgaeZJQq+6BqxcaoKg/COoOAUXeCgaf3wEm8rC4A2uqEaMyIxUwD5j6TYLJRn75a7KmQA+XCLYHMSoQaCpECrPJwXMkPFM2hUFAxCMyElATsrMSTLaOuthVZVnnFd8F95RNgwA58WxEgnwynd71Zw9slTqL17HSMHPnXFlNQzHrifFM6hXePHhmZNXiIlPwHFZqsaqn4a7LHqAB5lJt+M50RcHapm3A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 17, 2025 at 05:43:44PM +0200, David Hildenbrand wrote: > Let's introduce vm_normal_page_pud(), which ends up being fairly simple > because of our new common helpers and there not being a PUD-sized zero > folio. > > Use vm_normal_page_pud() in folio_walk_start() to resolve a TODO, > structuring the code like the other (pmd/pte) cases. Defer > introducing vm_normal_folio_pud() until really used. > > Signed-off-by: David Hildenbrand Ignoring the parameter stuff, I'd make the same comment I made wrt. vm_normal_page_pmd, but LGTM. Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs