From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D01A2C7115C for ; Wed, 25 Jun 2025 07:55:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 710666B00C4; Wed, 25 Jun 2025 03:55:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6C0C06B00C5; Wed, 25 Jun 2025 03:55:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 588D36B00C6; Wed, 25 Jun 2025 03:55:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 466F96B00C4 for ; Wed, 25 Jun 2025 03:55:04 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E65971A19D8 for ; Wed, 25 Jun 2025 07:55:03 +0000 (UTC) X-FDA: 83593162086.26.5BF553E Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf28.hostedemail.com (Postfix) with ESMTP id C509BC0009 for ; Wed, 25 Jun 2025 07:55:01 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=SjrdOX2s; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=bUX5vEHY; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=SjrdOX2s; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=bUX5vEHY; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750838102; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jr2DJml86CkvLgTSl6zdjggn2/vW3DsZt/BTczAFHQo=; b=TBcwS2CmVQmTbUjzrqjpNEj8uxW+oSmKXRKCMnv7LvIGumT1f+sgsG91qmOkKW81sMbi7S Mv3YKaZCCXJ2zRXS+yfXg6W6d9u0pJVfeUEYPSILA4DGy51YDeSi4PB5PPn8SnIVHS7b3n jF93uHdTfvE9Pwl9iFE9n50MV2hLRqA= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=SjrdOX2s; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=bUX5vEHY; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=SjrdOX2s; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=bUX5vEHY; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750838102; a=rsa-sha256; cv=none; b=2XEHy6qHsM0pWyPj12NO/xNeGD4ntDDZ8IUaySleQUc5UTS/aShT5eDwYWDOfIB0XnHo+9 3uNkx0j6Dee7vATVbu6DMLkj0x+Xgeg6gQVR5zNrP1csO1D4dx/H2xNpuB52UbwV32aSQF +NPLDLbgbDFSJgbayg6oPqzq+tLWfy8= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 49BF42116F; Wed, 25 Jun 2025 07:55:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750838100; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jr2DJml86CkvLgTSl6zdjggn2/vW3DsZt/BTczAFHQo=; b=SjrdOX2sDdKgblCBMUVnqceNrMIMGh7OJX/oXKNA/dYbvqUlTFLFP+jpNUZipabqT6lRUs NEn6D98AlAdhUOLJQJuROjeIfyitgRIrk2YpCJYVqqWiL5h9xC9uiOOT3WX7JiFJrAtEhY IzZ4nYNYrfDGb7c1Ur8Soy88nOFnBE0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750838100; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jr2DJml86CkvLgTSl6zdjggn2/vW3DsZt/BTczAFHQo=; b=bUX5vEHYowEIL50emhbwwFb2Vo3qPhtmEGVKJWUo61ycvBCV2bTYEWcMcHt/VS2qmRMSLI alj/+MB1POrNwdAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750838100; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jr2DJml86CkvLgTSl6zdjggn2/vW3DsZt/BTczAFHQo=; b=SjrdOX2sDdKgblCBMUVnqceNrMIMGh7OJX/oXKNA/dYbvqUlTFLFP+jpNUZipabqT6lRUs NEn6D98AlAdhUOLJQJuROjeIfyitgRIrk2YpCJYVqqWiL5h9xC9uiOOT3WX7JiFJrAtEhY IzZ4nYNYrfDGb7c1Ur8Soy88nOFnBE0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750838100; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jr2DJml86CkvLgTSl6zdjggn2/vW3DsZt/BTczAFHQo=; b=bUX5vEHYowEIL50emhbwwFb2Vo3qPhtmEGVKJWUo61ycvBCV2bTYEWcMcHt/VS2qmRMSLI alj/+MB1POrNwdAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id CDAA013301; Wed, 25 Jun 2025 07:54:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 5MYqL1KrW2gjEwAAD6G6ig (envelope-from ); Wed, 25 Jun 2025 07:54:58 +0000 Date: Wed, 25 Jun 2025 09:54:57 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Alistair Popple , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Zi Yan , Baolin Wang , Lorenzo Stoakes , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato Subject: Re: [PATCH RFC 01/14] mm/memory: drop highest_memmap_pfn sanity check in vm_normal_page() Message-ID: References: <20250617154345.2494405-1-david@redhat.com> <20250617154345.2494405-2-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: C509BC0009 X-Stat-Signature: nisq3awq5rqu667n5uydnbkh9e3qeohf X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1750838101-144974 X-HE-Meta: U2FsdGVkX18Y41gM/krDmVC3fc8mA0F/CFQEn6iogi6mw4CYxE1mBcrKEfROhYP0Fh3jEZC03wfp6S20/HrTs5fY5AmYZ2DAIbgGO6PkKBzI1p+ETfLBRvzKTZ+y7K2J6rTlsBLiuM3Eyrw3jQIP1yEb+ElYM44h8PQQwaFt0WhPeG7z7o22+r5epFZExVbJjpdfauwrU014oDkCe2sLWWLt6nbnANb7vHLedqqPcb0iXkeeJYLG9czQq+u8FAApPY+YZmYfgKBgJesCzHW77jgPSPhS8SAHvn7FHpPHMf1iJTx083GQ06g0Z9aJMOYngZ30k4x1MMIJ93oDiIntpcSn9zSzttkMOBaSa8fk+ttqzsu8c1tbUB2E1BiQsHGLvrRcB4SntUNrHrawmT3eleVp6W8O0UK2fBmTC0oY9SrNWP8hs69UCBRqi7b+HuE25opZ8ImULsi94flCvdP+u+PrBdJaxh5h9PPxB6rOjHWsLCQ58RFAS6/HNXMgrzY8E7ocb3WS2gpRp8x7uD7X10tuqNeU+2VN8bi3jJxIsA4HoMWoVHEEjtNYD/hgu8FS1Sm6xyx4pqPobA9QWbxhKsVKFEpZKLWURAbx6r4Mt7ByrNZFAh9hLqjhPD6DvEPHXf5zxs3/MosyUI7XyA7q+PeoTELZCZMvHekDuICroEvtXjAuZqSHLoof5fiP5mvlAvThPbc7r7+CD7L8yGuxvHu+8gKRmcO50JvuHG6Rrd7i07ApDJ5gNh80O6tf7S4Xbp+JlmOQ42WChkPxjKLbv/QcC6o4Y0sWYiiAZrEVmwdkv87ZCOWJSEOjFe6guLDvG2NywAbmNwxET9Y1+aGBOW9XHmW+/FAXbeKRqrC6VHXSNFAMWORKDussXTfdqPjHaAS9aIn4gQKT8TcsZauY6gwPV0c+iIYPsaWq3qxLNwZvIeLGW1EdTXdFnDfIOwVTUt+obm/8bajcetqkH6J cKDC/GzA mopdDOLUFwRpWVnAJM/SfOF06F6uNGl6kwpOd0zr0mQLNKtRJNAdue/PPnf4h5WDScVLW243gqJ9JlxhwMmudZ0qdatlrL2kd9sO8E1j2K1Bra6cF6uqOvhgDvc/OOnF75KgLm3MA+NgIYR3qPYVU8oN4IBCT8N02YHUzQGIp+0ddYU/u/R4yQ0/Lh73h/HxujurcTHoZxGpnujSnw9JewqAac5lhW7PBzSp06ueAtD+fFEcdtp9tBxZsxDmtei1v+THm/zRHZosnI0x7zRbFQYt/IcxHzEugTw8ReIkDXrhiJ9VKPZeWXY73EA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 23, 2025 at 04:04:01PM +0200, David Hildenbrand wrote: > Hi Oscar, Hi David, > > > I'm confused, I'm missing something here. > > Before this change we would return NULL if e.g: pfn > highest_memmap_pfn, but > > now we just print the warning and call pfn_to_page() anyway. > > AFAIK, pfn_to_page() doesn't return NULL? > > You're missing that vm_normal_page_pmd() was created as a copy from > vm_normal_page() [history of the sanity check above], but as we don't have > (and shouldn't have ...) print_bad_pmd(), we made the code look like this > would be something that can just happen. Ok I see. > > " > Do the same in vm_normal_page_pmd(), where we don't even report a > problem at all ... > " > > So we made something that should never happen a runtime sanity check without > ever reporting a problem ... all clear now, thanks :-) -- Oscar Salvador SUSE Labs