From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 105AAC77B7C for ; Wed, 25 Jun 2025 08:17:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9F9D6B00B5; Wed, 25 Jun 2025 04:17:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A48866B00B6; Wed, 25 Jun 2025 04:17:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 937D86B00B7; Wed, 25 Jun 2025 04:17:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7D2EE6B00B5 for ; Wed, 25 Jun 2025 04:17:44 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 40A4C141AAC for ; Wed, 25 Jun 2025 08:17:44 +0000 (UTC) X-FDA: 83593219248.09.5BC1C46 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf07.hostedemail.com (Postfix) with ESMTP id 1F1F94000B for ; Wed, 25 Jun 2025 08:17:41 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Q55K0RB8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=E3mgLJH3; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Q55K0RB8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=E3mgLJH3; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf07.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750839462; a=rsa-sha256; cv=none; b=ci3rt7hpo+o0T7N1JbQ8lWiLnG/UOUmnQIUjDujezjg4wCUV5s8wvDMZtUJJNsDOur/mib +d0NWixVIOp01ZtOQvgyTVGx7MfbKbIBllkjWjJupvZsdARuVjbfQgg1qYBkfxR6w9+ZJP dXaJP1QRUAgKhEcsLNMLan558dFaPVU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Q55K0RB8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=E3mgLJH3; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=Q55K0RB8; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=E3mgLJH3; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf07.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750839462; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N6h6TmZN5hM7wrd5vAf+hKIoaRPRzE8gRfNgOUlI21I=; b=EsFMg+qvwg1FDpYTAAMyD/g/8GwQdDOMU6IPjp+C1/JOQi1zSFxnIk/ZU/PoC/nelSLua6 hzmHYfowZLn0EpOAKdcpwM2JhW1eRaNIITdkn36Nl5nNDXkFm54NXwUENvWQfrPCtKEPtR eNfw9VdlxoMjXtej/hgLdloLVU2D2n0= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 774E02118F; Wed, 25 Jun 2025 08:17:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750839460; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=N6h6TmZN5hM7wrd5vAf+hKIoaRPRzE8gRfNgOUlI21I=; b=Q55K0RB8aZ1MZ3MqDUEosymYMztlMXygjqWMtS09PAf9zXxT+vQPaXZvowgh+Y7cQwpGoa vMKLbVH9MlvyhhsUC/DzyivxtnCB97w9bxSeVEbEEZCOjSWPCHLB01NJRWqcvpaDSTU+zz P5nxwEuhdoEGj1tEt+CSlZzsfK9w09s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750839460; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=N6h6TmZN5hM7wrd5vAf+hKIoaRPRzE8gRfNgOUlI21I=; b=E3mgLJH3XznDtoKDZyxl17SCQZWzuP3Hehoka7IIu7AEZQsxlWKlMjJGP8iSxk6psd/nIU mp6e2ZsfE4odCUDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750839460; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=N6h6TmZN5hM7wrd5vAf+hKIoaRPRzE8gRfNgOUlI21I=; b=Q55K0RB8aZ1MZ3MqDUEosymYMztlMXygjqWMtS09PAf9zXxT+vQPaXZvowgh+Y7cQwpGoa vMKLbVH9MlvyhhsUC/DzyivxtnCB97w9bxSeVEbEEZCOjSWPCHLB01NJRWqcvpaDSTU+zz P5nxwEuhdoEGj1tEt+CSlZzsfK9w09s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750839460; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=N6h6TmZN5hM7wrd5vAf+hKIoaRPRzE8gRfNgOUlI21I=; b=E3mgLJH3XznDtoKDZyxl17SCQZWzuP3Hehoka7IIu7AEZQsxlWKlMjJGP8iSxk6psd/nIU mp6e2ZsfE4odCUDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id EFCC613301; Wed, 25 Jun 2025 08:17:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id G7nNN6KwW2hgGgAAD6G6ig (envelope-from ); Wed, 25 Jun 2025 08:17:38 +0000 Date: Wed, 25 Jun 2025 10:17:33 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Alistair Popple , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Zi Yan , Baolin Wang , Lorenzo Stoakes , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato Subject: Re: [PATCH RFC 06/14] mm/huge_memory: support huge zero folio in vmf_insert_folio_pmd() Message-ID: References: <20250617154345.2494405-1-david@redhat.com> <20250617154345.2494405-7-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 1F1F94000B X-Rspamd-Server: rspam10 X-Stat-Signature: za1iptiwcc335kasdtscp6pxktck9fxw X-HE-Tag: 1750839461-360713 X-HE-Meta: U2FsdGVkX19fj72Tnlw3SZEc8NnQat2tuHFhk9PPH7/ixhRybx70ENfD3nhchG4mRSMCHp+XAbsV21kvUj6jeGtCaMvt07KSqixWZSNe5NF+dnNt7ET5qR8GWuCsDH53Ca0vjfpIcFHE/Ai9DXYqOIjeAyzV6rywu/qPs3pUen8OwbglbDKr58dE/FccO6gS7O0drEALQb3/1alrXITaZUuALlb+aHpwbes4+Po3cXW/XayfE8kAYR8Hx8yU5svB+wOpJrGpHBAhSOQ1wtZQYkEZMW7wDZYLckGwaUv5ZxJfGnjEhu3EB8jr8boIhMIEwMsl24tmiMmCk5uk6ZqVTBJsUe9ycjInyIED5ZtpYz/T5DkkDLWtxR5FqZSOeWKkC1GwROrE+jNEyzqMl/x/M+wx39B3DxQqcqqVXI207oo3bRwPJiOXJmxXYKfg9lXBZK79sTIJwma2tiWE/5k3+ptE5UJ/iPfekQoVJdU9Mi/dL9UIP6eZUMNl6wD15zGH8lXKN2aN9vaxdyz9gVy34wn7wjOowW9r+/VKtDolEgINMwa+R3vdaQt7qExQJSeHFRAx5/k1hFIJrvg6sxGOmG8V4/NMjeVHCfhI3BC6GWFrbGp1fkhxjEhgJB09EalttOl8vjXJ+jPB4M+VwS956n3MCbkEZzGf7STmSw5k9lVLs0yybMbaQNkS/mYfsEoIsCA1juh/9xGUVSd7ZUHJdxt0WH1KtCL/ZN/bTQe4+5yweFb98k5dJoKZvjUO/VOXPKZ8AgghVF+q1atCLxnWag+euq9F9QseBjAS7sLK+mh32qIMirBh5H+35niTKqrv5eZOR1mv64rEwEatw+a+qkSHXHyyOcmkhD5Esul1l6FGKUOvmjD7s6ZeByZ5Xpz85F1lUA+pzQRN3UR1ELypufhYRGbGCmpWMbonaJpow/1QRCnN+0701WZdOZ49eWsDpSkrKzAyhEwsTSY7C1v hps3cDCe wnTlsffKi1HVNxQxfsyrsTWW504pGIJG1dy14TI0UPcIMzpYo91ilFgt5/iknJunj40glsFO5/jZ+VPkmSJWkAaWUu+3OB3asp7p/gJsPYg1NKLUeRpQleYrhXEGLOddq6Wu7gP+R+e28AGCPyCVzvi1uigE7cMFaNFCBS5hsfuNZTtGt+XjKTujBDgqcLiwhf/21iInnT4cSPVb3IdI/aXaYxCE3uM+8IHLpimviFkqVlVmjJrvO+f6RKuhDuqGCPj9q+2whK9g6iFRijFcVxqwgM8zY6FFMv8BjkpotS5524dezo+rteBFk8sDgYqqCjBgy6DwRyZans2A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 25, 2025 at 10:15:22AM +0200, Oscar Salvador wrote: > On Tue, Jun 17, 2025 at 05:43:37PM +0200, David Hildenbrand wrote: > > Just like we do for vmf_insert_page_mkwrite() -> ... -> > > insert_page_into_pte_locked(), support the huge zero folio. > > > > Signed-off-by: David Hildenbrand > > insert_page_into_pte_locked() creates a special pte in case it finds the > zero folio while insert_pmd() doesn't. > I know that we didn't want to create special mappings for normal refcount folios > but this seems inconsistent? I'm pretty sure there's a reason but could you > elaborate on that? Heh, I should have checked further. I see that happening on patch#8. -- Oscar Salvador SUSE Labs