From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9D8CC7115C for ; Wed, 25 Jun 2025 13:12:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 82C756B00A0; Wed, 25 Jun 2025 09:12:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DD4B6B00A1; Wed, 25 Jun 2025 09:12:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 655D46B00CE; Wed, 25 Jun 2025 09:12:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4CE946B00A0 for ; Wed, 25 Jun 2025 09:12:59 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6219D10312F for ; Wed, 25 Jun 2025 13:12:58 +0000 (UTC) X-FDA: 83593963236.23.E359F01 Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) by imf22.hostedemail.com (Postfix) with ESMTP id 3DD5CC000E for ; Wed, 25 Jun 2025 13:12:56 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gz15Vh7o; spf=pass (imf22.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.219.49 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750857176; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O7XEAeABBEPfH4dacoEICW2H1x2av1UXnkGOMgIKze4=; b=NpMGgXlcF/wjFJ5flOpyyZGcVagh/yT7ZgT0zGnjh7PYAH7vV0Fnj0LStrEPioM0svKjRz 0F2mQB7cyNwgZfm65HW9fvBeoTmn0A0fj29888b4OEqZW1h1bJs54+LxvUYSspVnPvnZH9 ZPRpfn0x09PtoyDjqSdqevhd4/tPIto= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750857176; a=rsa-sha256; cv=none; b=T1aHNr7FM5Aa7e7TqQxl7reF983nAI5YAymNEMKZOP6qOqIhF7v0gc3rOKrT0KFnyOAUkd ld0Xo3gRO3vTWCkuv4TVKChXVVVatfbxXYKP17pPaQQbp/pZsxtSsshfDWlRn2G5jgvys3 RPY2sLWL/BFSffksJ0XUehdtus5T1S0= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gz15Vh7o; spf=pass (imf22.hostedemail.com: domain of boqun.feng@gmail.com designates 209.85.219.49 as permitted sender) smtp.mailfrom=boqun.feng@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-6face1d58dcso23567516d6.2 for ; Wed, 25 Jun 2025 06:12:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750857175; x=1751461975; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=O7XEAeABBEPfH4dacoEICW2H1x2av1UXnkGOMgIKze4=; b=gz15Vh7okFJuOTtKQXA0viGWmugMjMDNUREqC0ylVOBttNPsHJv8ikHoYQxfXTjj6z 0gAu80rBmIWv0Nzzjg6LxBc6pmxf1HlxzASZD3WX9aUDcz+/42nJEFIIGFo2Zg/4Wpih SnCKs8E0q4hvVXWj/GmeU3hvIrPSFF2R40We3/gIdJg0oq9U+8VyetzdE0+wHTQBc2Cm eeKRZgCLoyMURqfIwNHcd0ynscVX8PA9fA8xRqyeaxjobMl9EM+MKrw7tqDlm+hRxkb6 9IERnEvyAZpe5nCZksv80ExLwvk0WAJIEek9+SZPOTZ/vHhREoksbW+KWAdeFr3NQ6W3 AL8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750857175; x=1751461975; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O7XEAeABBEPfH4dacoEICW2H1x2av1UXnkGOMgIKze4=; b=v9EK1e3ckTpcOzS91cCFT7kzAfh9be501bRgeiUJMPS9HH4gQmYMTH0AIv33Z8ZFsC By1UmlizyRdxz5mBf1FTbFEpOOJwX6JA7yH5P6l3W2F6oOp38jKK8BCDG0lOy44RW61u tOMniUsmTDZjHQbdgm7CKNI8OuJv1S8/lc3COek+cb7SHfX01qbDdQH9I2HlcW124Azi oAigG8VCBEZwU5aby7mfgmyZz+4KYzWGIAeSqEQzxxXKfDWltyV2ObNH7br1kN6VTqZo Eo1Yiu/YR3MCR0HN9Y+ZKH2OtDMBqrnRow+EhPGiHv6+K3+37g8C86OfZK3H0Nfjnr2P wa/Q== X-Gm-Message-State: AOJu0YzKkrhwKKf6lMFE5FuBeufKL21v59qgvr5w8yPE5Oc8IX7NJLyS yuKW3QJe1q6Ana1ZZXGE0Mv0xAoLiCgBVotX+cGPexzyVs4cW9/JBiFN X-Gm-Gg: ASbGnct79QVSvXn2QOrIx8KKEW8RJ/chSFpNj5yPDwxoTyhr5fQ5+O5bTZsJuYiD9La b0Rif3xlcBeWv5uu3or/xSIz9ZOh/4QOznyxLHbnJ5sPnjbTGK3YPA0Ld01EHPKMuSehxZwxu/b WiY5oCfeoYnenFasj5fs8vpUxmgXEN2UX/Mwezf/5GPsGLCoFszbQPE3cuzBhsZPpZS2B6IJARD NnJccL0BO45YD2bnmxgnMU84f6VTj09DEytiaEfMCQXuHpdBJq3x2TnX8L569cG9jY3efNsFTjP et4nZopCMGdV4Wtz2XR0lSzW+K6W0RRW27vHYGWbdr11+w5GH0oL6zasfnDjDaPb4/sObhSDz2N Aw59bwJ82hdk7dGyJglpzplSjcz2tCRYyZu4U9jCIQ6U1Q5FvZMih X-Google-Smtp-Source: AGHT+IEKl2vX+++pejg4hzGpoabiaPqmms6wmMMNyFuJ2l2VDlniu7fykiwNfg3L8xSXuDe+8kTAOQ== X-Received: by 2002:a05:6214:224a:b0:6fd:5e46:dbc with SMTP id 6a1803df08f44-6fd5ef93451mr41870326d6.33.1750857174972; Wed, 25 Jun 2025 06:12:54 -0700 (PDT) Received: from fauth-a2-smtp.messagingengine.com (fauth-a2-smtp.messagingengine.com. [103.168.172.201]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6fd09460830sm67855996d6.51.2025.06.25.06.12.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 06:12:54 -0700 (PDT) Received: from phl-compute-11.internal (phl-compute-11.phl.internal [10.202.2.51]) by mailfauth.phl.internal (Postfix) with ESMTP id C34BCF40066; Wed, 25 Jun 2025 09:12:53 -0400 (EDT) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-11.internal (MEProxy); Wed, 25 Jun 2025 09:12:53 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddvgddvvdekiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeeuohhquhhnucfh vghnghcuoegsohhquhhnrdhfvghnghesghhmrghilhdrtghomheqnecuggftrfgrthhtvg hrnhephedugfduffffteeutddvheeuveelvdfhleelieevtdeguefhgeeuveeiudffiedv necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsghoqh hunhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqieelvdeghedtieegqddu jeejkeehheehvddqsghoqhhunhdrfhgvnhhgpeepghhmrghilhdrtghomhesfhhigihmvg drnhgrmhgvpdhnsggprhgtphhtthhopeelpdhmohguvgepshhmthhpohhuthdprhgtphht thhopehvihhtrghlhidrfihoohhlsehkohhnshhulhhkohdrshgvpdhrtghpthhtoheplh hinhhugidqmhhmsehkvhgrtghkrdhorhhgpdhrtghpthhtoheprghkphhmsehlihhnuhig qdhfohhunhgurghtihhonhdrohhrghdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlh esvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehurhgviihkihesghhmrghi lhdrtghomhdprhgtphhtthhopegurghkrheskhgvrhhnvghlrdhorhhgpdhrtghpthhtoh eprghlihgtvghrhihhlhesghhoohhglhgvrdgtohhmpdhrtghpthhtoheprhhushhtqdhf ohhrqdhlihhnuhigsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdhrtghpthhtohepsghoqh hunhesfhhigihmvgdrnhgrmhgv X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 25 Jun 2025 09:12:53 -0400 (EDT) Date: Wed, 25 Jun 2025 06:12:52 -0700 From: Boqun Feng To: Vitaly Wool Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Uladzislau Rezki , Danilo Krummrich , Alice Ryhl , rust-for-linux@vger.kernel.org Subject: Re: [PATCH v3 2/2] rust: support align and NUMA id in allocations Message-ID: References: <20250625062917.3379804-1-vitaly.wool@konsulko.se> <20250625063026.3379921-1-vitaly.wool@konsulko.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250625063026.3379921-1-vitaly.wool@konsulko.se> X-Rspamd-Queue-Id: 3DD5CC000E X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: zws3ygc6u3i9sfi4spqb5pt4u755o98h X-HE-Tag: 1750857176-188198 X-HE-Meta: U2FsdGVkX1+osNLm0SJzXiqqiQt8jK+rgZuFcgWYRAUerPInBjtlKTzWGnNLx6knC+noOTNCASn6V1ROCKPfSnvI+aykLzylWR+ixgLiNOcgcEFwfj/kclgGCoKFHqDKyhUBpepI3/YpSi+eZ+BmbASmK6pzOzrVob7mbLN7sJK+o15uZGBuFPsJ0MhypGE8h4iCwqMxHHhFAzbPh20z1fG1flZZoxrwCZkHeBLUnu2EMNW8v/aJyD5N3IwoX0n3H5BltscgohjcieBoWT1G4lESdFl4XJ5s6WimmJK2gyFR7hCEdKx1R7RLxaZKxj5D9rnS4KNflIJAeWUSt5O7CH/IBMTtdJYsXUZ2c3T1MfYdcUpRBRqUCMyomfGtYti/nhr3vAExQ9j/Mq46RbqV3HTUtGz92la8Tlxw3FugM8XlLFqavtnWe+tXDYXuM71KAD66jwnHiVoTqGUlHFx7ZI3gQ9NBqVLdSre5taix1pgoqUAGQu+nWt8wPnUJibrVqZTJmI/u9xEqwfdK/YCf5jRqFQFEUijaXmOzxkGiD1W3ST/2fZ7IZkYWSWv9E6+psKmFsfjbJjKC6wcurxWbNjdfHyBONtO3tY9iUQOMm7H/nbdEtHapPsOM+cNRZIOckwQwhZX+K2oOxGtTxxxHu8wXXni0B5LGgKCjUDoayc6C1oAg86itZ+IkRwc8oRvvlmcnsVNoh4+69oqmrH1b4DazffJtA20tj+iK7zxJLtku9IYYMNLPDM157v/VRwCShpdF5os9X0atVF24ZJpNUq6XFoWLSwtv+ZMii1su7MQjlOpIgoiB+uTiXP0kSSSpKvopZu7lco27W9rzz5++h/uUCAOsvpN+W49302qcKIMmQ6W9M7Vt8nXVhO3J62G4ai9HrDFAIkwn5SERN2ba3pvJ2m2RJd30pMqpXG+fs3hVhwbkT7EMcttXQmFbU1JPDVJd+wzkfR7+tcX2/bH M6BA9nOA jK701RIG65EQhxND8LvIy8LlsWNVYh2bmHMUVKh1KGCuUCTCq0zjR7YiFyNuyIW7MFNmYfjg2IJg7td/i7i6lqp7OH7cOd4eKzwQAA5GeVosb0r78s7TTpkI8L8fkfg4AdP+I247bT193YNF1kwNQ+fA98snO5wHOVBCUKL8g1ScTf/JREo/NrMIfAq3Z+OQ/zjCRgj1bzi3AZfnKM1CaZ7/WxAAMR0k2kl/PMcpDmtNXElvPsgOOilzSlc4BUw493VM1RNg/IV3FgOAkHjiivJhUyOnN6+E69oBx4U99sVL6XKtKBC7bw105L4ohYBrO9dLggV+3o2/g+CFrPUbLApbmEECVRNLz1N8NVUHf4HvND3kSR7bA9iMwPgm/r8jZ3o01dI9TkEWQ16hU5hAef+wZ3RPZKYvNd8sIaCD6p0ippmOAewx7Vw35crnIkAH7KLDW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 25, 2025 at 08:30:26AM +0200, Vitaly Wool wrote: [...] > @@ -151,16 +159,11 @@ unsafe fn realloc( > layout: Layout, > old_layout: Layout, > flags: Flags, > + nid: Option, > ) -> Result, AllocError> { > - // TODO: Support alignments larger than PAGE_SIZE. Thanks a lot for doing this! While you're at it, maybe we can add a few tests for various alignments of allocation? I'm thinking: #[repr(align(65536)] pub struct Test64k { a: i32 } #[kunit_tests(rust_vbox)] mod tests { #[test] fn large_allocation() -> Result { // Better use `new_uninit()` to avoid allocation on the stack. let x = VBox::::new_uninit(...)?; assert!(x.as_ptr().addr() & (kernel::sizes::SZ_64K - 1) == 0); } } Thoughts? Regards, Boqun > - if layout.align() > bindings::PAGE_SIZE { > - pr_warn!("Vmalloc does not support alignments larger than PAGE_SIZE yet.\n"); > - return Err(AllocError); > - } > - > // SAFETY: If not `None`, `ptr` is guaranteed to point to valid memory, which was previously > // allocated with this `Allocator`. > - unsafe { ReallocFunc::VREALLOC.call(ptr, layout, old_layout, flags) } > + unsafe { ReallocFunc::VREALLOC.call(ptr, layout, old_layout, flags, nid) } > } > } > [...]