From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E4F4C7EE30 for ; Wed, 25 Jun 2025 09:35:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13CD76B00A3; Wed, 25 Jun 2025 05:35:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0ED0F6B00A9; Wed, 25 Jun 2025 05:35:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ECFF36B00AB; Wed, 25 Jun 2025 05:35:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DA6196B00A3 for ; Wed, 25 Jun 2025 05:35:04 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7952C5E56A for ; Wed, 25 Jun 2025 09:35:04 +0000 (UTC) X-FDA: 83593414128.16.B09ED45 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf06.hostedemail.com (Postfix) with ESMTP id 4AFA8180009 for ; Wed, 25 Jun 2025 09:35:02 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="GPnNP10/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=aWa40d3L; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="GPnNP10/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=aWa40d3L; spf=pass (imf06.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750844102; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D9yD9bDvc4ttPN1JbIa1TTy9wP5vivopfbZOV9iRQ4o=; b=wdMa29TyUm3JmU7zu1C7Ot7ETUIyhGUZOpk1tDnvOfbfs3Ra3Q30q9Yl67qMvj3RyfQyv9 +pg8pjAdexL9R92mR2QGG8xVUaqHGR9COjgHsgKqODgM+oAyoiirKj9kEVDwol2l+tiPGk 33AhOdNM5QCnBJG5BRWRPfKtfRJeGDo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750844102; a=rsa-sha256; cv=none; b=lHQbyTpGrPpLcdEOkQGUceyp+iieZ+K1OAhzLuwQ/lurgChMnG7L0H8XMKtXyMkEsPm4WW bRDdT+BTGPGSgvBXL3EwvI1Ps9tvjl9FWHGAemQ7WaztEPfzx6LJNcyZWog0MDEXkBEmwu gGXGzrLZrm6p9vSNk0ttxwkqbT6fxzY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="GPnNP10/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=aWa40d3L; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="GPnNP10/"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=aWa40d3L; spf=pass (imf06.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D18E51F441; Wed, 25 Jun 2025 09:35:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750844100; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D9yD9bDvc4ttPN1JbIa1TTy9wP5vivopfbZOV9iRQ4o=; b=GPnNP10/8VxFC0xTPvnzcEmlYxnOcsmX+aAqnKYNgYu2cjsDWyMDW9Bs2Dx5hqdJRSzlPJ Yvq22aBwLZwTIeEuRO/rgPREPzOrW8UMGEYvP8USIsYJQRuXqrkyfmVsCsAhjDQhp7yyxd 9/mK7HUm/59/9/8BgnfhuFhHwLK0SsU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750844100; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D9yD9bDvc4ttPN1JbIa1TTy9wP5vivopfbZOV9iRQ4o=; b=aWa40d3L6ijqeA3155PROSbkBuA67JPZ2t4v0J9mFBwaqwu+0GbN8u6iE6pVjMcPyhPbF5 kvvblYRcQ/qKcMCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750844100; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D9yD9bDvc4ttPN1JbIa1TTy9wP5vivopfbZOV9iRQ4o=; b=GPnNP10/8VxFC0xTPvnzcEmlYxnOcsmX+aAqnKYNgYu2cjsDWyMDW9Bs2Dx5hqdJRSzlPJ Yvq22aBwLZwTIeEuRO/rgPREPzOrW8UMGEYvP8USIsYJQRuXqrkyfmVsCsAhjDQhp7yyxd 9/mK7HUm/59/9/8BgnfhuFhHwLK0SsU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750844100; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=D9yD9bDvc4ttPN1JbIa1TTy9wP5vivopfbZOV9iRQ4o=; b=aWa40d3L6ijqeA3155PROSbkBuA67JPZ2t4v0J9mFBwaqwu+0GbN8u6iE6pVjMcPyhPbF5 kvvblYRcQ/qKcMCw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3EE7B13485; Wed, 25 Jun 2025 09:34:59 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id SemZDMPCW2gENQAAD6G6ig (envelope-from ); Wed, 25 Jun 2025 09:34:59 +0000 Date: Wed, 25 Jun 2025 11:34:57 +0200 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, nvdimm@lists.linux.dev, Andrew Morton , Juergen Gross , Stefano Stabellini , Oleksandr Tyshchenko , Dan Williams , Alistair Popple , Matthew Wilcox , Jan Kara , Alexander Viro , Christian Brauner , Zi Yan , Baolin Wang , Lorenzo Stoakes , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , David Vrabel Subject: Re: [PATCH RFC 14/14] mm: rename vm_ops->find_special_page() to vm_ops->find_normal_page() Message-ID: References: <20250617154345.2494405-1-david@redhat.com> <20250617154345.2494405-15-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250617154345.2494405-15-david@redhat.com> X-Rspamd-Queue-Id: 4AFA8180009 X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: 9pbsykwwnj7cossmxiph464otqg9z9cw X-HE-Tag: 1750844102-202921 X-HE-Meta: U2FsdGVkX1/aRn+CR+tpQ+WL57GdZHJfc4pFa3wG5f11Yc6xK0yNDpVNfReMyQeaGyb6alrQEJ61Fokqn96qFZ7us+HRARIyl55+QrfAK5jTA6oLTFGvmKci89WH5sraqNOrq5KRcHqMpWegjeqE7X1RW42u46eNmhpGg8SeKzrxc1nkI5f8JqXOy4FoPPHicN+rp7m+SNqVUmE8d4mduIy0h+nbFfIis79aDCs9cD6S4Csf0Sxnogp6wDdlWfnkH4VWs9s10IWnJ+Fag6hIbRNIw3NlyKAeNzPuuGD3ocmd3VLn6uJC27g8qFczHksGzsXKqNpvR8wWuVSXNul5B/+xsmkvxbMm8jZeeZj56ukQ2SLceKwU1mRWt00oI8P/dAiSh1r54fSWMoyaxcSuuusYX2SZ5nS4/JPVbnP30CZMfhdSNejar7lTL1urWtCQYrdD54fKuxwEeG/jnGgR0BfvIMKWzMQLVkpNkQ2cKo9zkzkvHIqQ//jCrPR5cTo5964nuoGwhsTWFAEePo3lIUYBlf0esz92TLkDd6IudCQIWXWsi9lFBOLGMlvYcSPCK7PmqVN6g7Joj+xqzrtnw3Ijo7ivIphiVRsILxbRQekFgxqrlQcHg6lFZLYPgZK0j9FiNmCEQ4a305E+8T2LKO9oikJFUI0u4fmR4oqe0Fj2dzDcb0Sj05cldG3xc4AvX+mdWUi/mAoEnq8EN6uNjT3poKoC3EZq0wTFg+cjs82lef6tsBNYSp2Tmief6gJsT9MGetmMvyDqRmp4gFRIbdWDGXE24oCGdKkchKl6+b0hXLhsBuvfzY95eqh5DF9GNgec7Mn5pUFwXcX45iB/fT2PW+1HcbSHj9Qu4VNdky8mOLZjcvGi0p0+/fOSlnBtpsM6vhLhB1WD0L14210tOkCa/D/I5sluNVy+z9R/vl3J9JwzS4LsJ/cYNyFt5JiajX4MpgjiK/u+v9cKLG+ OsYvnq+t XjDpqIk8YmD4GyaOuDn0oN/OUAi1osRhpunPRhiDWXciVggz2R7DDmW5nfTjCFocfrbi6+VLjEOJfNG3Gg4x3Vfd+AFNBg3uZs8nMilAnfnZMXmsSBi/Ajs7gaL+mOmDOWLT8o1sK37QOZCAqDTu5Vb3dPhKkyZ8w2Qbxr0/E1zlzpPtn8b7RNX2tZeat1i95VUVTd6P1btGv4gdR+LYjAInp5yr1TnaGXnxYUZsMdm3PSloPVBdmxX2EqVln+mZFD/eH1+gQ8lwnDLKs7uFMZeSoiWKtp0B7Rm89mkiJkULI5qDEecWjzh1bbQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 17, 2025 at 05:43:45PM +0200, David Hildenbrand wrote: > ... and hide it behind a kconfig option. There is really no need for > any !xen code to perform this check. > > The naming is a bit off: we want to find the "normal" page when a PTE > was marked "special". So it's really not "finding a special" page. > > Improve the documentation, and add a comment in the code where XEN ends > up performing the pte_mkspecial() through a hypercall. More details can > be found in commit 923b2919e2c3 ("xen/gntdev: mark userspace PTEs as > special on x86 PV guests"). Looks good to me. Since this seems a "mistake" from the past we don't want to repeat, I wonder whether we could seal FIND_NORMAL_PAGE somehow, and scream if someone tries to enable it on !XEN environments. -- Oscar Salvador SUSE Labs