From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF25AC7EE30 for ; Wed, 25 Jun 2025 09:58:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81EAF6B00A2; Wed, 25 Jun 2025 05:58:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CF566B00C5; Wed, 25 Jun 2025 05:58:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BDF96B00C6; Wed, 25 Jun 2025 05:58:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5753C6B00A2 for ; Wed, 25 Jun 2025 05:58:09 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 1A4741233E4 for ; Wed, 25 Jun 2025 09:58:09 +0000 (UTC) X-FDA: 83593472298.15.79ADA4D Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf06.hostedemail.com (Postfix) with ESMTP id 20B04180002 for ; Wed, 25 Jun 2025 09:58:06 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nWdJ4nCo; spf=pass (imf06.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750845487; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/npfTZitxQengKYWb557F20/C27QpY8KDAC6He/PIuw=; b=OSCUiomZxKYK+AHhfwJGeSUxEdzC9Xvl7n0OPZoS9jJREd0d7BZDLmCXjH5vFAkUIrc1c2 P/++a8bqVIgQZz7C23DXtQ7S0bkcxDwobPoDcBhQ5AUQy2jFug5HPlyNB2i1EbbTDX6z+j 909lIkgVozIFsZCFRtJOViQ2MmRx2yg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750845487; a=rsa-sha256; cv=none; b=hOdUiuwt62+f0px2pf68fTjP4xK9gbN8180fPi/fzzhx64PxYNh8pK5HTf7chbAi7BoTxG 05T42JMKuAqMj/SJg10uOdCJ1IwcxGrMyO/GBi9vxtkpbv8PjYQ4g6UDhTDZMFgLvODSbC Th7DqDKqfNQ5hJwRYYA22rTrEg0iAB4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=nWdJ4nCo; spf=pass (imf06.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-32b3c292bb4so11620401fa.1 for ; Wed, 25 Jun 2025 02:58:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750845485; x=1751450285; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=/npfTZitxQengKYWb557F20/C27QpY8KDAC6He/PIuw=; b=nWdJ4nCoLAs48Wr3X+Rd8N9yNQfoGZV84Ztts6mQh43pGf8l+8nL3om/6ZhdoVqYfq KSThH3Ks3vdpo/BVVX3nBa2p8Cll4Oa+68zLVU0WpWpPyrtro1jShw13Zz1T26kVP3HH IOJQNYRS0qK4nevX96LQoEs6gHk6sSe7UWWrrS3Wks+aYtMfVwpidR5u1ASDr99pK82g BwAwKlXG85Ytq04q3v3vT0NFQJYUNY+CYDaMaBxywhl0VAy3f54IFgZQN3WlJ8c4+89k g4rzirSzb4g2E/hr2CVbro4lv6+I891v+OdnPNYkFDUUz9nxBI6QBH92NeD6D756SLY8 FoAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750845485; x=1751450285; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/npfTZitxQengKYWb557F20/C27QpY8KDAC6He/PIuw=; b=MYr7kvv83TOUPuC10yMhS4mDd6rd7fov4cv9kX2khMf1BThzEFWjwHG8zeBgu+DUhr mKleLnB4rOg1HZ9KDt7yiBcIZdzscQV5KtwlN1MOnxT26OEZ9hIEDVn8gZkWeasMeqXx ws4gy86q8VOtuCs8WHHd1j8yGjjlq156PhQg9yC1K3WEwrOmYlXRoeIlvR8yFQhdaa9e rDf4Njahgp4Nz9hXMJC0MOVgavfo2f0TkTqyYAvdFaoX27w5Ay/1//SsJi9wEFMCkV3V lKzOPlxwXKFfS9vzZo501z2fhZ+M5EKBoIRDMA92br5RzBg1c9WyzHaUAzQARitFCOxO 1heQ== X-Gm-Message-State: AOJu0Yxx3r9Orxq0MNwaMvbnXisDTDHnwURUOSRNk5S8R8p+YQB6wRuy xtMvHv9JvvMZVUWrIIW0mgW7YsTDB2WqtUwa+IaFE8PVxlZRWmShvTI2 X-Gm-Gg: ASbGncsN/UzWUdrl9QHgBjJZo1I0oQO248hbhqH/tVm4YKVJ8vQw/byzOkjNWxDYwOY m1tN/04eYWhvZwSjYrbikf9DSBQSRXVi0F0CvrNoo+trkus4G+n4ejpvXTUhtswLB3P+QHzylXH sGwuTtzxW252wXDRrzwLt7VqHFO7C1mxOZ1nZvyzSvZSOURL7qBp8ZtKjiE1OtY3P7Qm7yGFDOG fPi8pSn7tpSWuGyv337LqOL4M0E5Ffag282NaujQfd7+7bBaB8EhWjW0pkEn1qd9zlbVXHbKerw z0nc2KuZI21Kww1cttMsisqNVUE6A3mZmPJAGSIq9nXQ55tey7uJDF7T8dUkYermomTKOyKNeRW w1g93GCQq6Es= X-Google-Smtp-Source: AGHT+IEuUl0LPKYIwxBVpX0GsbU51O5maIG7RCvFUWc1QTpSlMeggPoilMZieami+WVdxey7n6oTZg== X-Received: by 2002:a2e:bc1c:0:b0:32b:719f:1260 with SMTP id 38308e7fff4ca-32cc64b7cadmr6937511fa.9.1750845484907; Wed, 25 Jun 2025 02:58:04 -0700 (PDT) Received: from pc636 (host-95-203-1-180.mobileonline.telia.com. [95.203.1.180]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-32b97f794adsm19232261fa.26.2025.06.25.02.58.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jun 2025 02:58:04 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Wed, 25 Jun 2025 11:58:02 +0200 To: Vitaly Wool Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Uladzislau Rezki , Danilo Krummrich , Alice Ryhl , rust-for-linux@vger.kernel.org Subject: Re: [PATCH v3 1/2] mm/vmalloc: allow to set node and align in vrealloc Message-ID: References: <20250625062917.3379804-1-vitaly.wool@konsulko.se> <20250625063013.3379896-1-vitaly.wool@konsulko.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250625063013.3379896-1-vitaly.wool@konsulko.se> X-Rspamd-Queue-Id: 20B04180002 X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: 7ck1qeu4uw5nozuzx7assrfsfrk5y3xf X-HE-Tag: 1750845486-683870 X-HE-Meta: U2FsdGVkX1838dqsoR7kR8ko5z1AfS04tFQY27GEzbxUvQnpfnu1Vk6lsuI8h3N8m4haFRjziVSK8l1cmXg8Bh4wiIuA1NMCjhtnGH2tmbrvyYzbsjDYoXQulKvPgqEFqzvteOw25lAYwEUyZnn/afqcad6UQElTuEvqp1mvAR2PsevL+3pLEY0Q8zPwqG5XuLv77KKW4pri3pozVL8R/Qgg4/YuWJkyum9at13igwpslEsKMUd40nDlL8WwVIkd+AS6t+4+dqJyDsJnwJqsatJAK4KND1J4NL27ka8fpOoH9CacuL4zCZdTm2FOBoxxbZWCzWWMgz78s4Cff7wiUlaty+RCyP4BYNzhd3dJPc3Yw+hrIuVhsXDk35ub+p5YyA9PWQvWMrwlDsJUihZ0u6HJk9HexAsBjs58qSkpowv68GiIjI8+4K+zqMR7KUowSaP9B3I3WKhRkJLpCyG1kBrzSfBetyWHPJe1OK4UpetQRg7UVnlN0R9FMYXBTY3N1rLCIP66ZBZFAhLCRma/hEgls246FRvyHNyJHovt+nIYAH7M9aIhekZI4uTgFd/KmopO/8XOfj2svekYfpRg/lYseE/ztHtpmy4MadJOSboG97ladaFPGDinb523lE/lXfKIYDSvc/iCHKXDPCuwsUHMCZMreehLtdll2qVhz/uSBdPq/4F3tINVdNM15Rh0yBIWqNXZHE4FjALWSXOHSL5HUwdMW+IbV1t7LV3LGePP7CkJRT2ZUS/tXVmfetht02GbGuse36U8N20SeTaMOpG5L7BbrKoX1GI17awm2doE4F48flMH9ks+eCgp3rJ5/97Y40EbMYTwHevmDxjlGUXD5vzXy/lgnH4wKd+8G/oJi+SygsB26SgsaplTaFI2gupa0v5YC8gL6wMvSZRhW60CRJbw56e3LLmCAmrgvfKqAcAHK1Jr4crurAsRXdCoU6ay2fiKSTlwyZBAlB/ NukeAzjx JwCTlX6ob6RD8JF/Nhw/38GKqffeowsq3qAz44G6pNDaxYmtgLYtxbIUbAzRQExC7yJUXmDgvyLUVupY2bH8qRAaHUAogEJRSrh76N6RNWft2SyWNsDWad6Nd+2Fo3PUtYZUmo+KtlFD0ag1QZG9yFOP1AoVgAd2TspA3Gv95njyrBcbAHjMTpnNj3+/KWd+qeXG/pjpLXaYTPBXuTWGcLR4vO9JNmA38p7Jd9Zm/QnyDqlfHELxh5Qhb7BjRysjFSeOg6FQ/TasrCJGryT0fzf4Z6ogOV3syImRu2IXPudzVu1pJmLpVQe7vloYA84yi4VHjopWUblrwdIB291kKDAEOBM2zhd/H5G4kGEbguUz261xU45xaoVzqRLbJCVG86Np2MPJrJFnrb8vC93FRw3efE/lPVZ8wGLoOUseXH4YtfnwwYv6Ds9363/znJ3Iyp5ry2PXJ6gl1YBQIaSGKtg28gUOvQPm8iNx8nlcUzRxv58E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 25, 2025 at 08:30:13AM +0200, Vitaly Wool wrote: > Reimplement vrealloc() to be able to set node and alignment should > a user need to do so. Rename the function to vrealloc_node() to > better match what it actually does now and introduce a macro for > vrealloc() for backward compatibility. > > With that change we also provide the ability for the Rust part of > the kernel to set node and aligmnent in its allocations. > > Signed-off-by: Vitaly Wool > --- > include/linux/vmalloc.h | 8 +++++--- > mm/nommu.c | 3 ++- > mm/vmalloc.c | 16 +++++++++++++--- > 3 files changed, 20 insertions(+), 7 deletions(-) > > diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h > index fdc9aeb74a44..7d5251287687 100644 > --- a/include/linux/vmalloc.h > +++ b/include/linux/vmalloc.h > @@ -197,9 +197,11 @@ extern void *__vcalloc_noprof(size_t n, size_t size, gfp_t flags) __alloc_size(1 > extern void *vcalloc_noprof(size_t n, size_t size) __alloc_size(1, 2); > #define vcalloc(...) alloc_hooks(vcalloc_noprof(__VA_ARGS__)) > > -void * __must_check vrealloc_noprof(const void *p, size_t size, gfp_t flags) > - __realloc_size(2); > -#define vrealloc(...) alloc_hooks(vrealloc_noprof(__VA_ARGS__)) > +void *__must_check vrealloc_node_noprof(const void *p, size_t size, > + unsigned long align, gfp_t flags, int nid) __realloc_size(2); > +#define vrealloc_noprof(p, s, f) vrealloc_node_noprof(p, s, 1, f, NUMA_NO_NODE) > +#define vrealloc_node(...) alloc_hooks(vrealloc_node_noprof(__VA_ARGS__)) > +#define vrealloc(...) alloc_hooks(vrealloc_noprof(__VA_ARGS__)) > > extern void vfree(const void *addr); > extern void vfree_atomic(const void *addr); > diff --git a/mm/nommu.c b/mm/nommu.c > index b624acec6d2e..ae240115607f 100644 > --- a/mm/nommu.c > +++ b/mm/nommu.c > @@ -119,7 +119,8 @@ void *__vmalloc_noprof(unsigned long size, gfp_t gfp_mask) > } > EXPORT_SYMBOL(__vmalloc_noprof); > > -void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) > +void *vrealloc_node_noprof(const void *p, size_t size, unsigned long align, > + gfp_t flags, int nid) > { > return krealloc_noprof(p, size, (flags | __GFP_COMP) & ~__GFP_HIGHMEM); > } > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index ab986dd09b6a..117894301db1 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -4081,10 +4081,12 @@ void *vzalloc_node_noprof(unsigned long size, int node) > EXPORT_SYMBOL(vzalloc_node_noprof); > > /** > - * vrealloc - reallocate virtually contiguous memory; contents remain unchanged > + * vrealloc_node - reallocate virtually contiguous memory; contents remain unchanged > * @p: object to reallocate memory for > * @size: the size to reallocate > + * @align: requested alignment > * @flags: the flags for the page level allocator > + * @nid: node id > * > * If @p is %NULL, vrealloc() behaves exactly like vmalloc(). If @size is 0 and > * @p is not a %NULL pointer, the object pointed to is freed. > @@ -4103,7 +4105,7 @@ EXPORT_SYMBOL(vzalloc_node_noprof); > * Return: pointer to the allocated memory; %NULL if @size is zero or in case of > * failure > */ > -void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) > +void *vrealloc_node_noprof(const void *p, size_t size, unsigned long align, gfp_t flags, int nid) > { > struct vm_struct *vm = NULL; > size_t alloced_size = 0; > @@ -4127,6 +4129,13 @@ void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) > if (WARN(alloced_size < old_size, > "vrealloc() has mismatched area vs requested sizes (%p)\n", p)) > return NULL; > + if (WARN(nid != NUMA_NO_NODE && nid != page_to_nid(vmalloc_to_page(p)), > + "vrealloc() has mismatched nids\n")) > + return NULL; > + if (WARN((uintptr_t)p & (align - 1), > + "will not reallocate with a bigger alignment (0x%lx)\n", > + align)) > + return NULL; > } > > /* > @@ -4158,7 +4167,8 @@ void *vrealloc_noprof(const void *p, size_t size, gfp_t flags) > } > > /* TODO: Grow the vm_area, i.e. allocate and map additional pages. */ > - n = __vmalloc_noprof(size, flags); > + n = __vmalloc_node_noprof(size, align, flags, nid, __builtin_return_address(0)); > + > if (!n) > return NULL; > > -- > 2.39.2 > Reviewed-by: "Uladzislau Rezki (Sony)" -- Uladzislau Rezki