From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F4BFC77B7C for ; Wed, 25 Jun 2025 17:52:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F38A6B00C9; Wed, 25 Jun 2025 13:52:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A3B66B00CD; Wed, 25 Jun 2025 13:52:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 293536B00CF; Wed, 25 Jun 2025 13:52:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 11A796B00C9 for ; Wed, 25 Jun 2025 13:52:24 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 86F25BAA41 for ; Wed, 25 Jun 2025 17:52:23 +0000 (UTC) X-FDA: 83594667366.18.AF89E30 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf28.hostedemail.com (Postfix) with ESMTP id 41B43C000F for ; Wed, 25 Jun 2025 17:52:21 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=hfl5uXtV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="GEec/7xo"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=hfl5uXtV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="GEec/7xo"; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750873941; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x/hssygHw+m37RmPXPWJbRXpFWFXQ2itxK9rSA/a6JA=; b=JrOeNQ2JWitqIceF5v5Bbzolrq+z7Kz8WHDq0MqE54zOMOL9Aeb6vqxkCuHhIH+EY+0MUL Py3leD4dnK02wku3ffO2l8Q24pYR6d/LPv5oEvo2jKEchL/OTZxf8AQnv/lZlDytJZkjNB pXioyL8lPflDKHteuQFFOM+ypVeGVsM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=hfl5uXtV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="GEec/7xo"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=hfl5uXtV; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="GEec/7xo"; spf=pass (imf28.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750873941; a=rsa-sha256; cv=none; b=aZGpIJGjmdS/5Ozi0m/I52M39QvjwJNj+cQYqZ8itNz8LMG6Hbs5m84tDp7EQ1XNLiPMNL o8FlWlTsdib2uIVoDzQtNLs4qlIu0nmLrdbFWdRddsV2zSU7qjGJLtrXjTrxa/uhaPHnus 9MJgfBe+uo9WnM77Lu+L/OiF99vKHPw= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9EE3F2116C; Wed, 25 Jun 2025 17:52:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750873939; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x/hssygHw+m37RmPXPWJbRXpFWFXQ2itxK9rSA/a6JA=; b=hfl5uXtVMJzn7ovOErbWUON+Hmntvg/ajAIFBchjl8ReCEflhjFcDbD4V1NRkwLI1SB3UH zKetR3sw7N0/8y2ICGQ1pI1xYw9WFl03u6EmRC0PuoMZu8SY41YNYib1q+gEuTXGk9lsPu f1YkL6YVE2YSl/WOUYoexJyq+ifdRvQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750873939; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x/hssygHw+m37RmPXPWJbRXpFWFXQ2itxK9rSA/a6JA=; b=GEec/7xopnmhhPUqeK7gzwE5fRSXtecBMpSycdNr4kqhBc5jUIg1jJtJCesJFz6RFetCZn LRnvdgR9GPPwNyAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1750873939; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x/hssygHw+m37RmPXPWJbRXpFWFXQ2itxK9rSA/a6JA=; b=hfl5uXtVMJzn7ovOErbWUON+Hmntvg/ajAIFBchjl8ReCEflhjFcDbD4V1NRkwLI1SB3UH zKetR3sw7N0/8y2ICGQ1pI1xYw9WFl03u6EmRC0PuoMZu8SY41YNYib1q+gEuTXGk9lsPu f1YkL6YVE2YSl/WOUYoexJyq+ifdRvQ= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1750873939; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=x/hssygHw+m37RmPXPWJbRXpFWFXQ2itxK9rSA/a6JA=; b=GEec/7xopnmhhPUqeK7gzwE5fRSXtecBMpSycdNr4kqhBc5jUIg1jJtJCesJFz6RFetCZn LRnvdgR9GPPwNyAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 210CB13301; Wed, 25 Jun 2025 17:52:19 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id L+WPBVM3XGhMUQAAD6G6ig (envelope-from ); Wed, 25 Jun 2025 17:52:19 +0000 Date: Wed, 25 Jun 2025 19:52:17 +0200 From: Oscar Salvador To: Dan Carpenter Cc: David Hildenbrand , Andrew Morton , Harry Yoo , Vlastimil Babka , Jonathan Cameron , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2 next] mm,memory_hotplug: set failure reason in offline_pages() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 41B43C000F X-Stat-Signature: 4z5ayj8cp37b54xpk3tmkcuk71ogjod7 X-Rspam-User: X-HE-Tag: 1750873941-101346 X-HE-Meta: U2FsdGVkX19gmwMlvxnKDnmRwHooTMSXTC894JP/jnf+6YaaLNpIIDKp3zeDvXutpJ87Dz9UcTnLC6uNB3vyCkhu3CQR1dJAU5za2rEgAO3dLZMTk+xUD/WidCa9Y1gcXxCZ6KYo6u/opczH4fUAEqDrcMVRnNLVP9RWR8kfinM7hdMjTj5ANeM8uwApkS99aGhoxyG7WYur4SG57onOZvr4uq6XV2ehxeBS++RxDf6vkc5CSWBJA/8BX8Xqd71n95XZpf7xuYyEjp3JDmNs7Rw+FuY8h+kCDfCblBv7ukRY3ENv8jWWIQkyyZv4fDh90dCLFO1aR5OG3ERHy2wjns0Rwigq9X6psXbdW1IwsMgi2TdAHHKbR/epGLABIdjVk6kDzuY+/X28m9ISk1wDNpU5UY/K8CMZv9+mpTx5rg6hSgaBVulqlduQsyaYY8LBADvV8dVkbcvQrDD/4UzAMHhq0pIejtQmNemcxHw44iB4PHdZOGettXCPzUu2gU9gMTBsGeaHghjIQ1vG0H2vhsCmqAVZX+n81RFZ/3fMo85Tlk9quvO2KHCEOHGxj7AQD2gIQtpiXT3iCPgEg9xpwFxK0c6MfizQuR7T3wj2TWJEMyWdSR7yxnG4fzY4OJr20Mt4L0MQeCSFboifwP1gdvvc1DfYPnhXJE3medjjjnYvelR0/8EoNY2bIggHylBjxbK2WafazO1GAZY9zxfKsISpFjwlgYELwUY/Rp5xSxyqQfgdZzm0d9At8c/XtaspKjw07OUBSjSox/tZG+7GQzqhSaZe3geNXA2iuP6cC9wAgYB1gTdV2dwAFVHQPk9ZBnrPweEKoHNOA5CvXyptfTqPbaQ4viQSvx3sWuWmXbY72esjoUtEToCQ4fScfrBMC/VlrBjTqhn5YOOXzMWmT9Jzhb4kEPo8XPuSOtD/XpKVxn4WDWsVcGvEkvfZDLh8RwO61SgOi3i646u9CqN 7a5sRuLe ilTbCaEQfDo+4uDh6PLB5nz92LcrNaTGmjMEMy+aNeVW5F95PkPljRVgSbr3DPdGiTsAOu4jn0KtfdbRCd5WfNIAe/+vZYyXqnxLq6fEFDzcSDRc2c2OvCHt3AodC6BpgbALmJwpOEwqAVttlh+LrqFX0tMEKfN7awDlzMSF/MwDtYlvgRcMYHddcp4i0CpKCt9KUGN9MKUBWv5YIOpgaRzid1kjeIXYUJ/1OM5Y+u1f7GqCSqcHLhBdT//q4zeOihe7ZWB0S73tODteFy7idpEgj5HvaMBvVnjzSnIQHiCpfgTpn+DIb3BI8a2dPIxxIPw8Al1o9Wt+2oH0B9hYnaiPd0HVAAey8c+I9T9eTm7kUDagZkFOG9HsD6g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 25, 2025 at 10:32:04AM -0500, Dan Carpenter wrote: > The "reason" variable is uninitialized on this error path. It's supposed > to explain why the function failed. > > Fixes: e4e2806b639c ("mm,memory_hotplug: implement numa node notifier") > Signed-off-by: Dan Carpenter Thanks Dan! Acked-by: Oscar Salvador Although.. we might be in time to squash it, right? -- Oscar Salvador SUSE Labs