From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7C08C83F09 for ; Tue, 8 Jul 2025 15:17:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30F006B0096; Tue, 8 Jul 2025 11:17:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BFCE6B009A; Tue, 8 Jul 2025 11:17:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1D5846B009B; Tue, 8 Jul 2025 11:17:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0B1DC6B0096 for ; Tue, 8 Jul 2025 11:17:40 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 81669BAA2C for ; Tue, 8 Jul 2025 15:17:39 +0000 (UTC) X-FDA: 83641451838.08.46E3AA9 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by imf23.hostedemail.com (Postfix) with ESMTP id A08F7140006 for ; Tue, 8 Jul 2025 15:17:37 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=eis7t3c9; spf=pass (imf23.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751987857; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CU6TeFNrSMiDTvmFFa/i5WXjWCTVyBBXRGYVVCZBhHM=; b=KGQHmrvgwlXh2T56xFNI+1HpUV7DDTJHBKX7LvjNahC3/M5iRzOmBIou2uNEqmLaE81aWP O0DDO+l37ETx+f1C5U7cCapdh59cjCE+NZSBSJ10y0gAz/17kbbjCLAaUPgSqo0oC0W1es 98JCBC6dsXs6qk9fXh99fO4lZredfz4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751987857; a=rsa-sha256; cv=none; b=Sp+Lw/IQojvj/bdx4x7ZkTPViG6kXRfeRqTF/8Zu8AyPD4rUlIZcP117wPnOIiijftBgqd adpBk/35Te91KxkwoPOaCxvaYTlulynPtO2rWcOpPVirmUANcvpFbXtHNb+xndigX6bi5X m5/d0RUoA0762jOUZkAeS3OYw6XkwL4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=eis7t3c9; spf=pass (imf23.hostedemail.com: domain of mhocko@suse.com designates 209.85.128.53 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-45348bff79fso48713475e9.2 for ; Tue, 08 Jul 2025 08:17:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1751987856; x=1752592656; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CU6TeFNrSMiDTvmFFa/i5WXjWCTVyBBXRGYVVCZBhHM=; b=eis7t3c9HOIKaSLydIN70h7EWZJHtty25JW2VdTv7DJbSSK+ALZiKb2bdCUOn4W5c9 JZAi2C1X9cT199GLFirQBZ1Z3J9FNYlWPhtVgavBQj+Wyfzlt9p3qjzAZW6TNfMmK+PV pL9zbFK7l7duON9zllb2z/hvLIB8JdDSVOEBrDheuo0hVN+H5FA3Y+w20huqvE8JJ2cM 2OkndMNZN2oQE5gKLZ7welSSAX4Ctgs7KhG4uOklFQIMekRJRTTBhzQhcvGWfV33ozPO ZG1jFf3fV3hjozxbVLOzFPZvpG6Rt6hG1FBRFUwFNC7+dliaWC5dhIxBll5catBkDyNV E9Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751987856; x=1752592656; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CU6TeFNrSMiDTvmFFa/i5WXjWCTVyBBXRGYVVCZBhHM=; b=T94vDP8rpoxY76cKPB8HvLgQ1CO+1b4+Sk6EeWoz5lClJBwYFEm1dtPrenlJpz17zA J7gew6Xq7vWGrTYS1wsYmUN8CXXMaadvXZZ2vcxiWXKvTZixpr8dOVb80bxQfTVMwh71 hphQ1UGdRtisDfCFFeEDlOVG4lH054Ga/8IKE+Igulrc+1UmLu7pxBDvaW1WlQOBDo5u GgjV/iSC7T8cLd7D0C/gdsrMod5tfWzgnl34wpt7Y26Z6+rxbknSAXVcJPfzJljT8dnl aRefq/7AqjZXGa1IY0JOr2IZq/YVzeKtl0QUFlqV3VYnD8nvLQjhEqCI93116afdbyZn IICA== X-Gm-Message-State: AOJu0YxiL77+N8uUJ5FvAgFv6J5gIbamblFe3txuTIdM4ybqZB9wdlGB +vypZs5MvPQKkLqimRCKldFNcaDbEnSLs5iLQ6y1RfhUoGjSE16xI56PeC1/ygTR0Hg= X-Gm-Gg: ASbGncupuVOuE0USJ7CkouJ1Bpf0I/sefcBSTR2xkY2S44M3UMhNRhUXfhmjDh7ka+5 Wg56+k5oFkLEhzm7F71FROIZGn12F99kMxMHMUR1zVOMUeU09t77O0JP3qNssVgvlVBPmUSj/xC mAUlQVSE9gz76mtzmM96n9IrNNk+9mLTpy3Pbu5giDtrjzu/2AuTivRIR37A+dAwxjQIC0or6RW SDiotspqACNjOxsw72sthBesWAmOd/i+3JvIgZyPFLs/gWCE3MKKncoGcc4Je3vkxVg12wWgnk3 +wlo6zbEPfseDTJ+B7vYriGIbh0WTETjrjOBbBhoXra5ITgUDnj8EyWYp4RMn0LqiN+SwJ0pLBQ = X-Google-Smtp-Source: AGHT+IFzfxV2rUTYuCgiPSvs0ZawDdkTY/iPGWYSKkuxAJEvzxu4BGSMwoOjKQHIL+QHoZbuT7zUCw== X-Received: by 2002:a05:600c:45cf:b0:441:d2d8:bd8b with SMTP id 5b1f17b1804b1-454b4e779camr149636425e9.8.1751987856261; Tue, 08 Jul 2025 08:17:36 -0700 (PDT) Received: from localhost (109-81-17-167.rct.o2.cz. [109.81.17.167]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-454cd38eee8sm25294775e9.6.2025.07.08.08.17.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 08:17:35 -0700 (PDT) Date: Tue, 8 Jul 2025 17:17:33 +0200 From: Michal Hocko To: Uladzislau Rezki Cc: linux-mm@kvack.org, Andrew Morton , LKML , Baoquan He Subject: Re: [RFC 2/7] mm/vmalloc: Support non-blocking GFP flags in alloc_vmap_area() Message-ID: References: <20250704152537.55724-1-urezki@gmail.com> <20250704152537.55724-3-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A08F7140006 X-Stat-Signature: uhpfnucg53zrrkeawhijfcmcbngcggkn X-HE-Tag: 1751987857-645720 X-HE-Meta: U2FsdGVkX1/wL+Qt76/1iTi6JdlG5XQSok3RnbGphaW3arz1hS9zyLfQMZT69Z9Sy0J6MdhjxmFfhDMGPFdNPb5HM5kPgFniyQfTiIcG4wbgkYL7/lDEJUWzToNPqeMLiiEOzdEMBDC+21N13L8fF2vgVUV7vwQ1KmMzvm5BVRcOx0ZhekZ+ZLgi0j5FItnsBGlnkefqIZAKKU7f2tFnTMJeRHel//m/EePU24pK43fDjAx5UlzFfWMVjPirxC4YpyAu0olqvf6AavyhZWKfnfg0jYG7gqmIeI3D/074QMRWxNMl6SSterQ192qirQ6oUYzMU4LsVTC7Uag9ImeuvGOm7vDRTGXFG9a3MxmdRHplK1ymEBc3TQkyrSFmVCc9Er4UozT9kC5u8g8sZVqL3QO+0yM85oYdjC3QB2nA660dOltJFKFJ8Or4dKfgOaf0qvkde//3gJcibLyNAFOqzSEZu+biwlSJYhO/HEpWOG9ZlZ6D/v/VP/pTg6F1O2B2hPf4zHMuYyepMzpc6sz1ThgJU5VwW2ziGpA5p03ee+0FdigaxQmECahuNhHVvnqbkfzIAVlDHdD9rLkcxNnjaqu16lmc3EcYS+/Qr+N1truF7+ybfg4Qk6IfpoomNa0xMiVJleCj2Nm0Sn/6tLTpEDFfPrUViojq9QBW55eBs3gwN53FpHINqERW+oWztCfxYrE9I8VeycurjznTD9QFwbfkqUurlHXlTCFydU+2g9F4uGh8Q78617MeiK0sHKOS37T/JJyWlIvK/fTHjeYuwmOA7YYM4f9zdajTHIi64YrsRjRoh0+1wImo8Utj8vQRIIaFOCggFyZ7Z1cd2h9J9crFW5umt0gcMsqlIGi8yIL7gHwb74YY82s3CRWIyzjsH2bKUP+QzkO5Zn3j3sioyQu8cyvtbnzX+pYM0wCSHDORcZ4saxZn/+U0ih/r2gKTXuTPapWfEajftAO1grK rAsyUbI9 BL1lBMfj0xMbN6cVxj9kNnXqLd6RFSLSZzOjTSFPCXiqHxJdg9kyZYXmJ3U2YKAGeixq+2Bz43IkXmVRP/e3kIyyLOmhZGdb+FNgmfu8BOSCXEaB21vTYxE9fDpCWeBJdTm0+R6QnGSN+7A8WrVAZxEMZKOGh5ivU+6bQk2szcL7oKVpVqoDhJ36Cmnqapje60LFIp95ljfXmykU3abgzOfcKclNe+vamqYSZa0rn3VFAFLFfnEnSXk7iqNO3ebJ2RGajQls4CybNrmvvBtquhnvjvfUoOgexK3HtQe0X381W+GI3vt30mVX/vQzBkQdJuQ35XBjs34W1hKHbTZX1CjFx8sKdJCqXTSdH6/SJimWVhgc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 08-07-25 14:34:28, Uladzislau Rezki wrote: > On Mon, Jul 07, 2025 at 09:11:35AM +0200, Michal Hocko wrote: > > On Fri 04-07-25 17:25:32, Uladzislau Rezki wrote: > > [...] > > > @@ -2030,7 +2033,8 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, > > > */ > > > va = node_alloc(size, align, vstart, vend, &addr, &vn_id); > > > if (!va) { > > > - gfp_mask = gfp_mask & GFP_RECLAIM_MASK; > > > + if (allow_block) > > > + gfp_mask = gfp_mask & GFP_RECLAIM_MASK; > > > > I don't follow here and is this even correct? > > > Allow nested flags to follow a user request if there is a request > to not block. For example if we apply GFP_RECLAIM_MASK to GFP_ATOMIC > GFP_ATOMIC is converted to zero, thus to GFP_NOWAIT. I still do not follow. The aim of this code is to filter out all non-reclaim related flags. Why that should work differently for non-waiting allocations? Btw. if you had GPP_ATOMIC the resulting mask will be still GFP_ATOMIC as both __GFP_HIGH|__GFP_KSWAPD_RECLAIM are part of GFP_RECLAIM_MASK. -- Michal Hocko SUSE Labs