From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C52DFC83F0A for ; Wed, 9 Jul 2025 21:01:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5485A6B008C; Wed, 9 Jul 2025 17:01:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 520786B00A4; Wed, 9 Jul 2025 17:01:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45CE26B00C4; Wed, 9 Jul 2025 17:01:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 37F246B008C for ; Wed, 9 Jul 2025 17:01:01 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id AC29F10B855 for ; Wed, 9 Jul 2025 21:01:00 +0000 (UTC) X-FDA: 83645945880.28.F53434B Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by imf29.hostedemail.com (Postfix) with ESMTP id 247EB120015 for ; Wed, 9 Jul 2025 21:00:58 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Whehk9WW; spf=pass (imf29.hostedemail.com: domain of dakr@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752094859; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/9fd82iNgzj1KGn0wx2BLD1c1MJ4AJG18DNN4TVd6MA=; b=Mpd4LYyl/3kyfDhHPg1gmKUxJbsNzYhipTufVIKwZB0wqfWu5bAV5WvEduuSwNW3uDfpgM MQozyYkpEf7LbkzI7mzkyX4VsuJem1N+eQA0uKmcEFUy/bSN67fK9KqiVTlimek01ZigeJ t2LY40BDkYipyO2XYVnD6SsYGEz7Rjk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752094859; a=rsa-sha256; cv=none; b=NNBiUNLM5k/eGpHX+QbMltLsO7of67cFOW8YDt9oB/Yz08FFqqdugoPjOx0zrLG5Bpu63w +u2Ak81kpjF0Mz7X4nA5+k5l4/axrwuT6teCImB/Zc7GoY+0UJNCtmXvkwEDMpWfxO/UxA J3J+p6Sxk/y56mNGkT/0AjcQUhOCvws= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Whehk9WW; spf=pass (imf29.hostedemail.com: domain of dakr@kernel.org designates 172.105.4.254 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 96C7E61152; Wed, 9 Jul 2025 21:00:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25A55C4CEEF; Wed, 9 Jul 2025 21:00:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1752094858; bh=AmnUb7yJNWX4dwwep1SMKT/h6N+Cx4+LrtblZJzni+k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Whehk9WWYghHn/wCtVNA/Tk0Zu86XExQdHkvRXk6QzqRubkOrrgp2yH7/mNyMKFmt yyXcAVZZqHIEVFAUQFyvqgoqe0EQv01OYJuE5oEHZAazBJNRyYMQ3uxE3PG9VwQ3+Z R++8huQw5IDFb86bXOYYjdhnA2b5qdQfPoPQnw3pS0FK3Y2h9wr9kGSxsQCfLRUVea IR9lbCBScLQ3AJebsy/XXxQG9luGKNUpMMU7vtTAIaGnvTAVe/fffs6YcLVEKtY4i2 D17/VKX4Rh9Dgpbom2XJXg+GDgrs/hSCRuxLfYjgb6h3ekw/FBpivjfy8SimhpcwRC VE9dLj/Bcy5QQ== Date: Wed, 9 Jul 2025 23:00:52 +0200 From: Danilo Krummrich To: Vitaly Wool Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Uladzislau Rezki , Alice Ryhl , Vlastimil Babka , rust-for-linux@vger.kernel.org, Lorenzo Stoakes , "Liam R . Howlett" , Kent Overstreet , linux-bcachefs@vger.kernel.org, bpf@vger.kernel.org, Herbert Xu , Jann Horn , Pedro Falcato Subject: Re: [PATCH v12 4/4] rust: support large alignments in allocations Message-ID: References: <20250709172345.1031907-1-vitaly.wool@konsulko.se> <20250709172509.1032067-1-vitaly.wool@konsulko.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250709172509.1032067-1-vitaly.wool@konsulko.se> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 247EB120015 X-Stat-Signature: sh16r5eyop8oy6qm7fc4eqy5oz3t36dq X-HE-Tag: 1752094858-539604 X-HE-Meta: U2FsdGVkX1/W164cj99q0wqs+Mem+WlJEp+z+aCarEtFJ6458D+qt0202HHOYggEAd7ZF/LOFBMTcV8E9jx8n8TV3bmvl8xHHuDn7q9rbBaBD9jtmPckeuCp4D4HtDGDOmFBEBnYAWfcbX7EJcMfGcZFODsNhsnlLQEMKMnj/LQwaWMIypmCnGjKRQ4suZaDe5f9FuVzcTp3B2gjL4rJFRyspToWNgOx7xfVQlEV+F4iJLLFZBZjmiQ2sbz2kj6nu8zoUk6que3Pa39XMsnp5ReARFpe9F4YTLj+qbD+LNcTDU7LHKczs16o2/nS9zypl9PSUSLKNuMd7z/LCtRx3p6ftUcI3/WRJCN5CFYlULNmwwen/W4+zUnLVqoyfLx+obmcpzY72vbOTjukVZehUf3Xk1oulf9U5d0tUkqN3DhOgYzYau01gO8lDdZ9J5iM1iXCXXxYPMtXyr6bWY1U0dN1knMcxJc8lyQfJ9ird+cH0JdD9oJaWe/IL2yJgSsRluNrbksXfeWkONq+NkLHS3sLjY15Zrt+L0t35yiXFfX52zAzflHThQJLyeK3GTZ7sg4BRk9Krxhi5g//RGT+gr0NNXoKnKE27QoAhaRCk1g1iYM9semdRgsJZhPAaRNliJ1KTUJtqwAjCA7pvZdyVtcxISxFVgz7GHN7yt1Aczil00mIic39jWlCJkyfFTHThOvjNuvkrV+h1MCfvgf061c0Fka4dBn0jWXecz8pHxncpAYGuk27EHURCr/Pjav8k/QRLJI9XPbzjNhWbroMvGACO9OW7klEwasOJwrqzwgPQzHMt6ELN1PrcI2aaRQ/9CqSHgD37enRIh3bDa0p2cJLH5j6Z6nxun7I1dxQLigNaBDPxz3x1Rik5fd0p3NPdkMSaZFEzdkZ2Ff7AjI2rXnAamPqVGjNhXBUq0pDruC3rIWjyaiisOXDg8VGLBrZQwAynsPdQBbPhPZMiYc sJYWxH4j CtKxPgYB9mRetYdDI3rPU0Qbawz613HEuU8rqHGuDtCZvnr7NnPd2A/BuiBJ2v7V9tSzkFYn//sRq3ZDk4UnMDPETBDO/0ayYoeBpNGFCxx5zC0ujcRBM8sjV3AnIzRJpX44Y1Eq8/Ob6xHWQ03cv/l00bRZDM3xkaWR7f2ydlD0WROqGLpMqWlvKewSB/la3d8U6Xs7qL3C58ILWr/uAur2LmJM8XgjOoNiXwRcrF3ynBpqI3+S0D4flOJD4vsdD8LAQkq/+ufavOzCfvsMCxTml3Z+bvhVuw+Wzt50Mt0PFlq+c+MArkYcdOQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 09, 2025 at 07:25:09PM +0200, Vitaly Wool wrote: > void * __must_check __realloc_size(2) > -rust_helper_krealloc_node(const void *objp, size_t new_size, gfp_t flags, int node) > +rust_helper_krealloc_node_align(const void *objp, size_t new_size, unsigned long align, > + gfp_t flags, int node) CHECK: Alignment should match open parenthesis #38: FILE: rust/helpers/slab.c:14: +rust_helper_kvrealloc_node_align(const void *p, size_t size, unsigned long align, + gfp_t flags, int node) total: 0 errors, 0 warnings, 1 checks, 94 lines checked Please make sure to always run scripts/checkpatch.pl. :) > @@ -185,12 +180,6 @@ unsafe fn realloc( > flags: Flags, > nid: NumaNode, > ) -> Result, AllocError> { > - // TODO: Support alignments larger than PAGE_SIZE. > - if layout.align() > bindings::PAGE_SIZE { > - pr_warn!("KVmalloc does not support alignments larger than PAGE_SIZE yet.\n"); > - return Err(AllocError); > - } > - Since you remove the pr_warn!(), you also have to remove the corresponding import, otherwise you get a clippy warning. Please build with CLIPPY=1, see also [1]. [1] https://rust-for-linux.com/contributing#submit-checklist-addendum