From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2224C8302F for ; Mon, 30 Jun 2025 13:26:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E7B36B00C6; Mon, 30 Jun 2025 09:26:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 770E36B00D9; Mon, 30 Jun 2025 09:26:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 612506B00DA; Mon, 30 Jun 2025 09:26:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4B8186B00C6 for ; Mon, 30 Jun 2025 09:26:53 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F1267BA155 for ; Mon, 30 Jun 2025 13:26:52 +0000 (UTC) X-FDA: 83612142264.11.D5C6556 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf16.hostedemail.com (Postfix) with ESMTP id 9AD2D180008 for ; Mon, 30 Jun 2025 13:26:50 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=twVn18qU; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=rH1ToKF8; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=twVn18qU; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=rH1ToKF8; spf=pass (imf16.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751290011; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P4dKDhV7HkHnR/fM06ZQ3VumFSoemzPHeiTMaH7qh8g=; b=xCzbeGgb/jFb1G9tHL/XEvOY6zj/ZgLYBW2IsJqdyMScP9q7AiBn2FfekI8Miz5V8AcEhg S7uKc5k1rbGlPiKx0zlutfYtM/oIJpB6Qy/Sb/oLB9clRgPcXusXSJ/gOz6ZH08piut8BQ 3Ck4hlrBdZ47eyDoff5JLTe+vkhObtE= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=twVn18qU; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=rH1ToKF8; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=twVn18qU; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=rH1ToKF8; spf=pass (imf16.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751290011; a=rsa-sha256; cv=none; b=EWgpxYzzPXQVE9t9zpsrFI2D3e+aPkNfifJsMlHoLmvn35xXHQgynNfT1jX1QkfrML7klo QvLzxzhAcA/bJWh6YaM2i4btrhlOEVNvGDwgnmdPWgtpAucZTbp2A77jknt7DGP/jTDOCp r4kwdsfaLPCLx3QA3q/PKvX5VerNO/U= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9BE281F397; Mon, 30 Jun 2025 13:26:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751290008; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P4dKDhV7HkHnR/fM06ZQ3VumFSoemzPHeiTMaH7qh8g=; b=twVn18qUxwWl/xc6qNMIqVlShHP0g2wOWcv9pruz7LQ3sJ6LlLgexX2WuITrlO+pZNlxt1 Sklq4cwwcRHsQkKLUdA+kBsevjE+OT6TUZGmDwEvoVl4WY2XoHvkFYVUOZaapyafSanJhW a3lI7R2fWlT+et7jSHOPz7mrWWsLnak= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751290008; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P4dKDhV7HkHnR/fM06ZQ3VumFSoemzPHeiTMaH7qh8g=; b=rH1ToKF8a//Wim8aB/cQ2WQ92HMBCwrquiYSTV/ulwveH9qAQ8NYtgxsNSh5O6SDXpibzw JzU+Qc3fSwkZHgBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751290008; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P4dKDhV7HkHnR/fM06ZQ3VumFSoemzPHeiTMaH7qh8g=; b=twVn18qUxwWl/xc6qNMIqVlShHP0g2wOWcv9pruz7LQ3sJ6LlLgexX2WuITrlO+pZNlxt1 Sklq4cwwcRHsQkKLUdA+kBsevjE+OT6TUZGmDwEvoVl4WY2XoHvkFYVUOZaapyafSanJhW a3lI7R2fWlT+et7jSHOPz7mrWWsLnak= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751290008; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=P4dKDhV7HkHnR/fM06ZQ3VumFSoemzPHeiTMaH7qh8g=; b=rH1ToKF8a//Wim8aB/cQ2WQ92HMBCwrquiYSTV/ulwveH9qAQ8NYtgxsNSh5O6SDXpibzw JzU+Qc3fSwkZHgBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 235C513983; Mon, 30 Jun 2025 13:26:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id YAjdBZiQYmhPXQAAD6G6ig (envelope-from ); Mon, 30 Jun 2025 13:26:48 +0000 Date: Mon, 30 Jun 2025 15:26:45 +0200 From: Oscar Salvador To: Oscar Salvador Cc: Gavin Guo , Andrew Morton , David Hildenbrand , Muchun Song , Peter Xu , Linux Memory Management List , LKML Subject: Re: [PATCH v3 1/5] mm,hugetlb: Change mechanism to detect a COW on private mapping Message-ID: References: <20250627102904.107202-1-osalvador@suse.de> <20250627102904.107202-2-osalvador@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 9AD2D180008 X-Stat-Signature: xksmti81ky6h76qu3hss67r1prryaqth X-Rspam-User: X-HE-Tag: 1751290010-245361 X-HE-Meta: U2FsdGVkX19aJSZZAt9aMClMyxaRT/utjhFkE2s4Q0WRg20+2i5f3dXtkDeDDfp/ECTHPuxujGrD7A3k+y0sSyHiy2oCOfGVs0fUcDIyFBiIR6L1snl1hNJtdSWqyWWqU8I0rXl1AEk7L18ZxHNpwcBlfJws9cplAv0FFgSaLlezAzkavOG78b+cOyuYZv2A/xZP+d/+NE+Y/7uMJEE04UYOkHIsiTSyEVnSaGvLqjxgmgTJ+KllcYvcV8VBqJYuz1LwdR86SHFHslK9Bith4i3HchvYC21kPRPTAdE2xYns8dYM3HGd9O1XWaFlpqMjqXzH6CLxBMEUjzKKMY03fPUaTYn/mmmTa8bsFp01bCBntIH0cQgPVTw87qgWCAdxENSXIIOAlmsY/HRx7XsSwCM7ev0aFx7OCHRGWtS/ZFzdAoZOwW+DKA7Nuut78GhEwz40jI6JJZcjX5BrFOZaTJ24z1jKW8S7TOFO/TtY+51/ZJQNd8tKzOLIp3X2+mCAtqwMSex99BzgIKyPSwFUUjPW2VCH9qt14JKCe4npMYzMFFttNbud++ZGyd1eGwh+Bh04KstVpX6l5lDfJeaPRUUkSBCoed0jCaO8ESqKp2st7LddgkZqln9dDfAU0/baL8WuyuKMzVWle9HZG5ApTisrgwTMgSSMbViwBJW2PlGDH5g6fMNw4hqcC/e0f9UAtiPBQ9BiojB9hCqTQDzUHepJWb+aH/I0fFvecB21/a33sxRXH2SBLzY/jCpAOqCstyQ6Jn+GSMD6mvSUaMxacLJMkK89iKmZ0jhzk1kmHsGrpPxLnk1+EpjIfEgU43m6K6kSA2oFF/1khFCkxp3lcIfBFUnGn1Fy7UK/Cd9LIvrurpNSujx/TmGQQGKWqtgKEBKLVQq2Cfws4ReRneC/qdh/npcFqUaUdEIcwGFyQrOpx26U6846WubXfdrgYajSfhle3DR1kCMk+LVyEHq 6KjhzGUP IMFe70DXXe3On2BoVEPLTvPmBgYgM2CengOeh5EkmxmZhx7EJNsyMq3pwJNIoU/dMSgDLmBbAFT8QMBtHKMPfrEAtfHPkpJW1MFIw1zkCNI470rWuo9RSFIK70AbSt+91NgN6jimdtG2H1wSWzXCXOhyEa955sQBtGSJPsd256ABfXAMryNRi+elvupwUCyJH/eTEYMEHc4wfl+BoLjmKmbXRVTGMZf80agh17WWMoe3Po36t+BuWS0KuIsH6Jm9oU9oXwa3xkxS5GNdg52B91vlsgMQ3FiUxG/E7hq8GY1KKy4aJXK+HjJ5MClQQdx6/+u3yn695/W/f2vY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Jun 29, 2025 at 10:12:06PM +0200, Oscar Salvador wrote: > Nevermind, I just wrote my own reproducer. > I see two ways of fixing this, the simpler being a trylock instead of a > lock, like the original code did. > I'll sleep on it and fix it tomorrow. I crafted the fix, and now my reproducer no longer reproduces the problem. Also, with the fix the whole lock-unlock dance becomes much more simple. I'll send out a v4 later today. -- Oscar Salvador SUSE Labs